LoginCidadao\OpenIDBundle\Storage\AccessToken

Complexity

Total Complexity

7

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	getAccessToken()	0	24	2
B	setAccessToken()	0	32	3
A	setSubjectIdentifierService()	0	4	1

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\OpenIDBundle\Storage;

use LoginCidadao\CoreBundle\Model\PersonInterface;
use LoginCidadao\OAuthBundle\Entity\Client;
use LoginCidadao\OAuthBundle\Model\ClientInterface;
use LoginCidadao\OpenIDBundle\Service\SubjectIdentifierService;
use OAuth2\ServerBundle\Storage\AccessToken as BaseClass;
use OAuth2\Storage\AccessTokenInterface;
use Doctrine\ORM\EntityManager;

class AccessToken extends BaseClass implements AccessTokenInterface
{
    /** @var EntityManager */
    private $em;

    /** @var SubjectIdentifierService */
    private $subjectIdentifierService;

    public function __construct(EntityManager $EntityManager)

The parameter $EntityManager is not named in camelCase.

$EntityManager does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    {
        parent::__construct($EntityManager);

$EntityManager does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->em = $EntityManager;

$EntityManager does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    /**
     * Look up the supplied oauth_token from storage.
     *
     * We need to retrieve access token data as we create and verify tokens.
     *
     * @param $oauth_token
     * oauth_token to be check with.
     *
     * @return array|null

Consider making the return type a bit more specific; maybe use null|array<string,string|integer|null>.

     * An associative array as below, and return NULL if the supplied oauth_token
     * is invalid:
     * - client_id: Stored client identifier.
     * - expires: Stored expiration in unix timestamp.
     * - scope: (optional) Stored scope values in space-separated string.
     *
     * @ingroup oauth2_section_7
     */
    public function getAccessToken($oauth_token)

The parameter $oauth_token is not named in camelCase.

    {
        /** @var \LoginCidadao\OAuthBundle\Entity\AccessToken $accessToken */
        $accessToken = $this->em->getRepository('LoginCidadaoOAuthBundle:AccessToken')
            ->findOneBy(['token' => $oauth_token]);

$oauth_token does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (!$accessToken) {
            return null;
        }

        /** @var Client $client */
        $client = $accessToken->getClient();

        /** @var PersonInterface $person */
        $person = $accessToken->getUser();

        return [
            'client_id' => $client->getClientId(),
            'user_id' => $this->subjectIdentifierService->getSubjectIdentifier($person, $client),

$client is of type object<LoginCidadao\OAuthBundle\Entity\Client>, but the function expects a null|object<LoginCidadao\OpenIDBundle\Entity\ClientMetadata>.

            'expires' => $accessToken->getExpiresAt(),
            'scope' => $accessToken->getScope(),
            'id_token' => $accessToken->getIdToken(),
        ];
    }

    /**
     * Store the supplied access token values to storage.
     *
     * We need to store access token data as we create and verify tokens.
     *
     * @param string $oauth_token
     * oauth_token to be stored.
     * @param string $client_id
     * Client identifier to be stored.
     * @param string $user_id
     * User identifier to be stored.
     * @param int $expires Expiration to be stored as a Unix timestamp.
     * @param string $scope (optional) Scopes to be stored in space-separated string.

Should the type for parameter $scope not be string|null?

     * @param null|string $id_token
     * @return null|void
     * @ingroup oauth2_section_4
     */
    public function setAccessToken($oauth_token, $client_id, $user_id, $expires, $scope = null, $id_token = null)

The parameter $oauth_token is not named in camelCase.

The parameter $client_id is not named in camelCase.

The parameter $user_id is not named in camelCase.

The parameter $id_token is not named in camelCase.

    {
        // Get Client Entity
        $id = explode('_', $client_id);

$client_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        /** @var ClientInterface $client */
        $client = $this->em->getRepository('LoginCidadaoOAuthBundle:Client')->find($id[0]);

        if (!$client) {
            return null;
        }

        if ($user_id === null) {

$user_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            return null;
        } else {
            /** @var PersonInterface $user */
            $user = $this->em->getRepository('LoginCidadaoCoreBundle:Person')->find($user_id);

$user_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        // Create Access Token
        $accessToken = new \LoginCidadao\OAuthBundle\Entity\AccessToken();
        $accessToken->setToken($oauth_token);

$oauth_token does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $accessToken->setClient($client);
        $accessToken->setUser($user);
        $accessToken->setExpiresAt($expires);
        $accessToken->setScope($scope);
        $accessToken->setIdToken($id_token);

$id_token does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        // Store Access Token and Authorization
        $this->em->persist($accessToken);
        $this->em->flush();
    }

    public function setSubjectIdentifierService(SubjectIdentifierService $subjectIdentifierService)
    {
        $this->subjectIdentifierService = $subjectIdentifierService;
    }
}