LolHandler::handle() - Code Metrics - PHPointless/monolol - Measure and Improve Code Quality continuously with Scrutinizer

LolHandler::handle() B
last analyzed 2016-01-23 11:29 UTC

↳ Parent: LolHandler

Complexity

Conditions	5
Paths	5

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	21
ccs	14
cts	14
cp	1
rs	8.7624
cc	5
eloc	11
nc	5
nop	1
crap	5

<?php

namespace Monolol\Handlers;

use Monolog\Handler\AbstractHandler;
use Monolog\Handler\HandlerInterface;
use Monolol\Lolifier;

class LolHandler extends AbstractHandler
{
    private
        $lolifier;
class A {
    var $property;
}
    
    protected
        $handler,
class A {
    var $property;
}
        $bubble;
    
    public function __construct($handler, Lolifier $lolifier, $bubble = true)
    {
        $this->handler = $handler;
        $this->lolifier = $lolifier;
        $this->bubble = $bubble;
        
        if (!$this->handler instanceof HandlerInterface && !is_callable($this->handler)) {
            throw new \RuntimeException("The given handler (".json_encode($this->handler).") is not a callable nor a Monolog\Handler\HandlerInterface object");
        }
    }
    
    public function isHandling(array $record)
    {
        return $this->lolifier->isHandling($record);
    }
    
    public function handle(array $record)
    {
        if (! $this->handler instanceof HandlerInterface) {
            $this->handler = call_user_func($this->handler, $record, $this);
            if (! $this->handler instanceof HandlerInterface) {
                throw new \RuntimeException("The factory callable should return a HandlerInterface");
            }
        }
        
        $record = $this->lolifier->lolify($record);
        
        if ($this->processors) {

            foreach ($this->processors as $processor) {
                $record = call_user_func($processor, $record);
            }
        }
        
        $this->handler->handle($record);
        
        return false === $this->bubble;
    }
}


1		<?php
2
3		namespace Monolol\Handlers;
4
5		use Monolog\Handler\AbstractHandler;
6		use Monolog\Handler\HandlerInterface;
7		use Monolol\Lolifier;
8
9		class LolHandler extends AbstractHandler
10		{
11		private
12		$lolifier;
		0 ignored issues – show Coding Style introduced 2016-01-11 20:20 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$lolifier`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
13
14		protected
15		$handler,
		0 ignored issues – show Coding Style introduced 2016-01-11 20:20 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2016-01-11 20:20 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$handler`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
16		$bubble;
17
18	5	public function __construct($handler, Lolifier $lolifier, $bubble = true)
19		{
20	5	$this->handler = $handler;
21	5	$this->lolifier = $lolifier;
22	5	$this->bubble = $bubble;
23
24	5	if (!$this->handler instanceof HandlerInterface && !is_callable($this->handler)) {
25		throw new \RuntimeException("The given handler (".json_encode($this->handler).") is not a callable nor a Monolog\Handler\HandlerInterface object");
26		}
27	5	}
28
29		public function isHandling(array $record)
30		{
31		return $this->lolifier->isHandling($record);
32		}
33
34	5	public function handle(array $record)
35		{
36	5	if (! $this->handler instanceof HandlerInterface) {
37	2	$this->handler = call_user_func($this->handler, $record, $this);
38	2	if (! $this->handler instanceof HandlerInterface) {
39	1	throw new \RuntimeException("The factory callable should return a HandlerInterface");
40		}
41	1	}
42
43	4	$record = $this->lolifier->lolify($record);
44
45	4	if ($this->processors) {
		0 ignored issues – show Bug Best Practice introduced 2016-01-11 20:20 UTC by Report Bug Copy Issue Report The expression `$this->processors` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
46	1	foreach ($this->processors as $processor) {
47	1	$record = call_user_func($processor, $record);
48	1	}
49	1	}
50
51	4	$this->handler->handle($record);
52
53	4	return false === $this->bubble;
54		}
55		}
56

PHPointless / monolol

LolHandler::handle() B last analyzed 2016-01-23 11:29 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

LolHandler::handle() B
last analyzed 2016-01-23 11:29 UTC