PHPieces\ANZGateway\Charge

Complexity

Total Complexity

8

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	formDecode()	0	23	1
A	validate()	0	6	2
A	isSuccess()	0	7	2
A	getMessage()	0	4	1
A	toArray()	0	15	1

<?php

namespace PHPieces\ANZGateway;

use PHPieces\ANZGateway\exceptions\RequiredArgumentException;
use PHPieces\ANZGateway\models\ResponseCode;
use Exception;

class Charge
{
    const AMOUNT = 'vpc_Amount';
    const BATCH_NO = 'vpc_BatchNo';
    const CARD = 'vpc_Card';
    const LOCALE = 'vpc_Locale';
    const MERCH_TXN_REF = 'vpc_MerchTxnRef';
    const ORDER_INFO = 'vpc_OrderInfo';
    const RECEIPT_NO = 'vpc_ReceiptNo';
    const TRANSACTION_NO = 'vpc_TransactionNo';

    /**
     *
     * @var ResponseCode
     */
    public $responseCode;
    public $amount;
    public $batchNo;
    public $card;
    public $locale;
    public $merchTxnRef;
    public $orderInfo;
    public $receiptNo;
    public $transactionNo;
    public $responseContent;
    private $failedValidation = false;

    public function __construct($params)
    {
        $this->formDecode($params);
        $this->validate();
    }

    private function formDecode(string $params) : void
    {
        $output = [];
        parse_str($params, $output);
        $this->responseContent = $params;
        $this->responseCode = ResponseCode::create($output);

It seems like $output can also be of type null; however, PHPieces\ANZGateway\models\Model::create() does only seem to accept array, maybe add an additional type check?

It seems like \PHPieces\ANZGateway\models\ResponseCode::create($output) of type object<self> is incompatible with the declared type object<PHPieces\ANZGateway\models\ResponseCode> of property $responseCode.

        //Required
        $this->transactionNo = @$output[self::TRANSACTION_NO];

        //From Input
        $this->amount = @$output[self::AMOUNT];
        $this->locale = @$output[self::LOCALE];
        $this->merchTxnRef = @$output[self::MERCH_TXN_REF];
        $this->orderInfo = @$output[self::ORDER_INFO];

        //Optional
        $this->batchNo = @$output[self::BATCH_NO];
        $this->card = @$output[self::CARD];
        $this->receiptNo = @$output[self::RECEIPT_NO];

        $this->validate();
    }

    /**
     *
     * @throws RequiredArgumentException
     * @throws Exception
     */
    private function validate() : void
    {
        if (empty($this->transactionNo)) {
            $this->failedValidation = true;
        }
    }

    public function isSuccess() : bool
    {
        if ($this->failedValidation) {
            return false;
        }
        return $this->responseCode->isSuccess();
    }

    public function getMessage() : string
    {
        return $this->responseCode->getErrorMessage();
    }

    public function toArray() : array
    {
        return [
            'responseContent' => $this->responseContent,
            'responseCode'    => $this->responseCode->toJson(),
            'amount'          => $this->amount,
            'batchNo'         => $this->batchNo,
            'card'            => $this->card,
            'locale'          => $this->locale,
            'merchTxnRef'     => $this->merchTxnRef,
            'orderInfo'       => $this->orderInfo,
            'receiptNo'       => $this->receiptNo,
            'transactionNo'   => $this->transactionNo,
        ];
    }
}