App - Code Metrics - PHPieces/Framework - Measure and Improve Code Quality continuously with Scrutinizer

App A
last analyzed 2016-06-29 10:30 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	6
Bugs	0	Features	3

Metric	Value
wmc	7
c	6
b	0
f	3
lcom	1
cbo	4
dl	0
loc	71
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	bootstrap()	4	1
A	run()	8	1
A	get()	4	1
A	post()	4	1
B	loadContainer()	27	1
A	getResponse()	6	1

<?php

namespace PHPieces\Framework;

use \League\Plates\Engine;
use League\Route\RouteCollection;
use Zend\Diactoros\Response;
use Zend\Diactoros\Response\SapiEmitter;
use Zend\Diactoros\ServerRequestFactory;

class App
{
    public $container;

    public $route;

    public function __construct($config)
    {
        $this->config = $config;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->bootstrap();
    }

    public function bootstrap()
    {
        $this->loadContainer();
    }

    public function run()
    {
        $request = $this->container->get('request');
        
        $response = $this->getResponse($request);

        $this->container->get('emitter')->emit($response);
    }

    public function get($route, $handler)
    {
        $this->route->map('GET', $route, $handler);
    }

    public function post($route, $handler)
    {
        $this->route->map('POST', $route, $handler);
    }

    protected function loadContainer()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->container = new \League\Container\Container;

        $this->container->delegate(
            new \League\Container\ReflectionContainer
        );

        $this->container->share('response', Response::class);

        $this->container->share(
            'request',
            ServerRequestFactory::fromGlobals(
                $_SERVER,
                $_GET,
                $_POST,
                $_COOKIE,
                $_FILES
            )
        );

        $this->container->share('emitter', SapiEmitter::class);

        $this->route = new RouteCollection($this->container);

        $this->container->share(Engine::class, Engine::class)->withArgument($this->config['template_dir']);
    }

    public function getResponse($request)
    {
        $response = $this->route->dispatch($request, $this->container->get('response'));

        return $response;
    }
}


1			<?php
2
3			namespace PHPieces\Framework;
4
5			use \League\Plates\Engine;
6			use League\Route\RouteCollection;
7			use Zend\Diactoros\Response;
8			use Zend\Diactoros\Response\SapiEmitter;
9			use Zend\Diactoros\ServerRequestFactory;
10
11			class App
12			{
13			public $container;
14
15			public $route;
16
17			public function __construct($config)
18			{
19			$this->config = $config;
			0 ignored issues – show Bug introduced 2016-06-26 09:20 UTC by Report Bug Copy Issue Report The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			$this->bootstrap();
21			}
22
23			public function bootstrap()
24			{
25			$this->loadContainer();
26			}
27
28			public function run()
29			{
30			$request = $this->container->get('request');
31
32			$response = $this->getResponse($request);
33
34			$this->container->get('emitter')->emit($response);
35			}
36
37			public function get($route, $handler)
38			{
39			$this->route->map('GET', $route, $handler);
40			}
41
42			public function post($route, $handler)
43			{
44			$this->route->map('POST', $route, $handler);
45			}
46
47			protected function loadContainer()
			0 ignored issues – show Coding Style introduced 2016-06-26 09:20 UTC by Report Bug Copy Issue Report `loadContainer` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-06-26 09:20 UTC by Report Bug Copy Issue Report `loadContainer` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-06-26 09:20 UTC by Report Bug Copy Issue Report `loadContainer` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-06-26 09:20 UTC by Report Bug Copy Issue Report `loadContainer` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-06-26 09:20 UTC by Report Bug Copy Issue Report `loadContainer` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
48			{
49			$this->container = new \League\Container\Container;
50
51			$this->container->delegate(
52			new \League\Container\ReflectionContainer
53			);
54
55			$this->container->share('response', Response::class);
56
57			$this->container->share(
58			'request',
59			ServerRequestFactory::fromGlobals(
60			$_SERVER,
61			$_GET,
62			$_POST,
63			$_COOKIE,
64			$_FILES
65			)
66			);
67
68			$this->container->share('emitter', SapiEmitter::class);
69
70			$this->route = new RouteCollection($this->container);
71
72			$this->container->share(Engine::class, Engine::class)->withArgument($this->config['template_dir']);
73			}
74
75			public function getResponse($request)
76			{
77			$response = $this->route->dispatch($request, $this->container->get('response'));
78
79			return $response;
80			}
81			}
82

PHPieces / Framework

App A last analyzed 2016-06-29 10:30 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like

App A
last analyzed 2016-06-29 10:30 UTC