| Conditions | 21 |
| Paths | 9 |
| Total Lines | 34 |
| Code Lines | 18 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 72 | public function setServers(array $servers): static |
||
| 73 | { |
||
| 74 | $this->enforceLockedProperty(__FUNCTION__); |
||
| 75 | foreach ($servers as $server) { |
||
| 76 | if (\array_key_exists('saslUser', $server) || array_key_exists('saslPassword', $server)) { |
||
| 77 | throw new PhpfastcacheInvalidConfigurationException('Unlike Memcached, Memcache does not support SASL authentication'); |
||
| 78 | } |
||
| 79 | |||
| 80 | if ($diff = array_diff(array_keys($server), ['host', 'port', 'path'])) { |
||
| 81 | throw new PhpfastcacheInvalidConfigurationException('Unknown keys for memcached server: ' . implode(', ', $diff)); |
||
| 82 | } |
||
| 83 | |||
| 84 | if (!empty($server['host']) && !empty($server['path'])) { |
||
| 85 | throw new PhpfastcacheInvalidConfigurationException('Host and path cannot be simultaneous defined.'); |
||
| 86 | } |
||
| 87 | |||
| 88 | if ((isset($server['host']) && !is_string($server['host'])) || (empty($server['path']) && empty($server['host']))) { |
||
| 89 | throw new PhpfastcacheInvalidConfigurationException('Host must be a valid string in "$server" configuration array if path is not defined'); |
||
| 90 | } |
||
| 91 | |||
| 92 | if ((isset($server['path']) && !is_string($server['path'])) || (empty($server['host']) && empty($server['path']))) { |
||
| 93 | throw new PhpfastcacheInvalidConfigurationException('Path must be a valid string in "$server" configuration array if host is not defined'); |
||
| 94 | } |
||
| 95 | |||
| 96 | if (!empty($server['host']) && (empty($server['port']) || !is_int($server['port'])|| $server['port'] < 1)) { |
||
| 97 | throw new PhpfastcacheInvalidConfigurationException('Port must be a valid integer in "$server" configuration array'); |
||
| 98 | } |
||
| 99 | |||
| 100 | if (!empty($server['port']) && !empty($server['path'])) { |
||
| 101 | throw new PhpfastcacheInvalidConfigurationException('Port should not be defined along with path'); |
||
| 102 | } |
||
| 103 | } |
||
| 104 | $this->servers = $servers; |
||
| 105 | return $this; |
||
| 106 | } |
||
| 149 |