Complex classes like PathSeekerTrait often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PathSeekerTrait, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
20 | trait PathSeekerTrait |
||
21 | { |
||
22 | /** |
||
23 | * @var array |
||
24 | */ |
||
25 | public $tmp = []; |
||
26 | |||
27 | /** |
||
28 | * @param bool $skip_create_path |
||
|
|||
29 | * @param $config |
||
30 | * @return string |
||
31 | * @throws \Exception |
||
32 | */ |
||
33 | public function getPath($getBasePath = false) |
||
34 | { |
||
35 | $tmp_dir = rtrim(ini_get('upload_tmp_dir') ? ini_get('upload_tmp_dir') : sys_get_temp_dir(), '\\/') . DIRECTORY_SEPARATOR . 'phpfastcache'; |
||
36 | |||
37 | if (!isset($this->config[ 'path' ]) || $this->config[ 'path' ] == '') { |
||
38 | if (self::isPHPModule()) { |
||
39 | $path = $tmp_dir; |
||
40 | } else { |
||
41 | $document_root_path = rtrim($_SERVER[ 'DOCUMENT_ROOT' ], '/') . '/../'; |
||
42 | $path = isset($_SERVER[ 'DOCUMENT_ROOT' ]) && is_writable($document_root_path) ? $document_root_path : rtrim(__DIR__, '/') . '/'; |
||
43 | } |
||
44 | |||
45 | if ($this->config[ 'path' ] != '') { |
||
46 | $path = $this->config[ 'path' ]; |
||
1 ignored issue
–
show
|
|||
47 | } |
||
48 | |||
49 | } else { |
||
50 | $path = $this->config[ 'path' ]; |
||
51 | } |
||
52 | |||
53 | if ($getBasePath === true) { |
||
54 | return $path; |
||
55 | } |
||
56 | |||
57 | $securityKey = array_key_exists('securityKey', $this->config) ? $this->config[ 'securityKey' ] : ''; |
||
58 | if (!$securityKey || $securityKey === 'auto') { |
||
59 | if (isset($_SERVER[ 'HTTP_HOST' ])) { |
||
60 | $securityKey = preg_replace('/^www./', '', strtolower(str_replace(':', '_', $_SERVER[ 'HTTP_HOST' ]))); |
||
61 | } else { |
||
62 | $securityKey = ($this->isPHPModule() ? 'web' : 'cli'); |
||
63 | } |
||
64 | } |
||
65 | |||
66 | if ($securityKey !== '') { |
||
67 | $securityKey .= '/'; |
||
68 | } |
||
69 | |||
70 | $securityKey = static::cleanFileName($securityKey); |
||
71 | |||
72 | $full_path = rtrim($path, '/') . '/' . $securityKey; |
||
73 | $full_pathx = md5($full_path); |
||
74 | |||
75 | |||
76 | if (!isset($this->tmp[ $full_pathx ])) { |
||
77 | |||
78 | if (!@file_exists($full_path) || !@is_writable($full_path)) { |
||
79 | if (!@file_exists($full_path)) { |
||
80 | @mkdir($full_path, $this->setChmodAuto(), true); |
||
1 ignored issue
–
show
|
|||
81 | } |
||
82 | if (!@is_writable($full_path)) { |
||
83 | @chmod($full_path, $this->setChmodAuto()); |
||
1 ignored issue
–
show
|
|||
84 | } |
||
85 | if (!@is_writable($full_path)) { |
||
86 | // switch back to tmp dir again if the path is not writeable |
||
87 | $full_path = rtrim($tmp_dir, '/') . '/' . $securityKey; |
||
88 | if (!@file_exists($full_path)) { |
||
89 | @mkdir($full_path, $this->setChmodAuto(), true); |
||
1 ignored issue
–
show
|
|||
90 | } |
||
91 | if (!@is_writable($full_path)) { |
||
92 | @chmod($full_path, $this->setChmodAuto()); |
||
1 ignored issue
–
show
|
|||
93 | } |
||
94 | } |
||
95 | if (!@file_exists($full_path) || !@is_writable($full_path)) { |
||
96 | throw new phpFastCacheCoreException('PLEASE CREATE OR CHMOD ' . $full_path . ' - 0777 OR ANY WRITABLE PERMISSION!', 92); |
||
97 | } |
||
98 | } |
||
99 | |||
100 | $this->tmp[ $full_pathx ] = true; |
||
101 | $this->htaccessGen($full_path, array_key_exists('htaccess', $this->config) ? $this->config[ 'htaccess' ] : false); |
||
102 | } |
||
103 | |||
104 | return realpath($full_path); |
||
105 | } |
||
106 | |||
107 | /** |
||
108 | * @param $keyword |
||
109 | * @return string |
||
110 | */ |
||
111 | protected function encodeFilename($keyword) |
||
112 | { |
||
113 | return md5($keyword); |
||
114 | } |
||
115 | |||
116 | /** |
||
117 | * @return bool |
||
118 | */ |
||
119 | public function isExpired() |
||
120 | { |
||
121 | trigger_error(__FUNCTION__ . '() is deprecated, use ExtendedCacheItemInterface::isExpired() instead.', E_USER_DEPRECATED); |
||
122 | |||
123 | return true; |
||
124 | } |
||
125 | |||
126 | |||
127 | /** |
||
128 | * @return string |
||
129 | * @throws \phpFastCache\Exceptions\phpFastCacheCoreException |
||
130 | */ |
||
131 | public function getFileDir() |
||
132 | { |
||
133 | return $this->getPath() . DIRECTORY_SEPARATOR . self::FILE_DIR; |
||
134 | } |
||
135 | |||
136 | /** |
||
137 | * @param $keyword |
||
138 | * @param bool $skip |
||
139 | * @return string |
||
140 | * @throws phpFastCacheDriverException |
||
141 | */ |
||
142 | private function getFilePath($keyword, $skip = false) |
||
143 | { |
||
144 | $path = $this->getFileDir(); |
||
145 | |||
146 | if ($keyword === false) { |
||
147 | return $path; |
||
148 | } |
||
149 | |||
150 | $filename = $this->encodeFilename($keyword); |
||
151 | $folder = substr($filename, 0, 2); |
||
152 | $path = rtrim($path, '/') . '/' . $folder; |
||
153 | /** |
||
154 | * Skip Create Sub Folders; |
||
155 | */ |
||
156 | if ($skip == false) { |
||
157 | if (!file_exists($path)) { |
||
158 | if (@!mkdir($path, $this->setChmodAuto(), true)) { |
||
1 ignored issue
–
show
|
|||
159 | throw new phpFastCacheDriverException('PLEASE CHMOD ' . $this->getPath() . ' - ' . $this->setChmodAuto() . ' OR ANY WRITABLE PERMISSION!'); |
||
160 | } |
||
161 | } |
||
162 | } |
||
163 | |||
164 | return $path . '/' . $filename . '.txt'; |
||
165 | } |
||
166 | |||
167 | |||
168 | /** |
||
169 | * @param $this ->config |
||
170 | * @return int |
||
171 | */ |
||
172 | public function setChmodAuto() |
||
180 | |||
181 | /** |
||
182 | * @param $filename |
||
183 | * @return mixed |
||
184 | */ |
||
185 | protected static function cleanFileName($filename) |
||
196 | |||
197 | /** |
||
198 | * @param $path |
||
199 | * @param bool $create |
||
200 | * @throws \Exception |
||
201 | */ |
||
202 | protected function htaccessGen($path, $create = true) |
||
229 | } |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italy
is not defined by the methodfinale(...)
.The most likely cause is that the parameter was removed, but the annotation was not.