Driver - Code Metrics - Inspection of "Fixed directory write issues" - PHPSocialNetwork/phpfastcache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — v5 ( 3fd0ee...307e18 )

by Georges

created 2016-05-15 02:10 UTC

Driver B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	270
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	9

Importance

Changes	9
Bugs	4	Features	2

Metric	Value
c	9
b	4
f	2
dl	0
loc	270
rs	8.3157
wmc	43
lcom	2
cbo	9

13 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	driverCheck()	4	2
C	driverWrite()	38	8
A	driverRead()	22	3
A	driverDelete()	16	4
C	driverClear()	31	11
A	driverConnect()	4	1
A	driverIsHit()	12	2
B	isValidOption()	24	5
A	getFilesDir()	4	1
A	getValidOptions()	4	1
A	getRequiredOptions()	4	1
A	getStats()	17	2

How to fix Complexity

<?php
/**
 *
 * This file is part of phpFastCache.
 *
 * @license MIT License (MIT)
 *
 * For full copyright and license information, please see the docs/CREDITS.txt file.
 *
 * @author Khoa Bui (khoaofgod)  <[email protected]> http://www.phpfastcache.com
 * @author Georges.L (Geolim4)  <[email protected]>
 *
 */

namespace phpFastCache\Drivers\Files;

use phpFastCache\Cache\ExtendedCacheItemInterface;
use phpFastCache\Core\DriverAbstract;
use phpFastCache\Core\PathSeekerTrait;
use phpFastCache\Core\StandardPsr6StructureTrait;
use phpFastCache\Entities\driverStatistic;
use phpFastCache\Exceptions\phpFastCacheDriverCheckException;
use phpFastCache\Exceptions\phpFastCacheDriverException;
use phpFastCache\Util\Directory;
use Psr\Cache\CacheItemInterface;

/**
 * Class Driver
 * @package phpFastCache\Drivers
 */
class Driver extends DriverAbstract
{
    use PathSeekerTrait, StandardPsr6StructureTrait;
    /**
     *
     */
    const FILES_DIR = 'files';

    /**
     * Driver constructor.
     * @param array $config
     * @throws phpFastCacheDriverException
     */
    public function __construct(array $config = [])
    {
        $this->setup($config);

        if (!$this->driverCheck()) {
            throw new phpFastCacheDriverCheckException(sprintf(self::DRIVER_CHECK_FAILURE, $this->getDriverName()));
        }
    }

    /**
     * @return bool
     */
    public function driverCheck()
    {
        return is_writable($this->getFilesDir()) || @mkdir($this->getFilesDir(), $this->setChmodAuto(), true);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
    }

    /**
     * @param \Psr\Cache\CacheItemInterface $item
     * @return mixed
     * @throws \InvalidArgumentException
     */
    public function driverWrite(CacheItemInterface $item)
    {
        /**
         * Check for Cross-Driver type confusion
         */
        if ($item instanceof Item) {
            $file_path = $this->getFilePath($item->getKey());
            $data = $this->encode($this->driverPreWrap($item));

            $toWrite = true;
            /*
             * Skip if Existing Caching in Options
             */
            if (isset($option[ 'skipExisting' ]) && $option[ 'skipExisting' ] == true && file_exists($file_path)) {

                $content = $this->readfile($file_path);
                $old = $this->decode($content);
                $toWrite = false;
                if ($old->isExpired()) {
                    $toWrite = true;
                }
            }

            // Force write
            try {
                if ($toWrite == true) {

                    $f = fopen($file_path, 'w+');
                    fwrite($f, $data);
                    fclose($f);

                    return true;
                }
            } catch (\Exception $e) {
                return false;
            }
        } else {
            throw new \InvalidArgumentException('Cross-Driver type confusion detected');
        }
    }

    /**
     * @param string $key
     * @return mixed
     * @throws \InvalidArgumentException
     */
    public function driverRead($key)
    {
        /**
         * Check for Cross-Driver type confusion
         */
        $file_path = $this->getFilePath($key);
        if (!file_exists($file_path)) {
            return null;
        }

        $content = $this->readfile($file_path);
        $object = $this->decode($content);

        if ($this->driverUnwrapTime($object)->getTimestamp() < time()) {
            @unlink($file_path);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}

            return null;
        }

        return $object;

    }

    /**
     * @param \Psr\Cache\CacheItemInterface $item
     * @return bool
     * @throws \InvalidArgumentException
     */
    public function driverDelete(CacheItemInterface $item)
    {
        /**
         * Check for Cross-Driver type confusion
         */
        if ($item instanceof Item) {
            $file_path = $this->getFilePath($item->getKey(), true);
            if (file_exists($file_path) && @unlink($file_path)) {
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                return true;
            } else {
                return false;
            }
        } else {
            throw new \InvalidArgumentException('Cross-Driver type confusion detected');
        }
    }

    /**
     * @return bool
     */
    public function driverClear()
    {
        $return = null;
        $path = $this->getFilePath(false);
        $dir = @opendir($path);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
        if (!$dir) {
            throw new phpFastCacheDriverException("Can't read PATH:" . $path);
        }

        while ($file = readdir($dir)) {
            if ($file != '.' && $file != '..' && is_dir($path . '/' . $file)) {
                // read sub dir
                $subdir = @opendir($path . '/' . $file);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                if (!$subdir) {
                    throw new phpFastCacheDriverException("Can't read path:" . $path . '/' . $file);
                }

                while ($subdirFile = readdir($subdir)) {
                    if ($subdirFile != '.' && $subdirFile != '..') {
                        $file_path = $path . '/' . $file . '/' . $subdirFile;
                        $result = @unlink($file_path);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                        if ($return !== false) {
                            $return = $result;
                        }
                    }
                }
            }
        }

        return (bool) $return;
    }

    /**
     * @return bool
     */
    public function driverConnect()
    {
        return true;
    }

    /**
     * @param \Psr\Cache\CacheItemInterface $item
     * @return bool
     * @throws \InvalidArgumentException
     */
    public function driverIsHit(CacheItemInterface $item)
    {
        $file_path = $this->getFilePath($item->getKey(), true);
        if (!file_exists($file_path)) {
            return false;
        } else {
            // check expired or not
            $value = $this->driverRead($item->getKey());

            return !($value == null);
        }
    }

    /**
     * @param string $optionName
     * @param mixed $optionValue
     * @return bool
     * @throws \InvalidArgumentException
     */
    public static function isValidOption($optionName, $optionValue)
    {
        parent::isValidOption($optionName, $optionValue);
        switch($optionName)
        {
            case 'path':
                return is_string($optionValue);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'default_chmod':
                return is_numeric($optionValue);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'securityKey':
                return is_string($optionValue);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'htaccess':
                return is_bool($optionValue);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                return false;
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }

    /**
     * @return string
     * @throws \phpFastCache\Exceptions\phpFastCacheCoreException
     */
    public function getFilesDir()
    {
        return $this->getPath() . DIRECTORY_SEPARATOR . self::FILES_DIR;
    }

    /**
     * @return array
     */
    public static function getValidOptions()
    {
        return ['path', 'default_chmod', 'securityKey', 'htaccess'];
    }

    /**
     * @return array
     */
    public static function getRequiredOptions()
    {
        return ['path'];
    }

    /********************
     *
     * PSR-6 Extended Methods
     *
     *******************/

    /**
     * @return driverStatistic
     * @throws \phpFastCache\Exceptions\phpFastCacheCoreException
     * @throws \phpFastCache\Exceptions\phpFastCacheDriverException
     */
    public function getStats()
    {
        $stat = new driverStatistic();
        $path = $this->getFilePath(false);
        
        if (!is_dir($path)) {
            throw new phpFastCacheDriverException("Can't read PATH:" . $path, 94);
        }else{
            $size = Directory::dirSize($path);
        }

        $stat->setData('')
          ->setSize($size)
          ->setInfo('Number of files used to build the cache: ' . Directory::getFileCount($path));

        return $stat;
    }
}

Push — v5 ( 3fd0ee...307e18 )

Driver B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Complexity

Complex Class

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

1			<?php
2			/**
3			*
4			* This file is part of phpFastCache.
5			*
6			* @license MIT License (MIT)
7			*
8			* For full copyright and license information, please see the docs/CREDITS.txt file.
9			*
10			* @author Khoa Bui (khoaofgod) <[email protected]> http://www.phpfastcache.com
11			* @author Georges.L (Geolim4) <[email protected]>
12			*
13			*/
14
15			namespace phpFastCache\Drivers\Files;
16
17			use phpFastCache\Cache\ExtendedCacheItemInterface;
18			use phpFastCache\Core\DriverAbstract;
19			use phpFastCache\Core\PathSeekerTrait;
20			use phpFastCache\Core\StandardPsr6StructureTrait;
21			use phpFastCache\Entities\driverStatistic;
22			use phpFastCache\Exceptions\phpFastCacheDriverCheckException;
23			use phpFastCache\Exceptions\phpFastCacheDriverException;
24			use phpFastCache\Util\Directory;
25			use Psr\Cache\CacheItemInterface;
26
27			/**
28			* Class Driver
29			* @package phpFastCache\Drivers
30			*/
31			class Driver extends DriverAbstract
32			{
33			use PathSeekerTrait, StandardPsr6StructureTrait;
34			/**
35			*
36			*/
37			const FILES_DIR = 'files';
38
39			/**
40			* Driver constructor.
41			* @param array $config
42			* @throws phpFastCacheDriverException
43			*/
44			public function __construct(array $config = [])
45			{
46			$this->setup($config);
47
48			if (!$this->driverCheck()) {
49			throw new phpFastCacheDriverCheckException(sprintf(self::DRIVER_CHECK_FAILURE, $this->getDriverName()));
50			}
51			}
52
53			/**
54			* @return bool
55			*/
56			public function driverCheck()
57			{
58			return is_writable($this->getFilesDir()) \|\| @mkdir($this->getFilesDir(), $this->setChmodAuto(), true);
			0 ignored issues – show Security File Manipulation introduced 2016-05-15 02:13 UTC by Report Bug Copy Issue Report `$this->getFilesDir()` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
59			}
60
61			/**
62			* @param \Psr\Cache\CacheItemInterface $item
63			* @return mixed
64			* @throws \InvalidArgumentException
65			*/
66			public function driverWrite(CacheItemInterface $item)
67			{
68			/**
69			* Check for Cross-Driver type confusion
70			*/
71			if ($item instanceof Item) {
72			$file_path = $this->getFilePath($item->getKey());
73			$data = $this->encode($this->driverPreWrap($item));
74
75			$toWrite = true;
76			/*
77			* Skip if Existing Caching in Options
78			*/
79			if (isset($option[ 'skipExisting' ]) && $option[ 'skipExisting' ] == true && file_exists($file_path)) {
			0 ignored issues – show Bug introduced 2016-05-12 20:38 UTC by Report Bug Copy Issue Report The variable `$option` seems to never exist, and therefore `isset` should always return `false`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
80			$content = $this->readfile($file_path);
81			$old = $this->decode($content);
82			$toWrite = false;
83			if ($old->isExpired()) {
84			$toWrite = true;
85			}
86			}
87
88			// Force write
89			try {
90			if ($toWrite == true) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-05-12 20:38 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
91			$f = fopen($file_path, 'w+');
92			fwrite($f, $data);
93			fclose($f);
94
95			return true;
96			}
97			} catch (\Exception $e) {
98			return false;
99			}
100			} else {
101			throw new \InvalidArgumentException('Cross-Driver type confusion detected');
102			}
103			}
104
105			/**
106			* @param string $key
107			* @return mixed
108			* @throws \InvalidArgumentException
109			*/
110			public function driverRead($key)
111			{
112			/**
113			* Check for Cross-Driver type confusion
114			*/
115			$file_path = $this->getFilePath($key);
116			if (!file_exists($file_path)) {
117			return null;
118			}
119
120			$content = $this->readfile($file_path);
121			$object = $this->decode($content);
122
123			if ($this->driverUnwrapTime($object)->getTimestamp() < time()) {
124			@unlink($file_path);
			0 ignored issues – show Security File Manipulation introduced 2016-05-15 02:13 UTC by Report Bug Copy Issue Report `$file_path` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
125
126			return null;
127			}
128
129			return $object;
130
131			}
132
133			/**
134			* @param \Psr\Cache\CacheItemInterface $item
135			* @return bool
136			* @throws \InvalidArgumentException
137			*/
138			public function driverDelete(CacheItemInterface $item)
139			{
140			/**
141			* Check for Cross-Driver type confusion
142			*/
143			if ($item instanceof Item) {
144			$file_path = $this->getFilePath($item->getKey(), true);
145			if (file_exists($file_path) && @unlink($file_path)) {
			0 ignored issues – show Security File Manipulation introduced 2016-05-15 02:13 UTC by Report Bug Copy Issue Report `$file_path` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
146			return true;
147			} else {
148			return false;
149			}
150			} else {
151			throw new \InvalidArgumentException('Cross-Driver type confusion detected');
152			}
153			}
154
155			/**
156			* @return bool
157			*/
158			public function driverClear()
159			{
160			$return = null;
161			$path = $this->getFilePath(false);
162			$dir = @opendir($path);
			0 ignored issues – show Security File Exposure introduced 2016-05-15 02:13 UTC by Report Bug Copy Issue Report `$path` can contain request data and is used in file inclusion context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
163			if (!$dir) {
164			throw new phpFastCacheDriverException("Can't read PATH:" . $path);
165			}
166
167			while ($file = readdir($dir)) {
168			if ($file != '.' && $file != '..' && is_dir($path . '/' . $file)) {
169			// read sub dir
170			$subdir = @opendir($path . '/' . $file);
			0 ignored issues – show Security File Exposure introduced 2016-05-15 02:13 UTC by Report Bug Copy Issue Report `$path . '/' . $file` can contain request data and is used in file inclusion context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
171			if (!$subdir) {
172			throw new phpFastCacheDriverException("Can't read path:" . $path . '/' . $file);
173			}
174
175			while ($subdirFile = readdir($subdir)) {
176			if ($subdirFile != '.' && $subdirFile != '..') {
177			$file_path = $path . '/' . $file . '/' . $subdirFile;
178			$result = @unlink($file_path);
			0 ignored issues – show Security File Manipulation introduced 2016-05-15 02:13 UTC by Report Bug Copy Issue Report `$file_path` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
179			if ($return !== false) {
180			$return = $result;
181			}
182			}
183			}
184			}
185			}
186
187			return (bool) $return;
188			}
189
190			/**
191			* @return bool
192			*/
193			public function driverConnect()
194			{
195			return true;
196			}
197
198			/**
199			* @param \Psr\Cache\CacheItemInterface $item
200			* @return bool
201			* @throws \InvalidArgumentException
202			*/
203			public function driverIsHit(CacheItemInterface $item)
204			{
205			$file_path = $this->getFilePath($item->getKey(), true);
206			if (!file_exists($file_path)) {
207			return false;
208			} else {
209			// check expired or not
210			$value = $this->driverRead($item->getKey());
211
212			return !($value == null);
213			}
214			}
215
216			/**
217			* @param string $optionName
218			* @param mixed $optionValue
219			* @return bool
220			* @throws \InvalidArgumentException
221			*/
222			public static function isValidOption($optionName, $optionValue)
223			{
224			parent::isValidOption($optionName, $optionValue);
225			switch($optionName)
226			{
227			case 'path':
228			return is_string($optionValue);
229			break;
			1 ignored issue – show Unused Code introduced 2016-05-14 15:03 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
230
231			case 'default_chmod':
232			return is_numeric($optionValue);
233			break;
			1 ignored issue – show Unused Code introduced 2016-05-14 15:03 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
234
235			case 'securityKey':
236			return is_string($optionValue);
237			break;
			1 ignored issue – show Unused Code introduced 2016-05-15 02:13 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
238			case 'htaccess':
239			return is_bool($optionValue);
240			break;
			1 ignored issue – show Unused Code introduced 2016-05-14 15:03 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
241			default:
242			return false;
243			break;
			1 ignored issue – show Unused Code introduced 2016-05-14 15:03 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
244			}
245			}
246
247			/**
248			* @return string
249			* @throws \phpFastCache\Exceptions\phpFastCacheCoreException
250			*/
251			public function getFilesDir()
252			{
253			return $this->getPath() . DIRECTORY_SEPARATOR . self::FILES_DIR;
254			}
255
256			/**
257			* @return array
258			*/
259			public static function getValidOptions()
260			{
261			return ['path', 'default_chmod', 'securityKey', 'htaccess'];
262			}
263
264			/**
265			* @return array
266			*/
267			public static function getRequiredOptions()
268			{
269			return ['path'];
270			}
271
272			/********************
273			*
274			* PSR-6 Extended Methods
275			*
276			*******************/
277
278			/**
279			* @return driverStatistic
280			* @throws \phpFastCache\Exceptions\phpFastCacheCoreException
281			* @throws \phpFastCache\Exceptions\phpFastCacheDriverException
282			*/
283			public function getStats()
284			{
285			$stat = new driverStatistic();
286			$path = $this->getFilePath(false);
287
288			if (!is_dir($path)) {
289			throw new phpFastCacheDriverException("Can't read PATH:" . $path, 94);
290			}else{
291			$size = Directory::dirSize($path);
292			}
293
294			$stat->setData('')
295			->setSize($size)
296			->setInfo('Number of files used to build the cache: ' . Directory::getFileCount($path));
297
298			return $stat;
299			}
300			}

PHPSocialNetwork / phpfastcache

Push — v5 ( 3fd0ee...307e18 )

Driver B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Complexity

Complex Class

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like