Completed
Push — v5 ( 3c8367...ea3345 )
by Georges
02:37
created
src/phpFastCache/Drivers/Redis/Driver.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -122,11 +122,11 @@
 block discarded – undo
122 122
         } else {
123 123
             $this->instance = $this->instance ?: new RedisClient();
124 124
 
125
-            $host = isset($this->config[ 'host' ]) ? $this->config[ 'host' ] : '127.0.0.1';
126
-            $port = isset($this->config[ 'port' ]) ? (int) $this->config[ 'port' ] : '6379';
127
-            $password = isset($this->config[ 'password' ]) ? $this->config[ 'password' ] : '';
128
-            $database = isset($this->config[ 'database' ]) ? $this->config[ 'database' ] : '';
129
-            $timeout = isset($this->config[ 'timeout' ]) ? $this->config[ 'timeout' ] : '';
125
+            $host = isset($this->config['host']) ? $this->config['host'] : '127.0.0.1';
126
+            $port = isset($this->config['port']) ? (int) $this->config['port'] : '6379';
127
+            $password = isset($this->config['password']) ? $this->config['password'] : '';
128
+            $database = isset($this->config['database']) ? $this->config['database'] : '';
129
+            $timeout = isset($this->config['timeout']) ? $this->config['timeout'] : '';
130 130
 
131 131
             if (!$this->instance->connect($host, (int) $port, (int) $timeout)) {
132 132
                 return false;
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -175,9 +175,9 @@
 block discarded – undo
175 175
         $info = $this->instance->info();
176 176
         $date = (new \DateTime())->setTimestamp(time() - $info['uptime_in_seconds']);
177 177
         return (new driverStatistic())
178
-          ->setData(implode(', ', array_keys($this->itemInstances)))
179
-          ->setRawData($info)
180
-          ->setSize($info['used_memory'])
181
-          ->setInfo(sprintf("The Redis daemon v%s is up since %s.\n For more information see RawData. \n Driver size includes the memory allocation size.", $info['redis_version'], $date->format(DATE_RFC2822)));
178
+            ->setData(implode(', ', array_keys($this->itemInstances)))
179
+            ->setRawData($info)
180
+            ->setSize($info['used_memory'])
181
+            ->setInfo(sprintf("The Redis daemon v%s is up since %s.\n For more information see RawData. \n Driver size includes the memory allocation size.", $info['redis_version'], $date->format(DATE_RFC2822)));
182 182
     }
183 183
 }
184 184
\ No newline at end of file
Please login to merge, or discard this patch.
src/phpFastCache/Drivers/Cookie/Item.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
             $this->driver->setItem($this);
43 43
         } else {
44 44
             throw new \InvalidArgumentException(sprintf('$key must be a string, got type "%s" instead.',
45
-              gettype($key)));
45
+                gettype($key)));
46 46
         }
47 47
     }
48 48
 
Please login to merge, or discard this patch.
src/phpFastCache/Drivers/Cookie/Driver.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             $keyword = self::PREFIX . $item->getKey();
80 80
             $v = json_encode($this->driverPreWrap($item));
81 81
 
82
-            if (isset($this->config[ 'limited_memory_each_object' ]) && strlen($v) > $this->config[ 'limited_memory_each_object' ]) {
82
+            if (isset($this->config['limited_memory_each_object']) && strlen($v) > $this->config['limited_memory_each_object']) {
83 83
                 return false;
84 84
             }
85 85
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         // return null if no caching
101 101
         // return value if in caching
102 102
         $keyword = self::PREFIX . $key;
103
-        $x = isset($_COOKIE[ $keyword ]) ? $this->decode(json_decode($_COOKIE[ $keyword ], true)) : false;
103
+        $x = isset($_COOKIE[$keyword]) ? $this->decode(json_decode($_COOKIE[$keyword], true)) : false;
104 104
 
105 105
         if ($x == false) {
106 106
             return null;
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     {
122 122
         $this->driverConnect();
123 123
         $keyword = self::PREFIX . $key;
124
-        $x = isset($_COOKIE[ $keyword ]) ? $this->decode(json_decode($_COOKIE[ $keyword ])->t) : false;
124
+        $x = isset($_COOKIE[$keyword]) ? $this->decode(json_decode($_COOKIE[$keyword])->t) : false;
125 125
 
126 126
         return $x ? $x - time() : $x;
127 127
     }
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
         if ($item instanceof Item) {
140 140
             $this->driverConnect();
141 141
             $keyword = self::PREFIX . $item->getKey();
142
-            $_COOKIE[ $keyword ] = null;
142
+            $_COOKIE[$keyword] = null;
143 143
 
144 144
             return @setcookie($keyword, null, -10);
145 145
         } else {
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
         $this->driverConnect();
157 157
         foreach ($_COOKIE as $keyword => $value) {
158 158
             if (strpos($keyword, self::PREFIX) !== false) {
159
-                $_COOKIE[ $keyword ] = null;
159
+                $_COOKIE[$keyword] = null;
160 160
                 $result = @setcookie($keyword, null, -10);
161 161
                 if ($return !== false) {
162 162
                     $return = $result;
Please login to merge, or discard this patch.
src/phpFastCache/Drivers/Leveldb/Driver.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
     }
129 129
 
130 130
     /**
131
-     * @return bool
131
+     * @return boolean|null
132 132
      */
133 133
     public function driverConnect()
134 134
     {
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -176,9 +176,9 @@
 block discarded – undo
176 176
     public function getStats()
177 177
     {
178 178
         return (new driverStatistic())
179
-          ->setData(implode(', ', array_keys($this->itemInstances)))
180
-          ->setInfo('Number of files used to build the cache: ' . Directory::getFileCount($this->getLeveldbFile()))
181
-          ->setSize(Directory::dirSize($this->getLeveldbFile()));
179
+            ->setData(implode(', ', array_keys($this->itemInstances)))
180
+            ->setInfo('Number of files used to build the cache: ' . Directory::getFileCount($this->getLeveldbFile()))
181
+            ->setSize(Directory::dirSize($this->getLeveldbFile()));
182 182
     }
183 183
 
184 184
     /**
Please login to merge, or discard this patch.
src/phpFastCache/Drivers/Ssdb/Driver.php 3 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -147,10 +147,10 @@
 block discarded – undo
147 147
     {
148 148
         try{
149 149
             $server = isset($this->config[ 'ssdb' ]) ? $this->config[ 'ssdb' ] : [
150
-              'host' => "127.0.0.1",
151
-              'port' => 8888,
152
-              'password' => '',
153
-              'timeout' => 2000,
150
+                'host' => "127.0.0.1",
151
+                'port' => 8888,
152
+                'password' => '',
153
+                'timeout' => 2000,
154 154
             ];
155 155
 
156 156
             $host = $server[ 'host' ];
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -145,18 +145,18 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function driverConnect()
147 147
     {
148
-        try{
149
-            $server = isset($this->config[ 'ssdb' ]) ? $this->config[ 'ssdb' ] : [
148
+        try {
149
+            $server = isset($this->config['ssdb']) ? $this->config['ssdb'] : [
150 150
               'host' => "127.0.0.1",
151 151
               'port' => 8888,
152 152
               'password' => '',
153 153
               'timeout' => 2000,
154 154
             ];
155 155
 
156
-            $host = $server[ 'host' ];
157
-            $port = isset($server[ 'port' ]) ? (int) $server[ 'port' ] : 8888;
158
-            $password = isset($server[ 'password' ]) ? $server[ 'password' ] : '';
159
-            $timeout = !empty($server[ 'timeout' ]) ? (int) $server[ 'timeout' ] : 2000;
156
+            $host = $server['host'];
157
+            $port = isset($server['port']) ? (int) $server['port'] : 8888;
158
+            $password = isset($server['password']) ? $server['password'] : '';
159
+            $timeout = !empty($server['timeout']) ? (int) $server['timeout'] : 2000;
160 160
             $this->instance = new SimpleSSDB($host, $port, $timeout);
161 161
             if (!empty($password)) {
162 162
                 $this->instance->auth($password);
@@ -167,8 +167,8 @@  discard block
 block discarded – undo
167 167
             } else {
168 168
                 return true;
169 169
             }
170
-        }catch(SSDBException $e){
171
-            throw new phpFastCacheDriverException('Ssdb failed to connect with error: '. $e->getMessage(), 0 , $e);
170
+        } catch (SSDBException $e) {
171
+            throw new phpFastCacheDriverException('Ssdb failed to connect with error: ' . $e->getMessage(), 0, $e);
172 172
         }
173 173
     }
174 174
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
             } else {
168 168
                 return true;
169 169
             }
170
-        }catch(SSDBException $e){
170
+        } catch(SSDBException $e){
171 171
             throw new phpFastCacheDriverException('Ssdb failed to connect with error: '. $e->getMessage(), 0 , $e);
172 172
         }
173 173
     }
Please login to merge, or discard this patch.
src/phpFastCache/Cache/DriverBaseTrait.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
 
116 116
 
117 117
     /**
118
-     * @param $file
118
+     * @param string $file
119 119
      * @return string
120 120
      * @throws \Exception
121 121
      */
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -214,9 +214,9 @@
 block discarded – undo
214 214
     public function driverPreWrap(ExtendedCacheItemInterface $item)
215 215
     {
216 216
         return [
217
-          self::DRIVER_DATA_WRAPPER_INDEX => $item->get(),
218
-          self::DRIVER_TIME_WRAPPER_INDEX => $item->getExpirationDate(),
219
-          self::DRIVER_TAGS_WRAPPER_INDEX => $item->getTags(),
217
+            self::DRIVER_DATA_WRAPPER_INDEX => $item->get(),
218
+            self::DRIVER_TIME_WRAPPER_INDEX => $item->getExpirationDate(),
219
+            self::DRIVER_TAGS_WRAPPER_INDEX => $item->getTags(),
220 220
         ];
221 221
     }
222 222
 
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         if (is_array($config_name)) {
66 66
             $this->config = array_merge($this->config, $config_name);
67 67
         } else {
68
-            $this->config[ $config_name ] = $value;
68
+            $this->config[$config_name] = $value;
69 69
         }
70 70
     }
71 71
 
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
      */
183 183
     public function driverUnwrapData(array $wrapper)
184 184
     {
185
-        return $wrapper[ self::DRIVER_DATA_WRAPPER_INDEX ];
185
+        return $wrapper[self::DRIVER_DATA_WRAPPER_INDEX];
186 186
     }
187 187
 
188 188
     /**
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
      */
192 192
     public function driverUnwrapTags(array $wrapper)
193 193
     {
194
-        return $wrapper[ self::DRIVER_TAGS_WRAPPER_INDEX ];
194
+        return $wrapper[self::DRIVER_TAGS_WRAPPER_INDEX];
195 195
     }
196 196
 
197 197
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
      */
202 202
     public function driverUnwrapTime(array $wrapper)
203 203
     {
204
-        return $wrapper[ self::DRIVER_TIME_WRAPPER_INDEX ];
204
+        return $wrapper[self::DRIVER_TIME_WRAPPER_INDEX];
205 205
     }
206 206
 
207 207
     /**
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
         foreach ($tagsItems as $tagsItem) {
256 256
             $data = (array) $tagsItem->get();
257 257
 
258
-            unset($data[ $item->getKey() ]);
258
+            unset($data[$item->getKey()]);
259 259
             $tagsItem->set($data);
260 260
 
261 261
             /**
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
      */
307 307
     public static function isValidOption($optionName, $optionValue)
308 308
     {
309
-        if(!is_string($optionName))
309
+        if (!is_string($optionName))
310 310
         {
311 311
             throw new \InvalidArgumentException('$optionName must be a string');
312 312
         }
Please login to merge, or discard this patch.
src/phpFastCache/Drivers/Apc/Driver.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -154,9 +154,9 @@
 block discarded – undo
154 154
         $stats = (array) apc_cache_info('user');
155 155
         $date = (new \DateTime())->setTimestamp($stats['start_time']);
156 156
         return (new driverStatistic())
157
-          ->setData(implode(', ', array_keys($this->itemInstances)))
158
-          ->setInfo(sprintf("The APC cache is up since %s, and have %d item(s) in cache.\n For more information see RawData.", $date->format(DATE_RFC2822), $stats['num_entries']))
159
-          ->setRawData($stats)
160
-          ->setSize($stats['mem_size']);
157
+            ->setData(implode(', ', array_keys($this->itemInstances)))
158
+            ->setInfo(sprintf("The APC cache is up since %s, and have %d item(s) in cache.\n For more information see RawData.", $date->format(DATE_RFC2822), $stats['num_entries']))
159
+            ->setRawData($stats)
160
+            ->setSize($stats['mem_size']);
161 161
     }
162 162
 }
163 163
\ No newline at end of file
Please login to merge, or discard this patch.
src/phpFastCache/Util/Directory.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,8 +83,8 @@
 block discarded – undo
83 83
 
84 84
         $files = new RecursiveIteratorIterator
85 85
         (
86
-          new RecursiveDirectoryIterator($source, RecursiveDirectoryIterator::SKIP_DOTS),
87
-          RecursiveIteratorIterator::CHILD_FIRST
86
+            new RecursiveDirectoryIterator($source, RecursiveDirectoryIterator::SKIP_DOTS),
87
+            RecursiveIteratorIterator::CHILD_FIRST
88 88
         );
89 89
         
90 90
         foreach ($files as $fileinfo) {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -81,8 +81,7 @@  discard block
 block discarded – undo
81 81
             return unlink($source);
82 82
         }
83 83
 
84
-        $files = new RecursiveIteratorIterator
85
-        (
84
+        $files = new RecursiveIteratorIterator(
86 85
           new RecursiveDirectoryIterator($source, RecursiveDirectoryIterator::SKIP_DOTS),
87 86
           RecursiveIteratorIterator::CHILD_FIRST
88 87
         );
@@ -95,7 +94,7 @@  discard block
 block discarded – undo
95 94
                 if (self::rrmdir($fileinfo->getRealPath()) === false) {
96 95
                     return false;
97 96
                 }
98
-            } else if(unlink($fileinfo->getRealPath()) === false) {
97
+            } else if (unlink($fileinfo->getRealPath()) === false) {
99 98
                 return false;
100 99
             }
101 100
         }
Please login to merge, or discard this patch.
src/phpFastCache/CacheManager.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
       'fallback' => 'files', //Fall back when old driver is not support
57 57
       'securityKey' => 'auto',
58 58
       'htaccess' => true,
59
-      'path' => '',// if not set will be the value of sys_get_temp_dir()
59
+      'path' => '', // if not set will be the value of sys_get_temp_dir()
60 60
       "limited_memory_each_object" => 4096, // maximum size (bytes) of object store in memory
61 61
       "compress_data" => false, // compress stored data, if the backend supports it
62 62
     ];
@@ -82,15 +82,15 @@  discard block
 block discarded – undo
82 82
         }
83 83
 
84 84
         $instance = crc32($driver . serialize($config));
85
-        if (!isset(self::$instances[ $instance ])) {
85
+        if (!isset(self::$instances[$instance])) {
86 86
             $class = self::getNamespacePath() . $driver . '\Driver';
87
-            self::$instances[ $instance ] = new $class($config);
87
+            self::$instances[$instance] = new $class($config);
88 88
         } else {
89 89
            // trigger_error('[' . $driver . '] Calling CacheManager::getInstance for already instanced drivers is a bad practice and have a significant impact on performances.
90 90
            // See https://github.com/PHPSocialNetwork/phpfastcache/wiki/[V5]-Why-calling-getInstance%28%29-each-time-is-a-bad-practice-%3F');
91 91
         }
92 92
 
93
-        return self::$instances[ $instance ];
93
+        return self::$instances[$instance];
94 94
     }
95 95
 
96 96
     /**
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
      */
124 124
     public static function __callStatic($name, $arguments)
125 125
     {
126
-        $options = (array_key_exists(0, $arguments) && is_array($arguments) ? $arguments[ 0 ] : []);
126
+        $options = (array_key_exists(0, $arguments) && is_array($arguments) ? $arguments[0] : []);
127 127
 
128 128
         return self::getInstance($name, $options);
129 129
     }
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         if (is_array($name)) {
166 166
             self::$config = array_merge(self::$config, $name);
167 167
         } else {
168
-            self::$config[ $name ] = $value;
168
+            self::$config[$name] = $value;
169 169
         }
170 170
     }
171 171
 
Please login to merge, or discard this patch.
Indentation   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -52,13 +52,13 @@  discard block
 block discarded – undo
52 52
      * @var array
53 53
      */
54 54
     public static $config = [
55
-      'default_chmod' => 0777, // 0777 recommended
56
-      'fallback' => 'files', //Fall back when old driver is not support
57
-      'securityKey' => 'auto',
58
-      'htaccess' => true,
59
-      'path' => '',// if not set will be the value of sys_get_temp_dir()
60
-      "limited_memory_each_object" => 4096, // maximum size (bytes) of object store in memory
61
-      "compress_data" => false, // compress stored data, if the backend supports it
55
+        'default_chmod' => 0777, // 0777 recommended
56
+        'fallback' => 'files', //Fall back when old driver is not support
57
+        'securityKey' => 'auto',
58
+        'htaccess' => true,
59
+        'path' => '',// if not set will be the value of sys_get_temp_dir()
60
+        "limited_memory_each_object" => 4096, // maximum size (bytes) of object store in memory
61
+        "compress_data" => false, // compress stored data, if the backend supports it
62 62
     ];
63 63
 
64 64
     /**
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             $class = self::getNamespacePath() . $driver . '\Driver';
90 90
             self::$instances[ $instance ] = new $class($config);
91 91
         } else {
92
-           trigger_error('[' . $driver . '] Calling CacheManager::getInstance for already instanced drivers is a bad practice and have a significant impact on performances.
92
+            trigger_error('[' . $driver . '] Calling CacheManager::getInstance for already instanced drivers is a bad practice and have a significant impact on performances.
93 93
            See https://github.com/PHPSocialNetwork/phpfastcache/wiki/[V5]-Why-calling-getInstance%28%29-each-time-is-a-bad-practice-%3F');
94 94
         }
95 95
 
@@ -178,21 +178,21 @@  discard block
 block discarded – undo
178 178
     public static function getStaticSystemDrivers()
179 179
     {
180 180
         return [
181
-          'Sqlite',
182
-          'Files',
183
-          'Apc',
184
-          'Apcu',
185
-          'Memcache',
186
-          'Memcached',
187
-          'Couchbase',
188
-          'Mongodb',
189
-          'Predis',
190
-          'Redis',
191
-          'Ssdb',
192
-          'Leveldb',
193
-          'Wincache',
194
-          'Xcache',
195
-          'Devnull',
181
+            'Sqlite',
182
+            'Files',
183
+            'Apc',
184
+            'Apcu',
185
+            'Memcache',
186
+            'Memcached',
187
+            'Couchbase',
188
+            'Mongodb',
189
+            'Predis',
190
+            'Redis',
191
+            'Ssdb',
192
+            'Leveldb',
193
+            'Wincache',
194
+            'Xcache',
195
+            'Devnull',
196 196
         ];
197 197
     }
198 198
 
Please login to merge, or discard this patch.