PHPSocialNetwork / phpfastcache

src/phpFastCache/EventManager.php

Braces +3 added lines, -3 removed lines

@@ -84,13 +84,13 @@
             if(is_callable($arguments[0])){
                 if(isset($arguments[1]) && is_string($arguments[0])){
                     $this->events[$name][$arguments[1]] = $arguments[0];
-                }else {
+                } else {
                     $this->events[$name][] = $arguments[0];
                 }
-            }else{
+            } else{
                 throw new \InvalidArgumentException(sprintf('Expected Callable, got "%s"', gettype($arguments[0])));
             }
-        }else{
+        } else{
             throw new \BadMethodCallException('An event must start with "on" such as "onCacheGetItem"');
         }
     }

Spacing +9 added lines, -9 removed lines

@@ -66,8 +66,8 @@ 
     public function dispatch($eventName, ...$args)
     {
         $eventName = 'on' . ucfirst($eventName);
-        if(array_key_exists($eventName, $this->events)){
-            foreach ($this->events[ $eventName ] as $event) {
+        if (array_key_exists($eventName, $this->events)) {
+            foreach ($this->events[$eventName] as $event) {
                 call_user_func_array($event, $args);
             }
         }
@@ -81,17 +81,17 @@ 
      */
     public function __call($name, $arguments)
     {
-        if(strpos($name, 'on') === 0){
-            if(is_callable($arguments[0])){
-                if(isset($arguments[1]) && is_string($arguments[0])){
+        if (strpos($name, 'on') === 0) {
+            if (is_callable($arguments[0])) {
+                if (isset($arguments[1]) && is_string($arguments[0])) {
                     $this->events[$name][$arguments[1]] = $arguments[0];
-                }else {
+                } else {
                     $this->events[$name][] = $arguments[0];
                 }
-            }else{
+            } else {
                 throw new \InvalidArgumentException(sprintf('Expected Callable, got "%s"', gettype($arguments[0])));
             }
-        }else{
+        } else {
             throw new \BadMethodCallException('An event must start with "on" such as "onCacheGetItem"');
         }
     }
@@ -103,7 +103,7 @@ 
      */
     public function unbindEventCallback($eventName, $callbackName)
     {
-        if(isset($this->events[$eventName][$callbackName])){
+        if (isset($this->events[$eventName][$callbackName])) {
             unset($this->events[$eventName][$callbackName]);
             return true;
         }

tests/NewCacheInstance.test.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 if (!class_exists('phpFastCache\CacheManager')) {
     echo "[FAIL] Autoload failed to find the CacheManager\n";
     $status = 255;
-}else{
+} else {
     echo "[PASS] Autoload successfully found the CacheManager\n";
 }
 

Braces +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 if (!class_exists('phpFastCache\CacheManager')) {
     echo "[FAIL] Autoload failed to find the CacheManager\n";
     $status = 255;
-}else{
+} else{
     echo "[PASS] Autoload successfully found the CacheManager\n";
 }
 

tests/EventManager.test.php

Spacing +4 added lines, -4 removed lines

@@ -16,8 +16,8 @@ 
 $status = 0;
 echo "Testing EventManager\n";
 
-EventManager::getInstance()->onCacheSaveItem(function(ExtendedCacheItemPoolInterface $itemPool, ExtendedCacheItemInterface $item){
-    if($item->get() === 1000){
+EventManager::getInstance()->onCacheSaveItem(function(ExtendedCacheItemPoolInterface $itemPool, ExtendedCacheItemInterface $item) {
+    if ($item->get() === 1000) {
         $item->increment(337);
     }
 });
@@ -30,9 +30,9 @@ 
 $cacheInstance->save($item);
 
 
-if($cacheInstance->getItem($cacheKey)->get() === 1337){
+if ($cacheInstance->getItem($cacheKey)->get() === 1337) {
     echo "[PASS] The dispatched event executed the custom callback to alter to item.\n";
-}else{
+} else {
     echo "[FAIL] The dispatched event did not worked well, the expected value '1337', got '" . (int) $cacheInstance->getItem($cacheKey)->get() . "'\n";
     $status = 1;
 }

Braces +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 if (!class_exists('phpFastCache\CacheManager')) {
     echo "[FAIL] Autoload failed to find the CacheManager\n";
     $status = 255;
-}else{
+} else{
     echo "[PASS] Autoload successfully found the CacheManager\n";
 }
 

src/phpFastCache/Drivers/Files/Driver.php

Doc Comments +4 added lines, -4 removed lines

@@ -60,7 +60,7 @@ 
 
     /**
      * @param \Psr\Cache\CacheItemInterface $item
-     * @return mixed
+     * @return boolean
      * @throws \InvalidArgumentException
      */
     protected function driverWrite(CacheItemInterface $item)
@@ -146,7 +146,7 @@ 
     /**
      * @param string $optionName
      * @param mixed $optionValue
-     * @return bool
+     * @return boolean|null
      * @throws \InvalidArgumentException
      */
     public static function isValidOption($optionName, $optionValue)
@@ -174,7 +174,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getValidOptions()
     {
@@ -182,7 +182,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getRequiredOptions()
     {

src/phpFastCache/Core/Pool/IO/IOHelperTrait.php

Braces +3 added lines, -3 removed lines

@@ -97,11 +97,11 @@ 
                 return $tmp_dir;
             }
             return $full_path;
-        }else{
+        } else{
             if (!isset($this->tmp[ $full_path_hash ]) || (!@file_exists($full_path) || !@is_writable($full_path))) {
                 if (!@file_exists($full_path)) {
                     @mkdir($full_path, $this->setChmodAuto(), true);
-                }else if (!@is_writable($full_path)) {
+                } else if (!@is_writable($full_path)) {
                     @chmod($full_path, $this->setChmodAuto());
                 }
 
@@ -312,7 +312,7 @@ 
             if(!rename($tmpFilename, $file)){
                 throw new phpFastCacheIOException(sprintf('Failed to rename %s to %s', $tmpFilename, $file));
             }
-        }else{
+        } else{
             $f = fopen($file, 'w+');
             $octetWritten = fwrite($f, $data);
             fclose($f);

Spacing +18 added lines, -18 removed lines

@@ -41,10 +41,10 @@ 
          * Calculate the security key
          */
         {
-            $securityKey = array_key_exists('securityKey', $this->config) ? $this->config[ 'securityKey' ] : '';
+            $securityKey = array_key_exists('securityKey', $this->config) ? $this->config['securityKey'] : '';
             if (!$securityKey || $securityKey === 'auto') {
-                if (isset($_SERVER[ 'HTTP_HOST' ])) {
-                    $securityKey = preg_replace('/^www./', '', strtolower(str_replace(':', '_', $_SERVER[ 'HTTP_HOST' ])));
+                if (isset($_SERVER['HTTP_HOST'])) {
+                    $securityKey = preg_replace('/^www./', '', strtolower(str_replace(':', '_', $_SERVER['HTTP_HOST'])));
                 } else {
                     $securityKey = ($this->isPHPModule() ? 'web' : 'cli');
                 }
@@ -63,10 +63,10 @@ 
          */
         $tmp_dir = rtrim($tmp_dir, '/') . DIRECTORY_SEPARATOR;
 
-        if (empty($this->config[ 'path' ]) || !is_string($this->config[ 'path' ])) {
+        if (empty($this->config['path']) || !is_string($this->config['path'])) {
             $path = $tmp_dir;
         } else {
-            $path = rtrim($this->config[ 'path' ], '/') . DIRECTORY_SEPARATOR;
+            $path = rtrim($this->config['path'], '/') . DIRECTORY_SEPARATOR;
         }
 
         $path_suffix = $securityKey . DIRECTORY_SEPARATOR . $this->getDriverName();
@@ -81,16 +81,16 @@ 
          * return the temp dir
          */
         if ($readonly === true) {
-            if($this->config[ 'autoTmpFallback' ] && (!@file_exists($full_path) || !@is_writable($full_path))){
+            if ($this->config['autoTmpFallback'] && (!@file_exists($full_path) || !@is_writable($full_path))) {
                 return $full_path_tmp;
             }
             return $full_path;
-        }else{
-            if (!isset($this->tmp[ $full_path_hash ]) || (!@file_exists($full_path) || !@is_writable($full_path))) {
+        } else {
+            if (!isset($this->tmp[$full_path_hash]) || (!@file_exists($full_path) || !@is_writable($full_path))) {
                 if (!@file_exists($full_path)) {
                     @mkdir($full_path, $this->setChmodAuto(), true);
-                }else if (!@is_writable($full_path)) {
-                    if (!@chmod($full_path, $this->setChmodAuto()) && $this->config[ 'autoTmpFallback' ])
+                } else if (!@is_writable($full_path)) {
+                    if (!@chmod($full_path, $this->setChmodAuto()) && $this->config['autoTmpFallback'])
                     {
                         /**
                          * Switch back to tmp dir
@@ -112,8 +112,8 @@ 
                     throw new phpFastCacheIOException('PLEASE CREATE OR CHMOD ' . $full_path . ' - 0777 OR ANY WRITABLE PERMISSION!');
                 }
 
-                $this->tmp[ $full_path_hash ] = $full_path;
-                $this->htaccessGen($full_path, array_key_exists('htaccess', $this->config) ? $this->config[ 'htaccess' ] : false);
+                $this->tmp[$full_path_hash] = $full_path;
+                $this->htaccessGen($full_path, array_key_exists('htaccess', $this->config) ? $this->config['htaccess'] : false);
             }
         }
 
@@ -180,10 +180,10 @@ 
      */
     public function setChmodAuto()
     {
-        if (!isset($this->config[ 'default_chmod' ]) || $this->config[ 'default_chmod' ] == '' || is_null($this->config[ 'default_chmod' ])) {
+        if (!isset($this->config['default_chmod']) || $this->config['default_chmod'] == '' || is_null($this->config['default_chmod'])) {
             return 0777;
         } else {
-            return $this->config[ 'default_chmod' ];
+            return $this->config['default_chmod'];
         }
     }
 
@@ -213,7 +213,7 @@ 
         if ($create === true) {
             if (!is_writable($path)) {
                 try {
-                    if(!chmod($path, 0777)){
+                    if (!chmod($path, 0777)) {
                         throw new phpFastCacheIOException('Chmod failed on : ' . $path);
                     }
                 } catch (phpFastCacheIOException $e) {
@@ -284,7 +284,7 @@ 
          */
         $this->eventManager->dispatch('CacheWriteFileOnDisk', $this, $file, $secureFileManipulation);
 
-        if($secureFileManipulation){
+        if ($secureFileManipulation) {
             $tmpFilename = Directory::getAbsolutePath(dirname($file) . '/tmp_' . md5(
                 str_shuffle(uniqid($this->getDriverName(), false))
                 . str_shuffle(uniqid($this->getDriverName(), false))
@@ -296,10 +296,10 @@ 
             flock($f, LOCK_UN);
             fclose($f);
 
-            if(!rename($tmpFilename, $file)){
+            if (!rename($tmpFilename, $file)) {
                 throw new phpFastCacheIOException(sprintf('Failed to rename %s to %s', $tmpFilename, $file));
             }
-        }else{
+        } else {
             $f = fopen($file, 'w+');
             $octetWritten = fwrite($f, $data);
             fclose($f);

Doc Comments +4 added lines, -4 removed lines

@@ -130,7 +130,7 @@ 
 
 
     /**
-     * @param $keyword
+     * @param false|string $keyword
      * @param bool $skip
      * @return string
      * @throws phpFastCacheIOException
@@ -197,7 +197,7 @@ 
 
     /**
      * @param $filename
-     * @return mixed
+     * @return string
      */
     protected static function cleanFileName($filename)
     {
@@ -212,7 +212,7 @@ 
     }
 
     /**
-     * @param $path
+     * @param string $path
      * @param bool $create
      * @throws phpFastCacheIOException
      */
@@ -249,7 +249,7 @@ 
 
 
     /**
-     * @param $file
+     * @param string $file
      * @return string
      * @throws phpFastCacheIOException
      */

Indentation +8 added lines, -8 removed lines

@@ -202,9 +202,9 @@ 
     protected static function cleanFileName($filename)
     {
         $regex = [
-          '/[\?\[\]\/\\\=\<\>\:\;\,\'\"\&\$\#\*\(\)\|\~\`\!\{\}]/',
-          '/\.$/',
-          '/^\./',
+            '/[\?\[\]\/\\\=\<\>\:\;\,\'\"\&\$\#\*\(\)\|\~\`\!\{\}]/',
+            '/\.$/',
+            '/^\./',
         ];
         $replace = ['-', '', ''];
 
@@ -296,7 +296,7 @@ 
             $tmpFilename = Directory::getAbsolutePath(dirname($file) . '/tmp_' . md5(
                 str_shuffle(uniqid($this->getDriverName(), false))
                 . str_shuffle(uniqid($this->getDriverName(), false))
-              ));
+                ));
 
             $f = fopen($tmpFilename, 'w+');
             flock($f, LOCK_EX);
@@ -338,11 +338,11 @@ 
         }
 
         $stat->setData(implode(', ', array_keys($this->itemInstances)))
-          ->setRawData([
+            ->setRawData([
             'tmp' => $this->tmp
-          ])
-          ->setSize(Directory::dirSize($path))
-          ->setInfo('Number of files used to build the cache: ' . Directory::getFileCount($path));
+            ])
+            ->setSize(Directory::dirSize($path))
+            ->setInfo('Number of files used to build the cache: ' . Directory::getFileCount($path));
 
         return $stat;
     }

tests/ReadWriteOperations.test.php

Indentation +3 added lines, -3 removed lines

@@ -23,9 +23,9 @@
 $keys = [];
 
 $dirs = [
-  __DIR__ . '/../var/cache/IO-',
-  sys_get_temp_dir() . '/phpfastcache/IO-1',
-  sys_get_temp_dir() . '/phpfastcache/IO-2'
+    __DIR__ . '/../var/cache/IO-',
+    sys_get_temp_dir() . '/phpfastcache/IO-1',
+    sys_get_temp_dir() . '/phpfastcache/IO-2'
 ];
 
 

Spacing +5 added lines, -5 removed lines

@@ -39,9 +39,9 @@ 
     {
         $cacheInstanceName = 'cacheInstance' . $i;
 
-        $instances[$dirIndex][$cacheInstanceName] = CacheManager::getInstance('Files',array('path' => $dir . str_pad($i, 3, '0', STR_PAD_LEFT)));
+        $instances[$dirIndex][$cacheInstanceName] = CacheManager::getInstance('Files', array('path' => $dir . str_pad($i, 3, '0', STR_PAD_LEFT)));
 
-        foreach($keys[$dirIndex] as $index => $key)
+        foreach ($keys[$dirIndex] as $index => $key)
         {
             $items[$dirIndex][$index] = $instances[$dirIndex][$cacheInstanceName]->getItem($key);
             $items[$dirIndex][$index]->set("test-$dirIndex-$index")->expiresAfter(600);
@@ -51,11 +51,11 @@ 
         $instances[$dirIndex][$cacheInstanceName]->detachAllItems();
     }
 
-    foreach($instances[$dirIndex] as $cacheInstanceName => $instance)
+    foreach ($instances[$dirIndex] as $cacheInstanceName => $instance)
     {
-        foreach($keys[$dirIndex] as $index => $key)
+        foreach ($keys[$dirIndex] as $index => $key)
         {
-            if($instances[$dirIndex][$cacheInstanceName]->getItem($key)->get() === "test-$dirIndex-$index")
+            if ($instances[$dirIndex][$cacheInstanceName]->getItem($key)->get() === "test-$dirIndex-$index")
             {
                 echo "[PASS] Item #{$key} of instance #{$cacheInstanceName} of dir #{$dirIndex} has returned the expected value (" . gettype("test-$dirIndex-$index") . ":'" . "test-$dirIndex-$index" . "')\n";
             }

Braces +1 added lines, -2 removed lines

@@ -58,8 +58,7 @@
             if($instances[$dirIndex][$cacheInstanceName]->getItem($key)->get() === "test-$dirIndex-$index")
             {
                 echo "[PASS] Item #{$key} of instance #{$cacheInstanceName} of dir #{$dirIndex} has returned the expected value (" . gettype("test-$dirIndex-$index") . ":'" . "test-$dirIndex-$index" . "')\n";
-            }
-            else
+            } else
             {
                 echo "[FAIL] Item #{$key} of instance #{$cacheInstanceName} of dir #{$dirIndex} returned an unexpected value (" . gettype($instances[$dirIndex][$cacheInstanceName]->getItem($key)->get()) . ":'" . $instances[$dirIndex][$cacheInstanceName]->getItem($key)->get() . "') expected (" . gettype("test-$dirIndex-$index") . ":'" . "test-$dirIndex-$index" . "') \n";
                 $status = 255;

src/autoload.php

Indentation +1 added lines, -1 removed lines

@@ -46,6 +46,6 @@
 });
 
 if ((!defined('PFC_IGNORE_COMPOSER_WARNING') || !PFC_IGNORE_COMPOSER_WARNING) && class_exists('Composer\Autoload\ClassLoader')) {
-  trigger_error('Your project already makes use of Composer. You SHOULD use the composer dependency "phpfastcache/phpfastcache" instead of hard-autoloading.',
+    trigger_error('Your project already makes use of Composer. You SHOULD use the composer dependency "phpfastcache/phpfastcache" instead of hard-autoloading.',
     E_USER_WARNING);
 }
\ No newline at end of file

Spacing +4 added lines, -4 removed lines

@@ -18,9 +18,9 @@ 
 /**
  * Register Autoload
  */
-spl_autoload_register(function ($entity) {
+spl_autoload_register(function($entity) {
     $module = explode('\\', $entity, 2);
-    if (!in_array($module[ 0 ], ['phpFastCache', 'Psr'])) {
+    if (!in_array($module[0], ['phpFastCache', 'Psr'])) {
         /**
          * Not a part of phpFastCache file
          * then we return here.
@@ -31,7 +31,7 @@ 
 
         if (is_readable($path)) {
             require_once $path;
-        }else{
+        } else {
             trigger_error('Cannot locate the Psr/Cache files', E_USER_ERROR);
         }
         return;
@@ -40,7 +40,7 @@ 
 
         if (is_readable($path)) {
             require_once $path;
-        }else{
+        } else {
             trigger_error('Cannot locate the Psr/SimpleCache files', E_USER_ERROR);
         }
         return;

Braces +2 added lines, -2 removed lines

@@ -119,7 +119,7 @@ 
             flock($f, LOCK_UN);
             fclose($f);
             rename($tmpFilename, $file);
-        }else{
+        } else{
             $f = fopen($file, 'w+');
             $octetWritten = fwrite($f, $data);
             fclose($f);
@@ -208,7 +208,7 @@ 
              * reuse it else set a new Date
              */
             $wrap[ self::DRIVER_CDATE_WRAPPER_INDEX ] = $item->getCreationDate() ?: new \DateTime();
-        }else{
+        } else{
             $wrap[ self::DRIVER_MDATE_WRAPPER_INDEX ] = null;
             $wrap[ self::DRIVER_CDATE_WRAPPER_INDEX ] = null;
         }

src/phpFastCache/Drivers/Memstatic/Driver.php

Indentation +16 added lines, -16 removed lines

@@ -29,9 +29,9 @@ 
 {
     use DriverBaseTrait;
 
-  /**
-   * @var array
-   */
+    /**
+     * @var array
+     */
     protected $staticStack = [];
 
     /**
@@ -85,7 +85,7 @@ 
     {
         $key = md5($item->getKey());
         if(isset($this->staticStack[$key])){
-          return $this->staticStack[$key];
+            return $this->staticStack[$key];
         }
         return null;
     }
@@ -101,12 +101,12 @@ 
          * Check for Cross-Driver type confusion
          */
         if ($item instanceof Item) {
-          $key = md5($item->getKey());
-          if(isset($this->staticStack[$key])){
-              unset($this->staticStack[$key]);
-              return true;
-          }
-          return false;
+            $key = md5($item->getKey());
+            if(isset($this->staticStack[$key])){
+                unset($this->staticStack[$key]);
+                return true;
+            }
+            return false;
         } else {
             throw new \InvalidArgumentException('Cross-Driver type confusion detected');
         }
@@ -117,9 +117,9 @@ 
      */
     protected function driverClear()
     {
-      unset($this->staticStack);
-      $this->staticStack = [];
-      return true;
+        unset($this->staticStack);
+        $this->staticStack = [];
+        return true;
     }
 
     /**
@@ -143,9 +143,9 @@ 
     {
         $stat = new driverStatistic();
         $stat->setInfo('[Memstatic] A memory static driver')
-          ->setSize(mb_strlen(serialize($this->staticStack)))
-          ->setData(implode(', ', array_keys($this->itemInstances)))
-          ->setRawData($this->staticStack);
+            ->setSize(mb_strlen(serialize($this->staticStack)))
+            ->setData(implode(', ', array_keys($this->itemInstances)))
+            ->setRawData($this->staticStack);
 
         return $stat;
     }

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
     protected function driverRead(CacheItemInterface $item)
     {
         $key = md5($item->getKey());
-        if(isset($this->staticStack[$key])){
+        if (isset($this->staticStack[$key])) {
           return $this->staticStack[$key];
         }
         return null;
@@ -102,7 +102,7 @@ 
          */
         if ($item instanceof Item) {
           $key = md5($item->getKey());
-          if(isset($this->staticStack[$key])){
+          if (isset($this->staticStack[$key])) {
               unset($this->staticStack[$key]);
               return true;
           }

src/phpFastCache/Core/Pool/ExtendedCacheItemPoolTrait.php

Doc Comments +2 added lines, -1 removed lines

@@ -46,6 +46,7 @@ 
 
     /**
      * @inheritdoc
+     * @param string $tagName
      */
     public function getItemsByTag($tagName)
     {
@@ -416,7 +417,7 @@ 
 
     /**
      * @internal This method de-register an item from $this->itemInstances
-     * @param CacheItemInterface|string $item
+     * @param CacheItemInterface $item
      * @throws \InvalidArgumentException
      */
     protected function deregisterItem($item)

Spacing +16 added lines, -16 removed lines

@@ -38,7 +38,7 @@ 
      */
     public function getItemsAsJsonString(array $keys = [], $option = 0, $depth = 512)
     {
-        $callback = function (CacheItemInterface $item) {
+        $callback = function(CacheItemInterface $item) {
             return $item->get();
         };
         return json_encode(array_map($callback, array_values($this->getItems($keys))), $option, $depth);
@@ -52,7 +52,7 @@ 
         if (is_string($tagName)) {
             $driverResponse = $this->getItem($this->getTagKey($tagName));
             if ($driverResponse->isHit()) {
-                $items = (array)$driverResponse->get();
+                $items = (array) $driverResponse->get();
 
                 /**
                  * getItems() may provides expired item(s)
@@ -64,7 +64,7 @@ 
                  *
                  * #headache
                  */
-                return array_filter($this->getItems(array_unique(array_keys($items))), function (ExtendedCacheItemInterface $item) {
+                return array_filter($this->getItems(array_unique(array_keys($items))), function(ExtendedCacheItemInterface $item) {
                     return $item->isHit();
                 });
             } else {
@@ -82,9 +82,9 @@ 
     {
         $items = [];
         foreach (array_unique($tagNames) as $tagName) {
-            if(is_string($tagName)){
+            if (is_string($tagName)) {
                 $items = array_merge($items, $this->getItemsByTag($tagName));
-            }else{
+            } else {
                 throw new InvalidArgumentException('$tagName must be a a string');
             }
         }
@@ -102,7 +102,7 @@ 
 
         foreach ($items as $key => $item) {
             if (array_diff($tagNames, $item->getTags())) {
-                unset($items[ $key ]);
+                unset($items[$key]);
             }
         }
 
@@ -115,7 +115,7 @@ 
      */
     public function getItemsByTagsAsJsonString(array $tagNames, $option = 0, $depth = 512)
     {
-        $callback = function (CacheItemInterface $item) {
+        $callback = function(CacheItemInterface $item) {
             return $item->get();
         };
 
@@ -386,7 +386,7 @@ 
      */
     public function detachItem(CacheItemInterface $item)
     {
-        if (isset($this->itemInstances[ $item->getKey() ])) {
+        if (isset($this->itemInstances[$item->getKey()])) {
             $this->deregisterItem($item);
         }
     }
@@ -406,10 +406,10 @@ 
      */
     public function attachItem(CacheItemInterface $item)
     {
-        if (isset($this->itemInstances[ $item->getKey() ]) && spl_object_hash($item) !== spl_object_hash($this->itemInstances[ $item->getKey() ])) {
+        if (isset($this->itemInstances[$item->getKey()]) && spl_object_hash($item) !== spl_object_hash($this->itemInstances[$item->getKey()])) {
             throw new \LogicException('The item already exists and cannot be overwritten because the Spl object hash mismatches ! You probably tried to re-attach a detached item which has been already retrieved from cache.');
         } else {
-            $this->itemInstances[ $item->getKey() ] = $item;
+            $this->itemInstances[$item->getKey()] = $item;
         }
     }
 
@@ -422,10 +422,10 @@ 
     protected function deregisterItem($item)
     {
         if ($item instanceof CacheItemInterface) {
-            unset($this->itemInstances[ $item->getKey() ]);
+            unset($this->itemInstances[$item->getKey()]);
 
         } else if (is_string($item)) {
-            unset($this->itemInstances[ $item ]);
+            unset($this->itemInstances[$item]);
         } else {
             throw new \InvalidArgumentException('Invalid type for $item variable');
         }
@@ -445,8 +445,8 @@ 
      */
     public function isAttached(CacheItemInterface $item)
     {
-        if (isset($this->itemInstances[ $item->getKey() ])) {
-            return spl_object_hash($item) === spl_object_hash($this->itemInstances[ $item->getKey() ]);
+        if (isset($this->itemInstances[$item->getKey()])) {
+            return spl_object_hash($item) === spl_object_hash($this->itemInstances[$item->getKey()]);
         }
         return null;
     }
@@ -466,8 +466,8 @@ 
      */
     public function saveMultiple(...$items)
     {
-        if (isset($items[ 0 ]) && is_array($items[ 0 ])) {
-            foreach ($items[ 0 ] as $item) {
+        if (isset($items[0]) && is_array($items[0])) {
+            foreach ($items[0] as $item) {
                 $this->save($item);
             }
             return true;

Braces +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
         foreach (array_unique($tagNames) as $tagName) {
             if(is_string($tagName)){
                 $items = array_merge($items, $this->getItemsByTag($tagName));
-            }else{
+            } else{
                 throw new InvalidArgumentException('$tagName must be a a string');
             }
         }