Client::handleError() - Code Metrics - Inspection of "Guzzle 6.0" - PHPSC/pagseguro - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#45)

unknown

created 2016-02-02 15:50 UTC

Client::handleError() A

↳ Parent: Client::post()

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.4285
cc	2
eloc	4
nc	2
nop	1
crap	2

<?php
namespace PHPSC\PagSeguro\Client;

use GuzzleHttp\Client as HttpClient;
use GuzzleHttp\Exception\RequestException;
use SimpleXMLElement;

/**
 * @author Luís Otávio Cobucci Oblonczyk <[email protected]>
 * @author Paulo Peixoto Filho <[email protected]>
 */

class Client {
	/**
	 * @var HttpClient
	 */
	private $client;

	/**
	 * @param HttpClient $client
	 */
	public function __construct(HttpClient $client = null) {
		$this->client = $client ?: new HttpClient();
	}

	/**
	 * @param string $url
	 * @param SimpleXMLElement $body
	 *
	 * @return SimpleXMLElement
	 */
	public function post($url, SimpleXMLElement $body) {

		try {
			$response = $this->client->post($url, ['headers' => ['Content-Type' => 'application/xml; charset=UTF-8'], 'body' => $body->asXML(), 'verify' => false]);
		} catch (RequestException $e) {
			throw PagSeguroException::create($e->getResponse());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}

		return new SimpleXMLElement((string) $response->getBody());
	}

	/**
	 * @param string $url
	 *
	 * @return SimpleXMLElement
	 */
	public function get($url) {
		try {
			$response = $this->client->get($url, ['verify' => false]);
		} catch (RequestException $e) {
			throw PagSeguroException::create($e->getResponse());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}

		return new SimpleXMLElement((string) $response->getBody());
	}
}


1		<?php
2		namespace PHPSC\PagSeguro\Client;
3
4		use GuzzleHttp\Client as HttpClient;
5		use GuzzleHttp\Exception\RequestException;
6		use SimpleXMLElement;
7
8		/**
9		* @author Luís Otávio Cobucci Oblonczyk <[email protected]>
10		* @author Paulo Peixoto Filho <[email protected]>
11		*/
12
13		class Client {
14		/**
15		* @var HttpClient
16		*/
17		private $client;
18
19		/**
20		* @param HttpClient $client
21		*/
22	6	public function __construct(HttpClient $client = null) {
23		$this->client = $client ?: new HttpClient();
24	6	}
25	6
26	6	/**
27		* @param string $url
28		* @param SimpleXMLElement $body
29		*
30		* @return SimpleXMLElement
31		*/
32		public function post($url, SimpleXMLElement $body) {
33	2
34		try {
35	2	$response = $this->client->post($url, ['headers' => ['Content-Type' => 'application/xml; charset=UTF-8'], 'body' => $body->asXML(), 'verify' => false]);
36	1	} catch (RequestException $e) {
37		throw PagSeguroException::create($e->getResponse());
		0 ignored issues – show Documentation introduced 2016-02-02 15:54 UTC by Report Bug Copy Issue Report `$e->getResponse()` is of type `object<Psr\Http\Message\ResponseInterface>`, but the function expects a `object<GuzzleHttp\Message\Response>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38		}
39	1
40		return new SimpleXMLElement((string) $response->getBody());
41		}
42
43		/**
44		* @param string $url
45		*
46		* @return SimpleXMLElement
47		*/
48	1	public function get($url) {
49		try {
50	1	$response = $this->client->get($url, ['verify' => false]);
51	1	} catch (RequestException $e) {
52		throw PagSeguroException::create($e->getResponse());
		0 ignored issues – show Documentation introduced 2016-02-02 15:54 UTC by Report Bug Copy Issue Report `$e->getResponse()` is of type `object<Psr\Http\Message\ResponseInterface>`, but the function expects a `object<GuzzleHttp\Message\Response>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53	1	}
54	1
55		return new SimpleXMLElement((string) $response->getBody());
56	1	}
57		}
58

PHPSC / pagseguro

Pull Request — develop (#45)

Client::handleError() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like