RequestTest - Code Metrics - Inspection of "Merge pull request #53 from PHPSC/improve-serializ..." - PHPSC/pagseguro - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 726e4d...2a8883 )

by Luís

created 2017-05-28 19:15 UTC

RequestTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	116
Duplicated Lines	12.07 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	11
c	1
b	0
f	0
lcom	1
cbo	2
dl	14
loc	116
rs	10

How to fix Duplicated Code

<?php
namespace PHPSC\PagSeguro\Requests\PreApprovals;

use SimpleXMLElement;
use DateTime;
use PHPSC\PagSeguro\Customer\Customer;
use PHPSC\PagSeguro\Customer\Phone;
use PHPSC\PagSeguro\Customer\Address;

/**
 * @author Adelar Tiemann Junior <[email protected]>
 */
class RequestTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var Request
     */
    private $request;

    /**
     * @var PreApproval
     */
    private $preApproval;

    protected function setUp()
    {
        $this->preApproval = $this->createMock(PreApproval::class);
        $this->request = new Request($this->preApproval);
    }

    /**
     * @test
     */
    public function constructShouldConfigureTheAttributes()
    {
        $this->assertAttributeInstanceOf(PreApproval::class, 'preApproval', $this->request);
    }

    /**
     * @test
     */
    public function getPreApprovalShouldReturnConfiguredPreApproval()
    {
        $this->assertInstanceOf(PreApproval::class, $this->request->getPreApproval());
    }

    /**
     * @test
     */
    public function getReferenceShouldReturnConfiguredReference()
    {
        $this->request->setReference('someRef');

        $this->assertEquals('someRef', $this->request->getReference());
    }

    /**
     * @test
     */
    public function setReferenceShouldChangeTheAttribute()
    {
        $this->request->setReference('test');

        $this->assertAttributeEquals('test', 'reference', $this->request);
    }

    /**
     * @test
     */
    public function getRedirectToShouldReturnConfiguredRedirectTo()
    {
        $this->request->setRedirectTo('someRedirect');

        $this->assertEquals('someRedirect', $this->request->getRedirectTo());
    }

    /**
     * @test
     */
    public function setRedirectToShouldChangeTheAttribute()
    {
        $this->request->setRedirectTo('otherRedirect');

        $this->assertAttributeEquals('otherRedirect', 'redirectTo', $this->request);
    }

    /**
     * @test
     */
    public function getReviewOnShouldReturnConfiguredReviewOn()
    {
        $this->request->setReviewOn('someReview');

        $this->assertEquals('someReview', $this->request->getReviewOn());
    }

    /**
     * @test
     */
    public function setReviewOnToShouldChangeTheAttribute()
    {
        $this->request->setReviewOn('otherReview');

        $this->assertAttributeEquals('otherReview', 'reviewOn', $this->request);
    }

    /**
     * @test
     */
    public function getCustomerShouldReturnConfiguredCustomer()
    {
        $customer = $this->createMock(Customer::class);
        $this->request->setCustomer($customer);

        $this->assertSame($customer, $this->request->getCustomer());
    }

    /**
     * @test
     */
    public function setCustomerToShouldChangeTheAttribute()
    {
        $customer = $this->createMock(Customer::class);
        $this->request->setCustomer($customer);

        $this->assertAttributeSame($customer, 'customer', $this->request);
    }

    public function testSerializeShouldXMLFull()
    {
        $preApproval = new PreApproval();
        $preApproval->setChargeType('auto');
        $preApproval->setName('Assinatura Revista');
        $preApproval->setPeriod('MONTHLY');
        $preApproval->setFinalDate(new DateTime('2016-11-18', new \DateTimeZone('UTC')));
        $preApproval->setMaxTotalAmount(3000);
        $preApproval->setDetails('Cobranca Mensal da Revista');
        $preApproval->setAmountPerPayment(100);
        $preApproval->setMaxAmountPerPayment(150);
        $preApproval->setInitialDate(new DateTime('2015-11-18', new \DateTimeZone('UTC')));
        $preApproval->setMaxPaymentsPerPeriod(12);
        $preApproval->setMaxAmountPerPeriod(1200);

        $customerAddress = new Address('AC', 'Sao Maite', '99500-079', 'Centro', 'Rua David Delgado', '55', 'Fundos');
        $customerPhone = new Phone('11', '99999999');
        $customer = new Customer('[email protected]', 'FooBar', $customerPhone, $customerAddress);

        $request = new Request($preApproval);
        $request->setCustomer($customer);
        $request->setReference('abcdef');
        $request->setReviewOn('http://localhost/return.php');
        $request->setRedirectTo('http://localhost/success.php');

        $xml = $request->xmlSerialize();

        $this->assertInstanceOf(SimpleXMLElement::class, $xml);
        $expected = simplexml_load_file(__DIR__ . '/xml/preAprovalsRequestFull.xml');
        $this->assertEquals($expected, $xml);
    }
}


1			<?php
2			namespace PHPSC\PagSeguro\Requests\PreApprovals;
3
4			use SimpleXMLElement;
5			use DateTime;
6			use PHPSC\PagSeguro\Customer\Customer;
7			use PHPSC\PagSeguro\Customer\Phone;
8			use PHPSC\PagSeguro\Customer\Address;
9
10			/**
11			* @author Adelar Tiemann Junior <[email protected]>
12			*/
13			class RequestTest extends \PHPUnit_Framework_TestCase
14			{
15			/**
16			* @var Request
17			*/
18			private $request;
19
20			/**
21			* @var PreApproval
22			*/
23			private $preApproval;
24
25			protected function setUp()
26			{
27			$this->preApproval = $this->createMock(PreApproval::class);
28			$this->request = new Request($this->preApproval);
29			}
30
31			/**
32			* @test
33			*/
34			public function constructShouldConfigureTheAttributes()
35			{
36			$this->assertAttributeInstanceOf(PreApproval::class, 'preApproval', $this->request);
37			}
38
39			/**
40			* @test
41			*/
42			public function getPreApprovalShouldReturnConfiguredPreApproval()
43			{
44			$this->assertInstanceOf(PreApproval::class, $this->request->getPreApproval());
45			}
46
47			/**
48			* @test
49			*/
50			public function getReferenceShouldReturnConfiguredReference()
51			{
52			$this->request->setReference('someRef');
53
54			$this->assertEquals('someRef', $this->request->getReference());
55			}
56
57			/**
58			* @test
59			*/
60			public function setReferenceShouldChangeTheAttribute()
61			{
62			$this->request->setReference('test');
63
64			$this->assertAttributeEquals('test', 'reference', $this->request);
65			}
66
67			/**
68			* @test
69			*/
70			public function getRedirectToShouldReturnConfiguredRedirectTo()
71			{
72			$this->request->setRedirectTo('someRedirect');
73
74			$this->assertEquals('someRedirect', $this->request->getRedirectTo());
75			}
76
77			/**
78			* @test
79			*/
80			public function setRedirectToShouldChangeTheAttribute()
81			{
82			$this->request->setRedirectTo('otherRedirect');
83
84			$this->assertAttributeEquals('otherRedirect', 'redirectTo', $this->request);
85			}
86
87			/**
88			* @test
89			*/
90			public function getReviewOnShouldReturnConfiguredReviewOn()
91			{
92			$this->request->setReviewOn('someReview');
93
94			$this->assertEquals('someReview', $this->request->getReviewOn());
95			}
96
97			/**
98			* @test
99			*/
100			public function setReviewOnToShouldChangeTheAttribute()
101			{
102			$this->request->setReviewOn('otherReview');
103
104			$this->assertAttributeEquals('otherReview', 'reviewOn', $this->request);
105			}
106
107			/**
108			* @test
109			*/
110			public function getCustomerShouldReturnConfiguredCustomer()
111			{
112			$customer = $this->createMock(Customer::class);
113			$this->request->setCustomer($customer);
114
115			$this->assertSame($customer, $this->request->getCustomer());
116			}
117
118			/**
119			* @test
120			*/
121			public function setCustomerToShouldChangeTheAttribute()
122			{
123			$customer = $this->createMock(Customer::class);
124			$this->request->setCustomer($customer);
125
126			$this->assertAttributeSame($customer, 'customer', $this->request);
127			}
128
129			public function testSerializeShouldXMLFull()
130			{
131			$preApproval = new PreApproval();
132			$preApproval->setChargeType('auto');
133			$preApproval->setName('Assinatura Revista');
134			$preApproval->setPeriod('MONTHLY');
135			$preApproval->setFinalDate(new DateTime('2016-11-18', new \DateTimeZone('UTC')));
136			$preApproval->setMaxTotalAmount(3000);
137			$preApproval->setDetails('Cobranca Mensal da Revista');
138			$preApproval->setAmountPerPayment(100);
139			$preApproval->setMaxAmountPerPayment(150);
140			$preApproval->setInitialDate(new DateTime('2015-11-18', new \DateTimeZone('UTC')));
141			$preApproval->setMaxPaymentsPerPeriod(12);
142			$preApproval->setMaxAmountPerPeriod(1200);
143
144			$customerAddress = new Address('AC', 'Sao Maite', '99500-079', 'Centro', 'Rua David Delgado', '55', 'Fundos');
145			$customerPhone = new Phone('11', '99999999');
146			$customer = new Customer('[email protected]', 'FooBar', $customerPhone, $customerAddress);
147
148			$request = new Request($preApproval);
149			$request->setCustomer($customer);
150			$request->setReference('abcdef');
151			$request->setReviewOn('http://localhost/return.php');
152			$request->setRedirectTo('http://localhost/success.php');
153
154			$xml = $request->xmlSerialize();
155
156			$this->assertInstanceOf(SimpleXMLElement::class, $xml);
157			$expected = simplexml_load_file(__DIR__ . '/xml/preAprovalsRequestFull.xml');
158			$this->assertEquals($expected, $xml);
159			}
160			}
161

PHPSC / pagseguro

Push — develop ( 726e4d...2a8883 )

RequestTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like