TextDataTest - Code Metrics - Inspection of "Apply Scrutinizer patches for doc comments" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (b42baf)

by Adrien

created 2016-08-26 05:12 UTC

TextDataTest B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	352
Duplicated Lines	6.53 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	23
loc	352
rs	8.3157
wmc	43
lcom	1
cbo	2

43 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	testCHAR()	0	7	1
A	providerCHAR()	0	4	1
A	testCODE()	0	7	1
A	providerCODE()	0	4	1
A	testCONCATENATE()	0	7	1
A	providerCONCATENATE()	0	4	1
A	testLEFT()	0	7	1
A	providerLEFT()	0	4	1
A	testMID()	0	7	1
A	providerMID()	0	4	1
A	testRIGHT()	0	7	1
A	providerRIGHT()	0	4	1
A	testLOWER()	0	7	1
A	providerLOWER()	0	4	1
A	testUPPER()	0	7	1
A	providerUPPER()	0	4	1
A	testPROPER()	0	7	1
A	providerPROPER()	0	4	1
A	testLEN()	0	7	1
A	providerLEN()	0	4	1
A	testSEARCH()	0	7	1
A	providerSEARCH()	0	4	1
A	testFIND()	0	7	1
A	providerFIND()	0	4	1
A	testREPLACE()	0	7	1
A	providerREPLACE()	0	4	1
A	testSUBSTITUTE()	0	7	1
A	providerSUBSTITUTE()	0	4	1
A	testTRIM()	0	7	1
A	providerTRIM()	0	4	1
A	testCLEAN()	0	7	1
A	providerCLEAN()	0	4	1
A	testDOLLAR()	0	7	1
A	providerDOLLAR()	0	4	1
A	testFIXED()	0	7	1
A	providerFIXED()	0	4	1
A	testT()	0	7	1
A	providerT()	0	4	1
A	testTEXT()	12	12	1
A	providerTEXT()	0	4	1
A	testVALUE()	11	11	1
A	providerVALUE()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like TextDataTest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use TextDataTest, and based on these observations, apply Extract Interface, too.

<?php

namespace PhpSpreadsheetTests\Calculation;

use PhpSpreadsheet\Calculation\Functions;
use PhpSpreadsheet\Calculation\TextData;
use PhpSpreadsheet\Shared\StringHelper;

class TextDataTest extends \PHPUnit_Framework_TestCase
{
    public function setUp()
    {
        Functions::setCompatibilityMode(Functions::COMPATIBILITY_EXCEL);
    }

    /**
     * @dataProvider providerCHAR
     */
    public function testCHAR()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'CHARACTER'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerCHAR()
    {
        return require 'data/Calculation/TextData/CHAR.php';
    }

    /**
     * @dataProvider providerCODE
     */
    public function testCODE()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'ASCIICODE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerCODE()
    {
        return require 'data/Calculation/TextData/CODE.php';
    }

    /**
     * @dataProvider providerCONCATENATE
     */
    public function testCONCATENATE()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'CONCATENATE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerCONCATENATE()
    {
        return require 'data/Calculation/TextData/CONCATENATE.php';
    }

    /**
     * @dataProvider providerLEFT
     */
    public function testLEFT()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'LEFT'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerLEFT()
    {
        return require 'data/Calculation/TextData/LEFT.php';
    }

    /**
     * @dataProvider providerMID
     */
    public function testMID()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'MID'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerMID()
    {
        return require 'data/Calculation/TextData/MID.php';
    }

    /**
     * @dataProvider providerRIGHT
     */
    public function testRIGHT()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'RIGHT'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerRIGHT()
    {
        return require 'data/Calculation/TextData/RIGHT.php';
    }

    /**
     * @dataProvider providerLOWER
     */
    public function testLOWER()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'LOWERCASE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerLOWER()
    {
        return require 'data/Calculation/TextData/LOWER.php';
    }

    /**
     * @dataProvider providerUPPER
     */
    public function testUPPER()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'UPPERCASE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerUPPER()
    {
        return require 'data/Calculation/TextData/UPPER.php';
    }

    /**
     * @dataProvider providerPROPER
     */
    public function testPROPER()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'PROPERCASE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerPROPER()
    {
        return require 'data/Calculation/TextData/PROPER.php';
    }

    /**
     * @dataProvider providerLEN
     */
    public function testLEN()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'STRINGLENGTH'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerLEN()
    {
        return require 'data/Calculation/TextData/LEN.php';
    }

    /**
     * @dataProvider providerSEARCH
     */
    public function testSEARCH()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'SEARCHINSENSITIVE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerSEARCH()
    {
        return require 'data/Calculation/TextData/SEARCH.php';
    }

    /**
     * @dataProvider providerFIND
     */
    public function testFIND()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'SEARCHSENSITIVE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerFIND()
    {
        return require 'data/Calculation/TextData/FIND.php';
    }

    /**
     * @dataProvider providerREPLACE
     */
    public function testREPLACE()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'REPLACE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerREPLACE()
    {
        return require 'data/Calculation/TextData/REPLACE.php';
    }

    /**
     * @dataProvider providerSUBSTITUTE
     */
    public function testSUBSTITUTE()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'SUBSTITUTE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerSUBSTITUTE()
    {
        return require 'data/Calculation/TextData/SUBSTITUTE.php';
    }

    /**
     * @dataProvider providerTRIM
     */
    public function testTRIM()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'TRIMSPACES'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerTRIM()
    {
        return require 'data/Calculation/TextData/TRIM.php';
    }

    /**
     * @dataProvider providerCLEAN
     */
    public function testCLEAN()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'TRIMNONPRINTABLE'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerCLEAN()
    {
        return require 'data/Calculation/TextData/CLEAN.php';
    }

    /**
     * @dataProvider providerDOLLAR
     */
    public function testDOLLAR()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'DOLLAR'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerDOLLAR()
    {
        return require 'data/Calculation/TextData/DOLLAR.php';
    }

    /**
     * @dataProvider providerFIXED
     */
    public function testFIXED()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'FIXEDFORMAT'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerFIXED()
    {
        return require 'data/Calculation/TextData/FIXED.php';
    }

    /**
     * @dataProvider providerT
     */
    public function testT()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'RETURNSTRING'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerT()
    {
        return require 'data/Calculation/TextData/T.php';
    }

    /**
     * @dataProvider providerTEXT
     */
    public function testTEXT()

    {
        //    Enforce decimal and thousands separator values to UK/US, and currency code to USD
        call_user_func([StringHelper::class, 'setDecimalSeparator'], '.');
        call_user_func([StringHelper::class, 'setThousandsSeparator'], ',');
        call_user_func([StringHelper::class, 'setCurrencyCode'], '$');

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'TEXTFORMAT'], $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerTEXT()
    {
        return require 'data/Calculation/TextData/TEXT.php';
    }

    /**
     * @dataProvider providerVALUE
     */
    public function testVALUE()

    {
        call_user_func([StringHelper::class, 'setDecimalSeparator'], '.');
        call_user_func([StringHelper::class, 'setThousandsSeparator'], ' ');
        call_user_func([StringHelper::class, 'setCurrencyCode'], '$');

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array([TextData::class, 'VALUE'], $args);
        $this->assertEquals($expectedResult, $result, null, 1E-8);
    }

    public function providerVALUE()
    {
        return require 'data/Calculation/TextData/VALUE.php';
    }
}


1		<?php
2
3		namespace PhpSpreadsheetTests\Calculation;
4
5		use PhpSpreadsheet\Calculation\Functions;
6		use PhpSpreadsheet\Calculation\TextData;
7		use PhpSpreadsheet\Shared\StringHelper;
8
9		class TextDataTest extends \PHPUnit_Framework_TestCase
10		{
11		public function setUp()
12		{
13		Functions::setCompatibilityMode(Functions::COMPATIBILITY_EXCEL);
14		}
15
16		/**
17		* @dataProvider providerCHAR
18		*/
19		public function testCHAR()
20		{
21		$args = func_get_args();
22		$expectedResult = array_pop($args);
23		$result = call_user_func_array([TextData::class, 'CHARACTER'], $args);
24		$this->assertEquals($expectedResult, $result);
25		}
26
27		public function providerCHAR()
28		{
29		return require 'data/Calculation/TextData/CHAR.php';
30		}
31
32		/**
33		* @dataProvider providerCODE
34		*/
35		public function testCODE()
36		{
37		$args = func_get_args();
38		$expectedResult = array_pop($args);
39		$result = call_user_func_array([TextData::class, 'ASCIICODE'], $args);
40		$this->assertEquals($expectedResult, $result);
41		}
42
43		public function providerCODE()
44		{
45		return require 'data/Calculation/TextData/CODE.php';
46		}
47
48		/**
49		* @dataProvider providerCONCATENATE
50		*/
51		public function testCONCATENATE()
52		{
53		$args = func_get_args();
54		$expectedResult = array_pop($args);
55		$result = call_user_func_array([TextData::class, 'CONCATENATE'], $args);
56		$this->assertEquals($expectedResult, $result);
57		}
58
59		public function providerCONCATENATE()
60		{
61		return require 'data/Calculation/TextData/CONCATENATE.php';
62		}
63
64		/**
65		* @dataProvider providerLEFT
66		*/
67		public function testLEFT()
68		{
69		$args = func_get_args();
70		$expectedResult = array_pop($args);
71		$result = call_user_func_array([TextData::class, 'LEFT'], $args);
72		$this->assertEquals($expectedResult, $result);
73		}
74
75		public function providerLEFT()
76		{
77		return require 'data/Calculation/TextData/LEFT.php';
78		}
79
80		/**
81		* @dataProvider providerMID
82		*/
83		public function testMID()
84		{
85		$args = func_get_args();
86		$expectedResult = array_pop($args);
87		$result = call_user_func_array([TextData::class, 'MID'], $args);
88		$this->assertEquals($expectedResult, $result);
89		}
90
91		public function providerMID()
92		{
93		return require 'data/Calculation/TextData/MID.php';
94		}
95
96		/**
97		* @dataProvider providerRIGHT
98		*/
99		public function testRIGHT()
100		{
101		$args = func_get_args();
102		$expectedResult = array_pop($args);
103		$result = call_user_func_array([TextData::class, 'RIGHT'], $args);
104		$this->assertEquals($expectedResult, $result);
105		}
106
107		public function providerRIGHT()
108		{
109		return require 'data/Calculation/TextData/RIGHT.php';
110		}
111
112		/**
113		* @dataProvider providerLOWER
114		*/
115		public function testLOWER()
116		{
117		$args = func_get_args();
118		$expectedResult = array_pop($args);
119		$result = call_user_func_array([TextData::class, 'LOWERCASE'], $args);
120		$this->assertEquals($expectedResult, $result);
121		}
122
123		public function providerLOWER()
124		{
125		return require 'data/Calculation/TextData/LOWER.php';
126		}
127
128		/**
129		* @dataProvider providerUPPER
130		*/
131		public function testUPPER()
132		{
133		$args = func_get_args();
134		$expectedResult = array_pop($args);
135		$result = call_user_func_array([TextData::class, 'UPPERCASE'], $args);
136		$this->assertEquals($expectedResult, $result);
137		}
138
139		public function providerUPPER()
140		{
141		return require 'data/Calculation/TextData/UPPER.php';
142		}
143
144		/**
145		* @dataProvider providerPROPER
146		*/
147		public function testPROPER()
148		{
149		$args = func_get_args();
150		$expectedResult = array_pop($args);
151		$result = call_user_func_array([TextData::class, 'PROPERCASE'], $args);
152		$this->assertEquals($expectedResult, $result);
153		}
154
155		public function providerPROPER()
156		{
157		return require 'data/Calculation/TextData/PROPER.php';
158		}
159
160		/**
161		* @dataProvider providerLEN
162		*/
163		public function testLEN()
164		{
165		$args = func_get_args();
166		$expectedResult = array_pop($args);
167		$result = call_user_func_array([TextData::class, 'STRINGLENGTH'], $args);
168		$this->assertEquals($expectedResult, $result);
169		}
170
171		public function providerLEN()
172		{
173		return require 'data/Calculation/TextData/LEN.php';
174		}
175
176		/**
177		* @dataProvider providerSEARCH
178		*/
179		public function testSEARCH()
180		{
181		$args = func_get_args();
182		$expectedResult = array_pop($args);
183		$result = call_user_func_array([TextData::class, 'SEARCHINSENSITIVE'], $args);
184		$this->assertEquals($expectedResult, $result);
185		}
186
187		public function providerSEARCH()
188		{
189		return require 'data/Calculation/TextData/SEARCH.php';
190		}
191
192		/**
193		* @dataProvider providerFIND
194		*/
195		public function testFIND()
196		{
197		$args = func_get_args();
198		$expectedResult = array_pop($args);
199		$result = call_user_func_array([TextData::class, 'SEARCHSENSITIVE'], $args);
200		$this->assertEquals($expectedResult, $result);
201		}
202
203		public function providerFIND()
204		{
205		return require 'data/Calculation/TextData/FIND.php';
206		}
207
208		/**
209		* @dataProvider providerREPLACE
210		*/
211		public function testREPLACE()
212		{
213		$args = func_get_args();
214		$expectedResult = array_pop($args);
215		$result = call_user_func_array([TextData::class, 'REPLACE'], $args);
216		$this->assertEquals($expectedResult, $result);
217		}
218
219		public function providerREPLACE()
220		{
221		return require 'data/Calculation/TextData/REPLACE.php';
222		}
223
224		/**
225		* @dataProvider providerSUBSTITUTE
226		*/
227		public function testSUBSTITUTE()
228		{
229		$args = func_get_args();
230		$expectedResult = array_pop($args);
231		$result = call_user_func_array([TextData::class, 'SUBSTITUTE'], $args);
232		$this->assertEquals($expectedResult, $result);
233		}
234
235		public function providerSUBSTITUTE()
236		{
237		return require 'data/Calculation/TextData/SUBSTITUTE.php';
238		}
239
240		/**
241		* @dataProvider providerTRIM
242		*/
243		public function testTRIM()
244		{
245		$args = func_get_args();
246		$expectedResult = array_pop($args);
247		$result = call_user_func_array([TextData::class, 'TRIMSPACES'], $args);
248		$this->assertEquals($expectedResult, $result);
249		}
250
251		public function providerTRIM()
252		{
253		return require 'data/Calculation/TextData/TRIM.php';
254		}
255
256		/**
257		* @dataProvider providerCLEAN
258		*/
259		public function testCLEAN()
260		{
261		$args = func_get_args();
262		$expectedResult = array_pop($args);
263		$result = call_user_func_array([TextData::class, 'TRIMNONPRINTABLE'], $args);
264		$this->assertEquals($expectedResult, $result);
265		}
266
267		public function providerCLEAN()
268		{
269		return require 'data/Calculation/TextData/CLEAN.php';
270		}
271
272		/**
273		* @dataProvider providerDOLLAR
274		*/
275		public function testDOLLAR()
276		{
277		$args = func_get_args();
278		$expectedResult = array_pop($args);
279		$result = call_user_func_array([TextData::class, 'DOLLAR'], $args);
280		$this->assertEquals($expectedResult, $result);
281		}
282
283		public function providerDOLLAR()
284		{
285		return require 'data/Calculation/TextData/DOLLAR.php';
286		}
287
288		/**
289		* @dataProvider providerFIXED
290		*/
291		public function testFIXED()
292		{
293		$args = func_get_args();
294		$expectedResult = array_pop($args);
295		$result = call_user_func_array([TextData::class, 'FIXEDFORMAT'], $args);
296		$this->assertEquals($expectedResult, $result);
297		}
298
299		public function providerFIXED()
300		{
301		return require 'data/Calculation/TextData/FIXED.php';
302		}
303
304		/**
305		* @dataProvider providerT
306		*/
307		public function testT()
308		{
309		$args = func_get_args();
310		$expectedResult = array_pop($args);
311		$result = call_user_func_array([TextData::class, 'RETURNSTRING'], $args);
312		$this->assertEquals($expectedResult, $result);
313		}
314
315		public function providerT()
316		{
317		return require 'data/Calculation/TextData/T.php';
318		}
319
320		/**
321		* @dataProvider providerTEXT
322		*/
323	View Code Duplication	public function testTEXT()
		0 ignored issues – show Duplication introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
324		{
325		// Enforce decimal and thousands separator values to UK/US, and currency code to USD
326		call_user_func([StringHelper::class, 'setDecimalSeparator'], '.');
327		call_user_func([StringHelper::class, 'setThousandsSeparator'], ',');
328		call_user_func([StringHelper::class, 'setCurrencyCode'], '$');
329
330		$args = func_get_args();
331		$expectedResult = array_pop($args);
332		$result = call_user_func_array([TextData::class, 'TEXTFORMAT'], $args);
333		$this->assertEquals($expectedResult, $result);
334		}
335
336		public function providerTEXT()
337		{
338		return require 'data/Calculation/TextData/TEXT.php';
339		}
340
341		/**
342		* @dataProvider providerVALUE
343		*/
344	View Code Duplication	public function testVALUE()
		0 ignored issues – show Duplication introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
345		{
346		call_user_func([StringHelper::class, 'setDecimalSeparator'], '.');
347		call_user_func([StringHelper::class, 'setThousandsSeparator'], ' ');
348		call_user_func([StringHelper::class, 'setCurrencyCode'], '$');
349
350		$args = func_get_args();
351		$expectedResult = array_pop($args);
352		$result = call_user_func_array([TextData::class, 'VALUE'], $args);
353		$this->assertEquals($expectedResult, $result, null, 1E-8);
354		}
355
356		public function providerVALUE()
357		{
358		return require 'data/Calculation/TextData/VALUE.php';
359		}
360		}
361

PHPOffice / PhpSpreadsheet