Complex classes like MathTrigTest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MathTrigTest, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
9 | class MathTrigTest extends \PHPUnit_Framework_TestCase |
||
10 | { |
||
11 | public function setUp() |
||
15 | |||
16 | /** |
||
17 | * @dataProvider providerATAN2 |
||
18 | */ |
||
19 | public function testATAN2() |
||
26 | |||
27 | public function providerATAN2() |
||
31 | |||
32 | /** |
||
33 | * @dataProvider providerCEILING |
||
34 | */ |
||
35 | public function testCEILING() |
||
42 | |||
43 | public function providerCEILING() |
||
47 | |||
48 | /** |
||
49 | * @dataProvider providerCOMBIN |
||
50 | */ |
||
51 | public function testCOMBIN() |
||
58 | |||
59 | public function providerCOMBIN() |
||
63 | |||
64 | /** |
||
65 | * @dataProvider providerEVEN |
||
66 | */ |
||
67 | public function testEVEN() |
||
74 | |||
75 | public function providerEVEN() |
||
79 | |||
80 | /** |
||
81 | * @dataProvider providerODD |
||
82 | */ |
||
83 | public function testODD() |
||
90 | |||
91 | public function providerODD() |
||
95 | |||
96 | /** |
||
97 | * @dataProvider providerFACT |
||
98 | */ |
||
99 | public function testFACT() |
||
106 | |||
107 | public function providerFACT() |
||
111 | |||
112 | /** |
||
113 | * @dataProvider providerFACTDOUBLE |
||
114 | */ |
||
115 | public function testFACTDOUBLE() |
||
122 | |||
123 | public function providerFACTDOUBLE() |
||
127 | |||
128 | /** |
||
129 | * @dataProvider providerFLOOR |
||
130 | */ |
||
131 | public function testFLOOR() |
||
138 | |||
139 | public function providerFLOOR() |
||
143 | |||
144 | /** |
||
145 | * @dataProvider providerGCD |
||
146 | */ |
||
147 | public function testGCD() |
||
154 | |||
155 | public function providerGCD() |
||
159 | |||
160 | /** |
||
161 | * @dataProvider providerLCM |
||
162 | */ |
||
163 | public function testLCM() |
||
170 | |||
171 | public function providerLCM() |
||
175 | |||
176 | /** |
||
177 | * @dataProvider providerINT |
||
178 | */ |
||
179 | public function testINT() |
||
186 | |||
187 | public function providerINT() |
||
191 | |||
192 | /** |
||
193 | * @dataProvider providerSIGN |
||
194 | */ |
||
195 | public function testSIGN() |
||
202 | |||
203 | public function providerSIGN() |
||
207 | |||
208 | /** |
||
209 | * @dataProvider providerPOWER |
||
210 | */ |
||
211 | public function testPOWER() |
||
218 | |||
219 | public function providerPOWER() |
||
223 | |||
224 | /** |
||
225 | * @dataProvider providerLOG |
||
226 | */ |
||
227 | public function testLOG() |
||
234 | |||
235 | public function providerLOG() |
||
239 | |||
240 | /** |
||
241 | * @dataProvider providerMOD |
||
242 | */ |
||
243 | public function testMOD() |
||
250 | |||
251 | public function providerMOD() |
||
255 | |||
256 | /** |
||
257 | * @dataProvider providerMDETERM |
||
258 | */ |
||
259 | public function testMDETERM() |
||
266 | |||
267 | public function providerMDETERM() |
||
271 | |||
272 | /** |
||
273 | * @dataProvider providerMINVERSE |
||
274 | * @group fail19 |
||
275 | */ |
||
276 | public function testMINVERSE() |
||
285 | |||
286 | public function providerMINVERSE() |
||
290 | |||
291 | /** |
||
292 | * @dataProvider providerMMULT |
||
293 | * @group fail19 |
||
294 | */ |
||
295 | public function testMMULT() |
||
304 | |||
305 | public function providerMMULT() |
||
309 | |||
310 | /** |
||
311 | * @dataProvider providerMULTINOMIAL |
||
312 | */ |
||
313 | public function testMULTINOMIAL() |
||
320 | |||
321 | public function providerMULTINOMIAL() |
||
325 | |||
326 | /** |
||
327 | * @dataProvider providerMROUND |
||
328 | */ |
||
329 | public function testMROUND() |
||
338 | |||
339 | public function providerMROUND() |
||
343 | |||
344 | /** |
||
345 | * @dataProvider providerPRODUCT |
||
346 | */ |
||
347 | public function testPRODUCT() |
||
354 | |||
355 | public function providerPRODUCT() |
||
359 | |||
360 | /** |
||
361 | * @dataProvider providerQUOTIENT |
||
362 | */ |
||
363 | public function testQUOTIENT() |
||
370 | |||
371 | public function providerQUOTIENT() |
||
375 | |||
376 | /** |
||
377 | * @dataProvider providerROUNDUP |
||
378 | */ |
||
379 | public function testROUNDUP() |
||
386 | |||
387 | public function providerROUNDUP() |
||
391 | |||
392 | /** |
||
393 | * @dataProvider providerROUNDDOWN |
||
394 | */ |
||
395 | public function testROUNDDOWN() |
||
402 | |||
403 | public function providerROUNDDOWN() |
||
407 | |||
408 | /** |
||
409 | * @dataProvider providerSERIESSUM |
||
410 | */ |
||
411 | public function testSERIESSUM() |
||
418 | |||
419 | public function providerSERIESSUM() |
||
423 | |||
424 | /** |
||
425 | * @dataProvider providerSUMSQ |
||
426 | */ |
||
427 | public function testSUMSQ() |
||
434 | |||
435 | public function providerSUMSQ() |
||
439 | |||
440 | /** |
||
441 | * @dataProvider providerTRUNC |
||
442 | */ |
||
443 | public function testTRUNC() |
||
450 | |||
451 | public function providerTRUNC() |
||
455 | |||
456 | /** |
||
457 | * @dataProvider providerROMAN |
||
458 | */ |
||
459 | public function testROMAN() |
||
466 | |||
467 | public function providerROMAN() |
||
471 | |||
472 | /** |
||
473 | * @dataProvider providerSQRTPI |
||
474 | */ |
||
475 | public function testSQRTPI() |
||
482 | |||
483 | public function providerSQRTPI() |
||
487 | |||
488 | /** |
||
489 | * @dataProvider providerSUMIF |
||
490 | */ |
||
491 | public function testSUMIF() |
||
498 | |||
499 | public function providerSUMIF() |
||
561 | } |
||
562 |