Inspection of "WIP: Make global usage of use in header" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#147)

unknown

created 2017-05-03 15:03 UTC

Status

Doc Comments +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -505,7 +505,7 @@  discard block
 block discarded – undo
      *
      * @param mixed $token the token to convert
      *
-     * @return mixed the converted token on success
+     * @return string the converted token on success
      */
     private function convert($token)
     {
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
      *
      * @param string $string a string for conversion to its ptg value
      *
-     * @return mixed the converted token on success
+     * @return string the converted token on success
      */
     private function convertString($string)
     {
@@ -654,7 +654,7 @@  discard block
 block discarded – undo
      *
      * @param string $token an Excel range in the Sheet1!A1:A2 format
      *
-     * @return mixed the packed ptgArea3d token on success
+     * @return string the packed ptgArea3d token on success
      */
     private function convertRange3d($token)
     {
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
      *
      * @param string $cell An Excel cell reference
      *
-     * @return mixed the packed ptgRef3d token on success
+     * @return string the packed ptgRef3d token on success
      */
     private function convertRef3d($cell)
     {
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
      *
      * @param string $ext_ref The name of the external reference
      *
-     * @return mixed The reference index in packed() format on success
+     * @return string The reference index in packed() format on success
      */
     private function getRefIndex($ext_ref)
     {
@@ -896,7 +896,7 @@  discard block
 block discarded – undo
      *
      * @param string $cell The Excel cell reference to be packed
      *
-     * @return array Array containing the row and column in packed() format
+     * @return string[] Array containing the row and column in packed() format
      */
     private function cellToPackedRowcol($cell)
     {
@@ -925,7 +925,7 @@  discard block
 block discarded – undo
      *
      * @param string $range The Excel range to be packed
      *
-     * @return array Array containing (row1,col1,row2,col2) in packed() format
+     * @return string[] Array containing (row1,col1,row2,col2) in packed() format
      */
     private function rangeToPackedRange($range)
     {
@@ -1041,7 +1041,7 @@  discard block
 block discarded – undo
     /**
      * Checks if it's a valid token.
      *
-     * @param mixed $token the token to check
+     * @param string $token the token to check
      *
      * @return mixed The checked token or false on failure
      */
@@ -1127,7 +1127,7 @@  discard block
 block discarded – undo
      * @param string $formula the formula to parse, without the initial equal
      *                        sign (=)
      *
-     * @return mixed true on success
+     * @return boolean true on success
      */
     public function parse($formula)
     {

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader02.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@
 block discarded – undo
 
 $inputFileName = './sampleData/example1.xls';
 
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
 $reader = new \PhpOffice\PhpSpreadsheet\Reader\Xls();
 //	$reader = new \PhpOffice\PhpSpreadsheet\Reader\Xlsx();
 //	$reader = new \PhpOffice\PhpSpreadsheet\Reader\Xml();

Please login to merge, or discard this patch.

docs/Examples/Reading WorkBook Data/exampleWorkBookReader01.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -37,53 +37,53 @@
 block discarded – undo
 
 /*  Read the document's creator property  **/
 $creator = $spreadsheet->getProperties()->getCreator();
-echo '<b>Document Creator: </b>',$creator,'<br />';
+echo '<b>Document Creator: </b>', $creator, '<br />';
 
 /*  Read the Date when the workbook was created (as a PHP timestamp value)  **/
 $creationDatestamp = $spreadsheet->getProperties()->getCreated();
 /*  Format the date and time using the standard PHP date() function  **/
 $creationDate = date('l, d<\s\up>S</\s\up> F Y', $creationDatestamp);
 $creationTime = date('g:i A', $creationDatestamp);
-echo '<b>Created On: </b>',$creationDate,' at ',$creationTime,'<br />';
+echo '<b>Created On: </b>', $creationDate, ' at ', $creationTime, '<br />';
 
 /*  Read the name of the last person to modify this workbook  **/
 $modifiedBy = $spreadsheet->getProperties()->getLastModifiedBy();
-echo '<b>Last Modified By: </b>',$modifiedBy,'<br />';
+echo '<b>Last Modified By: </b>', $modifiedBy, '<br />';
 
 /*  Read the Date when the workbook was last modified (as a PHP timestamp value)  **/
 $modifiedDatestamp = $spreadsheet->getProperties()->getModified();
 /*  Format the date and time using the standard PHP date() function  **/
 $modifiedDate = date('l, d<\s\up>S</\s\up> F Y', $modifiedDatestamp);
 $modifiedTime = date('g:i A', $modifiedDatestamp);
-echo '<b>Last Modified On: </b>',$modifiedDate,' at ',$modifiedTime,'<br />';
+echo '<b>Last Modified On: </b>', $modifiedDate, ' at ', $modifiedTime, '<br />';
 
 /*  Read the workbook title property  **/
 $workbookTitle = $spreadsheet->getProperties()->getTitle();
-echo '<b>Title: </b>',$workbookTitle,'<br />';
+echo '<b>Title: </b>', $workbookTitle, '<br />';
 
 /*  Read the workbook description property  **/
 $description = $spreadsheet->getProperties()->getDescription();
-echo '<b>Description: </b>',$description,'<br />';
+echo '<b>Description: </b>', $description, '<br />';
 
 /*  Read the workbook subject property  **/
 $subject = $spreadsheet->getProperties()->getSubject();
-echo '<b>Subject: </b>',$subject,'<br />';
+echo '<b>Subject: </b>', $subject, '<br />';
 
 /*  Read the workbook keywords property  **/
 $keywords = $spreadsheet->getProperties()->getKeywords();
-echo '<b>Keywords: </b>',$keywords,'<br />';
+echo '<b>Keywords: </b>', $keywords, '<br />';
 
 /*  Read the workbook category property  **/
 $category = $spreadsheet->getProperties()->getCategory();
-echo '<b>Category: </b>',$category,'<br />';
+echo '<b>Category: </b>', $category, '<br />';
 
 /*  Read the workbook company property  **/
 $company = $spreadsheet->getProperties()->getCompany();
-echo '<b>Company: </b>',$company,'<br />';
+echo '<b>Company: </b>', $company, '<br />';
 
 /*  Read the workbook manager property  **/
 $manager = $spreadsheet->getProperties()->getManager();
-echo '<b>Manager: </b>',$manager,'<br />';
+echo '<b>Manager: </b>', $manager, '<br />';
 
 ?>
 <body>

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DAVERAGE.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DVARP.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DSTDEVP.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DVAR.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DSTDEV.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DMIN.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

		@@ -505,7 +505,7 @@ discard block
		block discarded – undo
505	505	*
506	506	* @param mixed $token the token to convert
507	507	*
508		- * @return mixed the converted token on success
	508	+ * @return string the converted token on success
509	509	*/
510	510	private function convert($token)
511	511	{
		@@ -576,7 +576,7 @@ discard block
		block discarded – undo
576	576	*
577	577	* @param string $string a string for conversion to its ptg value
578	578	*
579		- * @return mixed the converted token on success
	579	+ * @return string the converted token on success
580	580	*/
581	581	private function convertString($string)
582	582	{
		@@ -654,7 +654,7 @@ discard block
		block discarded – undo
654	654	*
655	655	* @param string $token an Excel range in the Sheet1!A1:A2 format
656	656	*
657		- * @return mixed the packed ptgArea3d token on success
	657	+ * @return string the packed ptgArea3d token on success
658	658	*/
659	659	private function convertRange3d($token)
660	660	{
		@@ -706,7 +706,7 @@ discard block
		block discarded – undo
706	706	*
707	707	* @param string $cell An Excel cell reference
708	708	*
709		- * @return mixed the packed ptgRef3d token on success
	709	+ * @return string the packed ptgRef3d token on success
710	710	*/
711	711	private function convertRef3d($cell)
712	712	{
		@@ -805,7 +805,7 @@ discard block
		block discarded – undo
805	805	*
806	806	* @param string $ext_ref The name of the external reference
807	807	*
808		- * @return mixed The reference index in packed() format on success
	808	+ * @return string The reference index in packed() format on success
809	809	*/
810	810	private function getRefIndex($ext_ref)
811	811	{
		@@ -896,7 +896,7 @@ discard block
		block discarded – undo
896	896	*
897	897	* @param string $cell The Excel cell reference to be packed
898	898	*
899		- * @return array Array containing the row and column in packed() format
	899	+ * @return string[] Array containing the row and column in packed() format
900	900	*/
901	901	private function cellToPackedRowcol($cell)
902	902	{
		@@ -925,7 +925,7 @@ discard block
		block discarded – undo
925	925	*
926	926	* @param string $range The Excel range to be packed
927	927	*
928		- * @return array Array containing (row1,col1,row2,col2) in packed() format
	928	+ * @return string[] Array containing (row1,col1,row2,col2) in packed() format
929	929	*/
930	930	private function rangeToPackedRange($range)
931	931	{
		@@ -1041,7 +1041,7 @@ discard block
		block discarded – undo
1041	1041	/**
1042	1042	* Checks if it's a valid token.
1043	1043	*
1044		- * @param mixed $token the token to check
	1044	+ * @param string $token the token to check
1045	1045	*
1046	1046	* @return mixed The checked token or false on failure
1047	1047	*/
		@@ -1127,7 +1127,7 @@ discard block
		block discarded – undo
1127	1127	* @param string $formula the formula to parse, without the initial equal
1128	1128	* sign (=)
1129	1129	*
1130		- * @return mixed true on success
	1130	+ * @return boolean true on success
1131	1131	*/
1132	1132	public function parse($formula)
1133	1133	{

		@@ -27,7 +27,7 @@
		block discarded – undo
27	27
28	28	$inputFileName = './sampleData/example1.xls';
29	29
30		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
	30	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
31	31	$reader = new \PhpOffice\PhpSpreadsheet\Reader\Xls();
32	32	// $reader = new \PhpOffice\PhpSpreadsheet\Reader\Xlsx();
33	33	// $reader = new \PhpOffice\PhpSpreadsheet\Reader\Xml();

		@@ -37,53 +37,53 @@
		block discarded – undo
37	37
38	38	/* Read the document's creator property **/
39	39	$creator = $spreadsheet->getProperties()->getCreator();
40		-echo '<b>Document Creator: </b>',$creator,'<br />';
	40	+echo '<b>Document Creator: </b>', $creator, '<br />';
41	41
42	42	/* Read the Date when the workbook was created (as a PHP timestamp value) **/
43	43	$creationDatestamp = $spreadsheet->getProperties()->getCreated();
44	44	/* Format the date and time using the standard PHP date() function **/
45	45	$creationDate = date('l, d<\s\up>S</\s\up> F Y', $creationDatestamp);
46	46	$creationTime = date('g:i A', $creationDatestamp);
47		-echo '<b>Created On: </b>',$creationDate,' at ',$creationTime,'<br />';
	47	+echo '<b>Created On: </b>', $creationDate, ' at ', $creationTime, '<br />';
48	48
49	49	/* Read the name of the last person to modify this workbook **/
50	50	$modifiedBy = $spreadsheet->getProperties()->getLastModifiedBy();
51		-echo '<b>Last Modified By: </b>',$modifiedBy,'<br />';
	51	+echo '<b>Last Modified By: </b>', $modifiedBy, '<br />';
52	52
53	53	/* Read the Date when the workbook was last modified (as a PHP timestamp value) **/
54	54	$modifiedDatestamp = $spreadsheet->getProperties()->getModified();
55	55	/* Format the date and time using the standard PHP date() function **/
56	56	$modifiedDate = date('l, d<\s\up>S</\s\up> F Y', $modifiedDatestamp);
57	57	$modifiedTime = date('g:i A', $modifiedDatestamp);
58		-echo '<b>Last Modified On: </b>',$modifiedDate,' at ',$modifiedTime,'<br />';
	58	+echo '<b>Last Modified On: </b>', $modifiedDate, ' at ', $modifiedTime, '<br />';
59	59
60	60	/* Read the workbook title property **/
61	61	$workbookTitle = $spreadsheet->getProperties()->getTitle();
62		-echo '<b>Title: </b>',$workbookTitle,'<br />';
	62	+echo '<b>Title: </b>', $workbookTitle, '<br />';
63	63
64	64	/* Read the workbook description property **/
65	65	$description = $spreadsheet->getProperties()->getDescription();
66		-echo '<b>Description: </b>',$description,'<br />';
	66	+echo '<b>Description: </b>', $description, '<br />';
67	67
68	68	/* Read the workbook subject property **/
69	69	$subject = $spreadsheet->getProperties()->getSubject();
70		-echo '<b>Subject: </b>',$subject,'<br />';
	70	+echo '<b>Subject: </b>', $subject, '<br />';
71	71
72	72	/* Read the workbook keywords property **/
73	73	$keywords = $spreadsheet->getProperties()->getKeywords();
74		-echo '<b>Keywords: </b>',$keywords,'<br />';
	74	+echo '<b>Keywords: </b>', $keywords, '<br />';
75	75
76	76	/* Read the workbook category property **/
77	77	$category = $spreadsheet->getProperties()->getCategory();
78		-echo '<b>Category: </b>',$category,'<br />';
	78	+echo '<b>Category: </b>', $category, '<br />';
79	79
80	80	/* Read the workbook company property **/
81	81	$company = $spreadsheet->getProperties()->getCompany();
82		-echo '<b>Company: </b>',$company,'<br />';
	82	+echo '<b>Company: </b>', $company, '<br />';
83	83
84	84	/* Read the workbook manager property **/
85	85	$manager = $spreadsheet->getProperties()->getManager();
86		-echo '<b>Manager: </b>',$manager,'<br />';
	86	+echo '<b>Manager: </b>', $manager, '<br />';
87	87
88	88	?>
89	89	<body>

PHPOffice / PhpSpreadsheet

Pull Request — develop (#147)

Status

Category

Doc Comments +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch