Completed
Push — develop ( 467bab...e1f81f )
by Adrien
10:03
created
src/PhpSpreadsheet/Shared/ZipStreamWrapper.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     /**
102 102
      * Implements support for fstat().
103 103
      *
104
-     * @return  boolean
104
+     * @return  string
105 105
      */
106 106
     public function statName()
107 107
     {
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     /**
112 112
      * Implements support for fstat().
113 113
      *
114
-     * @return  boolean
114
+     * @return  string
115 115
      */
116 116
     public function url_stat() // @codingStandardsIgnoreLine
117 117
     {
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
      *
168 168
      * @param    int        $offset    byte offset
169 169
      * @param    int        $whence    SEEK_SET, SEEK_CUR or SEEK_END
170
-     * @return    bool
170
+     * @return    boolean|null
171 171
      */
172 172
     public function stream_seek($offset, $whence) // @codingStandardsIgnoreLine
173 173
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Spreadsheet.php 1 patch
Doc Comments   +11 added lines, -10 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     /**
138 138
     * The workbook has macros ?
139 139
     *
140
-    * @return true if workbook has macros, false if not
140
+    * @return boolean if workbook has macros, false if not
141 141
     */
142 142
     public function hasMacros()
143 143
     {
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     /**
179 179
     * Set the macros certificate
180 180
     *
181
-    * @param string|null $Certificate
181
+    * @param string|null $certificate
182 182
     */
183 183
     public function setMacrosCertificate($certificate = null)
184 184
     {
@@ -233,6 +233,7 @@  discard block
 block discarded – undo
233 233
     * retrieve ribbon XML Data
234 234
     *
235 235
     * return string|null|array
236
+    * @return string
236 237
     */
237 238
     public function getRibbonXMLData($what = 'all') //we need some constants here...
238 239
     {
@@ -308,7 +309,7 @@  discard block
 block discarded – undo
308 309
     /**
309 310
     * This workbook have a custom UI ?
310 311
     *
311
-    * @return true|false
312
+    * @return boolean
312 313
     */
313 314
     public function hasRibbon()
314 315
     {
@@ -318,7 +319,7 @@  discard block
 block discarded – undo
318 319
     /**
319 320
     * This workbook have additionnal object for the ribbon ?
320 321
     *
321
-    * @return true|false
322
+    * @return boolean
322 323
     */
323 324
     public function hasRibbonBinObjects()
324 325
     {
@@ -617,7 +618,7 @@  discard block
 block discarded – undo
617 618
      * Get index for sheet
618 619
      *
619 620
      * @param  Worksheet $pSheet
620
-     * @return Sheet index
621
+     * @return integer index
621 622
      * @throws Exception
622 623
      */
623 624
     public function getIndex(Worksheet $pSheet)
@@ -636,7 +637,7 @@  discard block
 block discarded – undo
636 637
      *
637 638
      * @param  string $sheetName Sheet name to modify index for
638 639
      * @param  int $newIndex New index for the sheet
639
-     * @return New sheet index
640
+     * @return integer sheet index
640 641
      * @throws Exception
641 642
      */
642 643
     public function setIndexByName($sheetName, $newIndex)
@@ -778,7 +779,7 @@  discard block
 block discarded – undo
778 779
      * Add named range
779 780
      *
780 781
      * @param  NamedRange $namedRange
781
-     * @return PHPExcel
782
+     * @return boolean
782 783
      */
783 784
     public function addNamedRange(NamedRange $namedRange)
784 785
     {
@@ -823,7 +824,7 @@  discard block
 block discarded – undo
823 824
      *
824 825
      * @param  string  $namedRange
825 826
      * @param  Worksheet|null  $pSheet  Scope: use null for global scope.
826
-     * @return PHPExcel
827
+     * @return Spreadsheet
827 828
      */
828 829
     public function removeNamedRange($namedRange, Worksheet $pSheet = null)
829 830
     {
@@ -842,7 +843,7 @@  discard block
 block discarded – undo
842 843
     /**
843 844
      * Get worksheet iterator
844 845
      *
845
-     * @return WorksheetIterator
846
+     * @return Worksheet\Iterator
846 847
      */
847 848
     public function getWorksheetIterator()
848 849
     {
@@ -852,7 +853,7 @@  discard block
 block discarded – undo
852 853
     /**
853 854
      * Copy workbook (!= clone!)
854 855
      *
855
-     * @return PHPExcel
856
+     * @return Spreadsheet
856 857
      */
857 858
     public function copy()
858 859
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Style.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@
 block discarded – undo
150 150
     /**
151 151
      * Get parent. Only used for style supervisor
152 152
      *
153
-     * @return PHPExcel
153
+     * @return Style
154 154
      */
155 155
     public function getParent()
156 156
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Style/Conditional.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     /**
101 101
      * Get Condition type
102 102
      *
103
-     * @return string
103
+     * @return integer
104 104
      */
105 105
     public function getConditionType()
106 106
     {
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     /**
123 123
      * Get Operator type
124 124
      *
125
-     * @return string
125
+     * @return integer
126 126
      */
127 127
     public function getOperatorType()
128 128
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet.php 1 patch
Doc Comments   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
     /**
330 330
      * Create a new worksheet
331 331
      *
332
-     * @param PHPExcel        $pParent
332
+     * @param PHPExcel        $parent
333 333
      * @param string        $pTitle
334 334
      */
335 335
     public function __construct(Spreadsheet $parent = null, $pTitle = 'Worksheet')
@@ -586,7 +586,7 @@  discard block
 block discarded – undo
586 586
      * Get a chart by its index position
587 587
      *
588 588
      * @param string $index Chart index position
589
-     * @return false|Chart
589
+     * @return null|Chart
590 590
      * @throws Exception
591 591
      */
592 592
     public function getChartByIndex($index = null)
@@ -768,7 +768,7 @@  discard block
 block discarded – undo
768 768
     /**
769 769
      * Get parent
770 770
      *
771
-     * @return PHPExcel
771
+     * @return Spreadsheet
772 772
      */
773 773
     public function getParent()
774 774
     {
@@ -778,7 +778,7 @@  discard block
 block discarded – undo
778 778
     /**
779 779
      * Re-bind parent
780 780
      *
781
-     * @param PHPExcel $parent
781
+     * @param Spreadsheet $parent
782 782
      * @return Worksheet
783 783
      */
784 784
     public function rebindParent(Spreadsheet $parent)
@@ -1078,7 +1078,7 @@  discard block
 block discarded – undo
1078 1078
      * Set a cell value
1079 1079
      *
1080 1080
      * @param string $pCoordinate Coordinate of the cell
1081
-     * @param mixed $pValue Value of the cell
1081
+     * @param integer $pValue Value of the cell
1082 1082
      * @param bool $returnCell   Return the worksheet (false, default) or the cell (true)
1083 1083
      * @return Worksheet|Cell    Depending on the last parameter being specified
1084 1084
      */
@@ -1091,8 +1091,8 @@  discard block
 block discarded – undo
1091 1091
     /**
1092 1092
      * Set a cell value by using numeric cell coordinates
1093 1093
      *
1094
-     * @param string $pColumn Numeric column coordinate of the cell (A = 0)
1095
-     * @param string $pRow Numeric row coordinate of the cell
1094
+     * @param integer $pColumn Numeric column coordinate of the cell (A = 0)
1095
+     * @param integer $pRow Numeric row coordinate of the cell
1096 1096
      * @param mixed $pValue Value of the cell
1097 1097
      * @param bool $returnCell Return the worksheet (false, default) or the cell (true)
1098 1098
      * @return Worksheet|Cell    Depending on the last parameter being specified
@@ -1122,8 +1122,8 @@  discard block
 block discarded – undo
1122 1122
     /**
1123 1123
      * Set a cell value by using numeric cell coordinates
1124 1124
      *
1125
-     * @param string $pColumn Numeric column coordinate of the cell
1126
-     * @param string $pRow Numeric row coordinate of the cell
1125
+     * @param integer $pColumn Numeric column coordinate of the cell
1126
+     * @param integer $pRow Numeric row coordinate of the cell
1127 1127
      * @param mixed $pValue Value of the cell
1128 1128
      * @param string $pDataType Explicit data type
1129 1129
      * @param bool $returnCell Return the worksheet (false, default) or the cell (true)
@@ -1183,8 +1183,8 @@  discard block
 block discarded – undo
1183 1183
     /**
1184 1184
      * Get cell at a specific coordinate by using numeric cell coordinates
1185 1185
      *
1186
-     * @param  string $pColumn Numeric column coordinate of the cell
1187
-     * @param string $pRow Numeric row coordinate of the cell
1186
+     * @param  integer $pColumn Numeric column coordinate of the cell
1187
+     * @param integer $pRow Numeric row coordinate of the cell
1188 1188
      * @param boolean $createIfNotExists  Flag indicating whether a new cell should be created if it doesn't
1189 1189
      *                                       already exist, or a null should be returned instead
1190 1190
      * @return null|Cell Cell that was found/created or null
@@ -1291,8 +1291,8 @@  discard block
 block discarded – undo
1291 1291
     /**
1292 1292
      * Cell at a specific coordinate by using numeric cell coordinates exists?
1293 1293
      *
1294
-     * @param string $pColumn Numeric column coordinate of the cell
1295
-     * @param string $pRow Numeric row coordinate of the cell
1294
+     * @param integer $pColumn Numeric column coordinate of the cell
1295
+     * @param integer $pRow Numeric row coordinate of the cell
1296 1296
      * @return boolean
1297 1297
      */
1298 1298
     public function cellExistsByColumnAndRow($pColumn = 0, $pRow = 1)
@@ -1351,7 +1351,7 @@  discard block
 block discarded – undo
1351 1351
     /**
1352 1352
      * Get column dimension at a specific column by using numeric cell coordinates
1353 1353
      *
1354
-     * @param string $pColumn Numeric column coordinate of the cell
1354
+     * @param integer $pColumn Numeric column coordinate of the cell
1355 1355
      * @return Worksheet\ColumnDimension
1356 1356
      */
1357 1357
     public function getColumnDimensionByColumn($pColumn = 0)
@@ -1472,7 +1472,7 @@  discard block
 block discarded – undo
1472 1472
     /**
1473 1473
      * Set conditional styles
1474 1474
      *
1475
-     * @param $pCoordinate string E.g. 'A1'
1475
+     * @param string $pCoordinate string E.g. 'A1'
1476 1476
      * @param $pValue Style\Conditional[]
1477 1477
      * @return Worksheet
1478 1478
      */
@@ -1893,7 +1893,7 @@  discard block
 block discarded – undo
1893 1893
     /**
1894 1894
      *    Set AutoFilter
1895 1895
      *
1896
-     *    @param    Worksheet\AutoFilter|string   $pValue
1896
+     *    @param    string   $pValue
1897 1897
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
1898 1898
      *    @throws Exception
1899 1899
      *    @return Worksheet
@@ -2903,7 +2903,7 @@  discard block
 block discarded – undo
2903 2903
      * Define the code name of the sheet
2904 2904
      *
2905 2905
      * @param null|string Same rule as Title minus space not allowed (but, like Excel, change silently space to underscore)
2906
-     * @return objWorksheet
2906
+     * @return Worksheet
2907 2907
      * @throws Exception
2908 2908
     */
2909 2909
     public function setCodeName($pValue = null)
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/AutoFilter.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -467,6 +467,7 @@  discard block
 block discarded – undo
467 467
      *
468 468
      *    @param    string                   $dynamicRuleType
469 469
      *    @param    AutoFilter\Column        &$filterColumn
470
+     * @param AutoFilter\Column $filterColumn
470 471
      *    @return mixed[]
471 472
      */
472 473
     private function dynamicFilterDateRange($dynamicRuleType, &$filterColumn)
@@ -571,6 +572,11 @@  discard block
 block discarded – undo
571 572
         return array('method' => 'filterTestInCustomDataSet', 'arguments' => array('filterRules' => $ruleValues, 'join' => AutoFilter\Column::AUTOFILTER_COLUMN_JOIN_AND));
572 573
     }
573 574
 
575
+    /**
576
+     * @param integer $columnID
577
+     * @param integer $startRow
578
+     * @param string $ruleType
579
+     */
574 580
     private function calculateTopTenValue($columnID, $startRow, $endRow, $ruleType, $ruleValue)
575 581
     {
576 582
         $range = $columnID.$startRow.':'.$columnID.$endRow;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/AutoFilter/Column/Rule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -286,7 +286,7 @@
 block discarded – undo
286 286
      *
287 287
      *    @param   string        $pRuleType
288 288
      *    @throws  \PHPExcel\Exception
289
-     *    @return  \PHPExcel\Worksheet\AutoFilter\Column
289
+     *    @return  Rule
290 290
      */
291 291
     public function setRuleType($pRuleType = self::AUTOFILTER_RULETYPE_FILTER)
292 292
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/ColumnCellIterator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
     /**
137 137
      * Return the current cell in this worksheet column
138 138
      *
139
-     * @return Row
139
+     * @return null|\PHPExcel\Cell
140 140
      */
141 141
     public function current()
142 142
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/ColumnDimension.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     /**
70 70
      * Get ColumnIndex
71 71
      *
72
-     * @return string
72
+     * @return integer
73 73
      */
74 74
     public function getColumnIndex()
75 75
     {
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     /**
102 102
      * Set Width
103 103
      *
104
-     * @param double $pValue
104
+     * @param integer $pValue
105 105
      * @return ColumnDimension
106 106
      */
107 107
     public function setWidth($pValue = -1)
Please login to merge, or discard this patch.