PHPOffice / PhpSpreadsheet

src/PhpSpreadsheet/Worksheet.php

Doc Comments +8 added lines, -8 removed lines

@@ -584,7 +584,7 @@ 
      *
      * @param string $index Chart index position
      * @throws Exception
-     * @return false|Chart
+     * @return null|Chart
      */
     public function getChartByIndex($index = null)
     {
@@ -1085,7 +1085,7 @@ 
      * Set a cell value
      *
      * @param string $pCoordinate Coordinate of the cell
-     * @param mixed $pValue Value of the cell
+     * @param integer $pValue Value of the cell
      * @param bool $returnCell   Return the worksheet (false, default) or the cell (true)
      * @return Worksheet|Cell    Depending on the last parameter being specified
      */
@@ -1196,8 +1196,8 @@ 
     /**
      * Get cell at a specific coordinate by using numeric cell coordinates
      *
-     * @param  string $pColumn Numeric column coordinate of the cell
-     * @param string $pRow Numeric row coordinate of the cell
+     * @param  integer $pColumn Numeric column coordinate of the cell
+     * @param integer $pRow Numeric row coordinate of the cell
      * @param bool $createIfNotExists  Flag indicating whether a new cell should be created if it doesn't
      *                                       already exist, or a null should be returned instead
      * @return null|Cell Cell that was found/created or null
@@ -1305,8 +1305,8 @@ 
     /**
      * Cell at a specific coordinate by using numeric cell coordinates exists?
      *
-     * @param string $pColumn Numeric column coordinate of the cell
-     * @param string $pRow Numeric row coordinate of the cell
+     * @param integer $pColumn Numeric column coordinate of the cell
+     * @param integer $pRow Numeric row coordinate of the cell
      * @return bool
      */
     public function cellExistsByColumnAndRow($pColumn = 0, $pRow = 1)
@@ -1923,7 +1923,7 @@ 
     /**
      *    Set AutoFilter
      *
-     *    @param    Worksheet\AutoFilter|string   $pValue
+     *    @param    string   $pValue
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
      *    @throws Exception
      *    @return Worksheet
@@ -2954,7 +2954,7 @@ 
      *
      * @param null|string Same rule as Title minus space not allowed (but, like Excel, change silently space to underscore)
      * @throws Exception
-     * @return objWorksheet
+     * @return Worksheet
      */
     public function setCodeName($pValue = null)
     {

src/PhpSpreadsheet/Worksheet/AutoFilter.php

Doc Comments +5 added lines

@@ -567,6 +567,11 @@
         return ['method' => 'filterTestInCustomDataSet', 'arguments' => ['filterRules' => $ruleValues, 'join' => AutoFilter\Column::AUTOFILTER_COLUMN_JOIN_AND]];
     }
 
+    /**
+     * @param integer $columnID
+     * @param integer $startRow
+     * @param string $ruleType
+     */
     private function calculateTopTenValue($columnID, $startRow, $endRow, $ruleType, $ruleValue)
     {
         $range = $columnID . $startRow . ':' . $columnID . $endRow;

src/PhpSpreadsheet/Worksheet/ColumnDimension.php

Doc Comments +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
     /**
      * Set Row Height
      *
-     * @param float $pValue
+     * @param integer $pValue
      * @return RowDimension
      */
     public function setRowHeight($pValue = -1)

tests/PhpSpreadsheetTests/Shared/StringTest.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     public function testGetCurrencyCode()
     {
         $localeconv = localeconv();
-        $expectedResult = (!empty($localeconv['currency_symbol']) ? $localeconv['currency_symbol'] : (!empty($localeconv['int_curr_symbol']) ? $localeconv['int_curr_symbol']: '$'));
+        $expectedResult = (!empty($localeconv['currency_symbol']) ? $localeconv['currency_symbol'] : (!empty($localeconv['int_curr_symbol']) ? $localeconv['int_curr_symbol'] : '$'));
         $result = call_user_func([StringHelper::class, 'getCurrencyCode']);
         $this->assertEquals($expectedResult, $result);
     }

tests/PhpSpreadsheetTests/Worksheet/ColumnIteratorTest.php

Indentation +4 added lines, -4 removed lines

@@ -18,11 +18,11 @@
             ->getMock();
 
         $this->mockWorksheet->expects($this->any())
-                 ->method('getHighestColumn')
-                 ->will($this->returnValue('E'));
+                    ->method('getHighestColumn')
+                    ->will($this->returnValue('E'));
         $this->mockWorksheet->expects($this->any())
-                 ->method('current')
-                 ->will($this->returnValue($this->mockColumn));
+                    ->method('current')
+                    ->will($this->returnValue($this->mockColumn));
     }
 
 

tests/PhpSpreadsheetTests/Worksheet/RowCellIteratorTest.php

Indentation +4 added lines, -4 removed lines

@@ -18,11 +18,11 @@
             ->getMock();
 
         $this->mockWorksheet->expects($this->any())
-                 ->method('getHighestColumn')
-                 ->will($this->returnValue('E'));
+                    ->method('getHighestColumn')
+                    ->will($this->returnValue('E'));
         $this->mockWorksheet->expects($this->any())
-                 ->method('getCellByColumnAndRow')
-                 ->will($this->returnValue($this->mockCell));
+                    ->method('getCellByColumnAndRow')
+                    ->will($this->returnValue($this->mockCell));
     }
 
 

tests/PhpSpreadsheetTests/Worksheet/ColumnCellIteratorTest.php

Indentation +4 added lines, -4 removed lines

@@ -18,11 +18,11 @@
             ->getMock();
 
         $this->mockWorksheet->expects($this->any())
-                 ->method('getHighestRow')
-                 ->will($this->returnValue(5));
+                    ->method('getHighestRow')
+                    ->will($this->returnValue(5));
         $this->mockWorksheet->expects($this->any())
-                 ->method('getCellByColumnAndRow')
-                 ->will($this->returnValue($this->mockCell));
+                    ->method('getCellByColumnAndRow')
+                    ->will($this->returnValue($this->mockCell));
     }
 
 

tests/PhpSpreadsheetTests/Worksheet/AutoFilter/ColumnTest.php

Indentation +4 added lines, -4 removed lines

@@ -113,7 +113,7 @@ 
     {
         $attributeSet = ['val' => 100,
                                 'maxVal' => 200,
-                             ];
+                                ];
 
         //    Setters return the instance to implement the fluent interface
         $result = $this->testAutoFilterColumnObject->setAttributes($attributeSet);
@@ -124,7 +124,7 @@ 
     {
         $attributeSet = ['val' => 100,
                                 'maxVal' => 200,
-                             ];
+                                ];
 
         $this->testAutoFilterColumnObject->setAttributes($attributeSet);
 
@@ -137,7 +137,7 @@ 
     {
         $attributeSet = ['val' => 100,
                                 'maxVal' => 200,
-                             ];
+                                ];
 
         foreach ($attributeSet as $attributeName => $attributeValue) {
             //    Setters return the instance to implement the fluent interface
@@ -150,7 +150,7 @@ 
     {
         $attributeSet = ['val' => 100,
                                 'maxVal' => 200,
-                             ];
+                                ];
 
         $this->testAutoFilterColumnObject->setAttributes($attributeSet);
 

tests/PhpSpreadsheetTests/Worksheet/RowIteratorTest.php

Indentation +4 added lines, -4 removed lines

@@ -18,11 +18,11 @@
             ->getMock();
 
         $this->mockWorksheet->expects($this->any())
-                 ->method('getHighestRow')
-                 ->will($this->returnValue(5));
+                    ->method('getHighestRow')
+                    ->will($this->returnValue(5));
         $this->mockWorksheet->expects($this->any())
-                 ->method('current')
-                 ->will($this->returnValue($this->mockRow));
+                    ->method('current')
+                    ->will($this->returnValue($this->mockRow));
     }