Completed
Pull Request — develop (#72)
by Henrik
27:27
created
docs/Examples/Reading WorkBook Data/exampleWorkBookReader03.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 echo '<b>Custom Properties: </b><br />';
42 42
 /*  Loop through the list of custom properties  **/
43 43
 foreach ($customPropertyList as $customPropertyName) {
44
-    echo '<b>',$customPropertyName,': </b>';
44
+    echo '<b>', $customPropertyName, ': </b>';
45 45
     /*  Retrieve the property value  **/
46 46
     $propertyValue = $spreadsheet->getProperties()->getCustomPropertyValue($customPropertyName);
47 47
     /*  Retrieve the property type  **/
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader12.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 //	$inputFileType = 'Gnumeric';
33 33
 $inputFileName = './sampleData/example1.xls';
34 34
 
35
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
35
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36 36
 $objReader = PHPExcel_IOFactory::createReader($inputFileType);
37 37
 echo 'Turning Formatting off for Load<br />';
38 38
 $objReader->setReadDataOnly(true);
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader13.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,11 +30,11 @@
 block discarded – undo
30 30
 
31 31
 $reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
32 32
 $inputFileName = array_shift($inputFileNames);
33
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #1 using IOFactory with a defined reader type of ',$inputFileType,'<br />';
33
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #1 using IOFactory with a defined reader type of ', $inputFileType, '<br />';
34 34
 $spreadsheet = $reader->load($inputFileName);
35 35
 $spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
36 36
 foreach ($inputFileNames as $sheet => $inputFileName) {
37
-    echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #',($sheet + 2),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
37
+    echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #', ($sheet + 2), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
38 38
     $reader->setSheetIndex($sheet + 1);
39 39
     $reader->loadIntoExisting($inputFileName, $spreadsheet);
40 40
     $spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader06.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 //	$inputFileType = 'Gnumeric';
33 33
 $inputFileName = './sampleData/example1.xls';
34 34
 
35
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
35
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36 36
 $objReader = PHPExcel_IOFactory::createReader($inputFileType);
37 37
 echo 'Turning Formatting off for Load<br />';
38 38
 $objReader->setReadDataOnly(true);
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader15.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,17 +26,17 @@
 block discarded – undo
26 26
 $inputFileName = './sampleData/example1.tsv';
27 27
 
28 28
 $reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
29
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #1 using IOFactory with a defined reader type of ',$inputFileType,'<br />';
29
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #1 using IOFactory with a defined reader type of ', $inputFileType, '<br />';
30 30
 $reader->setDelimiter("\t");
31 31
 $spreadsheet = $reader->load($inputFileName);
32 32
 $spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
33 33
 
34 34
 echo '<hr />';
35 35
 
36
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
36
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
37 37
 $loadedSheetNames = $spreadsheet->getSheetNames();
38 38
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
39
-    echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,' (Formatted)</b><br />';
39
+    echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, ' (Formatted)</b><br />';
40 40
     $spreadsheet->setActiveSheetIndexByName($loadedSheetName);
41 41
     $sheetData = $spreadsheet->getActiveSheet()->toArray(null, true, true, true);
42 42
     var_dump($sheetData);
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Reader/Xlsx.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -294,6 +294,11 @@  discard block
 block discarded – undo
294 294
         return isset($c->v) ? (string) $c->v : null;
295 295
     }
296 296
 
297
+    /**
298
+     * @param string $r
299
+     * @param string $cellDataType
300
+     * @param string $castBaseType
301
+     */
297 302
     private function castToFormula($c, $r, &$cellDataType, &$value, &$calculatedValue, &$sharedFormulas, $castBaseType)
298 303
     {
299 304
         $cellDataType = 'f';
@@ -2159,6 +2164,9 @@  discard block
 block discarded – undo
2159 2164
         return preg_replace('~[^/]+/\.\./~', '', dirname($base) . "/$add");
2160 2165
     }
2161 2166
 
2167
+    /**
2168
+     * @param string $style
2169
+     */
2162 2170
     private static function toCSSArray($style)
2163 2171
     {
2164 2172
         $style = str_replace(["\r", "\n"], '', $style);
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Spreadsheet.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
      * set ribbon XML data.
219 219
      *
220 220
      * @param null|mixed $target
221
-     * @param null|mixed $xmlData
221
+     * @param string $xmlData
222 222
      */
223 223
     public function setRibbonXMLData($target = null, $xmlData = null)
224 224
     {
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
      *
235 235
      * return string|null|array
236 236
      *
237
-     * @param mixed $what
237
+     * @param string $what
238 238
      *
239 239
      * @return string
240 240
      */
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
     /**
286 286
      * retrieve Binaries Ribbon Objects.
287 287
      *
288
-     * @param mixed $What
288
+     * @param string $What
289 289
      */
290 290
     public function getRibbonBinObjects($What = 'all')
291 291
     {
Please login to merge, or discard this patch.