Inspection of "minor fixes to unit tests" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#72)

by Henrik

created 2017-01-12 14:59 UTC

Status

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $objPHPExcel->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DSTDEV.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $objPHPExcel->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DVAR.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $objPHPExcel->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DMAX.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $objPHPExcel->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DCOUNT.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -30,17 +30,17 @@
		block discarded – undo
30	30	$worksheet = $objPHPExcel->getActiveSheet();
31	31
32	32	// Add some data
33		-$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
	33	+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
40	40	];
41		-$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
	41	+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
44	44	];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');

Please login to merge, or discard this patch.

docs/Examples/Calculations/DateTime/TIME.php 2 patches

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
 // Add some data
 $testDates = ['3:15',    '13:15',    '15:15:15',    '3:15 AM',    '3:15 PM',    '5PM',    '9:15AM',    '13:15AM',
-                  ];
+                    ];
 $testDateCount = count($testDates);
 
 for ($row = 1; $row <= $testDateCount; ++$row) {
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
 }
 
 $worksheet->getStyle('C1:C' . $testDateCount)
-          ->getNumberFormat()
-          ->setFormatCode('hh:mm:ss');
+            ->getNumberFormat()
+            ->setFormatCode('hh:mm:ss');
 
 echo '<hr />';
 

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

		@@ -30,9 +30,9 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$testDates = [[3, 15], [13, 15], [15, 15, 15], [3, 15, 30],
34		- [15, 15, 15], [5], [9, 15, 0], [9, 15, -1],
35		- [13, -14, -15], [0, 0, -1],
	33	+$testDates = [[3, 15], [13, 15], [15, 15, 15], [3, 15, 30],
	34	+ [15, 15, 15], [5], [9, 15, 0], [9, 15, -1],
	35	+ [13, -14, -15], [0, 0, -1],
36	36	];
37	37	$testDateCount = count($testDates);
38	38

Please login to merge, or discard this patch.

docs/Examples/Calculations/DateTime/DATEVALUE.php 2 patches

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@  discard block
 block discarded – undo
                     [2011, 2, 29],    [7, 5, 3],        [2012, 13, 1],    [2012, 11, 45],
                     [2012, 0, 0],    [2012, 1, 0],    [2012, 0, 1],
                     [2012, -2, 2],    [2012, 2, -2],    [2012, -2, -2],
-                  ];
+                    ];
 $testDateCount = count($testDates);
 
 $worksheet->fromArray($testDates, null, 'A1', true);
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
     $worksheet->setCellValue('E' . $row, '=D' . $row);
 }
 $worksheet->getStyle('E1:E' . $testDateCount)
-          ->getNumberFormat()
-          ->setFormatCode('yyyy-mmm-dd');
+            ->getNumberFormat()
+            ->setFormatCode('yyyy-mmm-dd');
 
 echo '<hr />';
 

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

		@@ -30,10 +30,10 @@
		block discarded – undo
30	30	$worksheet = $spreadsheet->getActiveSheet();
31	31
32	32	// Add some data
33		-$testDates = ['26 March 2012', '29 Feb 2012', 'April 1, 2012', '25/12/2012',
34		- '2012-Oct-31', '5th November', 'January 1st', 'April 2012',
35		- '17-03', '03-2012', '29 Feb 2011', '03-05-07',
36		- '03-MAY-07', '03-13-07',
	33	+$testDates = ['26 March 2012', '29 Feb 2012', 'April 1, 2012', '25/12/2012',
	34	+ '2012-Oct-31', '5th November', 'January 1st', 'April 2012',
	35	+ '17-03', '03-2012', '29 Feb 2011', '03-05-07',
	36	+ '03-MAY-07', '03-13-07',
37	37	];
38	38	$testDateCount = count($testDates);
39	39

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader08.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -33,18 +33,18 @@
 block discarded – undo
 $inputFileName = './sampleData/example1.xls';
 $sheetnames = ['Data Sheet #1', 'Data Sheet #3'];
 
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
 $objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
-echo 'Loading Sheet',((count($sheetnames) == 1) ? '' : 's'),' "',implode('" and "', $sheetnames),'" only<br />';
+echo 'Loading Sheet', ((count($sheetnames) == 1) ? '' : 's'), ' "', implode('" and "', $sheetnames), '" only<br />';
 $objReader->setLoadSheetsOnly($sheetnames);
 $spreadsheet = $objReader->load($inputFileName);
 
 echo '<hr />';
 
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
 $loadedSheetNames = $spreadsheet->getSheetNames();
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
+    echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
 }
 
 ?>

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader07.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -33,18 +33,18 @@
 block discarded – undo
 $inputFileName = './sampleData/example1.xls';
 $sheetname = 'Data Sheet #2';
 
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
 $objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
-echo 'Loading Sheet "',$sheetname,'" only<br />';
+echo 'Loading Sheet "', $sheetname, '" only<br />';
 $objReader->setLoadSheetsOnly($sheetname);
 $spreadsheet = $objReader->load($inputFileName);
 
 echo '<hr />';
 
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
 $loadedSheetNames = $spreadsheet->getSheetNames();
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
+    echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
 }
 
 ?>

Please login to merge, or discard this patch.

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31
32	32	// Add some data
33	33	$testDates = ['3:15', '13:15', '15:15:15', '3:15 AM', '3:15 PM', '5PM', '9:15AM', '13:15AM',
34		- ];
	34	+ ];
35	35	$testDateCount = count($testDates);
36	36
37	37	for ($row = 1; $row <= $testDateCount; ++$row) {
		@@ -41,8 +41,8 @@ discard block
		block discarded – undo
41	41	}
42	42
43	43	$worksheet->getStyle('C1:C' . $testDateCount)
44		- ->getNumberFormat()
45		- ->setFormatCode('hh:mm:ss');
	44	+ ->getNumberFormat()
	45	+ ->setFormatCode('hh:mm:ss');
46	46
47	47	echo '<hr />';
48	48

		@@ -35,7 +35,7 @@ discard block
		block discarded – undo
35	35	[2011, 2, 29], [7, 5, 3], [2012, 13, 1], [2012, 11, 45],
36	36	[2012, 0, 0], [2012, 1, 0], [2012, 0, 1],
37	37	[2012, -2, 2], [2012, 2, -2], [2012, -2, -2],
38		- ];
	38	+ ];
39	39	$testDateCount = count($testDates);
40	40
41	41	$worksheet->fromArray($testDates, null, 'A1', true);
		@@ -45,8 +45,8 @@ discard block
		block discarded – undo
45	45	$worksheet->setCellValue('E' . $row, '=D' . $row);
46	46	}
47	47	$worksheet->getStyle('E1:E' . $testDateCount)
48		- ->getNumberFormat()
49		- ->setFormatCode('yyyy-mmm-dd');
	48	+ ->getNumberFormat()
	49	+ ->setFormatCode('yyyy-mmm-dd');
50	50
51	51	echo '<hr />';
52	52

		@@ -33,18 +33,18 @@
		block discarded – undo
33	33	$inputFileName = './sampleData/example1.xls';
34	34	$sheetnames = ['Data Sheet #1', 'Data Sheet #3'];
35	35
36		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
	36	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
37	37	$objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
38		-echo 'Loading Sheet',((count($sheetnames) == 1) ? '' : 's'),' "',implode('" and "', $sheetnames),'" only<br />';
	38	+echo 'Loading Sheet', ((count($sheetnames) == 1) ? '' : 's'), ' "', implode('" and "', $sheetnames), '" only<br />';
39	39	$objReader->setLoadSheetsOnly($sheetnames);
40	40	$spreadsheet = $objReader->load($inputFileName);
41	41
42	42	echo '<hr />';
43	43
44		-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
	44	+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
45	45	$loadedSheetNames = $spreadsheet->getSheetNames();
46	46	foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
47		- echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
	47	+ echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
48	48	}
49	49
50	50	?>

PHPOffice / PhpSpreadsheet

Pull Request — develop (#72)

Status

Category

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch