Conditions | 1 |
Paths | 1 |
Total Lines | 62 |
Code Lines | 38 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
52 | public function providerAddColor() |
||
53 | { |
||
54 | $this->setUp(); |
||
55 | |||
56 | $workbookReflection = new \ReflectionClass(Workbook::class); |
||
57 | $propertyPalette = $workbookReflection->getProperty('palette'); |
||
58 | $propertyPalette->setAccessible(true); |
||
59 | |||
60 | $palette = $propertyPalette->getValue($this->workbook); |
||
61 | |||
62 | $newColor1 = [0x00, 0x00, 0x01, 0x00]; |
||
63 | $newColor2 = [0x00, 0x00, 0x02, 0x00]; |
||
64 | $newColor3 = [0x00, 0x00, 0x03, 0x00]; |
||
65 | |||
66 | // Add one new color |
||
67 | $paletteTestOne = $palette; |
||
68 | $paletteTestOne[8] = $newColor1; |
||
69 | |||
70 | // Add one new color + one existing color after index 8 |
||
71 | $paletteTestTwo = $paletteTestOne; |
||
72 | |||
73 | // Add one new color + one existing color before index 9 |
||
74 | $paletteTestThree = $paletteTestOne; |
||
75 | $paletteTestThree[9] = $palette[8]; |
||
76 | |||
77 | // Add three new color |
||
78 | $paletteTestFour = $palette; |
||
79 | $paletteTestFour[8] = $newColor1; |
||
80 | $paletteTestFour[9] = $newColor2; |
||
81 | $paletteTestFour[10] = $newColor3; |
||
82 | |||
83 | // Add all existing color |
||
84 | $colorsAdd = array_map([$this, 'paletteToColor'], $palette); |
||
85 | $paletteTestFive = $palette; |
||
86 | |||
87 | // Add new color after all existing color |
||
88 | $colorsAddTwo = array_map([$this, 'paletteToColor'], $palette); |
||
89 | $colorsAddTwo[] = $this->paletteToColor($newColor1); |
||
90 | $paletteTestSix = $palette; |
||
91 | |||
92 | // Add one existing color |
||
93 | $paletteTestSeven = $palette; |
||
94 | |||
95 | // Add two existing color |
||
96 | $paletteTestHeight = $palette; |
||
97 | |||
98 | // Add last existing color and add one new color |
||
99 | $keyPalette = array_keys($palette); |
||
100 | $last = end($keyPalette); |
||
101 | $lastColor = $this->paletteToColor($palette[$last]); |
||
102 | $paletteTestNine = $palette; |
||
103 | |||
104 | return [ |
||
105 | [[$this->paletteToColor($newColor1)], $paletteTestOne], |
||
106 | [[$this->paletteToColor($newColor1), $this->paletteToColor($palette[12])], $paletteTestTwo], |
||
107 | [[$this->paletteToColor($newColor1), $this->paletteToColor($palette[8])], $paletteTestThree], |
||
108 | [[$this->paletteToColor($newColor1), $this->paletteToColor($newColor2), $this->paletteToColor($newColor3)], $paletteTestFour], |
||
109 | [$colorsAdd, $paletteTestFive], |
||
110 | [$colorsAddTwo, $paletteTestSix], |
||
111 | [[$this->paletteToColor($palette[8])], $paletteTestSeven], |
||
112 | [[$this->paletteToColor($palette[25]), $this->paletteToColor($palette[10])], $paletteTestHeight], |
||
113 | [[$lastColor, $this->paletteToColor($newColor1)], $paletteTestNine], |
||
114 | ]; |
||
144 |