SampleTest::providerSample() - Code Metrics - Inspection of "Rename tests according to the class the class they..." - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 98b532...40efcd )

by Adrien

created 2017-11-03 03:47 UTC

SampleTest::providerSample() B

↳ Parent: SampleTest

Complexity

Conditions	5
Paths	8

Size

Total Lines	31
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	18
c	1
b	0
f	0
nc	8
nop	0
dl	0
loc	31
rs	8.439

<?php

namespace PhpOffice\PhpSpreadsheetTests\Sample;

use PhpOffice\PhpSpreadsheet\Helper\Sample;
use PHPUnit_Framework_TestCase;

class SampleTest extends PHPUnit_Framework_TestCase
{
    /**
     * @runInSeparateProcess
     * @preserveGlobalState disabled
     * @dataProvider providerSample
     *
     * @param mixed $sample
     */
    public function testSample($sample)
    {
        // Suppress output to console
        $this->setOutputCallback(function () {
        });

        require $sample;
    }

    public function providerSample()
    {
        $skipped = [
            'Chart/32_Chart_read_write_PDF.php', // Unfortunately JpGraph is not up to date for latest PHP and raise many warnings
            'Chart/32_Chart_read_write_HTML.php', // idem
        ];

        // Unfortunately some tests are too long be ran with code-coverage
        // analysis on Travis, so we need to exclude them
        global $argv;
function myFunction($a, $b) {
    // Do something
}
        if (in_array('--coverage-clover', $argv)) {
            $tooLongToBeCovered = [
                'Basic/06_Largescale.php',
                'Basic/13_CalculationCyclicFormulae.php',
            ];
            $skipped = array_merge($skipped, $tooLongToBeCovered);
        }

        $helper = new Sample();
        $result = [];
        foreach ($helper->getSamples() as $samples) {
            foreach ($samples as $sample) {

                if (!in_array($sample, $skipped)) {
                    $file = '../samples/' . $sample;
                    $result[] = [$file];
                }
            }
        }

        return $result;
    }
}


Push — develop ( 98b532...40efcd )

SampleTest::providerSample() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2
3			namespace PhpOffice\PhpSpreadsheetTests\Sample;
4
5			use PhpOffice\PhpSpreadsheet\Helper\Sample;
6			use PHPUnit_Framework_TestCase;
7
8			class SampleTest extends PHPUnit_Framework_TestCase
9			{
10			/**
11			* @runInSeparateProcess
12			* @preserveGlobalState disabled
13			* @dataProvider providerSample
14			*
15			* @param mixed $sample
16			*/
17			public function testSample($sample)
18			{
19			// Suppress output to console
20			$this->setOutputCallback(function () {
21			});
22
23			require $sample;
24			}
25
26			public function providerSample()
27			{
28			$skipped = [
29			'Chart/32_Chart_read_write_PDF.php', // Unfortunately JpGraph is not up to date for latest PHP and raise many warnings
30			'Chart/32_Chart_read_write_HTML.php', // idem
31			];
32
33			// Unfortunately some tests are too long be ran with code-coverage
34			// analysis on Travis, so we need to exclude them
35			global $argv;
			0 ignored issues – show Compatibility Best Practice introduced 2016-09-08 17:48 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
36			if (in_array('--coverage-clover', $argv)) {
37			$tooLongToBeCovered = [
38			'Basic/06_Largescale.php',
39			'Basic/13_CalculationCyclicFormulae.php',
40			];
41			$skipped = array_merge($skipped, $tooLongToBeCovered);
42			}
43
44			$helper = new Sample();
45			$result = [];
46			foreach ($helper->getSamples() as $samples) {
47			foreach ($samples as $sample) {
			0 ignored issues – show Bug introduced 2017-10-28 17:27 UTC by Report Bug Copy Issue Report The expression `$samples` of type `string` is not traversable. Loading history...
48			if (!in_array($sample, $skipped)) {
49			$file = '../samples/' . $sample;
50			$result[] = [$file];
51			}
52			}
53			}
54
55			return $result;
56			}
57			}
58

PHPOffice / PhpSpreadsheet

Push — develop ( 98b532...40efcd )

SampleTest::providerSample() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like