View GitHub Repository PhpSpreadsheet

Schedule Inspection
Subscribe
Completed
Pull Request — develop (#90)
by Tony
16:44
created
Status
Category
Toggle Patches
docs/Examples/Calculations/Database/DMAX.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -31,17 +31,17 @@
 
 block discarded – undo
31 31
32 32 
 // Add some data
33 33 
 $database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
40 
-                 ];
34 
+                    ['Apple',  18,       20,    14,      105.00],
35 
+                    ['Pear',   12,       12,    10,       96.00],
36 
+                    ['Cherry', 13,       14,     9,      105.00],
37 
+                    ['Apple',  14,       15,    10,       75.00],
38 
+                    ['Pear',    9,        8,     8,       76.80],
39 
+                    ['Apple',   8,        9,     6,       45.00],
40 
+                    ];
41 41 
 $criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
44 
-                 ];
42 
+                    ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
+                    ['="=Pear"',  null,     null,  null,    null,     null],
44 
+                    ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
47 47 
 $worksheet->fromArray($database, null, 'A4');
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -30,17 +30,17 @@
 
 block discarded – undo
30 30 
 $worksheet = $spreadsheet->getActiveSheet();
31 31
32 32 
 // Add some data
33 
-$database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
33 
+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34 
+                   ['Apple', 18, 20, 14, 105.00],
35 
+                   ['Pear', 12, 12, 10, 96.00],
36 
+                   ['Cherry', 13, 14, 9, 105.00],
37 
+                   ['Apple', 14, 15, 10, 75.00],
38 
+                   ['Pear', 9, 8, 8, 76.80],
39 
+                   ['Apple', 8, 9, 6, 45.00],
40 40 
                  ];
41 
-$criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
41 
+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
+                   ['="=Apple"', '>10', null, null, null, '<16'],
43 
+                   ['="=Pear"', null, null, null, null, null],
44 44 
                  ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
Please login to merge, or discard this patch.
docs/Examples/Calculations/Database/DGET.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -31,17 +31,17 @@
 
 block discarded – undo
31 31
32 32 
 // Add some data
33 33 
 $database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
40 
-                 ];
34 
+                    ['Apple',  18,       20,    14,      105.00],
35 
+                    ['Pear',   12,       12,    10,       96.00],
36 
+                    ['Cherry', 13,       14,     9,      105.00],
37 
+                    ['Apple',  14,       15,    10,       75.00],
38 
+                    ['Pear',    9,        8,     8,       76.80],
39 
+                    ['Apple',   8,        9,     6,       45.00],
40 
+                    ];
41 41 
 $criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
44 
-                 ];
42 
+                    ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
+                    ['="=Pear"',  null,     null,  null,    null,     null],
44 
+                    ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
47 47 
 $worksheet->fromArray($database, null, 'A4');
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -30,17 +30,17 @@
 
 block discarded – undo
30 30 
 $worksheet = $spreadsheet->getActiveSheet();
31 31
32 32 
 // Add some data
33 
-$database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
33 
+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34 
+                   ['Apple', 18, 20, 14, 105.00],
35 
+                   ['Pear', 12, 12, 10, 96.00],
36 
+                   ['Cherry', 13, 14, 9, 105.00],
37 
+                   ['Apple', 14, 15, 10, 75.00],
38 
+                   ['Pear', 9, 8, 8, 76.80],
39 
+                   ['Apple', 8, 9, 6, 45.00],
40 40 
                  ];
41 
-$criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
41 
+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
+                   ['="=Apple"', '>10', null, null, null, '<16'],
43 
+                   ['="=Pear"', null, null, null, null, null],
44 44 
                  ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
Please login to merge, or discard this patch.
docs/Examples/Calculations/Database/DCOUNT.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -31,17 +31,17 @@
 
 block discarded – undo
31 31
32 32 
 // Add some data
33 33 
 $database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
40 
-                 ];
34 
+                    ['Apple',  18,       20,    14,      105.00],
35 
+                    ['Pear',   12,       12,    10,       96.00],
36 
+                    ['Cherry', 13,       14,     9,      105.00],
37 
+                    ['Apple',  14,       15,    10,       75.00],
38 
+                    ['Pear',    9,        8,     8,       76.80],
39 
+                    ['Apple',   8,        9,     6,       45.00],
40 
+                    ];
41 41 
 $criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
44 
-                 ];
42 
+                    ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
+                    ['="=Pear"',  null,     null,  null,    null,     null],
44 
+                    ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
47 47 
 $worksheet->fromArray($database, null, 'A4');
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -30,17 +30,17 @@
 
 block discarded – undo
30 30 
 $worksheet = $spreadsheet->getActiveSheet();
31 31
32 32 
 // Add some data
33 
-$database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
33 
+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34 
+                   ['Apple', 18, 20, 14, 105.00],
35 
+                   ['Pear', 12, 12, 10, 96.00],
36 
+                   ['Cherry', 13, 14, 9, 105.00],
37 
+                   ['Apple', 14, 15, 10, 75.00],
38 
+                   ['Pear', 9, 8, 8, 76.80],
39 
+                   ['Apple', 8, 9, 6, 45.00],
40 40 
                  ];
41 
-$criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
41 
+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
+                   ['="=Apple"', '>10', null, null, null, '<16'],
43 
+                   ['="=Pear"', null, null, null, null, null],
44 44 
                  ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
Please login to merge, or discard this patch.
docs/Examples/Calculations/Database/DPRODUCT.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -31,17 +31,17 @@
 
 block discarded – undo
31 31
32 32 
 // Add some data
33 33 
 $database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
40 
-                 ];
34 
+                    ['Apple',  18,       20,    14,      105.00],
35 
+                    ['Pear',   12,       12,    10,       96.00],
36 
+                    ['Cherry', 13,       14,     9,      105.00],
37 
+                    ['Apple',  14,       15,    10,       75.00],
38 
+                    ['Pear',    9,        8,     8,       76.80],
39 
+                    ['Apple',   8,        9,     6,       45.00],
40 
+                    ];
41 41 
 $criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
44 
-                 ];
42 
+                    ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
+                    ['="=Pear"',  null,     null,  null,    null,     null],
44 
+                    ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
47 47 
 $worksheet->fromArray($database, null, 'A4');
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -30,17 +30,17 @@
 
 block discarded – undo
30 30 
 $worksheet = $spreadsheet->getActiveSheet();
31 31
32 32 
 // Add some data
33 
-$database = [['Tree',  'Height', 'Age', 'Yield', 'Profit'],
34 
-                   ['Apple',  18,       20,    14,      105.00],
35 
-                   ['Pear',   12,       12,    10,       96.00],
36 
-                   ['Cherry', 13,       14,     9,      105.00],
37 
-                   ['Apple',  14,       15,    10,       75.00],
38 
-                   ['Pear',    9,        8,     8,       76.80],
39 
-                   ['Apple',   8,        9,     6,       45.00],
33 
+$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34 
+                   ['Apple', 18, 20, 14, 105.00],
35 
+                   ['Pear', 12, 12, 10, 96.00],
36 
+                   ['Cherry', 13, 14, 9, 105.00],
37 
+                   ['Apple', 14, 15, 10, 75.00],
38 
+                   ['Pear', 9, 8, 8, 76.80],
39 
+                   ['Apple', 8, 9, 6, 45.00],
40 40 
                  ];
41 
-$criteria = [['Tree',      'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
-                   ['="=Apple"', '>10',    null,  null,    null,     '<16'],
43 
-                   ['="=Pear"',  null,     null,  null,    null,     null],
41 
+$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42 
+                   ['="=Apple"', '>10', null, null, null, '<16'],
43 
+                   ['="=Pear"', null, null, null, null, null],
44 44 
                  ];
45 45
46 46 
 $worksheet->fromArray($criteria, null, 'A1');
Please login to merge, or discard this patch.
docs/Examples/Calculations/index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,9 +36,9 @@
 
 block discarded – undo
36 36 
             $h1Text = $out[1];
37 37 
             $h2Text = (preg_match($h2Pattern, $fileData, $out)) ? $out[1] : '';
38 38
39 
-            echo '<a href="',$exampleFile,'">',$h1Text,'</a><br />';
39 
+            echo '<a href="', $exampleFile, '">', $h1Text, '</a><br />';
40 40 
             if ($h2Text > '') {
41 
-                echo $h2Text,'<br />';
41 
+                echo $h2Text, '<br />';
42 42 
             }
43 43 
         }
44 44 
     }
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Font.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -82,9 +82,9 @@  discard block
 
 block discarded – undo
82 82 
         $bFamily = 0; // Font family
83 83 
         $bCharSet = \PhpOffice\PhpSpreadsheet\Shared\Font::getCharsetFromFontName($this->font->getName()); // Character set
84 84
85 
-        $record = 0x31;        // Record identifier
86 
-        $reserved = 0x00;    // Reserved
87 
-        $grbit = 0x00;        // Font attributes
85 
+        $record = 0x31; // Record identifier
86 
+        $reserved = 0x00; // Reserved
87 
+        $grbit = 0x00; // Font attributes
88 88 
         if ($this->font->getItalic()) {
89 89 
             $grbit |= 0x02;
90 90 
         }
 
@@ -132,10 +132,10 @@  discard block
 
 block discarded – undo
132 132 
     private static function mapBold($bold)
133 133 
     {
134 134 
         if ($bold) {
135 
-            return 0x2BC;  //  700 = Bold font weight
135 
+            return 0x2BC; //  700 = Bold font weight
136 136 
         }
137 137
138 
-        return 0x190;      //  400 = Normal font weight
138 
+        return 0x190; //  400 = Normal font weight
139 139 
     }
140 140
141 141 
     /**
Please login to merge, or discard this patch.