Completed
Pull Request — develop (#90)
by Tony
16:44
created
src/PhpSpreadsheet/Worksheet/ColumnDimension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
     /**
101 101
      * Set Width.
102 102
      *
103
-     * @param float $pValue
103
+     * @param integer $pValue
104 104
      *
105 105
      * @return ColumnDimension
106 106
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/RowDimension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
     /**
101 101
      * Set Row Height.
102 102
      *
103
-     * @param float $pValue
103
+     * @param integer $pValue
104 104
      *
105 105
      * @return RowDimension
106 106
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Html.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1165,7 +1165,7 @@
 block discarded – undo
1165 1165
      * @param \PhpOffice\PhpSpreadsheet\Worksheet $pSheet \PhpOffice\PhpSpreadsheet\Worksheet
1166 1166
      * @param array $pValues Array containing cells in a row
1167 1167
      * @param int $pRow Row number (0-based)
1168
-     * @param mixed $cellType
1168
+     * @param string $cellType
1169 1169
      *
1170 1170
      * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
1171 1171
      *
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Parser.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
      *
506 506
      * @param mixed $token the token to convert
507 507
      *
508
-     * @return mixed the converted token on success
508
+     * @return string the converted token on success
509 509
      */
510 510
     private function convert($token)
511 511
     {
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
      *
577 577
      * @param string $string a string for conversion to its ptg value
578 578
      *
579
-     * @return mixed the converted token on success
579
+     * @return string the converted token on success
580 580
      */
581 581
     private function convertString($string)
582 582
     {
@@ -654,7 +654,7 @@  discard block
 block discarded – undo
654 654
      *
655 655
      * @param string $token an Excel range in the Sheet1!A1:A2 format
656 656
      *
657
-     * @return mixed the packed ptgArea3d token on success
657
+     * @return string the packed ptgArea3d token on success
658 658
      */
659 659
     private function convertRange3d($token)
660 660
     {
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
706 706
      *
707 707
      * @param string $cell An Excel cell reference
708 708
      *
709
-     * @return mixed the packed ptgRef3d token on success
709
+     * @return string the packed ptgRef3d token on success
710 710
      */
711 711
     private function convertRef3d($cell)
712 712
     {
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
      *
806 806
      * @param string $ext_ref The name of the external reference
807 807
      *
808
-     * @return mixed The reference index in packed() format on success
808
+     * @return string The reference index in packed() format on success
809 809
      */
810 810
     private function getRefIndex($ext_ref)
811 811
     {
@@ -896,7 +896,7 @@  discard block
 block discarded – undo
896 896
      *
897 897
      * @param string $cell The Excel cell reference to be packed
898 898
      *
899
-     * @return array Array containing the row and column in packed() format
899
+     * @return string[] Array containing the row and column in packed() format
900 900
      */
901 901
     private function cellToPackedRowcol($cell)
902 902
     {
@@ -925,7 +925,7 @@  discard block
 block discarded – undo
925 925
      *
926 926
      * @param string $range The Excel range to be packed
927 927
      *
928
-     * @return array Array containing (row1,col1,row2,col2) in packed() format
928
+     * @return string[] Array containing (row1,col1,row2,col2) in packed() format
929 929
      */
930 930
     private function rangeToPackedRange($range)
931 931
     {
@@ -1041,7 +1041,7 @@  discard block
 block discarded – undo
1041 1041
     /**
1042 1042
      * Checks if it's a valid token.
1043 1043
      *
1044
-     * @param mixed $token the token to check
1044
+     * @param string $token the token to check
1045 1045
      *
1046 1046
      * @return mixed The checked token or false on failure
1047 1047
      */
@@ -1127,7 +1127,7 @@  discard block
 block discarded – undo
1127 1127
      * @param string $formula the formula to parse, without the initial equal
1128 1128
      *                        sign (=)
1129 1129
      *
1130
-     * @return mixed true on success
1130
+     * @return boolean true on success
1131 1131
      */
1132 1132
     public function parse($formula)
1133 1133
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xlsx/Chart.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -410,8 +410,8 @@  discard block
 block discarded – undo
410 410
      * @param string $id1
411 411
      * @param string $id2
412 412
      * @param bool $isMultiLevelSeries
413
-     * @param mixed $xAxis
414
-     * @param mixed $yAxis
413
+     * @param null|Axis $xAxis
414
+     * @param null|Axis $yAxis
415 415
      *
416 416
      * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
417 417
      */
@@ -533,10 +533,10 @@  discard block
 block discarded – undo
533 533
      * @param string $id1
534 534
      * @param string $id2
535 535
      * @param bool $isMultiLevelSeries
536
-     * @param mixed $xAxis
537
-     * @param mixed $yAxis
538
-     * @param mixed $majorGridlines
539
-     * @param mixed $minorGridlines
536
+     * @param null|Axis $xAxis
537
+     * @param null|Axis $yAxis
538
+     * @param null|GridLines $majorGridlines
539
+     * @param null|GridLines $minorGridlines
540 540
      *
541 541
      * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
542 542
      */
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader12.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
     }
63 63
 }
64 64
 
65
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
65
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
66 66
 /*  Create a new Reader of the type defined in $inputFileType  **/
67 67
 $reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
68 68
 
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader06.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 //	$inputFileType = 'Gnumeric';
33 33
 $inputFileName = './sampleData/example1.xls';
34 34
 
35
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
35
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36 36
 $reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
37 37
 echo 'Loading all WorkSheets<br />';
38 38
 $reader->setLoadAllSheets();
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader17.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,16 +32,16 @@
 block discarded – undo
32 32
 //	$inputFileType = 'Gnumeric';
33 33
 $inputFileName = './sampleData/example1.xls';
34 34
 
35
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
35
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36 36
 $reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
37 37
 
38 38
 /*  Read the list of Worksheet Names from the Workbook file  **/
39 39
 echo 'Read the list of Worksheets in the WorkBook<br />';
40 40
 $worksheetNames = $reader->listWorksheetNames($inputFileName);
41 41
 
42
-echo 'There are ',count($worksheetNames),' worksheet',((count($worksheetNames) == 1) ? '' : 's'),' in the workbook<br /><br />';
42
+echo 'There are ', count($worksheetNames), ' worksheet', ((count($worksheetNames) == 1) ? '' : 's'), ' in the workbook<br /><br />';
43 43
 foreach ($worksheetNames as $worksheetName) {
44
-    echo $worksheetName,'<br />';
44
+    echo $worksheetName, '<br />';
45 45
 }
46 46
 
47 47
 ?>
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader05.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 //	$inputFileType = 'Gnumeric';
33 33
 $inputFileName = './sampleData/example1.xls';
34 34
 
35
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
35
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36 36
 $reader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
37 37
 echo 'Turning Formatting off for Load<br />';
38 38
 $reader->setReadDataOnly(true);
Please login to merge, or discard this patch.