Completed
Pull Request — develop (#90)
by Tony
16:44
created
src/PhpSpreadsheet/Shared/JAMA/EigenvalueDecomposition.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
     /**
820 820
      * Return the eigenvector matrix.
821 821
      *
822
-     * @return V
822
+     * @return Matrix
823 823
      */
824 824
     public function getV()
825 825
     {
@@ -849,7 +849,7 @@  discard block
 block discarded – undo
849 849
     /**
850 850
      * Return the block diagonal eigenvalue matrix.
851 851
      *
852
-     * @return D
852
+     * @return Matrix
853 853
      */
854 854
     public function getD()
855 855
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -778,7 +778,7 @@
 block discarded – undo
778 778
         }
779 779
     }
780 780
 
781
- // end hqr2
781
+    // end hqr2
782 782
 
783 783
     /**
784 784
      * Constructor: Check for symmetry, then construct the eigenvalue decomposition.
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/JAMA/LUDecomposition.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -241,7 +241,7 @@
 block discarded – undo
241 241
     /**
242 242
      * Solve A*X = B.
243 243
      *
244
-     * @param $B a Matrix with as many rows as A and any number of columns
244
+     * @param Matrix $B a Matrix with as many rows as A and any number of columns
245 245
      *
246 246
      * @throws \PhpOffice\PhpSpreadsheet\Calculation\Exception illegalArgumentException Matrix row dimensions must agree
247 247
      * @throws \PhpOffice\PhpSpreadsheet\Calculation\Exception runtimeException  Matrix is singular
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/JAMA/Matrix.php 1 patch
Doc Comments   +2 added lines, -19 removed lines patch added patch discarded remove patch
@@ -149,10 +149,6 @@  discard block
 block discarded – undo
149 149
      *
150 150
      *    Get a submatrix
151 151
      *
152
-     * @param int $i0 Initial row index
153
-     * @param int $iF Final row index
154
-     * @param int $j0 Initial column index
155
-     * @param int $jF Final column index
156 152
      *
157 153
      * @return Matrix Submatrix
158 154
      */
@@ -345,7 +341,7 @@  discard block
 block discarded – undo
345 341
      *
346 342
      * @param int $m Row dimension
347 343
      * @param int $n Column dimension
348
-     * @param mixed $c Diagonal value
344
+     * @param integer $c Diagonal value
349 345
      *
350 346
      * @return Matrix Diagonal matrix
351 347
      */
@@ -429,7 +425,7 @@  discard block
 block discarded – undo
429 425
      *
430 426
      *    Sum of diagonal elements
431 427
      *
432
-     * @return float Sum of diagonal elements
428
+     * @return integer Sum of diagonal elements
433 429
      */
434 430
     public function trace()
435 431
     {
@@ -458,7 +454,6 @@  discard block
 block discarded – undo
458 454
      *
459 455
      *    A + B
460 456
      *
461
-     * @param mixed $B Matrix/Array
462 457
      *
463 458
      * @return Matrix Sum
464 459
      */
@@ -500,7 +495,6 @@  discard block
 block discarded – undo
500 495
      *
501 496
      *    A = A + B
502 497
      *
503
-     * @param mixed $B Matrix/Array
504 498
      *
505 499
      * @return Matrix Sum
506 500
      */
@@ -556,7 +550,6 @@  discard block
 block discarded – undo
556 550
      *
557 551
      *    A - B
558 552
      *
559
-     * @param mixed $B Matrix/Array
560 553
      *
561 554
      * @return Matrix Sum
562 555
      */
@@ -598,7 +591,6 @@  discard block
 block discarded – undo
598 591
      *
599 592
      *    A = A - B
600 593
      *
601
-     * @param mixed $B Matrix/Array
602 594
      *
603 595
      * @return Matrix Sum
604 596
      */
@@ -655,7 +647,6 @@  discard block
 block discarded – undo
655 647
      *    Element-by-element multiplication
656 648
      *    Cij = Aij * Bij
657 649
      *
658
-     * @param mixed $B Matrix/Array
659 650
      *
660 651
      * @return Matrix Matrix Cij
661 652
      */
@@ -698,7 +689,6 @@  discard block
 block discarded – undo
698 689
      *    Element-by-element multiplication
699 690
      *    Aij = Aij * Bij
700 691
      *
701
-     * @param mixed $B Matrix/Array
702 692
      *
703 693
      * @return Matrix Matrix Aij
704 694
      */
@@ -755,7 +745,6 @@  discard block
 block discarded – undo
755 745
      *    Element-by-element right division
756 746
      *    A / B
757 747
      *
758
-     * @param Matrix $B Matrix B
759 748
      *
760 749
      * @return Matrix Division result
761 750
      */
@@ -817,7 +806,6 @@  discard block
 block discarded – undo
817 806
      *    Element-by-element right division
818 807
      *    Aij = Aij / Bij
819 808
      *
820
-     * @param mixed $B Matrix/Array
821 809
      *
822 810
      * @return Matrix Matrix Aij
823 811
      */
@@ -860,7 +848,6 @@  discard block
 block discarded – undo
860 848
      *    Element-by-element Left division
861 849
      *    A / B
862 850
      *
863
-     * @param Matrix $B Matrix B
864 851
      *
865 852
      * @return Matrix Division result
866 853
      */
@@ -903,7 +890,6 @@  discard block
 block discarded – undo
903 890
      *    Element-by-element Left division
904 891
      *    Aij = Aij / Bij
905 892
      *
906
-     * @param mixed $B Matrix/Array
907 893
      *
908 894
      * @return Matrix Matrix Aij
909 895
      */
@@ -945,7 +931,6 @@  discard block
 block discarded – undo
945 931
      *
946 932
      *    Matrix multiplication
947 933
      *
948
-     * @param mixed $n Matrix/Array/Scalar
949 934
      *
950 935
      * @return Matrix Product
951 936
      */
@@ -1038,7 +1023,6 @@  discard block
 block discarded – undo
1038 1023
      *
1039 1024
      *    A = A ^ B
1040 1025
      *
1041
-     * @param mixed $B Matrix/Array
1042 1026
      *
1043 1027
      * @return Matrix Sum
1044 1028
      */
@@ -1094,7 +1078,6 @@  discard block
 block discarded – undo
1094 1078
      *
1095 1079
      *    A = A & B
1096 1080
      *
1097
-     * @param mixed $B Matrix/Array
1098 1081
      *
1099 1082
      * @return Matrix Sum
1100 1083
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/JAMA/SingularValueDecomposition.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
     /**
442 442
      * Return the left singular vectors.
443 443
      *
444
-     * @return U
444
+     * @return Matrix
445 445
      */
446 446
     public function getU()
447 447
     {
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
     /**
452 452
      * Return the right singular vectors.
453 453
      *
454
-     * @return V
454
+     * @return Matrix
455 455
      */
456 456
     public function getV()
457 457
     {
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
     /**
472 472
      * Return the diagonal matrix of singular values.
473 473
      *
474
-     * @return S
474
+     * @return Matrix
475 475
      */
476 476
     public function getS()
477 477
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -436,7 +436,7 @@
 block discarded – undo
436 436
         } // end while
437 437
     }
438 438
 
439
- // end constructor
439
+    // end constructor
440 440
 
441 441
     /**
442 442
      * Return the left singular vectors.
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet.php 1 patch
Doc Comments   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -590,7 +590,7 @@  discard block
 block discarded – undo
590 590
      *
591 591
      * @throws Exception
592 592
      *
593
-     * @return false|Chart
593
+     * @return null|Chart
594 594
      */
595 595
     public function getChartByIndex($index = null)
596 596
     {
@@ -1120,7 +1120,7 @@  discard block
 block discarded – undo
1120 1120
      * Set a cell value.
1121 1121
      *
1122 1122
      * @param string $pCoordinate Coordinate of the cell
1123
-     * @param mixed $pValue Value of the cell
1123
+     * @param integer $pValue Value of the cell
1124 1124
      * @param bool $returnCell Return the worksheet (false, default) or the cell (true)
1125 1125
      *
1126 1126
      * @return Worksheet|Cell Depending on the last parameter being specified
@@ -1237,8 +1237,8 @@  discard block
 block discarded – undo
1237 1237
     /**
1238 1238
      * Get cell at a specific coordinate by using numeric cell coordinates.
1239 1239
      *
1240
-     * @param string $pColumn Numeric column coordinate of the cell
1241
-     * @param string $pRow Numeric row coordinate of the cell
1240
+     * @param integer $pColumn Numeric column coordinate of the cell
1241
+     * @param integer $pRow Numeric row coordinate of the cell
1242 1242
      * @param bool $createIfNotExists Flag indicating whether a new cell should be created if it doesn't
1243 1243
      *                                       already exist, or a null should be returned instead
1244 1244
      *
@@ -1348,8 +1348,8 @@  discard block
 block discarded – undo
1348 1348
     /**
1349 1349
      * Cell at a specific coordinate by using numeric cell coordinates exists?
1350 1350
      *
1351
-     * @param string $pColumn Numeric column coordinate of the cell
1352
-     * @param string $pRow Numeric row coordinate of the cell
1351
+     * @param integer $pColumn Numeric column coordinate of the cell
1352
+     * @param integer $pRow Numeric row coordinate of the cell
1353 1353
      *
1354 1354
      * @return bool
1355 1355
      */
@@ -1362,7 +1362,7 @@  discard block
 block discarded – undo
1362 1362
      * Get row dimension at a specific row.
1363 1363
      *
1364 1364
      * @param int $pRow Numeric index of the row
1365
-     * @param mixed $create
1365
+     * @param boolean $create
1366 1366
      *
1367 1367
      * @return Worksheet\RowDimension
1368 1368
      */
@@ -1388,7 +1388,7 @@  discard block
 block discarded – undo
1388 1388
      * Get column dimension at a specific column.
1389 1389
      *
1390 1390
      * @param string $pColumn String index of the column
1391
-     * @param mixed $create
1391
+     * @param boolean $create
1392 1392
      *
1393 1393
      * @return Worksheet\ColumnDimension
1394 1394
      */
@@ -1934,7 +1934,7 @@  discard block
 block discarded – undo
1934 1934
     /**
1935 1935
      * Set AutoFilter.
1936 1936
      *
1937
-     * @param Worksheet\AutoFilter|string $pValue
1937
+     * @param string $pValue
1938 1938
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
1939 1939
      *
1940 1940
      * @throws Exception
@@ -2996,7 +2996,7 @@  discard block
 block discarded – undo
2996 2996
      *
2997 2997
      * @throws Exception
2998 2998
      *
2999
-     * @return objWorksheet
2999
+     * @return Worksheet
3000 3000
      */
3001 3001
     public function setCodeName($pValue = null)
3002 3002
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/Row.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,6 @@  discard block
 block discarded – undo
43 43
     /**
44 44
      * Create a new row.
45 45
      *
46
-     * @param \PhpOffice\PhpSpreadsheet\Worksheet $parent
47 46
      * @param int $rowIndex
48 47
      */
49 48
     public function __construct(\PhpOffice\PhpSpreadsheet\Worksheet $worksheet = null, $rowIndex = 1)
@@ -87,7 +86,7 @@  discard block
 block discarded – undo
87 86
     /**
88 87
      * Returns bound worksheet.
89 88
      *
90
-     * @return Worksheet
89
+     * @return 
91 90
      */
92 91
     public function getWorksheet()
93 92
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Workbook.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -240,8 +240,8 @@  discard block
 block discarded – undo
240 240
      *
241 241
      * @param \PhpOffice\PhpSpreadsheet\Style
242 242
      * @param bool Is it a style XF?
243
-     * @param mixed $style
244
-     * @param mixed $isStyleXf
243
+     * @param \PhpOffice\PhpSpreadsheet\Style $style
244
+     * @param boolean $isStyleXf
245 245
      *
246 246
      * @return int Index to XF record
247 247
      */
@@ -796,7 +796,7 @@  discard block
 block discarded – undo
796 796
      *
797 797
      * @param string $name The name in UTF-8
798 798
      * @param string $formulaData The binary formula data
799
-     * @param string $sheetIndex 1-based sheet index the defined name applies to. 0 = global
799
+     * @param integer $sheetIndex 1-based sheet index the defined name applies to. 0 = global
800 800
      * @param bool $isBuiltIn Built-in name?
801 801
      *
802 802
      * @return string Complete binary record data
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/Engineering.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1853,7 +1853,7 @@  discard block
 block discarded – undo
1853 1853
      *
1854 1854
      * @param string $complexNumber the complex number for which you want the real coefficient
1855 1855
      *
1856
-     * @return float
1856
+     * @return string
1857 1857
      */
1858 1858
     public static function IMREAL($complexNumber)
1859 1859
     {
@@ -2291,7 +2291,7 @@  discard block
 block discarded – undo
2291 2291
      * Excel Function:
2292 2292
      *        IMSUM(complexNumber[,complexNumber[,...]])
2293 2293
      *
2294
-     * @param string $complexNumbers Series of complex numbers to add
2294
+     * @param string[] $complexNumbers Series of complex numbers to add
2295 2295
      *
2296 2296
      * @return string
2297 2297
      */
@@ -2331,7 +2331,7 @@  discard block
 block discarded – undo
2331 2331
      * Excel Function:
2332 2332
      *        IMPRODUCT(complexNumber[,complexNumber[,...]])
2333 2333
      *
2334
-     * @param string $complexNumbers Series of complex numbers to multiply
2334
+     * @param string[] $complexNumbers Series of complex numbers to multiply
2335 2335
      *
2336 2336
      * @return string
2337 2337
      */
@@ -2375,7 +2375,7 @@  discard block
 block discarded – undo
2375 2375
      *        DELTA(a[,b])
2376 2376
      *
2377 2377
      * @param float $a the first number
2378
-     * @param float $b The second number. If omitted, b is assumed to be zero.
2378
+     * @param integer $b The second number. If omitted, b is assumed to be zero.
2379 2379
      *
2380 2380
      * @return int
2381 2381
      */
@@ -2398,7 +2398,7 @@  discard block
 block discarded – undo
2398 2398
      * functions you calculate the count of values that exceed a threshold.
2399 2399
      *
2400 2400
      * @param float $number the value to test against step
2401
-     * @param float $step The threshold value.
2401
+     * @param integer $step The threshold value.
2402 2402
      *                                    If you omit a value for step, GESTEP uses zero.
2403 2403
      *
2404 2404
      * @return int
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/MathTrig.php 1 patch
Doc Comments   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -52,6 +52,10 @@  discard block
 block discarded – undo
52 52
         return [(int) $value];
53 53
     }
54 54
 
55
+    /**
56
+     * @param integer $num
57
+     * @param integer $n
58
+     */
55 59
     private static function romanCut($num, $n)
56 60
     {
57 61
         return ($num - ($num % $n)) / $n;
@@ -504,7 +508,7 @@  discard block
 block discarded – undo
504 508
      * @category Mathematical and Trigonometric Functions
505 509
      *
506 510
      * @param float $number The positive real number for which you want the logarithm
507
-     * @param float $base The base of the logarithm. If base is omitted, it is assumed to be 10.
511
+     * @param integer $base The base of the logarithm. If base is omitted, it is assumed to be 10.
508 512
      *
509 513
      * @return float
510 514
      */
@@ -822,8 +826,8 @@  discard block
 block discarded – undo
822 826
      *
823 827
      * Computes x raised to the power y.
824 828
      *
825
-     * @param float $x
826
-     * @param float $y
829
+     * @param integer $x
830
+     * @param integer $y
827 831
      *
828 832
      * @return float
829 833
      */
@@ -897,7 +901,7 @@  discard block
 block discarded – undo
897 901
      *
898 902
      * @param mixed $args Data values
899 903
      *
900
-     * @return float
904
+     * @return integer
901 905
      */
902 906
     public static function QUOTIENT(...$args)
903 907
     {
@@ -1035,9 +1039,6 @@  discard block
 block discarded – undo
1035 1039
      *
1036 1040
      * Returns the sum of a power series
1037 1041
      *
1038
-     * @param float $x Input value to the power series
1039
-     * @param float $n Initial power to which you want to raise $x
1040
-     * @param float $m Step by which to increase $n for each term in the series
1041 1042
      * @param array of mixed Data Series
1042 1043
      *
1043 1044
      * @return float
@@ -1215,7 +1216,7 @@  discard block
 block discarded – undo
1215 1216
      * @param mixed $aArgs
1216 1217
      * @param mixed $sumArgs
1217 1218
      *
1218
-     * @return float
1219
+     * @return integer
1219 1220
      */
1220 1221
     public static function SUMIF($aArgs, $condition, $sumArgs = [])
1221 1222
     {
@@ -1255,9 +1256,8 @@  discard block
 block discarded – undo
1255 1256
      *    @category Mathematical and Trigonometric Functions
1256 1257
      *
1257 1258
      * @param mixed $args Data values
1258
-     * @param string $condition the criteria that defines which cells will be summed
1259 1259
      *
1260
-     * @return float
1260
+     * @return integer
1261 1261
      */
1262 1262
     public static function SUMIFS(...$args)
1263 1263
     {
@@ -1446,7 +1446,7 @@  discard block
 block discarded – undo
1446 1446
      *
1447 1447
      * Truncates value to the number of fractional digits by number_digits.
1448 1448
      *
1449
-     * @param float $value
1449
+     * @param integer $value
1450 1450
      * @param int $digits
1451 1451
      *
1452 1452
      * @return float Truncated value
Please login to merge, or discard this patch.