Completed
Push — develop ( 30a5e4...a5c21a )
by Adrien
240:48 queued 175:47
created
src/PhpSpreadsheet/Worksheet/AutoFilter.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -567,6 +567,11 @@
 block discarded – undo
567 567
         return ['method' => 'filterTestInCustomDataSet', 'arguments' => ['filterRules' => $ruleValues, 'join' => AutoFilter\Column::AUTOFILTER_COLUMN_JOIN_AND]];
568 568
     }
569 569
 
570
+    /**
571
+     * @param integer $columnID
572
+     * @param integer $startRow
573
+     * @param string $ruleType
574
+     */
570 575
     private function calculateTopTenValue($columnID, $startRow, $endRow, $ruleType, $ruleValue)
571 576
     {
572 577
         $range = $columnID . $startRow . ':' . $columnID . $endRow;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/ColumnDimension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
     /**
102 102
      * Set Row Height
103 103
      *
104
-     * @param float $pValue
104
+     * @param integer $pValue
105 105
      * @return RowDimension
106 106
      */
107 107
     public function setRowHeight($pValue = -1)
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Shared/StringTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
     public function testGetCurrencyCode()
66 66
     {
67 67
         $localeconv = localeconv();
68
-        $expectedResult = (!empty($localeconv['currency_symbol']) ? $localeconv['currency_symbol'] : (!empty($localeconv['int_curr_symbol']) ? $localeconv['int_curr_symbol']: '$'));
68
+        $expectedResult = (!empty($localeconv['currency_symbol']) ? $localeconv['currency_symbol'] : (!empty($localeconv['int_curr_symbol']) ? $localeconv['int_curr_symbol'] : '$'));
69 69
         $result = call_user_func([StringHelper::class, 'getCurrencyCode']);
70 70
         $this->assertEquals($expectedResult, $result);
71 71
     }
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Worksheet/ColumnIteratorTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,11 +18,11 @@
 block discarded – undo
18 18
             ->getMock();
19 19
 
20 20
         $this->mockWorksheet->expects($this->any())
21
-                 ->method('getHighestColumn')
22
-                 ->will($this->returnValue('E'));
21
+                    ->method('getHighestColumn')
22
+                    ->will($this->returnValue('E'));
23 23
         $this->mockWorksheet->expects($this->any())
24
-                 ->method('current')
25
-                 ->will($this->returnValue($this->mockColumn));
24
+                    ->method('current')
25
+                    ->will($this->returnValue($this->mockColumn));
26 26
     }
27 27
 
28 28
 
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Worksheet/RowCellIteratorTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,11 +18,11 @@
 block discarded – undo
18 18
             ->getMock();
19 19
 
20 20
         $this->mockWorksheet->expects($this->any())
21
-                 ->method('getHighestColumn')
22
-                 ->will($this->returnValue('E'));
21
+                    ->method('getHighestColumn')
22
+                    ->will($this->returnValue('E'));
23 23
         $this->mockWorksheet->expects($this->any())
24
-                 ->method('getCellByColumnAndRow')
25
-                 ->will($this->returnValue($this->mockCell));
24
+                    ->method('getCellByColumnAndRow')
25
+                    ->will($this->returnValue($this->mockCell));
26 26
     }
27 27
 
28 28
 
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Worksheet/ColumnCellIteratorTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,11 +18,11 @@
 block discarded – undo
18 18
             ->getMock();
19 19
 
20 20
         $this->mockWorksheet->expects($this->any())
21
-                 ->method('getHighestRow')
22
-                 ->will($this->returnValue(5));
21
+                    ->method('getHighestRow')
22
+                    ->will($this->returnValue(5));
23 23
         $this->mockWorksheet->expects($this->any())
24
-                 ->method('getCellByColumnAndRow')
25
-                 ->will($this->returnValue($this->mockCell));
24
+                    ->method('getCellByColumnAndRow')
25
+                    ->will($this->returnValue($this->mockCell));
26 26
     }
27 27
 
28 28
 
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Worksheet/RowIteratorTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,11 +18,11 @@
 block discarded – undo
18 18
             ->getMock();
19 19
 
20 20
         $this->mockWorksheet->expects($this->any())
21
-                 ->method('getHighestRow')
22
-                 ->will($this->returnValue(5));
21
+                    ->method('getHighestRow')
22
+                    ->will($this->returnValue(5));
23 23
         $this->mockWorksheet->expects($this->any())
24
-                 ->method('current')
25
-                 ->will($this->returnValue($this->mockRow));
24
+                    ->method('current')
25
+                    ->will($this->returnValue($this->mockRow));
26 26
     }
27 27
 
28 28
 
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Worksheet/WorksheetRowTest.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@
 block discarded – undo
13 13
             ->disableOriginalConstructor()
14 14
             ->getMock();
15 15
         $this->mockWorksheet->expects($this->any())
16
-                 ->method('getHighestColumn')
17
-                 ->will($this->returnValue('E'));
16
+                    ->method('getHighestColumn')
17
+                    ->will($this->returnValue('E'));
18 18
     }
19 19
 
20 20
 
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Worksheet/WorksheetColumnTest.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@
 block discarded – undo
13 13
             ->disableOriginalConstructor()
14 14
             ->getMock();
15 15
         $this->mockWorksheet->expects($this->any())
16
-                 ->method('getHighestRow')
17
-                 ->will($this->returnValue(5));
16
+                    ->method('getHighestRow')
17
+                    ->will($this->returnValue(5));
18 18
     }
19 19
 
20 20
 
Please login to merge, or discard this patch.