SettingsTest::testSetXMLSettings() - Code Metrics - Inspection of "Settings: deleted libxml_disable_entity_loader() c..." - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( de57bf...976711 )

by Adrien

created 2017-03-12 13:00 UTC

SettingsTest::testSetXMLSettings() A

↳ Parent: SettingsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	0
loc	7
rs	9.4285
c	1
b	0
f	0

<?php

namespace PhpOffice\PhpSpreadsheetTests;

class SettingsTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var string
     */
    protected $prevValue;

    public function setUp()
    {
        $this->prevValue = libxml_disable_entity_loader();
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        libxml_disable_entity_loader(false); // Enable entity loader
    }

    protected function tearDown()
    {
        libxml_disable_entity_loader($this->prevValue);
    }

    public function testGetXMLSettings()
    {
        $result = \PhpOffice\PhpSpreadsheet\Settings::getLibXmlLoaderOptions();
        $this->assertTrue((bool) ((LIBXML_DTDLOAD | LIBXML_DTDATTR) & $result));
        $this->assertFalse(libxml_disable_entity_loader());
    }

    public function testSetXMLSettings()
    {
        \PhpOffice\PhpSpreadsheet\Settings::setLibXmlLoaderOptions(LIBXML_DTDLOAD | LIBXML_DTDATTR | LIBXML_DTDVALID);
        $result = \PhpOffice\PhpSpreadsheet\Settings::getLibXmlLoaderOptions();
        $this->assertTrue((bool) ((LIBXML_DTDLOAD | LIBXML_DTDATTR | LIBXML_DTDVALID) & $result));
        $this->assertFalse(libxml_disable_entity_loader());
    }
}


1			<?php
2
3			namespace PhpOffice\PhpSpreadsheetTests;
4
5			class SettingsTest extends \PHPUnit_Framework_TestCase
6			{
7			/**
8			* @var string
9			*/
10			protected $prevValue;
11
12			public function setUp()
13			{
14			$this->prevValue = libxml_disable_entity_loader();
			0 ignored issues – show Documentation Bug introduced 2017-03-12 10:29 UTC by Report Bug Copy Issue Report The property `$prevValue` was declared of type `string`, but `libxml_disable_entity_loader()` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
15			libxml_disable_entity_loader(false); // Enable entity loader
16			}
17
18			protected function tearDown()
19			{
20			libxml_disable_entity_loader($this->prevValue);
21			}
22
23			public function testGetXMLSettings()
24			{
25			$result = \PhpOffice\PhpSpreadsheet\Settings::getLibXmlLoaderOptions();
26			$this->assertTrue((bool) ((LIBXML_DTDLOAD \| LIBXML_DTDATTR) & $result));
27			$this->assertFalse(libxml_disable_entity_loader());
28			}
29
30			public function testSetXMLSettings()
31			{
32			\PhpOffice\PhpSpreadsheet\Settings::setLibXmlLoaderOptions(LIBXML_DTDLOAD \| LIBXML_DTDATTR \| LIBXML_DTDVALID);
33			$result = \PhpOffice\PhpSpreadsheet\Settings::getLibXmlLoaderOptions();
34			$this->assertTrue((bool) ((LIBXML_DTDLOAD \| LIBXML_DTDATTR \| LIBXML_DTDVALID) & $result));
35			$this->assertFalse(libxml_disable_entity_loader());
36			}
37			}
38

PHPOffice / PhpSpreadsheet

Push — develop ( de57bf...976711 )

SettingsTest::testSetXMLSettings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like