PhpOffice\PhpSpreadsheet\Writer\Xlsx\Worksheet::writeWorksheet()

Complexity

Conditions	3
Paths	3

Size

Total Lines	90
Code Lines	36

Duplication

Lines	5
Ratio	5.56 %

Code Coverage

Tests	33
CRAP Score	3.0016

Importance

Changes

0

<?php
    public function writeWorksheet($pSheet = null, $pStringTable = null, $includeCharts = false)
    {
        if (!is_null($pSheet)) {
            // Create XML writer
            $objWriter = null;

$objWriter is not used, you could remove the assignment.

            if ($this->getParentWriter()->getUseDiskCaching()) {

This code seems to be duplicated across your project.

                $objWriter = new XMLWriter(XMLWriter::STORAGE_DISK, $this->getParentWriter()->getDiskCachingDirectory());
            } else {
                $objWriter = new XMLWriter(XMLWriter::STORAGE_MEMORY);
            }

            // XML header
            $objWriter->startDocument('1.0', 'UTF-8', 'yes');

            // Worksheet
            $objWriter->startElement('worksheet');
            $objWriter->writeAttribute('xml:space', 'preserve');
            $objWriter->writeAttribute('xmlns', 'http://schemas.openxmlformats.org/spreadsheetml/2006/main');
            $objWriter->writeAttribute('xmlns:r', 'http://schemas.openxmlformats.org/officeDocument/2006/relationships');

                // sheetPr
                $this->writeSheetPr($objWriter, $pSheet);

                // Dimension
                $this->writeDimension($objWriter, $pSheet);

                // sheetViews
                $this->writeSheetViews($objWriter, $pSheet);

                // sheetFormatPr
                $this->writeSheetFormatPr($objWriter, $pSheet);

                // cols
                $this->writeCols($objWriter, $pSheet);

                // sheetData
                $this->writeSheetData($objWriter, $pSheet, $pStringTable);

It seems like $pStringTable defined by parameter $pStringTable on line 58 can also be of type null; however, PhpOffice\PhpSpreadsheet\Writer\Xlsx\Worksheet::writeSheetData() does only seem to accept array<integer,string>, maybe add an additional type check?

                // sheetProtection
                $this->writeSheetProtection($objWriter, $pSheet);

                // protectedRanges
                $this->writeProtectedRanges($objWriter, $pSheet);

                // autoFilter
                $this->writeAutoFilter($objWriter, $pSheet);

                // mergeCells
                $this->writeMergeCells($objWriter, $pSheet);

                // conditionalFormatting
                $this->writeConditionalFormatting($objWriter, $pSheet);

                // dataValidations
                $this->writeDataValidations($objWriter, $pSheet);

                // hyperlinks
                $this->writeHyperlinks($objWriter, $pSheet);

                // Print options
                $this->writePrintOptions($objWriter, $pSheet);

                // Page margins
                $this->writePageMargins($objWriter, $pSheet);

                // Page setup
                $this->writePageSetup($objWriter, $pSheet);

                // Header / footer
                $this->writeHeaderFooter($objWriter, $pSheet);

                // Breaks
                $this->writeBreaks($objWriter, $pSheet);

                // Drawings and/or Charts
                $this->writeDrawings($objWriter, $pSheet, $includeCharts);

                // LegacyDrawing
                $this->writeLegacyDrawing($objWriter, $pSheet);

                // LegacyDrawingHF
                $this->writeLegacyDrawingHF($objWriter, $pSheet);

            $objWriter->endElement();

            // Return
            return $objWriter->getData();
        }
        throw new WriterException('Invalid \\PhpOffice\\PhpSpreadsheet\\Worksheet object passed.');
    }