DateTest - Code Metrics - Inspection of "Merge branch 'develop' into feature/gh-7" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d19f73...aa97bb )

unknown

created 2016-08-14 14:52 UTC

DateTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	164
Duplicated Lines	36.59 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	60
loc	164
rs	10
wmc	17
lcom	1
cbo	1

16 Methods

Rating	Name	Duplication	Size	Complexity
A	testSetExcelCalendar()	0	12	2
A	testSetExcelCalendarWithInvalidValue()	0	6	1
A	testDateTimeExcelToTimestamp1900()	0	12	1
A	providerDateTimeExcelToTimestamp1900()	0	4	1
A	testDateTimePHPToExcel1900()	12	12	1
A	providerDateTimePHPToExcel1900()	0	4	1
A	testDateTimeFormattedPHPToExcel1900()	12	12	1
A	providerDateTimeFormattedPHPToExcel1900()	0	4	1
A	testDateTimeExcelToTimestamp1904()	12	12	1
A	providerDateTimeExcelToTimestamp1904()	0	4	1
A	testDateTimePHPToExcel1904()	12	12	1
A	providerDateTimePHPToExcel1904()	0	4	1
A	testIsDateTimeFormatCode()	0	7	1
A	providerIsDateTimeFormatCode()	0	4	1
A	testDateTimeExcelToTimestamp1900Timezone()	12	12	1
A	providerDateTimeExcelToTimestamp1900Timezone()	0	4	1

How to fix Duplicated Code

<?php

namespace PhpSpreadsheet\Tests\Shared;

use PHPExcel\Shared\Date;

class DateTest extends \PHPUnit_Framework_TestCase
{
    public function testSetExcelCalendar()
    {
        $calendarValues = array(
            Date::CALENDAR_MAC_1904,
            Date::CALENDAR_WINDOWS_1900,
        );

        foreach ($calendarValues as $calendarValue) {
            $result = call_user_func(array(Date::class,'setExcelCalendar'), $calendarValue);
            $this->assertTrue($result);
        }
    }

    public function testSetExcelCalendarWithInvalidValue()
    {
        $unsupportedCalendar = '2012';
        $result = call_user_func(array(Date::class,'setExcelCalendar'), $unsupportedCalendar);
        $this->assertFalse($result);
    }

    /**
     * @dataProvider providerDateTimeExcelToTimestamp1900
     */
    public function testDateTimeExcelToTimestamp1900()
    {
        $result = call_user_func(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            array(Date::class,'setExcelCalendar'),
            Date::CALENDAR_WINDOWS_1900
        );

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array(array(Date::class, 'excelToTimestamp'), $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerDateTimeExcelToTimestamp1900()
    {
        return include 'rawTestData/Shared/Date/ExcelToTimestamp1900.php';
    }

    /**
     * @dataProvider providerDateTimePHPToExcel1900
     */
    public function testDateTimePHPToExcel1900()

    {
        $result = call_user_func(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            array(Date::class,'setExcelCalendar'),
            Date::CALENDAR_WINDOWS_1900
        );

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array(array(Date::class,'PHPToExcel'), $args);
        $this->assertEquals($expectedResult, $result, null, 1E-5);
    }

    public function providerDateTimePHPToExcel1900()
    {
        return include 'rawTestData/Shared/Date/PHPToExcel1900.php';
    }

    /**
     * @dataProvider providerDateTimeFormattedPHPToExcel1900
     */
    public function testDateTimeFormattedPHPToExcel1900()

    {
        $result = call_user_func(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            array(Date::class,'setExcelCalendar'),
            Date::CALENDAR_WINDOWS_1900
        );

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array(array(Date::class,'formattedPHPToExcel'), $args);
        $this->assertEquals($expectedResult, $result, null, 1E-5);
    }

    public function providerDateTimeFormattedPHPToExcel1900()
    {
        return include 'rawTestData/Shared/Date/FormattedPHPToExcel1900.php';
    }

    /**
     * @dataProvider providerDateTimeExcelToTimestamp1904
     */
    public function testDateTimeExcelToTimestamp1904()

    {
        $result = call_user_func(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            array(Date::class,'setExcelCalendar'),
            Date::CALENDAR_MAC_1904
        );

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerDateTimeExcelToTimestamp1904()
    {
        return include 'rawTestData/Shared/Date/ExcelToTimestamp1904.php';
    }

    /**
     * @dataProvider providerDateTimePHPToExcel1904
     */
    public function testDateTimePHPToExcel1904()

    {
        $result = call_user_func(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            array(Date::class,'setExcelCalendar'),
            Date::CALENDAR_MAC_1904
        );

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array(array(Date::class,'PHPToExcel'), $args);
        $this->assertEquals($expectedResult, $result, null, 1E-5);
    }

    public function providerDateTimePHPToExcel1904()
    {
        return include 'rawTestData/Shared/Date/PHPToExcel1904.php';
    }

    /**
     * @dataProvider providerIsDateTimeFormatCode
     */
    public function testIsDateTimeFormatCode()
    {
        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array(array(Date::class,'isDateTimeFormatCode'), $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerIsDateTimeFormatCode()
    {
        return include 'rawTestData/Shared/Date/FormatCodes.php';
    }

    /**
     * @dataProvider providerDateTimeExcelToTimestamp1900Timezone
     */
    public function testDateTimeExcelToTimestamp1900Timezone()

    {
        $result = call_user_func(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            array(Date::class,'setExcelCalendar'),
            Date::CALENDAR_WINDOWS_1900
        );

        $args = func_get_args();
        $expectedResult = array_pop($args);
        $result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
        $this->assertEquals($expectedResult, $result);
    }

    public function providerDateTimeExcelToTimestamp1900Timezone()
    {
        return include 'rawTestData/Shared/Date/ExcelToTimestamp1900Timezone.php';
    }
}


1		<?php
2
3		namespace PhpSpreadsheet\Tests\Shared;
4
5		use PHPExcel\Shared\Date;
6
7		class DateTest extends \PHPUnit_Framework_TestCase
8		{
9		public function testSetExcelCalendar()
10		{
11		$calendarValues = array(
12		Date::CALENDAR_MAC_1904,
13		Date::CALENDAR_WINDOWS_1900,
14		);
15
16		foreach ($calendarValues as $calendarValue) {
17		$result = call_user_func(array(Date::class,'setExcelCalendar'), $calendarValue);
18		$this->assertTrue($result);
19		}
20		}
21
22		public function testSetExcelCalendarWithInvalidValue()
23		{
24		$unsupportedCalendar = '2012';
25		$result = call_user_func(array(Date::class,'setExcelCalendar'), $unsupportedCalendar);
26		$this->assertFalse($result);
27		}
28
29		/**
30		* @dataProvider providerDateTimeExcelToTimestamp1900
31		*/
32		public function testDateTimeExcelToTimestamp1900()
33		{
34		$result = call_user_func(
		0 ignored issues – show Unused Code introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35		array(Date::class,'setExcelCalendar'),
36		Date::CALENDAR_WINDOWS_1900
37		);
38
39		$args = func_get_args();
40		$expectedResult = array_pop($args);
41		$result = call_user_func_array(array(Date::class, 'excelToTimestamp'), $args);
42		$this->assertEquals($expectedResult, $result);
43		}
44
45		public function providerDateTimeExcelToTimestamp1900()
46		{
47		return include 'rawTestData/Shared/Date/ExcelToTimestamp1900.php';
48		}
49
50		/**
51		* @dataProvider providerDateTimePHPToExcel1900
52		*/
53	View Code Duplication	public function testDateTimePHPToExcel1900()
		0 ignored issues – show Duplication introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		{
55		$result = call_user_func(
		0 ignored issues – show Unused Code introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
56		array(Date::class,'setExcelCalendar'),
57		Date::CALENDAR_WINDOWS_1900
58		);
59
60		$args = func_get_args();
61		$expectedResult = array_pop($args);
62		$result = call_user_func_array(array(Date::class,'PHPToExcel'), $args);
63		$this->assertEquals($expectedResult, $result, null, 1E-5);
64		}
65
66		public function providerDateTimePHPToExcel1900()
67		{
68		return include 'rawTestData/Shared/Date/PHPToExcel1900.php';
69		}
70
71		/**
72		* @dataProvider providerDateTimeFormattedPHPToExcel1900
73		*/
74	View Code Duplication	public function testDateTimeFormattedPHPToExcel1900()
		0 ignored issues – show Duplication introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		$result = call_user_func(
		0 ignored issues – show Unused Code introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
77		array(Date::class,'setExcelCalendar'),
78		Date::CALENDAR_WINDOWS_1900
79		);
80
81		$args = func_get_args();
82		$expectedResult = array_pop($args);
83		$result = call_user_func_array(array(Date::class,'formattedPHPToExcel'), $args);
84		$this->assertEquals($expectedResult, $result, null, 1E-5);
85		}
86
87		public function providerDateTimeFormattedPHPToExcel1900()
88		{
89		return include 'rawTestData/Shared/Date/FormattedPHPToExcel1900.php';
90		}
91
92		/**
93		* @dataProvider providerDateTimeExcelToTimestamp1904
94		*/
95	View Code Duplication	public function testDateTimeExcelToTimestamp1904()
		0 ignored issues – show Duplication introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		{
97		$result = call_user_func(
		0 ignored issues – show Unused Code introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
98		array(Date::class,'setExcelCalendar'),
99		Date::CALENDAR_MAC_1904
100		);
101
102		$args = func_get_args();
103		$expectedResult = array_pop($args);
104		$result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
105		$this->assertEquals($expectedResult, $result);
106		}
107
108		public function providerDateTimeExcelToTimestamp1904()
109		{
110		return include 'rawTestData/Shared/Date/ExcelToTimestamp1904.php';
111		}
112
113		/**
114		* @dataProvider providerDateTimePHPToExcel1904
115		*/
116	View Code Duplication	public function testDateTimePHPToExcel1904()
		0 ignored issues – show Duplication introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
117		{
118		$result = call_user_func(
		0 ignored issues – show Unused Code introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
119		array(Date::class,'setExcelCalendar'),
120		Date::CALENDAR_MAC_1904
121		);
122
123		$args = func_get_args();
124		$expectedResult = array_pop($args);
125		$result = call_user_func_array(array(Date::class,'PHPToExcel'), $args);
126		$this->assertEquals($expectedResult, $result, null, 1E-5);
127		}
128
129		public function providerDateTimePHPToExcel1904()
130		{
131		return include 'rawTestData/Shared/Date/PHPToExcel1904.php';
132		}
133
134		/**
135		* @dataProvider providerIsDateTimeFormatCode
136		*/
137		public function testIsDateTimeFormatCode()
138		{
139		$args = func_get_args();
140		$expectedResult = array_pop($args);
141		$result = call_user_func_array(array(Date::class,'isDateTimeFormatCode'), $args);
142		$this->assertEquals($expectedResult, $result);
143		}
144
145		public function providerIsDateTimeFormatCode()
146		{
147		return include 'rawTestData/Shared/Date/FormatCodes.php';
148		}
149
150		/**
151		* @dataProvider providerDateTimeExcelToTimestamp1900Timezone
152		*/
153	View Code Duplication	public function testDateTimeExcelToTimestamp1900Timezone()
		0 ignored issues – show Duplication introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
154		{
155		$result = call_user_func(
		0 ignored issues – show Unused Code introduced 2016-08-14 05:24 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
156		array(Date::class,'setExcelCalendar'),
157		Date::CALENDAR_WINDOWS_1900
158		);
159
160		$args = func_get_args();
161		$expectedResult = array_pop($args);
162		$result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
163		$this->assertEquals($expectedResult, $result);
164		}
165
166		public function providerDateTimeExcelToTimestamp1900Timezone()
167		{
168		return include 'rawTestData/Shared/Date/ExcelToTimestamp1900Timezone.php';
169		}
170		}
171

PHPOffice / PhpSpreadsheet

Push — develop ( d19f73...aa97bb )

DateTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like