Completed
Pull Request — develop (#47)
by
unknown
10:56
created
src/PhpSpreadsheet/Worksheet.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
      *
616 616
      * @param string $index Chart index position
617 617
      * @throws Exception
618
-     * @return false|Chart
618
+     * @return null|Chart
619 619
      */
620 620
     public function getChartByIndex($index = null)
621 621
     {
@@ -1130,7 +1130,7 @@  discard block
 block discarded – undo
1130 1130
      * Set a cell value
1131 1131
      *
1132 1132
      * @param string $pCoordinate Coordinate of the cell
1133
-     * @param mixed $pValue Value of the cell
1133
+     * @param integer $pValue Value of the cell
1134 1134
      * @param bool $returnCell   Return the worksheet (false, default) or the cell (true)
1135 1135
      * @return Worksheet|Cell    Depending on the last parameter being specified
1136 1136
      */
@@ -1241,8 +1241,8 @@  discard block
 block discarded – undo
1241 1241
     /**
1242 1242
      * Get cell at a specific coordinate by using numeric cell coordinates
1243 1243
      *
1244
-     * @param  string $pColumn Numeric column coordinate of the cell
1245
-     * @param string $pRow Numeric row coordinate of the cell
1244
+     * @param  integer $pColumn Numeric column coordinate of the cell
1245
+     * @param integer $pRow Numeric row coordinate of the cell
1246 1246
      * @param bool $createIfNotExists  Flag indicating whether a new cell should be created if it doesn't
1247 1247
      *                                       already exist, or a null should be returned instead
1248 1248
      * @return null|Cell Cell that was found/created or null
@@ -1350,8 +1350,8 @@  discard block
 block discarded – undo
1350 1350
     /**
1351 1351
      * Cell at a specific coordinate by using numeric cell coordinates exists?
1352 1352
      *
1353
-     * @param string $pColumn Numeric column coordinate of the cell
1354
-     * @param string $pRow Numeric row coordinate of the cell
1353
+     * @param integer $pColumn Numeric column coordinate of the cell
1354
+     * @param integer $pRow Numeric row coordinate of the cell
1355 1355
      * @return bool
1356 1356
      */
1357 1357
     public function cellExistsByColumnAndRow($pColumn = 0, $pRow = 1)
@@ -1968,7 +1968,7 @@  discard block
 block discarded – undo
1968 1968
     /**
1969 1969
      *    Set AutoFilter
1970 1970
      *
1971
-     *    @param    AutoFilter|string   $pValue
1971
+     *    @param    string   $pValue
1972 1972
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
1973 1973
      *    @throws Exception
1974 1974
      *    @return Worksheet
@@ -2991,7 +2991,7 @@  discard block
 block discarded – undo
2991 2991
      *
2992 2992
      * @param null|string Same rule as Title minus space not allowed (but, like Excel, change silently space to underscore)
2993 2993
      * @throws Exception
2994
-     * @return objWorksheet
2994
+     * @return Worksheet
2995 2995
      */
2996 2996
     public function setCodeName($pValue = null)
2997 2997
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Parser.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
      *
508 508
      * @param mixed $token The token to convert
509 509
      *
510
-     * @return mixed the converted token on success
510
+     * @return string the converted token on success
511 511
      */
512 512
     private function convert($token)
513 513
     {
@@ -577,7 +577,7 @@  discard block
 block discarded – undo
577 577
      *
578 578
      * @param string $string A string for conversion to its ptg value
579 579
      *
580
-     * @return mixed the converted token on success
580
+     * @return string the converted token on success
581 581
      */
582 582
     private function convertString($string)
583 583
     {
@@ -656,7 +656,7 @@  discard block
 block discarded – undo
656 656
      *
657 657
      * @param string $token An Excel range in the Sheet1!A1:A2 format
658 658
      *
659
-     * @return mixed The packed ptgArea3d token on success
659
+     * @return string The packed ptgArea3d token on success
660 660
      */
661 661
     private function convertRange3d($token)
662 662
     {
@@ -708,7 +708,7 @@  discard block
 block discarded – undo
708 708
      *
709 709
      * @param string $cell An Excel cell reference
710 710
      *
711
-     * @return mixed The packed ptgRef3d token on success
711
+     * @return string The packed ptgRef3d token on success
712 712
      */
713 713
     private function convertRef3d($cell)
714 714
     {
@@ -807,7 +807,7 @@  discard block
 block discarded – undo
807 807
      *
808 808
      * @param string $ext_ref The name of the external reference
809 809
      *
810
-     * @return mixed The reference index in packed() format on success
810
+     * @return string The reference index in packed() format on success
811 811
      */
812 812
     private function getRefIndex($ext_ref)
813 813
     {
@@ -898,7 +898,7 @@  discard block
 block discarded – undo
898 898
      *
899 899
      * @param string $cell The Excel cell reference to be packed
900 900
      *
901
-     * @return array Array containing the row and column in packed() format
901
+     * @return string[] Array containing the row and column in packed() format
902 902
      */
903 903
     private function cellToPackedRowcol($cell)
904 904
     {
@@ -927,7 +927,7 @@  discard block
 block discarded – undo
927 927
      *
928 928
      * @param string $range The Excel range to be packed
929 929
      *
930
-     * @return array Array containing (row1,col1,row2,col2) in packed() format
930
+     * @return string[] Array containing (row1,col1,row2,col2) in packed() format
931 931
      */
932 932
     private function rangeToPackedRange($range)
933 933
     {
@@ -1043,7 +1043,7 @@  discard block
 block discarded – undo
1043 1043
     /**
1044 1044
      * Checks if it's a valid token.
1045 1045
      *
1046
-     * @param mixed $token The token to check
1046
+     * @param string $token The token to check
1047 1047
      *
1048 1048
      * @return mixed The checked token or false on failure
1049 1049
      */
@@ -1129,7 +1129,7 @@  discard block
 block discarded – undo
1129 1129
      * @param string $formula The formula to parse, without the initial equal
1130 1130
      *                        sign (=)
1131 1131
      *
1132
-     * @return mixed true on success
1132
+     * @return boolean true on success
1133 1133
      */
1134 1134
     public function parse($formula)
1135 1135
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Workbook.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -242,6 +242,7 @@  discard block
 block discarded – undo
242 242
      *
243 243
      * @param \PhpOffice\PhpSpreadsheet\Style
244 244
      * @param bool Is it a style XF?
245
+     * @param \PhpOffice\PhpSpreadsheet\Style $style
245 246
      *
246 247
      * @return int Index to XF record
247 248
      */
@@ -796,7 +797,7 @@  discard block
 block discarded – undo
796 797
      *
797 798
      * @param string $name        The name in UTF-8
798 799
      * @param string $formulaData The binary formula data
799
-     * @param string $sheetIndex  1-based sheet index the defined name applies to. 0 = global
800
+     * @param integer $sheetIndex  1-based sheet index the defined name applies to. 0 = global
800 801
      * @param bool   $isBuiltIn   Built-in name?
801 802
      *
802 803
      * @return string Complete binary record data
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Worksheet.php 1 patch
Doc Comments   +8 added lines, -6 removed lines patch added patch discarded remove patch
@@ -219,6 +219,8 @@  discard block
 block discarded – undo
219 219
      * @param bool                                $preCalculateFormulas Flag indicating whether formulas should be calculated or just written
220 220
      * @param string                              $phpSheet             The worksheet to write
221 221
      * @param \PhpOffice\PhpSpreadsheet\Worksheet $phpSheet
222
+     * @param integer $str_total
223
+     * @param integer $str_unique
222 224
      */
223 225
     public function __construct(&$str_total, &$str_unique, &$str_table, &$colors, $parser, $preCalculateFormulas, $phpSheet)
224 226
     {
@@ -620,7 +622,7 @@  discard block
 block discarded – undo
620 622
      * @param int   $row     Zero indexed row
621 623
      * @param int   $col     Zero indexed column
622 624
      * @param float $num     The number to write
623
-     * @param mixed $xfIndex The optional XF format
625
+     * @param integer $xfIndex The optional XF format
624 626
      *
625 627
      * @return int
626 628
      */
@@ -729,7 +731,7 @@  discard block
 block discarded – undo
729 731
      * @param int    $row     Zero indexed row
730 732
      * @param int    $col     Zero indexed column
731 733
      * @param string $str     The string to write
732
-     * @param mixed  $xfIndex The XF format index for the cell
734
+     * @param integer  $xfIndex The XF format index for the cell
733 735
      *
734 736
      * @return int
735 737
      */
@@ -796,7 +798,7 @@  discard block
 block discarded – undo
796 798
      *
797 799
      * @param int   $row     Zero indexed row
798 800
      * @param int   $col     Zero indexed column
799
-     * @param mixed $xfIndex The XF format index
801
+     * @param integer $xfIndex The XF format index
800 802
      */
801 803
     public function writeBlank($row, $col, $xfIndex)
802 804
     {
@@ -843,7 +845,7 @@  discard block
 block discarded – undo
843 845
      * @param int    $row             Zero indexed row
844 846
      * @param int    $col             Zero indexed column
845 847
      * @param string $formula         The formula text string
846
-     * @param mixed  $xfIndex         The XF format index
848
+     * @param integer  $xfIndex         The XF format index
847 849
      * @param mixed  $calculatedValue Calculated value
848 850
      *
849 851
      * @return int
@@ -2323,8 +2325,8 @@  discard block
 block discarded – undo
2323 2325
      * @param mixed $bitmap  The bitmap filename or GD-image resource
2324 2326
      * @param int   $x       The horizontal position (offset) of the image inside the cell
2325 2327
      * @param int   $y       The vertical position (offset) of the image inside the cell
2326
-     * @param float $scale_x The horizontal scale
2327
-     * @param float $scale_y The vertical scale
2328
+     * @param integer $scale_x The horizontal scale
2329
+     * @param integer $scale_y The vertical scale
2328 2330
      */
2329 2331
     public function insertBitmap($row, $col, $bitmap, $x = 0, $y = 0, $scale_x = 1, $scale_y = 1)
2330 2332
     {
Please login to merge, or discard this patch.