Completed
Pull Request — develop (#47)
by
unknown
10:56
created
src/PhpSpreadsheet/Cell.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -757,7 +757,7 @@
 block discarded – undo
757 757
      *    Calculate range boundaries
758 758
      *
759 759
      *    @param    string    $pRange        Cell range (e.g. A1:A1)
760
-     *    @return    array    Range coordinates array(Start Cell, End Cell)
760
+     *    @return    integer    Range coordinates array(Start Cell, End Cell)
761 761
      *                    where Start Cell and End Cell are arrays (Column ID, Row Number)
762 762
      */
763 763
     public static function getRangeBoundaries($pRange = 'A1:A1')
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
                 $this->value = DataType::checkErrorCode($pValue);
260 260
                 break;
261 261
             default:
262
-                throw new Exception('Invalid datatype: '.$pDataType);
262
+                throw new Exception('Invalid datatype: ' . $pDataType);
263 263
                 break;
264 264
         }
265 265
 
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
                 }
300 300
                 $result = '#N/A';
301 301
                 throw new Exception(
302
-                    $this->getWorksheet()->getTitle().'!'.$this->getCoordinate().' -> '.$ex->getMessage()
302
+                    $this->getWorksheet()->getTitle() . '!' . $this->getCoordinate() . ' -> ' . $ex->getMessage()
303 303
                 );
304 304
             }
305 305
 
@@ -614,7 +614,7 @@  discard block
 block discarded – undo
614 614
             throw new Exception('Cell coordinate can not be zero-length string');
615 615
         }
616 616
 
617
-        throw new Exception('Invalid cell coordinate '.$pCoordinateString);
617
+        throw new Exception('Invalid cell coordinate ' . $pCoordinateString);
618 618
     }
619 619
 
620 620
     /**
@@ -642,12 +642,12 @@  discard block
 block discarded – undo
642 642
 
643 643
             // Create absolute coordinate
644 644
             if (ctype_digit($pCoordinateString)) {
645
-                return $worksheet.'$'.$pCoordinateString;
645
+                return $worksheet . '$' . $pCoordinateString;
646 646
             } elseif (ctype_alpha($pCoordinateString)) {
647
-                return $worksheet.'$'.strtoupper($pCoordinateString);
647
+                return $worksheet . '$' . strtoupper($pCoordinateString);
648 648
             }
649 649
 
650
-            return $worksheet.self::absoluteCoordinate($pCoordinateString);
650
+            return $worksheet . self::absoluteCoordinate($pCoordinateString);
651 651
         }
652 652
 
653 653
         throw new Exception('Cell coordinate string can not be a range of cells');
@@ -680,7 +680,7 @@  discard block
 block discarded – undo
680 680
             $column = ltrim($column, '$');
681 681
             $row = ltrim($row, '$');
682 682
 
683
-            return $worksheet.'$'.$column.'$'.$row;
683
+            return $worksheet . '$' . $column . '$' . $row;
684 684
         }
685 685
 
686 686
         throw new Exception('Cell coordinate string can not be a range of cells');
@@ -861,7 +861,7 @@  discard block
 block discarded – undo
861 861
                 return $_indexCache[$pString];
862 862
             }
863 863
         }
864
-        throw new Exception('Column string index can not be '.((isset($pString{0})) ? 'longer than 3 characters' : 'empty'));
864
+        throw new Exception('Column string index can not be ' . ((isset($pString{0})) ? 'longer than 3 characters' : 'empty'));
865 865
     }
866 866
 
867 867
     /**
@@ -883,11 +883,11 @@  discard block
 block discarded – undo
883 883
             if ($pColumnIndex < 26) {
884 884
                 $_indexCache[$pColumnIndex] = chr(65 + $pColumnIndex);
885 885
             } elseif ($pColumnIndex < 702) {
886
-                $_indexCache[$pColumnIndex] = chr(64 + ($pColumnIndex / 26)).
886
+                $_indexCache[$pColumnIndex] = chr(64 + ($pColumnIndex / 26)) .
887 887
                                                 chr(65 + $pColumnIndex % 26);
888 888
             } else {
889
-                $_indexCache[$pColumnIndex] = chr(64 + (($pColumnIndex - 26) / 676)).
890
-                                                chr(65 + ((($pColumnIndex - 26) % 676) / 26)).
889
+                $_indexCache[$pColumnIndex] = chr(64 + (($pColumnIndex - 26) / 676)) .
890
+                                                chr(65 + ((($pColumnIndex - 26) % 676) / 26)) .
891 891
                                                 chr(65 + $pColumnIndex % 26);
892 892
             }
893 893
         }
@@ -938,7 +938,7 @@  discard block
 block discarded – undo
938 938
                 // Loop cells
939 939
                 while ($currentCol != $endCol) {
940 940
                     while ($currentRow <= $endRow) {
941
-                        $returnValue[] = $currentCol.$currentRow;
941
+                        $returnValue[] = $currentCol . $currentRow;
942 942
                         ++$currentRow;
943 943
                     }
944 944
                     ++$currentCol;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Chart/Properties.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -136,6 +136,11 @@  discard block
 block discarded – undo
136 136
         return (string) 100 - $alpha . '000';
137 137
     }
138 138
 
139
+    /**
140
+     * @param string $color
141
+     * @param integer $alpha
142
+     * @param string $type
143
+     */
139 144
     protected function setColorProperties($color, $alpha, $type)
140 145
     {
141 146
         return [
@@ -145,6 +150,9 @@  discard block
 block discarded – undo
145 150
         ];
146 151
     }
147 152
 
153
+    /**
154
+     * @param string $array_kay_selector
155
+     */
148 156
     protected function getLineStyleArrowSize($array_selector, $array_kay_selector)
149 157
     {
150 158
         $sizes = [
@@ -162,6 +170,9 @@  discard block
 block discarded – undo
162 170
         return $sizes[$array_selector][$array_kay_selector];
163 171
     }
164 172
 
173
+    /**
174
+     * @param integer $shadow_presets_option
175
+     */
165 176
     protected function getShadowPresetsMap($shadow_presets_option)
166 177
     {
167 178
         $presets_options = [
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@
 block discarded – undo
133 133
 
134 134
     protected function getTrueAlpha($alpha)
135 135
     {
136
-        return (string) 100 - $alpha.'000';
136
+        return (string) 100 - $alpha . '000';
137 137
     }
138 138
 
139 139
     protected function setColorProperties($color, $alpha, $type)
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/OLERead.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
     /**
71 71
      * Read the file
72 72
      *
73
-     * @param $sFileName string Filename
73
+     * @param string $sFileName string Filename
74 74
      * @throws \PhpSpreadsheet\Reader\Exception
75 75
      */
76 76
     public function read($sFileName)
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     {
79 79
         // Check if file exists and is readable
80 80
         if (!is_readable($sFileName)) {
81
-            throw new \PhpOffice\PhpSpreadsheet\Reader\Exception('Could not open '.$sFileName.' for reading! File does not exist, or it is not readable.');
81
+            throw new \PhpOffice\PhpSpreadsheet\Reader\Exception('Could not open ' . $sFileName . ' for reading! File does not exist, or it is not readable.');
82 82
         }
83 83
 
84 84
         // Get the file identifier
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
         // Check OLE identifier
89 89
         if ($this->data != self::IDENTIFIER_OLE) {
90
-            throw new \PhpOffice\PhpSpreadsheet\Reader\Exception('The filename '.$sFileName.' is not recognised as an OLE file');
90
+            throw new \PhpOffice\PhpSpreadsheet\Reader\Exception('The filename ' . $sFileName . ' is not recognised as an OLE file');
91 91
         }
92 92
 
93 93
         // Get the file data
@@ -283,12 +283,12 @@  discard block
 block discarded – undo
283 283
             }
284 284
 
285 285
             // Summary information
286
-            if ($name == chr(5).'SummaryInformation') {
286
+            if ($name == chr(5) . 'SummaryInformation') {
287 287
                 $this->summaryInformation = count($this->props) - 1;
288 288
             }
289 289
 
290 290
             // Additional Document Summary information
291
-            if ($name == chr(5).'DocumentSummaryInformation') {
291
+            if ($name == chr(5) . 'DocumentSummaryInformation') {
292 292
                 $this->documentSummaryInformation = count($this->props) - 1;
293 293
             }
294 294
 
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
             throw new \PhpOffice\PhpSpreadsheet\Reader\Exception('Parameter data is empty.');
312 312
         } elseif ($pos < 0) {
313 313
             // Invalid position
314
-            throw new \PhpOffice\PhpSpreadsheet\Reader\Exception('Parameter pos='.$pos.' is invalid.');
314
+            throw new \PhpOffice\PhpSpreadsheet\Reader\Exception('Parameter pos=' . $pos . ' is invalid.');
315 315
         }
316 316
 
317 317
         $len = strlen($data);
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/PCLZip/PclZip.php 2 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -2215,6 +2215,10 @@  discard block
 block discarded – undo
2215 2215
     // Description :
2216 2216
     // Parameters :
2217 2217
     // --------------------------------------------------------------------------------
2218
+
2219
+    /**
2220
+     * @param string $p_mode
2221
+     */
2218 2222
     public function privOpenFd($p_mode)
2219 2223
     {
2220 2224
         $v_result = 1;
@@ -3815,6 +3819,10 @@  discard block
 block discarded – undo
3815 3819
     // Parameters :
3816 3820
     // Return Values :
3817 3821
     // --------------------------------------------------------------------------------
3822
+
3823
+    /**
3824
+     * @param string $p_string
3825
+     */
3818 3826
     public function privExtractFileAsString(&$p_entry, &$p_string, &$p_options)
3819 3827
     {
3820 3828
         $v_result = 1;
Please login to merge, or discard this patch.
Spacing   +95 added lines, -95 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 
223 223
         // ----- Tests the zlib
224 224
         if (!function_exists('gzopen')) {
225
-            die('Abort '.basename(__FILE__).' : Missing zlib extensions');
225
+            die('Abort ' . basename(__FILE__) . ' : Missing zlib extensions');
226 226
         }
227 227
 
228 228
         // ----- Set the attributes
@@ -529,7 +529,7 @@  discard block
 block discarded – undo
529 529
             $v_string_list = explode(PCLZIP_SEPARATOR, $p_filelist);
530 530
         } else {
531 531
             // ----- Invalid variable type for $p_filelist
532
-            self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Invalid variable type '".gettype($p_filelist)."' for p_filelist");
532
+            self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Invalid variable type '" . gettype($p_filelist) . "' for p_filelist");
533 533
 
534 534
             return 0;
535 535
         }
@@ -1077,7 +1077,7 @@  discard block
 block discarded – undo
1077 1077
                 $this->privSwapBackMagicQuotes();
1078 1078
 
1079 1079
                 // ----- Error log
1080
-                self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \''.$this->zipname.'\' in binary read mode');
1080
+                self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \'' . $this->zipname . '\' in binary read mode');
1081 1081
 
1082 1082
                 // ----- Return
1083 1083
                 return 0;
@@ -1137,7 +1137,7 @@  discard block
 block discarded – undo
1137 1137
             // TBC : Should also check the archive format
1138 1138
             if (!is_file($p_archive)) {
1139 1139
                 // ----- Error log
1140
-                self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "No file with filename '".$p_archive."'");
1140
+                self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "No file with filename '" . $p_archive . "'");
1141 1141
                 $v_result = PCLZIP_ERR_MISSING_FILE;
1142 1142
             } else {
1143 1143
                 // ----- Duplicate the archive
@@ -1257,7 +1257,7 @@  discard block
 block discarded – undo
1257 1257
         }
1258 1258
 
1259 1259
         if ($p_with_code) {
1260
-            return $v_value.' ('.$this->error_code.')';
1260
+            return $v_value . ' (' . $this->error_code . ')';
1261 1261
         } else {
1262 1262
             return $v_value;
1263 1263
         }
@@ -1275,9 +1275,9 @@  discard block
 block discarded – undo
1275 1275
             return PclErrorString();
1276 1276
         } else {
1277 1277
             if ($p_full) {
1278
-                return $this->errorName(true).' : '.$this->error_string;
1278
+                return $this->errorName(true) . ' : ' . $this->error_string;
1279 1279
             } else {
1280
-                return $this->error_string.' [code '.$this->error_code.']';
1280
+                return $this->error_string . ' [code ' . $this->error_code . ']';
1281 1281
             }
1282 1282
         }
1283 1283
     }
@@ -1316,7 +1316,7 @@  discard block
 block discarded – undo
1316 1316
         // ----- Look if the file exits
1317 1317
         if (!is_file($this->zipname)) {
1318 1318
             // ----- Error log
1319
-            self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "Missing archive file '".$this->zipname."'");
1319
+            self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "Missing archive file '" . $this->zipname . "'");
1320 1320
 
1321 1321
             return false;
1322 1322
         }
@@ -1324,7 +1324,7 @@  discard block
 block discarded – undo
1324 1324
         // ----- Check that the file is readeable
1325 1325
         if (!is_readable($this->zipname)) {
1326 1326
             // ----- Error log
1327
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, "Unable to read archive '".$this->zipname."'");
1327
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, "Unable to read archive '" . $this->zipname . "'");
1328 1328
 
1329 1329
             return false;
1330 1330
         }
@@ -1368,7 +1368,7 @@  discard block
 block discarded – undo
1368 1368
             // ----- Check if the option is supported
1369 1369
             if (!isset($v_requested_options[$p_options_list[$i]])) {
1370 1370
                 // ----- Error log
1371
-                self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Invalid optional parameter '".$p_options_list[$i]."' for this method");
1371
+                self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Invalid optional parameter '" . $p_options_list[$i] . "' for this method");
1372 1372
 
1373 1373
                 // ----- Return
1374 1374
                 return self::errorCode();
@@ -1383,7 +1383,7 @@  discard block
 block discarded – undo
1383 1383
                     // ----- Check the number of parameters
1384 1384
                     if (($i + 1) >= $p_size) {
1385 1385
                         // ----- Error log
1386
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1386
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1387 1387
 
1388 1388
                         // ----- Return
1389 1389
                         return self::errorCode();
@@ -1397,14 +1397,14 @@  discard block
 block discarded – undo
1397 1397
                 case PCLZIP_OPT_TEMP_FILE_THRESHOLD:
1398 1398
                     // ----- Check the number of parameters
1399 1399
                     if (($i + 1) >= $p_size) {
1400
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1400
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1401 1401
 
1402 1402
                         return self::errorCode();
1403 1403
                     }
1404 1404
 
1405 1405
                     // ----- Check for incompatible options
1406 1406
                     if (isset($v_result_list[PCLZIP_OPT_TEMP_FILE_OFF])) {
1407
-                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '".PclZipUtilOptionText($p_options_list[$i])."' can not be used with option 'PCLZIP_OPT_TEMP_FILE_OFF'");
1407
+                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '" . PclZipUtilOptionText($p_options_list[$i]) . "' can not be used with option 'PCLZIP_OPT_TEMP_FILE_OFF'");
1408 1408
 
1409 1409
                         return self::errorCode();
1410 1410
                     }
@@ -1412,7 +1412,7 @@  discard block
 block discarded – undo
1412 1412
                     // ----- Check the value
1413 1413
                     $v_value = $p_options_list[$i + 1];
1414 1414
                     if ((!is_integer($v_value)) || ($v_value < 0)) {
1415
-                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Integer expected for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1415
+                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Integer expected for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1416 1416
 
1417 1417
                         return self::errorCode();
1418 1418
                     }
@@ -1425,7 +1425,7 @@  discard block
 block discarded – undo
1425 1425
                 case PCLZIP_OPT_TEMP_FILE_ON:
1426 1426
                     // ----- Check for incompatible options
1427 1427
                     if (isset($v_result_list[PCLZIP_OPT_TEMP_FILE_OFF])) {
1428
-                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '".PclZipUtilOptionText($p_options_list[$i])."' can not be used with option 'PCLZIP_OPT_TEMP_FILE_OFF'");
1428
+                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '" . PclZipUtilOptionText($p_options_list[$i]) . "' can not be used with option 'PCLZIP_OPT_TEMP_FILE_OFF'");
1429 1429
 
1430 1430
                         return self::errorCode();
1431 1431
                     }
@@ -1436,13 +1436,13 @@  discard block
 block discarded – undo
1436 1436
                 case PCLZIP_OPT_TEMP_FILE_OFF:
1437 1437
                     // ----- Check for incompatible options
1438 1438
                     if (isset($v_result_list[PCLZIP_OPT_TEMP_FILE_ON])) {
1439
-                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '".PclZipUtilOptionText($p_options_list[$i])."' can not be used with option 'PCLZIP_OPT_TEMP_FILE_ON'");
1439
+                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '" . PclZipUtilOptionText($p_options_list[$i]) . "' can not be used with option 'PCLZIP_OPT_TEMP_FILE_ON'");
1440 1440
 
1441 1441
                         return self::errorCode();
1442 1442
                     }
1443 1443
                     // ----- Check for incompatible options
1444 1444
                     if (isset($v_result_list[PCLZIP_OPT_TEMP_FILE_THRESHOLD])) {
1445
-                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '".PclZipUtilOptionText($p_options_list[$i])."' can not be used with option 'PCLZIP_OPT_TEMP_FILE_THRESHOLD'");
1445
+                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Option '" . PclZipUtilOptionText($p_options_list[$i]) . "' can not be used with option 'PCLZIP_OPT_TEMP_FILE_THRESHOLD'");
1446 1446
 
1447 1447
                         return self::errorCode();
1448 1448
                     }
@@ -1453,7 +1453,7 @@  discard block
 block discarded – undo
1453 1453
                     // ----- Check the number of parameters
1454 1454
                     if (($i + 1) >= $p_size) {
1455 1455
                         // ----- Error log
1456
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1456
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1457 1457
                         // ----- Return
1458 1458
                         return self::errorCode();
1459 1459
                     }
@@ -1470,7 +1470,7 @@  discard block
 block discarded – undo
1470 1470
                     // ----- Check the number of parameters
1471 1471
                     if (($i + 1) >= $p_size) {
1472 1472
                         // ----- Error log
1473
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1473
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1474 1474
                         // ----- Return
1475 1475
                         return self::errorCode();
1476 1476
                     }
@@ -1482,7 +1482,7 @@  discard block
 block discarded – undo
1482 1482
                         $v_result_list[$p_options_list[$i]] = $p_options_list[$i + 1];
1483 1483
                     } else {
1484 1484
                         // ----- Error log
1485
-                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Wrong parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1485
+                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Wrong parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1486 1486
                         // ----- Return
1487 1487
                         return self::errorCode();
1488 1488
                     }
@@ -1499,7 +1499,7 @@  discard block
 block discarded – undo
1499 1499
                     // ----- Check the number of parameters
1500 1500
                     if (($i + 1) >= $p_size) {
1501 1501
                         // ----- Error log
1502
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1502
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1503 1503
                         // ----- Return
1504 1504
                         return self::errorCode();
1505 1505
                     }
@@ -1509,7 +1509,7 @@  discard block
 block discarded – undo
1509 1509
                         $v_result_list[$p_options_list[$i]] = $p_options_list[$i + 1];
1510 1510
                     } else {
1511 1511
                         // ----- Error log
1512
-                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Wrong parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1512
+                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Wrong parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1513 1513
                         // ----- Return
1514 1514
                         return self::errorCode();
1515 1515
                     }
@@ -1523,7 +1523,7 @@  discard block
 block discarded – undo
1523 1523
                     // ----- Check the number of parameters
1524 1524
                     if (($i + 1) >= $p_size) {
1525 1525
                         // ----- Error log
1526
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1526
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1527 1527
 
1528 1528
                         // ----- Return
1529 1529
                         return self::errorCode();
@@ -1534,7 +1534,7 @@  discard block
 block discarded – undo
1534 1534
                         $v_result_list[$p_options_list[$i]] = $p_options_list[$i + 1];
1535 1535
                     } else {
1536 1536
                         // ----- Error log
1537
-                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Wrong parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1537
+                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Wrong parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1538 1538
 
1539 1539
                         // ----- Return
1540 1540
                         return self::errorCode();
@@ -1547,7 +1547,7 @@  discard block
 block discarded – undo
1547 1547
                     // ----- Check the number of parameters
1548 1548
                     if (($i + 1) >= $p_size) {
1549 1549
                         // ----- Error log
1550
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1550
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1551 1551
 
1552 1552
                         // ----- Return
1553 1553
                         return self::errorCode();
@@ -1562,12 +1562,12 @@  discard block
 block discarded – undo
1562 1562
                         // ----- Parse items
1563 1563
                         $v_work_list = explode(',', $p_options_list[$i + 1]);
1564 1564
                     } elseif (is_integer($p_options_list[$i + 1])) {
1565
-                        $v_work_list[0] = $p_options_list[$i + 1].'-'.$p_options_list[$i + 1];
1565
+                        $v_work_list[0] = $p_options_list[$i + 1] . '-' . $p_options_list[$i + 1];
1566 1566
                     } elseif (is_array($p_options_list[$i + 1])) {
1567 1567
                         $v_work_list = $p_options_list[$i + 1];
1568 1568
                     } else {
1569 1569
                         // ----- Error log
1570
-                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Value must be integer, string or array for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1570
+                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Value must be integer, string or array for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1571 1571
 
1572 1572
                         // ----- Return
1573 1573
                         return self::errorCode();
@@ -1598,7 +1598,7 @@  discard block
 block discarded – undo
1598 1598
                             $v_result_list[$p_options_list[$i]][$j]['end'] = $v_item_list[1];
1599 1599
                         } else {
1600 1600
                             // ----- Error log
1601
-                            self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Too many values in index range for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1601
+                            self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Too many values in index range for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1602 1602
 
1603 1603
                             // ----- Return
1604 1604
                             return self::errorCode();
@@ -1610,7 +1610,7 @@  discard block
 block discarded – undo
1610 1610
 
1611 1611
                             // ----- TBC : An automatic sort should be writen ...
1612 1612
                             // ----- Error log
1613
-                            self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Invalid order of index range for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1613
+                            self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Invalid order of index range for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1614 1614
 
1615 1615
                             // ----- Return
1616 1616
                             return self::errorCode();
@@ -1639,7 +1639,7 @@  discard block
 block discarded – undo
1639 1639
                     // ----- Check the number of parameters
1640 1640
                     if (($i + 1) >= $p_size) {
1641 1641
                         // ----- Error log
1642
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1642
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1643 1643
                         // ----- Return
1644 1644
                         return self::errorCode();
1645 1645
                     }
@@ -1662,7 +1662,7 @@  discard block
 block discarded – undo
1662 1662
                     // ----- Check the number of parameters
1663 1663
                     if (($i + 1) >= $p_size) {
1664 1664
                         // ----- Error log
1665
-                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1665
+                        self::privErrorLog(PCLZIP_ERR_MISSING_OPTION_VALUE, "Missing parameter value for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1666 1666
                         // ----- Return
1667 1667
                         return self::errorCode();
1668 1668
                     }
@@ -1673,7 +1673,7 @@  discard block
 block discarded – undo
1673 1673
                     // ----- Check that the value is a valid existing function
1674 1674
                     if (!function_exists($v_function_name)) {
1675 1675
                         // ----- Error log
1676
-                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Function '".$v_function_name."()' is not an existing function for option '".PclZipUtilOptionText($p_options_list[$i])."'");
1676
+                        self::privErrorLog(PCLZIP_ERR_INVALID_OPTION_VALUE, "Function '" . $v_function_name . "()' is not an existing function for option '" . PclZipUtilOptionText($p_options_list[$i]) . "'");
1677 1677
                         // ----- Return
1678 1678
                         return self::errorCode();
1679 1679
                     }
@@ -1684,7 +1684,7 @@  discard block
 block discarded – undo
1684 1684
                     break;
1685 1685
                 default:
1686 1686
                     // ----- Error log
1687
-                    self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Unknown parameter '".$p_options_list[$i]."'");
1687
+                    self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Unknown parameter '" . $p_options_list[$i] . "'");
1688 1688
 
1689 1689
                     // ----- Return
1690 1690
                     return self::errorCode();
@@ -1702,7 +1702,7 @@  discard block
 block discarded – undo
1702 1702
                     // ----- Look if present
1703 1703
                     if (!isset($v_result_list[$key])) {
1704 1704
                         // ----- Error log
1705
-                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, 'Missing mandatory parameter '.PclZipUtilOptionText($key).'('.$key.')');
1705
+                        self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, 'Missing mandatory parameter ' . PclZipUtilOptionText($key) . '(' . $key . ')');
1706 1706
 
1707 1707
                         // ----- Return
1708 1708
                         return self::errorCode();
@@ -1780,7 +1780,7 @@  discard block
 block discarded – undo
1780 1780
             // ----- Check if the option is supported
1781 1781
             if (!isset($v_requested_options[$v_key])) {
1782 1782
                 // ----- Error log
1783
-                self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Invalid file attribute '".$v_key."' for this file");
1783
+                self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Invalid file attribute '" . $v_key . "' for this file");
1784 1784
 
1785 1785
                 // ----- Return
1786 1786
                 return self::errorCode();
@@ -1790,7 +1790,7 @@  discard block
 block discarded – undo
1790 1790
             switch ($v_key) {
1791 1791
                 case PCLZIP_ATT_FILE_NAME:
1792 1792
                     if (!is_string($v_value)) {
1793
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type '.gettype($v_value).". String expected for attribute '".PclZipUtilOptionText($v_key)."'");
1793
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type ' . gettype($v_value) . ". String expected for attribute '" . PclZipUtilOptionText($v_key) . "'");
1794 1794
 
1795 1795
                         return self::errorCode();
1796 1796
                     }
@@ -1798,14 +1798,14 @@  discard block
 block discarded – undo
1798 1798
                     $p_filedescr['filename'] = PclZipUtilPathReduction($v_value);
1799 1799
 
1800 1800
                     if ($p_filedescr['filename'] == '') {
1801
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, "Invalid empty filename for attribute '".PclZipUtilOptionText($v_key)."'");
1801
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, "Invalid empty filename for attribute '" . PclZipUtilOptionText($v_key) . "'");
1802 1802
 
1803 1803
                         return self::errorCode();
1804 1804
                     }
1805 1805
                     break;
1806 1806
                 case PCLZIP_ATT_FILE_NEW_SHORT_NAME:
1807 1807
                     if (!is_string($v_value)) {
1808
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type '.gettype($v_value).". String expected for attribute '".PclZipUtilOptionText($v_key)."'");
1808
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type ' . gettype($v_value) . ". String expected for attribute '" . PclZipUtilOptionText($v_key) . "'");
1809 1809
 
1810 1810
                         return self::errorCode();
1811 1811
                     }
@@ -1813,14 +1813,14 @@  discard block
 block discarded – undo
1813 1813
                     $p_filedescr['new_short_name'] = PclZipUtilPathReduction($v_value);
1814 1814
 
1815 1815
                     if ($p_filedescr['new_short_name'] == '') {
1816
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, "Invalid empty short filename for attribute '".PclZipUtilOptionText($v_key)."'");
1816
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, "Invalid empty short filename for attribute '" . PclZipUtilOptionText($v_key) . "'");
1817 1817
 
1818 1818
                         return self::errorCode();
1819 1819
                     }
1820 1820
                     break;
1821 1821
                 case PCLZIP_ATT_FILE_NEW_FULL_NAME:
1822 1822
                     if (!is_string($v_value)) {
1823
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type '.gettype($v_value).". String expected for attribute '".PclZipUtilOptionText($v_key)."'");
1823
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type ' . gettype($v_value) . ". String expected for attribute '" . PclZipUtilOptionText($v_key) . "'");
1824 1824
 
1825 1825
                         return self::errorCode();
1826 1826
                     }
@@ -1828,7 +1828,7 @@  discard block
 block discarded – undo
1828 1828
                     $p_filedescr['new_full_name'] = PclZipUtilPathReduction($v_value);
1829 1829
 
1830 1830
                     if ($p_filedescr['new_full_name'] == '') {
1831
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, "Invalid empty full filename for attribute '".PclZipUtilOptionText($v_key)."'");
1831
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, "Invalid empty full filename for attribute '" . PclZipUtilOptionText($v_key) . "'");
1832 1832
 
1833 1833
                         return self::errorCode();
1834 1834
                     }
@@ -1836,7 +1836,7 @@  discard block
 block discarded – undo
1836 1836
                 // ----- Look for options that takes a string
1837 1837
                 case PCLZIP_ATT_FILE_COMMENT:
1838 1838
                     if (!is_string($v_value)) {
1839
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type '.gettype($v_value).". String expected for attribute '".PclZipUtilOptionText($v_key)."'");
1839
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type ' . gettype($v_value) . ". String expected for attribute '" . PclZipUtilOptionText($v_key) . "'");
1840 1840
 
1841 1841
                         return self::errorCode();
1842 1842
                     }
@@ -1844,7 +1844,7 @@  discard block
 block discarded – undo
1844 1844
                     break;
1845 1845
                 case PCLZIP_ATT_FILE_MTIME:
1846 1846
                     if (!is_integer($v_value)) {
1847
-                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type '.gettype($v_value).". Integer expected for attribute '".PclZipUtilOptionText($v_key)."'");
1847
+                        self::privErrorLog(PCLZIP_ERR_INVALID_ATTRIBUTE_VALUE, 'Invalid type ' . gettype($v_value) . ". Integer expected for attribute '" . PclZipUtilOptionText($v_key) . "'");
1848 1848
 
1849 1849
                         return self::errorCode();
1850 1850
                     }
@@ -1855,7 +1855,7 @@  discard block
 block discarded – undo
1855 1855
                     break;
1856 1856
                 default:
1857 1857
                     // ----- Error log
1858
-                    self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Unknown parameter '".$v_key."'");
1858
+                    self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, "Unknown parameter '" . $v_key . "'");
1859 1859
 
1860 1860
                     // ----- Return
1861 1861
                     return self::errorCode();
@@ -1868,7 +1868,7 @@  discard block
 block discarded – undo
1868 1868
                     if ($v_requested_options[$key] == 'mandatory') {
1869 1869
                         // ----- Look if present
1870 1870
                         if (!isset($p_file_list[$key])) {
1871
-                            self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, 'Missing mandatory parameter '.PclZipUtilOptionText($key).'('.$key.')');
1871
+                            self::privErrorLog(PCLZIP_ERR_INVALID_PARAMETER, 'Missing mandatory parameter ' . PclZipUtilOptionText($key) . '(' . $key . ')');
1872 1872
 
1873 1873
                             return self::errorCode();
1874 1874
                         }
@@ -1931,7 +1931,7 @@  discard block
 block discarded – undo
1931 1931
             } else {
1932 1932
                 // ----- Missing file
1933 1933
                 // ----- Error log
1934
-                self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "File '".$v_descr['filename']."' does not exist");
1934
+                self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "File '" . $v_descr['filename'] . "' does not exist");
1935 1935
 
1936 1936
                 // ----- Return
1937 1937
                 return self::errorCode();
@@ -1956,7 +1956,7 @@  discard block
 block discarded – undo
1956 1956
                         }
1957 1957
 
1958 1958
                         // ----- Compose the full filename
1959
-                        $v_dirlist_descr[$v_dirlist_nb]['filename'] = $v_descr['filename'].'/'.$v_item_handler;
1959
+                        $v_dirlist_descr[$v_dirlist_nb]['filename'] = $v_descr['filename'] . '/' . $v_item_handler;
1960 1960
 
1961 1961
                         // ----- Look for different stored filename
1962 1962
                         // Because the name of the folder was changed, the name of the
@@ -1964,7 +1964,7 @@  discard block
 block discarded – undo
1964 1964
                         if (($v_descr['stored_filename'] != $v_descr['filename'])
1965 1965
                                  && (!isset($p_options[PCLZIP_OPT_REMOVE_ALL_PATH]))) {
1966 1966
                             if ($v_descr['stored_filename'] != '') {
1967
-                                $v_dirlist_descr[$v_dirlist_nb]['new_full_name'] = $v_descr['stored_filename'].'/'.$v_item_handler;
1967
+                                $v_dirlist_descr[$v_dirlist_nb]['new_full_name'] = $v_descr['stored_filename'] . '/' . $v_item_handler;
1968 1968
                             } else {
1969 1969
                                 $v_dirlist_descr[$v_dirlist_nb]['new_full_name'] = $v_item_handler;
1970 1970
                             }
@@ -2079,14 +2079,14 @@  discard block
 block discarded – undo
2079 2079
         @rewind($this->zip_fd);
2080 2080
 
2081 2081
         // ----- Creates a temporay file
2082
-        $v_zip_temp_name = PCLZIP_TEMPORARY_DIR.uniqid('pclzip-').'.tmp';
2082
+        $v_zip_temp_name = PCLZIP_TEMPORARY_DIR . uniqid('pclzip-') . '.tmp';
2083 2083
 
2084 2084
         // ----- Open the temporary file in write mode
2085 2085
         if (($v_zip_temp_fd = @fopen($v_zip_temp_name, 'wb')) == 0) {
2086 2086
             $this->privCloseFd();
2087 2087
             $this->privSwapBackMagicQuotes();
2088 2088
 
2089
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \''.$v_zip_temp_name.'\' in binary write mode');
2089
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \'' . $v_zip_temp_name . '\' in binary write mode');
2090 2090
 
2091 2091
             // ----- Return
2092 2092
             return self::errorCode();
@@ -2159,10 +2159,10 @@  discard block
 block discarded – undo
2159 2159
             $v_comment = $p_options[PCLZIP_OPT_COMMENT];
2160 2160
         }
2161 2161
         if (isset($p_options[PCLZIP_OPT_ADD_COMMENT])) {
2162
-            $v_comment = $v_comment.$p_options[PCLZIP_OPT_ADD_COMMENT];
2162
+            $v_comment = $v_comment . $p_options[PCLZIP_OPT_ADD_COMMENT];
2163 2163
         }
2164 2164
         if (isset($p_options[PCLZIP_OPT_PREPEND_COMMENT])) {
2165
-            $v_comment = $p_options[PCLZIP_OPT_PREPEND_COMMENT].$v_comment;
2165
+            $v_comment = $p_options[PCLZIP_OPT_PREPEND_COMMENT] . $v_comment;
2166 2166
         }
2167 2167
 
2168 2168
         // ----- Calculate the size of the central header
@@ -2218,7 +2218,7 @@  discard block
 block discarded – undo
2218 2218
         // ----- Look if already open
2219 2219
         if ($this->zip_fd != 0) {
2220 2220
             // ----- Error log
2221
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Zip file \''.$this->zipname.'\' already open');
2221
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Zip file \'' . $this->zipname . '\' already open');
2222 2222
 
2223 2223
             // ----- Return
2224 2224
             return self::errorCode();
@@ -2227,7 +2227,7 @@  discard block
 block discarded – undo
2227 2227
         // ----- Open the zip file
2228 2228
         if (($this->zip_fd = @fopen($this->zipname, $p_mode)) == 0) {
2229 2229
             // ----- Error log
2230
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \''.$this->zipname.'\' in '.$p_mode.' mode');
2230
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \'' . $this->zipname . '\' in ' . $p_mode . ' mode');
2231 2231
 
2232 2232
             // ----- Return
2233 2233
             return self::errorCode();
@@ -2353,7 +2353,7 @@  discard block
 block discarded – undo
2353 2353
 
2354 2354
             // ----- Check the filename
2355 2355
             if (($p_filedescr_list[$j]['type'] != 'virtual_file') && (!file_exists($p_filedescr_list[$j]['filename']))) {
2356
-                self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "File '".$p_filedescr_list[$j]['filename']."' does not exist");
2356
+                self::privErrorLog(PCLZIP_ERR_MISSING_FILE, "File '" . $p_filedescr_list[$j]['filename'] . "' does not exist");
2357 2357
 
2358 2358
                 return self::errorCode();
2359 2359
             }
@@ -2647,10 +2647,10 @@  discard block
 block discarded – undo
2647 2647
         }
2648 2648
 
2649 2649
         // ----- Creates a compressed temporary file
2650
-        $v_gzip_temp_name = PCLZIP_TEMPORARY_DIR.uniqid('pclzip-').'.gz';
2650
+        $v_gzip_temp_name = PCLZIP_TEMPORARY_DIR . uniqid('pclzip-') . '.gz';
2651 2651
         if (($v_file_compressed = @gzopen($v_gzip_temp_name, 'wb')) == 0) {
2652 2652
             fclose($v_file);
2653
-            self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, 'Unable to open temporary file \''.$v_gzip_temp_name.'\' in binary write mode');
2653
+            self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, 'Unable to open temporary file \'' . $v_gzip_temp_name . '\' in binary write mode');
2654 2654
 
2655 2655
             return self::errorCode();
2656 2656
         }
@@ -2671,14 +2671,14 @@  discard block
 block discarded – undo
2671 2671
 
2672 2672
         // ----- Check the minimum file size
2673 2673
         if (filesize($v_gzip_temp_name) < 18) {
2674
-            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'gzip temporary file \''.$v_gzip_temp_name.'\' has invalid filesize - should be minimum 18 bytes');
2674
+            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'gzip temporary file \'' . $v_gzip_temp_name . '\' has invalid filesize - should be minimum 18 bytes');
2675 2675
 
2676 2676
             return self::errorCode();
2677 2677
         }
2678 2678
 
2679 2679
         // ----- Extract the compressed attributes
2680 2680
         if (($v_file_compressed = @fopen($v_gzip_temp_name, 'rb')) == 0) {
2681
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \''.$v_gzip_temp_name.'\' in binary read mode');
2681
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \'' . $v_gzip_temp_name . '\' in binary read mode');
2682 2682
 
2683 2683
             return self::errorCode();
2684 2684
         }
@@ -2711,7 +2711,7 @@  discard block
 block discarded – undo
2711 2711
 
2712 2712
         // ----- Add the compressed data
2713 2713
         if (($v_file_compressed = @fopen($v_gzip_temp_name, 'rb')) == 0) {
2714
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \''.$v_gzip_temp_name.'\' in binary read mode');
2714
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \'' . $v_gzip_temp_name . '\' in binary read mode');
2715 2715
 
2716 2716
             return self::errorCode();
2717 2717
         }
@@ -2779,9 +2779,9 @@  discard block
 block discarded – undo
2779 2779
                 $v_path_info = pathinfo($p_filename);
2780 2780
                 $v_dir = '';
2781 2781
                 if ($v_path_info['dirname'] != '') {
2782
-                    $v_dir = $v_path_info['dirname'].'/';
2782
+                    $v_dir = $v_path_info['dirname'] . '/';
2783 2783
                 }
2784
-                $v_stored_filename = $v_dir.$p_filedescr['new_short_name'];
2784
+                $v_stored_filename = $v_dir . $p_filedescr['new_short_name'];
2785 2785
             } else {
2786 2786
                 // ----- Calculate the stored filename
2787 2787
                 $v_stored_filename = $p_filename;
@@ -2798,7 +2798,7 @@  discard block
 block discarded – undo
2798 2798
 
2799 2799
                 if ((substr($p_filename, 0, 2) == './') || (substr($p_remove_dir, 0, 2) == './')) {
2800 2800
                     if ((substr($p_filename, 0, 2) == './') && (substr($p_remove_dir, 0, 2) != './')) {
2801
-                        $p_remove_dir = './'.$p_remove_dir;
2801
+                        $p_remove_dir = './' . $p_remove_dir;
2802 2802
                     }
2803 2803
                     if ((substr($p_filename, 0, 2) != './') && (substr($p_remove_dir, 0, 2) == './')) {
2804 2804
                         $p_remove_dir = substr($p_remove_dir, 2);
@@ -2821,9 +2821,9 @@  discard block
 block discarded – undo
2821 2821
             // ----- Look for path to add
2822 2822
             if ($p_add_dir != '') {
2823 2823
                 if (substr($p_add_dir, -1) == '/') {
2824
-                    $v_stored_filename = $p_add_dir.$v_stored_filename;
2824
+                    $v_stored_filename = $p_add_dir . $v_stored_filename;
2825 2825
                 } else {
2826
-                    $v_stored_filename = $p_add_dir.'/'.$v_stored_filename;
2826
+                    $v_stored_filename = $p_add_dir . '/' . $v_stored_filename;
2827 2827
                 }
2828 2828
             }
2829 2829
         }
@@ -2960,7 +2960,7 @@  discard block
 block discarded – undo
2960 2960
             $this->privSwapBackMagicQuotes();
2961 2961
 
2962 2962
             // ----- Error log
2963
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \''.$this->zipname.'\' in binary read mode');
2963
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \'' . $this->zipname . '\' in binary read mode');
2964 2964
 
2965 2965
             // ----- Return
2966 2966
             return self::errorCode();
@@ -3079,7 +3079,7 @@  discard block
 block discarded – undo
3079 3079
 
3080 3080
         // ----- Check the path
3081 3081
         if (($p_path == '') || ((substr($p_path, 0, 1) != '/') && (substr($p_path, 0, 3) != '../') && (substr($p_path, 1, 2) != ':/'))) {
3082
-            $p_path = './'.$p_path;
3082
+            $p_path = './' . $p_path;
3083 3083
         }
3084 3084
 
3085 3085
         // ----- Reduce the path last (and duplicated) '/'
@@ -3200,7 +3200,7 @@  discard block
 block discarded – undo
3200 3200
                 if ((isset($p_options[PCLZIP_OPT_STOP_ON_ERROR])) && ($p_options[PCLZIP_OPT_STOP_ON_ERROR] === true)) {
3201 3201
                     $this->privSwapBackMagicQuotes();
3202 3202
 
3203
-                    self::privErrorLog(PCLZIP_ERR_UNSUPPORTED_COMPRESSION, "Filename '".$v_header['stored_filename']."' is compressed by an unsupported compression method (".$v_header['compression'].') ');
3203
+                    self::privErrorLog(PCLZIP_ERR_UNSUPPORTED_COMPRESSION, "Filename '" . $v_header['stored_filename'] . "' is compressed by an unsupported compression method (" . $v_header['compression'] . ') ');
3204 3204
 
3205 3205
                     return self::errorCode();
3206 3206
                 }
@@ -3213,7 +3213,7 @@  discard block
 block discarded – undo
3213 3213
                 if ((isset($p_options[PCLZIP_OPT_STOP_ON_ERROR])) && ($p_options[PCLZIP_OPT_STOP_ON_ERROR] === true)) {
3214 3214
                     $this->privSwapBackMagicQuotes();
3215 3215
 
3216
-                    self::privErrorLog(PCLZIP_ERR_UNSUPPORTED_ENCRYPTION, "Unsupported encryption for  filename '".$v_header['stored_filename']."'");
3216
+                    self::privErrorLog(PCLZIP_ERR_UNSUPPORTED_ENCRYPTION, "Unsupported encryption for  filename '" . $v_header['stored_filename'] . "'");
3217 3217
 
3218 3218
                     return self::errorCode();
3219 3219
                 }
@@ -3395,14 +3395,14 @@  discard block
 block discarded – undo
3395 3395
 
3396 3396
         // ----- Add the path
3397 3397
         if ($p_path != '') {
3398
-            $p_entry['filename'] = $p_path.'/'.$p_entry['filename'];
3398
+            $p_entry['filename'] = $p_path . '/' . $p_entry['filename'];
3399 3399
         }
3400 3400
 
3401 3401
         // ----- Check a base_dir_restriction
3402 3402
         if (isset($p_options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION])) {
3403 3403
             $v_inclusion = PclZipUtilPathInclusion($p_options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION], $p_entry['filename']);
3404 3404
             if ($v_inclusion == 0) {
3405
-                self::privErrorLog(PCLZIP_ERR_DIRECTORY_RESTRICTION, "Filename '".$p_entry['filename']."' is outside PCLZIP_OPT_EXTRACT_DIR_RESTRICTION");
3405
+                self::privErrorLog(PCLZIP_ERR_DIRECTORY_RESTRICTION, "Filename '" . $p_entry['filename'] . "' is outside PCLZIP_OPT_EXTRACT_DIR_RESTRICTION");
3406 3406
 
3407 3407
                 return self::errorCode();
3408 3408
             }
@@ -3450,7 +3450,7 @@  discard block
 block discarded – undo
3450 3450
                     // For historical reason first PclZip implementation does not stop
3451 3451
                     // when this kind of error occurs.
3452 3452
                     if ((isset($p_options[PCLZIP_OPT_STOP_ON_ERROR])) && ($p_options[PCLZIP_OPT_STOP_ON_ERROR] === true)) {
3453
-                        self::privErrorLog(PCLZIP_ERR_ALREADY_A_DIRECTORY, "Filename '".$p_entry['filename']."' is already used by an existing directory");
3453
+                        self::privErrorLog(PCLZIP_ERR_ALREADY_A_DIRECTORY, "Filename '" . $p_entry['filename'] . "' is already used by an existing directory");
3454 3454
 
3455 3455
                         return self::errorCode();
3456 3456
                     }
@@ -3463,7 +3463,7 @@  discard block
 block discarded – undo
3463 3463
                     // For historical reason first PclZip implementation does not stop
3464 3464
                     // when this kind of error occurs.
3465 3465
                     if ((isset($p_options[PCLZIP_OPT_STOP_ON_ERROR])) && ($p_options[PCLZIP_OPT_STOP_ON_ERROR] === true)) {
3466
-                        self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, "Filename '".$p_entry['filename']."' exists and is write protected");
3466
+                        self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, "Filename '" . $p_entry['filename'] . "' exists and is write protected");
3467 3467
 
3468 3468
                         return self::errorCode();
3469 3469
                     }
@@ -3478,7 +3478,7 @@  discard block
 block discarded – undo
3478 3478
                         // For historical reason first PclZip implementation does not stop
3479 3479
                         // when this kind of error occurs.
3480 3480
                         if ((isset($p_options[PCLZIP_OPT_STOP_ON_ERROR])) && ($p_options[PCLZIP_OPT_STOP_ON_ERROR] === true)) {
3481
-                            self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, "Newer version of '".$p_entry['filename']."' exists and option PCLZIP_OPT_REPLACE_NEWER is not selected");
3481
+                            self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, "Newer version of '" . $p_entry['filename'] . "' exists and option PCLZIP_OPT_REPLACE_NEWER is not selected");
3482 3482
 
3483 3483
                             return self::errorCode();
3484 3484
                         }
@@ -3543,7 +3543,7 @@  discard block
 block discarded – undo
3543 3543
                     // ----- TBC
3544 3544
                     // Need to be finished
3545 3545
                     if (($p_entry['flag'] & 1) == 1) {
3546
-                        self::privErrorLog(PCLZIP_ERR_UNSUPPORTED_ENCRYPTION, 'File \''.$p_entry['filename'].'\' is encrypted. Encrypted files are not supported.');
3546
+                        self::privErrorLog(PCLZIP_ERR_UNSUPPORTED_ENCRYPTION, 'File \'' . $p_entry['filename'] . '\' is encrypted. Encrypted files are not supported.');
3547 3547
 
3548 3548
                         return self::errorCode();
3549 3549
                     }
@@ -3635,10 +3635,10 @@  discard block
 block discarded – undo
3635 3635
         $v_result = 1;
3636 3636
 
3637 3637
         // ----- Creates a temporary file
3638
-        $v_gzip_temp_name = PCLZIP_TEMPORARY_DIR.uniqid('pclzip-').'.gz';
3638
+        $v_gzip_temp_name = PCLZIP_TEMPORARY_DIR . uniqid('pclzip-') . '.gz';
3639 3639
         if (($v_dest_file = @fopen($v_gzip_temp_name, 'wb')) == 0) {
3640 3640
             fclose($v_file);
3641
-            self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, 'Unable to open temporary file \''.$v_gzip_temp_name.'\' in binary write mode');
3641
+            self::privErrorLog(PCLZIP_ERR_WRITE_OPEN_FAIL, 'Unable to open temporary file \'' . $v_gzip_temp_name . '\' in binary write mode');
3642 3642
 
3643 3643
             return self::errorCode();
3644 3644
         }
@@ -3675,7 +3675,7 @@  discard block
 block discarded – undo
3675 3675
         if (($v_src_file = @gzopen($v_gzip_temp_name, 'rb')) == 0) {
3676 3676
             @fclose($v_dest_file);
3677 3677
             $p_entry['status'] = 'read_error';
3678
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \''.$v_gzip_temp_name.'\' in binary read mode');
3678
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \'' . $v_gzip_temp_name . '\' in binary read mode');
3679 3679
 
3680 3680
             return self::errorCode();
3681 3681
         }
@@ -3944,7 +3944,7 @@  discard block
 block discarded – undo
3944 3944
             $p_header['status'] = 'invalid_header';
3945 3945
 
3946 3946
             // ----- Error log
3947
-            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Invalid block size : '.strlen($v_binary_data));
3947
+            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Invalid block size : ' . strlen($v_binary_data));
3948 3948
 
3949 3949
             // ----- Return
3950 3950
             return self::errorCode();
@@ -4039,7 +4039,7 @@  discard block
 block discarded – undo
4039 4039
             $p_header['status'] = 'invalid_header';
4040 4040
 
4041 4041
             // ----- Error log
4042
-            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Invalid block size : '.strlen($v_binary_data));
4042
+            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Invalid block size : ' . strlen($v_binary_data));
4043 4043
 
4044 4044
             // ----- Return
4045 4045
             return self::errorCode();
@@ -4162,7 +4162,7 @@  discard block
 block discarded – undo
4162 4162
         @fseek($this->zip_fd, $v_size);
4163 4163
         if (@ftell($this->zip_fd) != $v_size) {
4164 4164
             // ----- Error log
4165
-            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Unable to go to the end of the archive \''.$this->zipname.'\'');
4165
+            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Unable to go to the end of the archive \'' . $this->zipname . '\'');
4166 4166
 
4167 4167
             // ----- Return
4168 4168
             return self::errorCode();
@@ -4175,7 +4175,7 @@  discard block
 block discarded – undo
4175 4175
             @fseek($this->zip_fd, $v_size - 22);
4176 4176
             if (($v_pos = @ftell($this->zip_fd)) != ($v_size - 22)) {
4177 4177
                 // ----- Error log
4178
-                self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \''.$this->zipname.'\'');
4178
+                self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \'' . $this->zipname . '\'');
4179 4179
 
4180 4180
                 // ----- Return
4181 4181
                 return self::errorCode();
@@ -4202,7 +4202,7 @@  discard block
 block discarded – undo
4202 4202
             @fseek($this->zip_fd, $v_size - $v_maximum_size);
4203 4203
             if (@ftell($this->zip_fd) != ($v_size - $v_maximum_size)) {
4204 4204
                 // ----- Error log
4205
-                self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \''.$this->zipname.'\'');
4205
+                self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \'' . $this->zipname . '\'');
4206 4206
 
4207 4207
                 // ----- Return
4208 4208
                 return self::errorCode();
@@ -4246,7 +4246,7 @@  discard block
 block discarded – undo
4246 4246
         // ----- Look for invalid block size
4247 4247
         if (strlen($v_binary_data) != 18) {
4248 4248
             // ----- Error log
4249
-            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Invalid End of Central Dir Record size : '.strlen($v_binary_data));
4249
+            self::privErrorLog(PCLZIP_ERR_BAD_FORMAT, 'Invalid End of Central Dir Record size : ' . strlen($v_binary_data));
4250 4250
 
4251 4251
             // ----- Return
4252 4252
             return self::errorCode();
@@ -4364,7 +4364,7 @@  discard block
 block discarded – undo
4364 4364
                         // ----- Look if the directory is in the filename path
4365 4365
                         if ((strlen($v_header_list[$v_nb_extracted]['stored_filename']) > strlen($p_options[PCLZIP_OPT_BY_NAME][$j])) && (substr($v_header_list[$v_nb_extracted]['stored_filename'], 0, strlen($p_options[PCLZIP_OPT_BY_NAME][$j])) == $p_options[PCLZIP_OPT_BY_NAME][$j])) {
4366 4366
                             $v_found = true;
4367
-                        } elseif ((($v_header_list[$v_nb_extracted]['external'] & 0x00000010) == 0x00000010) /* Indicates a folder */ && ($v_header_list[$v_nb_extracted]['stored_filename'].'/' == $p_options[PCLZIP_OPT_BY_NAME][$j])) {
4367
+                        } elseif ((($v_header_list[$v_nb_extracted]['external'] & 0x00000010) == 0x00000010) /* Indicates a folder */ && ($v_header_list[$v_nb_extracted]['stored_filename'] . '/' == $p_options[PCLZIP_OPT_BY_NAME][$j])) {
4368 4368
                             $v_found = true;
4369 4369
                         }
4370 4370
                     } elseif ($v_header_list[$v_nb_extracted]['stored_filename'] == $p_options[PCLZIP_OPT_BY_NAME][$j]) {
@@ -4406,7 +4406,7 @@  discard block
 block discarded – undo
4406 4406
         // ----- Look if something need to be deleted
4407 4407
         if ($v_nb_extracted > 0) {
4408 4408
             // ----- Creates a temporay file
4409
-            $v_zip_temp_name = PCLZIP_TEMPORARY_DIR.uniqid('pclzip-').'.tmp';
4409
+            $v_zip_temp_name = PCLZIP_TEMPORARY_DIR . uniqid('pclzip-') . '.tmp';
4410 4410
 
4411 4411
             // ----- Creates a temporary zip archive
4412 4412
             $v_temp_zip = new self($v_zip_temp_name);
@@ -4671,14 +4671,14 @@  discard block
 block discarded – undo
4671 4671
         @rewind($p_archive_to_add->zip_fd);
4672 4672
 
4673 4673
         // ----- Creates a temporay file
4674
-        $v_zip_temp_name = PCLZIP_TEMPORARY_DIR.uniqid('pclzip-').'.tmp';
4674
+        $v_zip_temp_name = PCLZIP_TEMPORARY_DIR . uniqid('pclzip-') . '.tmp';
4675 4675
 
4676 4676
         // ----- Open the temporary file in write mode
4677 4677
         if (($v_zip_temp_fd = @fopen($v_zip_temp_name, 'wb')) == 0) {
4678 4678
             $this->privCloseFd();
4679 4679
             $p_archive_to_add->privCloseFd();
4680 4680
 
4681
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \''.$v_zip_temp_name.'\' in binary write mode');
4681
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \'' . $v_zip_temp_name . '\' in binary write mode');
4682 4682
 
4683 4683
             // ----- Return
4684 4684
             return self::errorCode();
@@ -4725,7 +4725,7 @@  discard block
 block discarded – undo
4725 4725
         }
4726 4726
 
4727 4727
         // ----- Merge the file comments
4728
-        $v_comment = $v_central_dir['comment'].' '.$v_central_dir_to_add['comment'];
4728
+        $v_comment = $v_central_dir['comment'] . ' ' . $v_central_dir_to_add['comment'];
4729 4729
 
4730 4730
         // ----- Calculate the size of the (new) central header
4731 4731
         $v_size = @ftell($v_zip_temp_fd) - $v_offset;
@@ -4806,7 +4806,7 @@  discard block
 block discarded – undo
4806 4806
         if (($v_zip_temp_fd = @fopen($p_archive_filename, 'rb')) == 0) {
4807 4807
             $this->privCloseFd();
4808 4808
 
4809
-            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive file \''.$p_archive_filename.'\' in binary write mode');
4809
+            self::privErrorLog(PCLZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive file \'' . $p_archive_filename . '\' in binary write mode');
4810 4810
 
4811 4811
             // ----- Return
4812 4812
             return self::errorCode();
@@ -4958,7 +4958,7 @@  discard block
 block discarded – undo
4958 4958
             } elseif ($v_list[$i] == '') {
4959 4959
                 // ----- First '/' i.e. root slash
4960 4960
                 if ($i == 0) {
4961
-                    $v_result = '/'.$v_result;
4961
+                    $v_result = '/' . $v_result;
4962 4962
                     if ($v_skip > 0) {
4963 4963
                         // ----- It is an invalid path, so the path is not modified
4964 4964
                         // TBC
@@ -4978,7 +4978,7 @@  discard block
 block discarded – undo
4978 4978
                 if ($v_skip > 0) {
4979 4979
                     --$v_skip;
4980 4980
                 } else {
4981
-                    $v_result = $v_list[$i].($i != (sizeof($v_list) - 1) ? '/'.$v_result : '');
4981
+                    $v_result = $v_list[$i] . ($i != (sizeof($v_list) - 1) ? '/' . $v_result : '');
4982 4982
                 }
4983 4983
             }
4984 4984
         }
@@ -4986,7 +4986,7 @@  discard block
 block discarded – undo
4986 4986
         // ----- Look for skip
4987 4987
         if ($v_skip > 0) {
4988 4988
             while ($v_skip > 0) {
4989
-                $v_result = '../'.$v_result;
4989
+                $v_result = '../' . $v_result;
4990 4990
                 --$v_skip;
4991 4991
             }
4992 4992
         }
@@ -5018,10 +5018,10 @@  discard block
 block discarded – undo
5018 5018
 
5019 5019
     // ----- Look for path beginning by ./
5020 5020
     if (($p_dir == '.') || ((strlen($p_dir) >= 2) && (substr($p_dir, 0, 2) == './'))) {
5021
-        $p_dir = PclZipUtilTranslateWinPath(getcwd(), false).'/'.substr($p_dir, 1);
5021
+        $p_dir = PclZipUtilTranslateWinPath(getcwd(), false) . '/' . substr($p_dir, 1);
5022 5022
     }
5023 5023
     if (($p_path == '.') || ((strlen($p_path) >= 2) && (substr($p_path, 0, 2) == './'))) {
5024
-        $p_path = PclZipUtilTranslateWinPath(getcwd(), false).'/'.substr($p_path, 1);
5024
+        $p_path = PclZipUtilTranslateWinPath(getcwd(), false) . '/' . substr($p_path, 1);
5025 5025
     }
5026 5026
 
5027 5027
     // ----- Explode dir and path by directory separator
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/Trend/BestFit.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -316,6 +316,10 @@
 block discarded – undo
316 316
         return $this->yBestFitValues;
317 317
     }
318 318
 
319
+    /**
320
+     * @param double $sumY2
321
+     * @param boolean $const
322
+     */
319 323
     protected function calculateGoodnessOfFit($sumX, $sumY, $sumX2, $sumY2, $sumXY, $meanX, $meanY, $const)
320 324
     {
321 325
         $SSres = $SScov = $SScor = $SStot = $SSsex = 0.0;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Style.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
     /**
148 148
      * Get parent. Only used for style supervisor
149 149
      *
150
-     * @return Spreadsheet
150
+     * @return Style
151 151
      */
152 152
     public function getParent()
153 153
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
                                 $rangeStart[1] : $rangeEnd[1] - $yMax + $y;
328 328
 
329 329
                             // build range for region
330
-                            $range = $colStart.$rowStart.':'.$colEnd.$rowEnd;
330
+                            $range = $colStart . $rowStart . ':' . $colEnd . $rowEnd;
331 331
 
332 332
                             // retrieve relevant style array for region
333 333
                             $regionStyles = $pStyles;
@@ -630,14 +630,14 @@  discard block
 block discarded – undo
630 630
         }
631 631
 
632 632
         return md5(
633
-            $this->fill->getHashCode().
634
-            $this->font->getHashCode().
635
-            $this->borders->getHashCode().
636
-            $this->alignment->getHashCode().
637
-            $this->numberFormat->getHashCode().
638
-            $hashConditionals.
639
-            $this->protection->getHashCode().
640
-            ($this->quotePrefix ? 't' : 'f').
633
+            $this->fill->getHashCode() .
634
+            $this->font->getHashCode() .
635
+            $this->borders->getHashCode() .
636
+            $this->alignment->getHashCode() .
637
+            $this->numberFormat->getHashCode() .
638
+            $hashConditionals .
639
+            $this->protection->getHashCode() .
640
+            ($this->quotePrefix ? 't' : 'f') .
641 641
             __CLASS__
642 642
         );
643 643
     }
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/AutoFilter.php 2 patches
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -567,6 +567,11 @@
 block discarded – undo
567 567
         return ['method' => 'filterTestInCustomDataSet', 'arguments' => ['filterRules' => $ruleValues, 'join' => AutoFilter\Column::AUTOFILTER_COLUMN_JOIN_AND]];
568 568
     }
569 569
 
570
+    /**
571
+     * @param integer $columnID
572
+     * @param integer $startRow
573
+     * @param string $ruleType
574
+     */
570 575
     private function calculateTopTenValue($columnID, $startRow, $endRow, $ruleType, $ruleValue)
571 576
     {
572 577
         $range = $columnID . $startRow . ':' . $columnID . $endRow;
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -425,7 +425,7 @@  discard block
 block discarded – undo
425 425
                 }
426 426
             } else {
427 427
                 //    String values are always tested for equality, factoring in for wildcards (hence a regexp test)
428
-                $retVal = preg_match('/^'.$rule['value'].'$/i', $cellValue);
428
+                $retVal = preg_match('/^' . $rule['value'] . '$/i', $cellValue);
429 429
             }
430 430
             //    If there are multiple conditions, then we need to test both using the appropriate join operator
431 431
             switch ($join) {
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
 
592 592
     private function calculateTopTenValue($columnID, $startRow, $endRow, $ruleType, $ruleValue)
593 593
     {
594
-        $range = $columnID.$startRow.':'.$columnID.$endRow;
594
+        $range = $columnID . $startRow . ':' . $columnID . $endRow;
595 595
         $dataValues = \PhpOffice\PhpSpreadsheet\Calculation\Functions::flattenArray($this->workSheet->rangeToArray($range, null, true, false));
596 596
 
597 597
         $dataValues = array_filter($dataValues);
@@ -674,7 +674,7 @@  discard block
 block discarded – undo
674 674
                                 ($ruleValue[AutoFilter\Column\Rule::AUTOFILTER_RULETYPE_DATEGROUP_SECOND] !== '')) {
675 675
                                 $time .= sprintf('%02d', $ruleValue[AutoFilter\Column\Rule::AUTOFILTER_RULETYPE_DATEGROUP_SECOND]);
676 676
                             }
677
-                            $dateTime = $date.$time;
677
+                            $dateTime = $date . $time;
678 678
                             $arguments['date'][] = $date;
679 679
                             $arguments['time'][] = $time;
680 680
                             $arguments['dateTime'][] = $dateTime;
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
722 722
                             ($dynamicRuleType == AutoFilter\Column\Rule::AUTOFILTER_RULETYPE_DYNAMIC_BELOWAVERAGE)) {
723 723
                             //    Number (Average) based
724 724
                             //    Calculate the average
725
-                            $averageFormula = '=AVERAGE('.$columnID.($rangeStart[1] + 1).':'.$columnID.$rangeEnd[1].')';
725
+                            $averageFormula = '=AVERAGE(' . $columnID . ($rangeStart[1] + 1) . ':' . $columnID . $rangeEnd[1] . ')';
726 726
                             $average = \PhpOffice\PhpSpreadsheet\Calculation::getInstance()->calculateFormula($averageFormula, null, $this->workSheet->getCell('A1'));
727 727
                             //    Set above/below rule based on greaterThan or LessTan
728 728
                             $operator = ($dynamicRuleType === AutoFilter\Column\Rule::AUTOFILTER_RULETYPE_DYNAMIC_ABOVEAVERAGE)
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
800 800
         for ($row = $rangeStart[1] + 1; $row <= $rangeEnd[1]; ++$row) {
801 801
             $result = true;
802 802
             foreach ($columnFilterTests as $columnID => $columnFilterTest) {
803
-                $cellValue = $this->workSheet->getCell($columnID.$row)->getCalculatedValue();
803
+                $cellValue = $this->workSheet->getCell($columnID . $row)->getCalculatedValue();
804 804
                 //    Execute the filter test
805 805
                 $result = $result &&
806 806
                     call_user_func_array(
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/ColumnDimension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
     /**
102 102
      * Set Row Height
103 103
      *
104
-     * @param float $pValue
104
+     * @param integer $pValue
105 105
      * @return RowDimension
106 106
      */
107 107
     public function setRowHeight($pValue = -1)
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Shared/StringTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
     public function testGetCurrencyCode()
66 66
     {
67 67
         $localeconv = localeconv();
68
-        $expectedResult = (!empty($localeconv['currency_symbol']) ? $localeconv['currency_symbol'] : (!empty($localeconv['int_curr_symbol']) ? $localeconv['int_curr_symbol']: '$'));
68
+        $expectedResult = (!empty($localeconv['currency_symbol']) ? $localeconv['currency_symbol'] : (!empty($localeconv['int_curr_symbol']) ? $localeconv['int_curr_symbol'] : '$'));
69 69
         $result = call_user_func([StringHelper::class, 'getCurrencyCode']);
70 70
         $this->assertEquals($expectedResult, $result);
71 71
     }
Please login to merge, or discard this patch.