Inspection of "Merge branch 'feature/gh-7' into develop" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( bf3457...467bab )

unknown

created 2016-08-14 23:21 UTC

Status

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 ini_set('display_errors', TRUE);
 ini_set('display_startup_errors', TRUE);
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 date_default_timezone_set('Europe/London');
 
@@ -39,14 +39,14 @@  discard block
 block discarded – undo
 
 
 
-echo date('H:i:s') , " Load from Excel5 template" , EOL;
+echo date('H:i:s'), " Load from Excel5 template", EOL;
 $objReader = \PHPExcel\IOFactory::createReader('Excel5');
 $objPHPExcel = $objReader->load("templates/30template.xls");
 
 
 
 
-echo date('H:i:s') , " Add new data to the template" , EOL;
+echo date('H:i:s'), " Add new data to the template", EOL;
 $data = array(array('title'		=> 'Excel for dummies',
 					'price'		=> 17.99,
 					'quantity'	=> 2
@@ -64,28 +64,28 @@  discard block
 block discarded – undo
 $objPHPExcel->getActiveSheet()->setCellValue('D1', \PHPExcel\Shared\Date::PHPToExcel(time()));
 
 $baseRow = 5;
-foreach($data as $r => $dataRow) {
+foreach ($data as $r => $dataRow) {
 	$row = $baseRow + $r;
-	$objPHPExcel->getActiveSheet()->insertNewRowBefore($row,1);
+	$objPHPExcel->getActiveSheet()->insertNewRowBefore($row, 1);
 
-	$objPHPExcel->getActiveSheet()->setCellValue('A'.$row, $r+1)
-	                              ->setCellValue('B'.$row, $dataRow['title'])
-	                              ->setCellValue('C'.$row, $dataRow['price'])
-	                              ->setCellValue('D'.$row, $dataRow['quantity'])
-	                              ->setCellValue('E'.$row, '=C'.$row.'*D'.$row);
+	$objPHPExcel->getActiveSheet()->setCellValue('A' . $row, $r + 1)
+	                              ->setCellValue('B' . $row, $dataRow['title'])
+	                              ->setCellValue('C' . $row, $dataRow['price'])
+	                              ->setCellValue('D' . $row, $dataRow['quantity'])
+	                              ->setCellValue('E' . $row, '=C' . $row . '*D' . $row);
 }
-$objPHPExcel->getActiveSheet()->removeRow($baseRow-1,1);
+$objPHPExcel->getActiveSheet()->removeRow($baseRow - 1, 1);
 
 
-echo date('H:i:s') , " Write to Excel5 format" , EOL;
+echo date('H:i:s'), " Write to Excel5 format", EOL;
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel5');
 $objWriter->save(str_replace('.php', '.xls', __FILE__));
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
 
 // Echo done
-echo date('H:i:s') , " Done writing file" , EOL;
-echo 'File has been created in ' , getcwd() , EOL;
+echo date('H:i:s'), " Done writing file", EOL;
+echo 'File has been created in ', getcwd(), EOL;

Please login to merge, or discard this patch.

Examples/32chartreadwrite.php 1 patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

@@ -6,7 +6,7 @@  discard block
 block discarded – undo
 ini_set('display_startup_errors', TRUE);
 date_default_timezone_set('Europe/London');
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 date_default_timezone_set('Europe/London');
 
@@ -18,63 +18,63 @@  discard block
 block discarded – undo
 
 if ((isset($argc)) && ($argc > 1)) {
 	$inputFileNames = array();
-	for($i = 1; $i < $argc; ++$i) {
+	for ($i = 1; $i < $argc; ++$i) {
 		$inputFileNames[] = dirname(__FILE__) . '/templates/' . $argv[$i];
 	}
 } else {
 	$inputFileNames = glob($inputFileNames);
 }
-foreach($inputFileNames as $inputFileName) {
+foreach ($inputFileNames as $inputFileName) {
 	$inputFileNameShort = basename($inputFileName);
 
 	if (!file_exists($inputFileName)) {
-		echo date('H:i:s') , " File " , $inputFileNameShort , ' does not exist' , EOL;
+		echo date('H:i:s'), " File ", $inputFileNameShort, ' does not exist', EOL;
 		continue;
 	}
 
-	echo date('H:i:s') , " Load Test from $inputFileType file " , $inputFileNameShort , EOL;
+	echo date('H:i:s'), " Load Test from $inputFileType file ", $inputFileNameShort, EOL;
 
 	$objReader = \PHPExcel\IOFactory::createReader($inputFileType);
 	$objReader->setIncludeCharts(TRUE);
 	$objPHPExcel = $objReader->load($inputFileName);
 
 
-	echo date('H:i:s') , " Iterate worksheets looking at the charts" , EOL;
+	echo date('H:i:s'), " Iterate worksheets looking at the charts", EOL;
 	foreach ($objPHPExcel->getWorksheetIterator() as $worksheet) {
 		$sheetName = $worksheet->getTitle();
-		echo 'Worksheet: ' , $sheetName , EOL;
+		echo 'Worksheet: ', $sheetName, EOL;
 
 		$chartNames = $worksheet->getChartNames();
-		if(empty($chartNames)) {
-			echo '    There are no charts in this worksheet' , EOL;
+		if (empty($chartNames)) {
+			echo '    There are no charts in this worksheet', EOL;
 		} else {
 			natsort($chartNames);
-			foreach($chartNames as $i => $chartName) {
+			foreach ($chartNames as $i => $chartName) {
 				$chart = $worksheet->getChartByName($chartName);
 				if (!is_null($chart->getTitle())) {
-					$caption = '"' . implode(' ',$chart->getTitle()->getCaption()) . '"';
+					$caption = '"' . implode(' ', $chart->getTitle()->getCaption()) . '"';
 				} else {
 					$caption = 'Untitled';
 				}
-				echo '    ' , $chartName , ' - ' , $caption , EOL;
-				echo str_repeat(' ',strlen($chartName)+3);
+				echo '    ', $chartName, ' - ', $caption, EOL;
+				echo str_repeat(' ', strlen($chartName) + 3);
 				$groupCount = $chart->getPlotArea()->getPlotGroupCount();
 				if ($groupCount == 1) {
 					$chartType = $chart->getPlotArea()->getPlotGroupByIndex(0)->getPlotType();
-					echo '    ' , $chartType , EOL;
+					echo '    ', $chartType, EOL;
 				} else {
 					$chartTypes = array();
-					for($i = 0; $i < $groupCount; ++$i) {
+					for ($i = 0; $i < $groupCount; ++$i) {
 						$chartTypes[] = $chart->getPlotArea()->getPlotGroupByIndex($i)->getPlotType();
 					}
 					$chartTypes = array_unique($chartTypes);
 					if (count($chartTypes) == 1) {
 						$chartType = 'Multiple Plot ' . array_pop($chartTypes);
-						echo '    ' , $chartType , EOL;
+						echo '    ', $chartType, EOL;
 					} elseif (count($chartTypes) == 0) {
-						echo '    *** Type not yet implemented' , EOL;
+						echo '    *** Type not yet implemented', EOL;
 					} else {
-						echo '    Combination Chart' , EOL;
+						echo '    Combination Chart', EOL;
 					}
 				}
 			}
@@ -84,19 +84,19 @@  discard block
 block discarded – undo
 
 	$outputFileName = basename($inputFileName);
 
-	echo date('H:i:s') , " Write Tests to Excel2007 file " , EOL;
+	echo date('H:i:s'), " Write Tests to Excel2007 file ", EOL;
 	$objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel2007');
 	$objWriter->setIncludeCharts(TRUE);
 	$objWriter->save($outputFileName);
-	echo date('H:i:s') , " File written to " , $outputFileName , EOL;
+	echo date('H:i:s'), " File written to ", $outputFileName, EOL;
 
 	$objPHPExcel->disconnectWorksheets();
 	unset($objPHPExcel);
 }
 
 // Echo memory peak usage
-echo date('H:i:s') , ' Peak memory usage: ' , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Peak memory usage: ', (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
 
 // Echo done
-echo date('H:i:s') , " Done writing files" , EOL;
-echo 'Files have been created in ' , getcwd() , EOL;
+echo date('H:i:s'), " Done writing files", EOL;
+echo 'Files have been created in ', getcwd(), EOL;

Please login to merge, or discard this patch.

Examples/16csv.php 1 patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 ini_set('display_startup_errors', TRUE);
 date_default_timezone_set('Europe/London');
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 date_default_timezone_set('Europe/London');
 
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 require_once dirname(__FILE__) . '/../src/Bootstrap.php';
 
 
-echo date('H:i:s') , " Write to CSV format" , EOL;
+echo date('H:i:s'), " Write to CSV format", EOL;
 $callStartTime = microtime(true);
 
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'CSV')->setDelimiter(',')
@@ -50,13 +50,13 @@  discard block
 block discarded – undo
                                                                   ->save(str_replace('.php', '.csv', __FILE__));
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
-echo date('H:i:s') , " File written to " , str_replace('.php', '.csv', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.csv', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
-echo date('H:i:s') , " Read from CSV format" , EOL;
+echo date('H:i:s'), " Read from CSV format", EOL;
 $callStartTime = microtime(true);
 $objReader = \PHPExcel\IOFactory::createReader('CSV')->setDelimiter(',')
                                                     ->setEnclosure('"')
@@ -65,25 +65,25 @@  discard block
 block discarded – undo
 
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
-echo 'Call time to reload Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo 'Call time to reload Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
-echo date('H:i:s') , " Write to Excel2007 format" , EOL;
+echo date('H:i:s'), " Write to Excel2007 format", EOL;
 $callStartTime = microtime(true);
 
 $objWriter2007 = \PHPExcel\IOFactory::createWriter($objPHPExcelFromCSV, 'Excel2007');
 $objWriter2007->save(str_replace('.php', '.xlsx', __FILE__));
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
-echo date('H:i:s') , " Write to CSV format" , EOL;
+echo date('H:i:s'), " Write to CSV format", EOL;
 $callStartTime = microtime(true);
 
 $objWriterCSV = \PHPExcel\IOFactory::createWriter($objPHPExcelFromCSV, 'CSV');
@@ -91,15 +91,15 @@  discard block
 block discarded – undo
 $objWriterCSV->save(str_replace('.php', '_excel.csv', __FILE__));
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
-echo date('H:i:s') , " File written to " , str_replace('.php', '_excel.csv', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '_excel.csv', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
 
 // Echo done
-echo date('H:i:s') , " Done writing files" , EOL;
-echo 'Files have been created in ' , getcwd() , EOL;
+echo date('H:i:s'), " Done writing files", EOL;
+echo 'Files have been created in ', getcwd(), EOL;

Please login to merge, or discard this patch.

Examples/OOCalcReader.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 /** \PHPExcel\IOFactory */
 require_once dirname(__FILE__) . '/../Classes/PHPExcel/IOFactory.php';
 
-echo date('H:i:s') , " Load from OOCalc file" , PHP_EOL;
+echo date('H:i:s'), " Load from OOCalc file", PHP_EOL;
 $callStartTime = microtime(true);
 
 $objReader = \PHPExcel\IOFactory::createReader('OOCalc');
@@ -42,20 +42,20 @@  discard block
 block discarded – undo
 
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
-echo 'Call time to read Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , PHP_EOL;
+echo 'Call time to read Workbook was ', sprintf('%.4f', $callTime), " seconds", PHP_EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , PHP_EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", PHP_EOL;
 
 
-echo date('H:i:s') , " Write to Excel2007 format" , PHP_EOL;
+echo date('H:i:s'), " Write to Excel2007 format", PHP_EOL;
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel2007');
 $objWriter->save(str_replace('.php', '.xlsx', __FILE__));
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', __FILE__) , PHP_EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', __FILE__), PHP_EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , PHP_EOL;
+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", PHP_EOL;
 
 // Echo done
-echo date('H:i:s') , " Done writing file" , PHP_EOL;
+echo date('H:i:s'), " Done writing file", PHP_EOL;
 

Please login to merge, or discard this patch.

Examples/11documentsecurity.php 1 patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 ini_set('display_errors', TRUE);
 ini_set('display_startup_errors', TRUE);
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 date_default_timezone_set('Europe/London');
 
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
 
 
 // Create new PHPExcel object
-echo date('H:i:s') , " Create new PHPExcel object" , EOL;
+echo date('H:i:s'), " Create new PHPExcel object", EOL;
 $objPHPExcel = new \PHPExcel\Spreadsheet();
 
 // Set document properties
-echo date('H:i:s') , " Set document properties" , EOL;
+echo date('H:i:s'), " Set document properties", EOL;
 $objPHPExcel->getProperties()->setCreator("Maarten Balliauw")
 							 ->setLastModifiedBy("Maarten Balliauw")
 							 ->setTitle("Office 2007 XLSX Test Document")
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 
 
 // Add some data
-echo date('H:i:s') , " Add some data" , EOL;
+echo date('H:i:s'), " Add some data", EOL;
 $objPHPExcel->setActiveSheetIndex(0);
 $objPHPExcel->getActiveSheet()->setCellValue('A1', 'Hello');
 $objPHPExcel->getActiveSheet()->setCellValue('B2', 'world!');
@@ -62,19 +62,19 @@  discard block
 block discarded – undo
 $objPHPExcel->getActiveSheet()->setCellValue('D2', 'world!');
 
 // Rename worksheet
-echo date('H:i:s') , " Rename worksheet" , EOL;
+echo date('H:i:s'), " Rename worksheet", EOL;
 $objPHPExcel->getActiveSheet()->setTitle('Simple');
 
 
 // Set document security
-echo date('H:i:s') , " Set document security" , EOL;
+echo date('H:i:s'), " Set document security", EOL;
 $objPHPExcel->getSecurity()->setLockWindows(true);
 $objPHPExcel->getSecurity()->setLockStructure(true);
 $objPHPExcel->getSecurity()->setWorkbookPassword("PHPExcel");
 
 
 // Set sheet security
-echo date('H:i:s') , " Set sheet security" , EOL;
+echo date('H:i:s'), " Set sheet security", EOL;
 $objPHPExcel->getActiveSheet()->getProtection()->setPassword('PHPExcel');
 $objPHPExcel->getActiveSheet()->getProtection()->setSheet(true); // This should be enabled in order to enable any of the following!
 $objPHPExcel->getActiveSheet()->getProtection()->setSort(true);
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
 
 
 // Save Excel 2007 file
-echo date('H:i:s') , " Write to Excel2007 format" , EOL;
+echo date('H:i:s'), " Write to Excel2007 format", EOL;
 $callStartTime = microtime(true);
 
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel2007');
@@ -95,15 +95,15 @@  discard block
 block discarded – undo
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
 
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
 
 // Echo done
-echo date('H:i:s') , " Done writing file" , EOL;
-echo 'File has been created in ' , getcwd() , EOL;
+echo date('H:i:s'), " Done writing file", EOL;
+echo 'File has been created in ', getcwd(), EOL;

Please login to merge, or discard this patch.

Examples/01simplePCLZip.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -31,18 +31,18 @@  discard block
 block discarded – undo
 ini_set('display_startup_errors', TRUE);
 date_default_timezone_set('Europe/London');
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 /** Include PHPExcel */
 require_once dirname(__FILE__) . '/../src/Bootstrap.php';
 
 
 // Create new PHPExcel object
-echo date('H:i:s') , " Create new PHPExcel object" , EOL;
+echo date('H:i:s'), " Create new PHPExcel object", EOL;
 $objPHPExcel = new \PHPExcel\Spreadsheet();
 
 // Set document properties
-echo date('H:i:s') , " Set document properties" , EOL;
+echo date('H:i:s'), " Set document properties", EOL;
 $objPHPExcel->getProperties()->setCreator("Maarten Balliauw")
 							 ->setLastModifiedBy("Maarten Balliauw")
 							 ->setTitle("PHPExcel Test Document")
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
 
 
 // Add some data
-echo date('H:i:s') , " Add some data" , EOL;
+echo date('H:i:s'), " Add some data", EOL;
 $objPHPExcel->setActiveSheetIndex(0)
             ->setCellValue('A1', 'Hello')
             ->setCellValue('B2', 'world!')
@@ -66,13 +66,13 @@  discard block
 block discarded – undo
             ->setCellValue('A5', 'éàèùâêîôûëïüÿäöüç');
 
 
-$objPHPExcel->getActiveSheet()->setCellValue('A8',"Hello\nWorld");
+$objPHPExcel->getActiveSheet()->setCellValue('A8', "Hello\nWorld");
 $objPHPExcel->getActiveSheet()->getRowDimension(8)->setRowHeight(-1);
 $objPHPExcel->getActiveSheet()->getStyle('A8')->getAlignment()->setWrapText(true);
 
 
 // Rename worksheet
-echo date('H:i:s') , " Rename worksheet" , EOL;
+echo date('H:i:s'), " Rename worksheet", EOL;
 $objPHPExcel->getActiveSheet()->setTitle('Simple');
 
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
 
 
 // Save Excel 2007 file
-echo date('H:i:s') , " Write to Excel2007 format" , EOL;
+echo date('H:i:s'), " Write to Excel2007 format", EOL;
 $callStartTime = microtime(true);
 
 // Use PCLZip rather than ZipArchive to create the Excel2007 OfficeOpenXML file
@@ -92,15 +92,15 @@  discard block
 block discarded – undo
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
 
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
 
 // Echo done
-echo date('H:i:s') , " Done writing files" , EOL;
-echo 'Files have been created in ' , getcwd() , EOL;
+echo date('H:i:s'), " Done writing files", EOL;
+echo 'Files have been created in ', getcwd(), EOL;

Please login to merge, or discard this patch.

Examples/31docproperties_write.php 1 patch

Spacing +32 added lines, -32 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 ini_set('display_errors', TRUE);
 ini_set('display_startup_errors', TRUE);
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 date_default_timezone_set('Europe/London');
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
 $inputFileName = 'templates/31docproperties.xlsx';
 
 
-echo date('H:i:s') , " Load Tests from $inputFileType file" , EOL;
+echo date('H:i:s'), " Load Tests from $inputFileType file", EOL;
 $callStartTime = microtime(true);
 
 $objPHPExcelReader = \PHPExcel\IOFactory::createReader($inputFileType);
@@ -50,12 +50,12 @@  discard block
 block discarded – undo
 
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
-echo 'Call time to read Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo 'Call time to read Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
-echo date('H:i:s') , " Adjust properties" , EOL;
+echo date('H:i:s'), " Adjust properties", EOL;
 $objPHPExcel->getProperties()->setTitle("Office 2007 XLSX Test Document")
 							 ->setSubject("Office 2007 XLSX Test Document")
 							 ->setDescription("Test XLSX document, generated using PHPExcel")
@@ -63,57 +63,57 @@  discard block
 block discarded – undo
 
 
 // Save Excel 2007 file
-echo date('H:i:s') , " Write to Excel2007 format" , EOL;
+echo date('H:i:s'), " Write to Excel2007 format", EOL;
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel2007');
 $objWriter->save(str_replace('.php', '.xlsx', __FILE__));
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " . (memory_get_peak_usage(true) / 1024 / 1024) . " MB" , EOL;
+echo date('H:i:s'), " Peak memory usage: " . (memory_get_peak_usage(true) / 1024 / 1024) . " MB", EOL;
 
 
 echo EOL;
 // Reread File
-echo date('H:i:s') , " Reread Excel2007 file" , EOL;
+echo date('H:i:s'), " Reread Excel2007 file", EOL;
 $objPHPExcelRead = \PHPExcel\IOFactory::load(str_replace('.php', '.xlsx', __FILE__));
 
 // Set properties
-echo date('H:i:s') , " Get properties" , EOL;
+echo date('H:i:s'), " Get properties", EOL;
 
-echo 'Core Properties:' , EOL;
-echo '    Created by - ' , $objPHPExcel->getProperties()->getCreator() , EOL;
-echo '    Created on - ' , date('d-M-Y',$objPHPExcel->getProperties()->getCreated()) , ' at ' ,
-                       date('H:i:s',$objPHPExcel->getProperties()->getCreated()) , EOL;
-echo '    Last Modified by - ' , $objPHPExcel->getProperties()->getLastModifiedBy() , EOL;
-echo '    Last Modified on - ' , date('d-M-Y',$objPHPExcel->getProperties()->getModified()) , ' at ' ,
-                             date('H:i:s',$objPHPExcel->getProperties()->getModified()) , EOL;
-echo '    Title - ' , $objPHPExcel->getProperties()->getTitle() , EOL;
-echo '    Subject - ' , $objPHPExcel->getProperties()->getSubject() , EOL;
-echo '    Description - ' , $objPHPExcel->getProperties()->getDescription() , EOL;
-echo '    Keywords: - ' , $objPHPExcel->getProperties()->getKeywords() , EOL;
+echo 'Core Properties:', EOL;
+echo '    Created by - ', $objPHPExcel->getProperties()->getCreator(), EOL;
+echo '    Created on - ', date('d-M-Y', $objPHPExcel->getProperties()->getCreated()), ' at ',
+                       date('H:i:s', $objPHPExcel->getProperties()->getCreated()), EOL;
+echo '    Last Modified by - ', $objPHPExcel->getProperties()->getLastModifiedBy(), EOL;
+echo '    Last Modified on - ', date('d-M-Y', $objPHPExcel->getProperties()->getModified()), ' at ',
+                             date('H:i:s', $objPHPExcel->getProperties()->getModified()), EOL;
+echo '    Title - ', $objPHPExcel->getProperties()->getTitle(), EOL;
+echo '    Subject - ', $objPHPExcel->getProperties()->getSubject(), EOL;
+echo '    Description - ', $objPHPExcel->getProperties()->getDescription(), EOL;
+echo '    Keywords: - ', $objPHPExcel->getProperties()->getKeywords(), EOL;
 
 
-echo 'Extended (Application) Properties:' , EOL;
-echo '    Category - ' , $objPHPExcel->getProperties()->getCategory() , EOL;
-echo '    Company - ' , $objPHPExcel->getProperties()->getCompany() , EOL;
-echo '    Manager - ' , $objPHPExcel->getProperties()->getManager() , EOL;
+echo 'Extended (Application) Properties:', EOL;
+echo '    Category - ', $objPHPExcel->getProperties()->getCategory(), EOL;
+echo '    Company - ', $objPHPExcel->getProperties()->getCompany(), EOL;
+echo '    Manager - ', $objPHPExcel->getProperties()->getManager(), EOL;
 
 
-echo 'Custom Properties:' , EOL;
+echo 'Custom Properties:', EOL;
 $customProperties = $objPHPExcel->getProperties()->getCustomProperties();
-foreach($customProperties as $customProperty) {
+foreach ($customProperties as $customProperty) {
 	$propertyValue = $objPHPExcel->getProperties()->getCustomPropertyValue($customProperty);
 	$propertyType = $objPHPExcel->getProperties()->getCustomPropertyType($customProperty);
-	echo '    ' , $customProperty , ' - (' , $propertyType , ') - ';
+	echo '    ', $customProperty, ' - (', $propertyType, ') - ';
 	if ($propertyType == \PHPExcel\Document\Properties::PROPERTY_TYPE_DATE) {
-		echo date('d-M-Y H:i:s',$propertyValue) , EOL;
+		echo date('d-M-Y H:i:s', $propertyValue), EOL;
 	} elseif ($propertyType == \PHPExcel\Document\Properties::PROPERTY_TYPE_BOOLEAN) {
-		echo (($propertyValue) ? 'TRUE' : 'FALSE') , EOL;
+		echo (($propertyValue) ? 'TRUE' : 'FALSE'), EOL;
 	} else {
-		echo $propertyValue , EOL;
+		echo $propertyValue, EOL;
 	}
 }
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) . " MB" , EOL;
+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024) . " MB", EOL;

Please login to merge, or discard this patch.

Examples/11documentsecurity-xls.php 1 patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 ini_set('display_errors', TRUE);
 ini_set('display_startup_errors', TRUE);
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 date_default_timezone_set('Europe/London');
 
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
 
 
 // Create new PHPExcel object
-echo date('H:i:s') , " Create new PHPExcel object" , EOL;
+echo date('H:i:s'), " Create new PHPExcel object", EOL;
 $objPHPExcel = new \PHPExcel\Spreadsheet();
 
 // Set document properties
-echo date('H:i:s') , " Set document properties" , EOL;
+echo date('H:i:s'), " Set document properties", EOL;
 $objPHPExcel->getProperties()->setCreator("Maarten Balliauw")
 							 ->setLastModifiedBy("Maarten Balliauw")
 							 ->setTitle("Office 2007 XLSX Test Document")
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 
 
 // Add some data
-echo date('H:i:s') , " Add some data" , EOL;
+echo date('H:i:s'), " Add some data", EOL;
 $objPHPExcel->setActiveSheetIndex(0);
 $objPHPExcel->getActiveSheet()->setCellValue('A1', 'Hello');
 $objPHPExcel->getActiveSheet()->setCellValue('B2', 'world!');
@@ -62,19 +62,19 @@  discard block
 block discarded – undo
 $objPHPExcel->getActiveSheet()->setCellValue('D2', 'world!');
 
 // Rename worksheet
-echo date('H:i:s') , " Rename worksheet" , EOL;
+echo date('H:i:s'), " Rename worksheet", EOL;
 $objPHPExcel->getActiveSheet()->setTitle('Simple');
 
 
 // Set document security
-echo date('H:i:s') , " Set document security" , EOL;
+echo date('H:i:s'), " Set document security", EOL;
 $objPHPExcel->getSecurity()->setLockWindows(true);
 $objPHPExcel->getSecurity()->setLockStructure(true);
 $objPHPExcel->getSecurity()->setWorkbookPassword("PHPExcel");
 
 
 // Set sheet security
-echo date('H:i:s') , " Set sheet security" , EOL;
+echo date('H:i:s'), " Set sheet security", EOL;
 $objPHPExcel->getActiveSheet()->getProtection()->setPassword('PHPExcel');
 $objPHPExcel->getActiveSheet()->getProtection()->setSheet(true); // This should be enabled in order to enable any of the following!
 $objPHPExcel->getActiveSheet()->getProtection()->setSort(true);
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
 
 
 // Save Excel 95 file
-echo date('H:i:s') , " Write to Excel5 format" , EOL;
+echo date('H:i:s'), " Write to Excel5 format", EOL;
 $callStartTime = microtime(true);
 
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel5');
@@ -95,15 +95,15 @@  discard block
 block discarded – undo
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
 
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
 
 // Echo done
-echo date('H:i:s') , " Done writing file" , EOL;
-echo 'File has been created in ' , getcwd() , EOL;
+echo date('H:i:s'), " Done writing file", EOL;
+echo 'File has been created in ', getcwd(), EOL;

Please login to merge, or discard this patch.

Examples/10autofilter-selection-2.php 1 patch

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -31,18 +31,18 @@  discard block
 block discarded – undo
 ini_set('display_startup_errors', TRUE);
 date_default_timezone_set('Europe/London');
 
-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
 
 /** Include PHPExcel */
 require_once dirname(__FILE__) . '/../src/Bootstrap.php';
 
 
 // Create new PHPExcel object
-echo date('H:i:s').' Create new PHPExcel object'.EOL;
+echo date('H:i:s') . ' Create new PHPExcel object' . EOL;
 $objPHPExcel = new \PHPExcel\Spreadsheet();
 
 // Set document properties
-echo date('H:i:s').' Set document properties'.EOL;
+echo date('H:i:s') . ' Set document properties' . EOL;
 $objPHPExcel->getProperties()->setCreator('Maarten Balliauw')
 							 ->setLastModifiedBy('Maarten Balliauw')
 							 ->setTitle('PHPExcel Test Document')
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
 							 ->setCategory('Test result file');
 
 // Create the worksheet
-echo date('H:i:s').' Add data'.EOL;
+echo date('H:i:s') . ' Add data' . EOL;
 $objPHPExcel->setActiveSheetIndex(0);
 $objPHPExcel->getActiveSheet()->setCellValue('A1', 'Financial Year')
                               ->setCellValue('B1', 'Financial Period')
@@ -64,44 +64,44 @@  discard block
 block discarded – undo
 $startYear--;
 $endYear++;
 
-$years = range($startYear,$endYear);
-$periods = range(1,12);
-$countries = array(	'United States',	'UK',		'France',	'Germany',
-					'Italy',			'Spain',	'Portugal',	'Japan'
+$years = range($startYear, $endYear);
+$periods = range(1, 12);
+$countries = array('United States', 'UK', 'France', 'Germany',
+					'Italy', 'Spain', 'Portugal', 'Japan'
 				  );
 
 $row = 2;
-foreach($years as $year) {
-	foreach($periods as $period) {
-		foreach($countries as $country) {
-			$endDays = date('t',mktime(0,0,0,$period,1,$year));
-			for($i = 1; $i <= $endDays; ++$i) {
+foreach ($years as $year) {
+	foreach ($periods as $period) {
+		foreach ($countries as $country) {
+			$endDays = date('t', mktime(0, 0, 0, $period, 1, $year));
+			for ($i = 1; $i <= $endDays; ++$i) {
 				$eDate = \PHPExcel\Shared\Date::formattedPHPToExcel(
 					$year,
 					$period,
 					$i
 				);
-				$value = rand(500,1000) * (1 + rand(-0.25,+0.25));
+				$value = rand(500, 1000) * (1 + rand(-0.25, +0.25));
 				$salesValue = $invoiceValue = NULL;
-				$incomeOrExpenditure = rand(-1,1);
+				$incomeOrExpenditure = rand(-1, 1);
 				if ($incomeOrExpenditure == -1) {
-					$expenditure = rand(-500,-1000) * (1 + rand(-0.25,+0.25));
+					$expenditure = rand(-500, -1000) * (1 + rand(-0.25, +0.25));
 					$income = NULL;
 				} elseif ($incomeOrExpenditure == 1) {
-					$expenditure = rand(-500,-1000) * (1 + rand(-0.25,+0.25));
-					$income = rand(500,1000) * (1 + rand(-0.25,+0.25));;
+					$expenditure = rand(-500, -1000) * (1 + rand(-0.25, +0.25));
+					$income = rand(500, 1000) * (1 + rand(-0.25, +0.25)); ;
 				} else {
 					$expenditure = NULL;
-					$income = rand(500,1000) * (1 + rand(-0.25,+0.25));;
+					$income = rand(500, 1000) * (1 + rand(-0.25, +0.25)); ;
 				}
-				$dataArray = array(	$year,
+				$dataArray = array($year,
 									$period,
 									$country,
 									$eDate,
 									$income,
 									$expenditure,
 								  );
-				$objPHPExcel->getActiveSheet()->fromArray($dataArray, NULL, 'A'.$row++);
+				$objPHPExcel->getActiveSheet()->fromArray($dataArray, NULL, 'A' . $row++);
 			}
 		}
 	}
@@ -110,20 +110,20 @@  discard block
 block discarded – undo
 
 
 // Set styling
-echo date('H:i:s').' Set styling'.EOL;
+echo date('H:i:s') . ' Set styling' . EOL;
 $objPHPExcel->getActiveSheet()->getStyle('A1:F1')->getFont()->setBold(true);
 $objPHPExcel->getActiveSheet()->getStyle('A1:F1')->getAlignment()->setWrapText(TRUE);
 $objPHPExcel->getActiveSheet()->getColumnDimension('C')->setWidth(12.5);
 $objPHPExcel->getActiveSheet()->getColumnDimension('D')->setWidth(10.5);
-$objPHPExcel->getActiveSheet()->getStyle('D2:D'.$row)->getNumberFormat()->setFormatCode(\PHPExcel\Style\NumberFormat::FORMAT_DATE_YYYYMMDD2);
-$objPHPExcel->getActiveSheet()->getStyle('E2:F'.$row)->getNumberFormat()->setFormatCode(\PHPExcel\Style\NumberFormat::FORMAT_CURRENCY_USD_SIMPLE);
+$objPHPExcel->getActiveSheet()->getStyle('D2:D' . $row)->getNumberFormat()->setFormatCode(\PHPExcel\Style\NumberFormat::FORMAT_DATE_YYYYMMDD2);
+$objPHPExcel->getActiveSheet()->getStyle('E2:F' . $row)->getNumberFormat()->setFormatCode(\PHPExcel\Style\NumberFormat::FORMAT_CURRENCY_USD_SIMPLE);
 $objPHPExcel->getActiveSheet()->getColumnDimension('F')->setWidth(14);
 $objPHPExcel->getActiveSheet()->freezePane('A2');
 
 
 
 // Set autofilter range
-echo date('H:i:s').' Set autofilter range'.EOL;
+echo date('H:i:s') . ' Set autofilter range' . EOL;
 // Always include the complete filter range!
 // Excel does support setting only the caption
 // row, but that's not a best practise...
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
 
 // Set active filters
 $autoFilter = $objPHPExcel->getActiveSheet()->getAutoFilter();
-echo date('H:i:s').' Set active filters'.EOL;
+echo date('H:i:s') . ' Set active filters' . EOL;
 // Filter the Country column on a filter value of Germany
 //	As it's just a simple value filter, we can use FILTERTYPE_FILTER
 $autoFilter->getColumn('C')
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
 
 
 // Save Excel 2007 file
-echo date('H:i:s') , " Write to Excel2007 format" , EOL;
+echo date('H:i:s'), " Write to Excel2007 format", EOL;
 $callStartTime = microtime(true);
 
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel2007');
@@ -183,14 +183,14 @@  discard block
 block discarded – undo
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
 
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
 // Save Excel 95 file
-echo date('H:i:s') , " Write to Excel5 format" , EOL;
+echo date('H:i:s'), " Write to Excel5 format", EOL;
 $callStartTime = microtime(true);
 
 $objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel5');
@@ -198,15 +198,15 @@  discard block
 block discarded – undo
 $callEndTime = microtime(true);
 $callTime = $callEndTime - $callStartTime;
 
-echo date('H:i:s') , " File written to " , str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
+echo date('H:i:s'), " File written to ", str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
 // Echo memory usage
-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
 
 
 // Echo memory peak usage
-echo date('H:i:s').' Peak memory usage: '.(memory_get_peak_usage(true) / 1024 / 1024).' MB'.EOL;
+echo date('H:i:s') . ' Peak memory usage: ' . (memory_get_peak_usage(true) / 1024 / 1024) . ' MB' . EOL;
 
 // Echo done
-echo date('H:i:s').' Done writing files'.EOL;
-echo 'Files have been created in ' , getcwd() , EOL;
+echo date('H:i:s') . ' Done writing files' . EOL;
+echo 'Files have been created in ', getcwd(), EOL;

Please login to merge, or discard this patch.

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	ini_set('display_errors', TRUE);
31	31	ini_set('display_startup_errors', TRUE);
32	32
33		-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
	33	+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
34	34
35	35	date_default_timezone_set('Europe/London');
36	36
		@@ -39,14 +39,14 @@ discard block
		block discarded – undo
39	39
40	40
41	41
42		-echo date('H:i:s') , " Load from Excel5 template" , EOL;
	42	+echo date('H:i:s'), " Load from Excel5 template", EOL;
43	43	$objReader = \PHPExcel\IOFactory::createReader('Excel5');
44	44	$objPHPExcel = $objReader->load("templates/30template.xls");
45	45
46	46
47	47
48	48
49		-echo date('H:i:s') , " Add new data to the template" , EOL;
	49	+echo date('H:i:s'), " Add new data to the template", EOL;
50	50	$data = array(array('title' => 'Excel for dummies',
51	51	'price' => 17.99,
52	52	'quantity' => 2
		@@ -64,28 +64,28 @@ discard block
		block discarded – undo
64	64	$objPHPExcel->getActiveSheet()->setCellValue('D1', \PHPExcel\Shared\Date::PHPToExcel(time()));
65	65
66	66	$baseRow = 5;
67		-foreach($data as $r => $dataRow) {
	67	+foreach ($data as $r => $dataRow) {
68	68	$row = $baseRow + $r;
69		- $objPHPExcel->getActiveSheet()->insertNewRowBefore($row,1);
	69	+ $objPHPExcel->getActiveSheet()->insertNewRowBefore($row, 1);
70	70
71		- $objPHPExcel->getActiveSheet()->setCellValue('A'.$row, $r+1)
72		- ->setCellValue('B'.$row, $dataRow['title'])
73		- ->setCellValue('C'.$row, $dataRow['price'])
74		- ->setCellValue('D'.$row, $dataRow['quantity'])
75		- ->setCellValue('E'.$row, '=C'.$row.'*D'.$row);
	71	+ $objPHPExcel->getActiveSheet()->setCellValue('A' . $row, $r + 1)
	72	+ ->setCellValue('B' . $row, $dataRow['title'])
	73	+ ->setCellValue('C' . $row, $dataRow['price'])
	74	+ ->setCellValue('D' . $row, $dataRow['quantity'])
	75	+ ->setCellValue('E' . $row, '=C' . $row . '*D' . $row);
76	76	}
77		-$objPHPExcel->getActiveSheet()->removeRow($baseRow-1,1);
	77	+$objPHPExcel->getActiveSheet()->removeRow($baseRow - 1, 1);
78	78
79	79
80		-echo date('H:i:s') , " Write to Excel5 format" , EOL;
	80	+echo date('H:i:s'), " Write to Excel5 format", EOL;
81	81	$objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel5');
82	82	$objWriter->save(str_replace('.php', '.xls', __FILE__));
83		-echo date('H:i:s') , " File written to " , str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
	83	+echo date('H:i:s'), " File written to ", str_replace('.php', '.xls', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
84	84
85	85
86	86	// Echo memory peak usage
87		-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
	87	+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
88	88
89	89	// Echo done
90		-echo date('H:i:s') , " Done writing file" , EOL;
91		-echo 'File has been created in ' , getcwd() , EOL;
	90	+echo date('H:i:s'), " Done writing file", EOL;
	91	+echo 'File has been created in ', getcwd(), EOL;

		@@ -6,7 +6,7 @@ discard block
		block discarded – undo
6	6	ini_set('display_startup_errors', TRUE);
7	7	date_default_timezone_set('Europe/London');
8	8
9		-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
	9	+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
10	10
11	11	date_default_timezone_set('Europe/London');
12	12
		@@ -18,63 +18,63 @@ discard block
		block discarded – undo
18	18
19	19	if ((isset($argc)) && ($argc > 1)) {
20	20	$inputFileNames = array();
21		- for($i = 1; $i < $argc; ++$i) {
	21	+ for ($i = 1; $i < $argc; ++$i) {
22	22	$inputFileNames[] = dirname(__FILE__) . '/templates/' . $argv[$i];
23	23	}
24	24	} else {
25	25	$inputFileNames = glob($inputFileNames);
26	26	}
27		-foreach($inputFileNames as $inputFileName) {
	27	+foreach ($inputFileNames as $inputFileName) {
28	28	$inputFileNameShort = basename($inputFileName);
29	29
30	30	if (!file_exists($inputFileName)) {
31		- echo date('H:i:s') , " File " , $inputFileNameShort , ' does not exist' , EOL;
	31	+ echo date('H:i:s'), " File ", $inputFileNameShort, ' does not exist', EOL;
32	32	continue;
33	33	}
34	34
35		- echo date('H:i:s') , " Load Test from $inputFileType file " , $inputFileNameShort , EOL;
	35	+ echo date('H:i:s'), " Load Test from $inputFileType file ", $inputFileNameShort, EOL;
36	36
37	37	$objReader = \PHPExcel\IOFactory::createReader($inputFileType);
38	38	$objReader->setIncludeCharts(TRUE);
39	39	$objPHPExcel = $objReader->load($inputFileName);
40	40
41	41
42		- echo date('H:i:s') , " Iterate worksheets looking at the charts" , EOL;
	42	+ echo date('H:i:s'), " Iterate worksheets looking at the charts", EOL;
43	43	foreach ($objPHPExcel->getWorksheetIterator() as $worksheet) {
44	44	$sheetName = $worksheet->getTitle();
45		- echo 'Worksheet: ' , $sheetName , EOL;
	45	+ echo 'Worksheet: ', $sheetName, EOL;
46	46
47	47	$chartNames = $worksheet->getChartNames();
48		- if(empty($chartNames)) {
49		- echo ' There are no charts in this worksheet' , EOL;
	48	+ if (empty($chartNames)) {
	49	+ echo ' There are no charts in this worksheet', EOL;
50	50	} else {
51	51	natsort($chartNames);
52		- foreach($chartNames as $i => $chartName) {
	52	+ foreach ($chartNames as $i => $chartName) {
53	53	$chart = $worksheet->getChartByName($chartName);
54	54	if (!is_null($chart->getTitle())) {
55		- $caption = '"' . implode(' ',$chart->getTitle()->getCaption()) . '"';
	55	+ $caption = '"' . implode(' ', $chart->getTitle()->getCaption()) . '"';
56	56	} else {
57	57	$caption = 'Untitled';
58	58	}
59		- echo ' ' , $chartName , ' - ' , $caption , EOL;
60		- echo str_repeat(' ',strlen($chartName)+3);
	59	+ echo ' ', $chartName, ' - ', $caption, EOL;
	60	+ echo str_repeat(' ', strlen($chartName) + 3);
61	61	$groupCount = $chart->getPlotArea()->getPlotGroupCount();
62	62	if ($groupCount == 1) {
63	63	$chartType = $chart->getPlotArea()->getPlotGroupByIndex(0)->getPlotType();
64		- echo ' ' , $chartType , EOL;
	64	+ echo ' ', $chartType, EOL;
65	65	} else {
66	66	$chartTypes = array();
67		- for($i = 0; $i < $groupCount; ++$i) {
	67	+ for ($i = 0; $i < $groupCount; ++$i) {
68	68	$chartTypes[] = $chart->getPlotArea()->getPlotGroupByIndex($i)->getPlotType();
69	69	}
70	70	$chartTypes = array_unique($chartTypes);
71	71	if (count($chartTypes) == 1) {
72	72	$chartType = 'Multiple Plot ' . array_pop($chartTypes);
73		- echo ' ' , $chartType , EOL;
	73	+ echo ' ', $chartType, EOL;
74	74	} elseif (count($chartTypes) == 0) {
75		- echo ' *** Type not yet implemented' , EOL;
	75	+ echo ' *** Type not yet implemented', EOL;
76	76	} else {
77		- echo ' Combination Chart' , EOL;
	77	+ echo ' Combination Chart', EOL;
78	78	}
79	79	}
80	80	}
		@@ -84,19 +84,19 @@ discard block
		block discarded – undo
84	84
85	85	$outputFileName = basename($inputFileName);
86	86
87		- echo date('H:i:s') , " Write Tests to Excel2007 file " , EOL;
	87	+ echo date('H:i:s'), " Write Tests to Excel2007 file ", EOL;
88	88	$objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel2007');
89	89	$objWriter->setIncludeCharts(TRUE);
90	90	$objWriter->save($outputFileName);
91		- echo date('H:i:s') , " File written to " , $outputFileName , EOL;
	91	+ echo date('H:i:s'), " File written to ", $outputFileName, EOL;
92	92
93	93	$objPHPExcel->disconnectWorksheets();
94	94	unset($objPHPExcel);
95	95	}
96	96
97	97	// Echo memory peak usage
98		-echo date('H:i:s') , ' Peak memory usage: ' , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
	98	+echo date('H:i:s'), ' Peak memory usage: ', (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
99	99
100	100	// Echo done
101		-echo date('H:i:s') , " Done writing files" , EOL;
102		-echo 'Files have been created in ' , getcwd() , EOL;
	101	+echo date('H:i:s'), " Done writing files", EOL;
	102	+echo 'Files have been created in ', getcwd(), EOL;

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31	ini_set('display_startup_errors', TRUE);
32	32	date_default_timezone_set('Europe/London');
33	33
34		-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
	34	+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
35	35
36	36	date_default_timezone_set('Europe/London');
37	37
		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41	require_once dirname(__FILE__) . '/../src/Bootstrap.php';
42	42
43	43
44		-echo date('H:i:s') , " Write to CSV format" , EOL;
	44	+echo date('H:i:s'), " Write to CSV format", EOL;
45	45	$callStartTime = microtime(true);
46	46
47	47	$objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'CSV')->setDelimiter(',')
		@@ -50,13 +50,13 @@ discard block
		block discarded – undo
50	50	->save(str_replace('.php', '.csv', __FILE__));
51	51	$callEndTime = microtime(true);
52	52	$callTime = $callEndTime - $callStartTime;
53		-echo date('H:i:s') , " File written to " , str_replace('.php', '.csv', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
54		-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
	53	+echo date('H:i:s'), " File written to ", str_replace('.php', '.csv', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
	54	+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
55	55	// Echo memory usage
56		-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
	56	+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
57	57
58	58
59		-echo date('H:i:s') , " Read from CSV format" , EOL;
	59	+echo date('H:i:s'), " Read from CSV format", EOL;
60	60	$callStartTime = microtime(true);
61	61	$objReader = \PHPExcel\IOFactory::createReader('CSV')->setDelimiter(',')
62	62	->setEnclosure('"')
		@@ -65,25 +65,25 @@ discard block
		block discarded – undo
65	65
66	66	$callEndTime = microtime(true);
67	67	$callTime = $callEndTime - $callStartTime;
68		-echo 'Call time to reload Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
	68	+echo 'Call time to reload Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
69	69	// Echo memory usage
70		-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
	70	+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
71	71
72	72
73		-echo date('H:i:s') , " Write to Excel2007 format" , EOL;
	73	+echo date('H:i:s'), " Write to Excel2007 format", EOL;
74	74	$callStartTime = microtime(true);
75	75
76	76	$objWriter2007 = \PHPExcel\IOFactory::createWriter($objPHPExcelFromCSV, 'Excel2007');
77	77	$objWriter2007->save(str_replace('.php', '.xlsx', __FILE__));
78	78	$callEndTime = microtime(true);
79	79	$callTime = $callEndTime - $callStartTime;
80		-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
81		-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
	80	+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
	81	+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
82	82	// Echo memory usage
83		-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
	83	+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
84	84
85	85
86		-echo date('H:i:s') , " Write to CSV format" , EOL;
	86	+echo date('H:i:s'), " Write to CSV format", EOL;
87	87	$callStartTime = microtime(true);
88	88
89	89	$objWriterCSV = \PHPExcel\IOFactory::createWriter($objPHPExcelFromCSV, 'CSV');
		@@ -91,15 +91,15 @@ discard block
		block discarded – undo
91	91	$objWriterCSV->save(str_replace('.php', '_excel.csv', __FILE__));
92	92	$callEndTime = microtime(true);
93	93	$callTime = $callEndTime - $callStartTime;
94		-echo date('H:i:s') , " File written to " , str_replace('.php', '_excel.csv', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
95		-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
	94	+echo date('H:i:s'), " File written to ", str_replace('.php', '_excel.csv', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
	95	+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
96	96	// Echo memory usage
97		-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
	97	+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
98	98
99	99
100	100	// Echo memory peak usage
101		-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
	101	+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
102	102
103	103	// Echo done
104		-echo date('H:i:s') , " Done writing files" , EOL;
105		-echo 'Files have been created in ' , getcwd() , EOL;
	104	+echo date('H:i:s'), " Done writing files", EOL;
	105	+echo 'Files have been created in ', getcwd(), EOL;

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	/** \PHPExcel\IOFactory */
34	34	require_once dirname(__FILE__) . '/../Classes/PHPExcel/IOFactory.php';
35	35
36		-echo date('H:i:s') , " Load from OOCalc file" , PHP_EOL;
	36	+echo date('H:i:s'), " Load from OOCalc file", PHP_EOL;
37	37	$callStartTime = microtime(true);
38	38
39	39	$objReader = \PHPExcel\IOFactory::createReader('OOCalc');
		@@ -42,20 +42,20 @@ discard block
		block discarded – undo
42	42
43	43	$callEndTime = microtime(true);
44	44	$callTime = $callEndTime - $callStartTime;
45		-echo 'Call time to read Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , PHP_EOL;
	45	+echo 'Call time to read Workbook was ', sprintf('%.4f', $callTime), " seconds", PHP_EOL;
46	46	// Echo memory usage
47		-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , PHP_EOL;
	47	+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", PHP_EOL;
48	48
49	49
50		-echo date('H:i:s') , " Write to Excel2007 format" , PHP_EOL;
	50	+echo date('H:i:s'), " Write to Excel2007 format", PHP_EOL;
51	51	$objWriter = \PHPExcel\IOFactory::createWriter($objPHPExcel, 'Excel2007');
52	52	$objWriter->save(str_replace('.php', '.xlsx', __FILE__));
53		-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', __FILE__) , PHP_EOL;
	53	+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', __FILE__), PHP_EOL;
54	54
55	55
56	56	// Echo memory peak usage
57		-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , PHP_EOL;
	57	+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", PHP_EOL;
58	58
59	59	// Echo done
60		-echo date('H:i:s') , " Done writing file" , PHP_EOL;
	60	+echo date('H:i:s'), " Done writing file", PHP_EOL;
61	61

		@@ -31,18 +31,18 @@ discard block
		block discarded – undo
31	31	ini_set('display_startup_errors', TRUE);
32	32	date_default_timezone_set('Europe/London');
33	33
34		-define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
	34	+define('EOL', (PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
35	35
36	36	/** Include PHPExcel */
37	37	require_once dirname(__FILE__) . '/../src/Bootstrap.php';
38	38
39	39
40	40	// Create new PHPExcel object
41		-echo date('H:i:s') , " Create new PHPExcel object" , EOL;
	41	+echo date('H:i:s'), " Create new PHPExcel object", EOL;
42	42	$objPHPExcel = new \PHPExcel\Spreadsheet();
43	43
44	44	// Set document properties
45		-echo date('H:i:s') , " Set document properties" , EOL;
	45	+echo date('H:i:s'), " Set document properties", EOL;
46	46	$objPHPExcel->getProperties()->setCreator("Maarten Balliauw")
47	47	->setLastModifiedBy("Maarten Balliauw")
48	48	->setTitle("PHPExcel Test Document")
		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53
54	54
55	55	// Add some data
56		-echo date('H:i:s') , " Add some data" , EOL;
	56	+echo date('H:i:s'), " Add some data", EOL;
57	57	$objPHPExcel->setActiveSheetIndex(0)
58	58	->setCellValue('A1', 'Hello')
59	59	->setCellValue('B2', 'world!')
		@@ -66,13 +66,13 @@ discard block
		block discarded – undo
66	66	->setCellValue('A5', 'éàèùâêîôûëïüÿäöüç');
67	67
68	68
69		-$objPHPExcel->getActiveSheet()->setCellValue('A8',"Hello\nWorld");
	69	+$objPHPExcel->getActiveSheet()->setCellValue('A8', "Hello\nWorld");
70	70	$objPHPExcel->getActiveSheet()->getRowDimension(8)->setRowHeight(-1);
71	71	$objPHPExcel->getActiveSheet()->getStyle('A8')->getAlignment()->setWrapText(true);
72	72
73	73
74	74	// Rename worksheet
75		-echo date('H:i:s') , " Rename worksheet" , EOL;
	75	+echo date('H:i:s'), " Rename worksheet", EOL;
76	76	$objPHPExcel->getActiveSheet()->setTitle('Simple');
77	77
78	78
		@@ -81,7 +81,7 @@ discard block
		block discarded – undo
81	81
82	82
83	83	// Save Excel 2007 file
84		-echo date('H:i:s') , " Write to Excel2007 format" , EOL;
	84	+echo date('H:i:s'), " Write to Excel2007 format", EOL;
85	85	$callStartTime = microtime(true);
86	86
87	87	// Use PCLZip rather than ZipArchive to create the Excel2007 OfficeOpenXML file
		@@ -92,15 +92,15 @@ discard block
		block discarded – undo
92	92	$callEndTime = microtime(true);
93	93	$callTime = $callEndTime - $callStartTime;
94	94
95		-echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
96		-echo 'Call time to write Workbook was ' , sprintf('%.4f',$callTime) , " seconds" , EOL;
	95	+echo date('H:i:s'), " File written to ", str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)), EOL;
	96	+echo 'Call time to write Workbook was ', sprintf('%.4f', $callTime), " seconds", EOL;
97	97	// Echo memory usage
98		-echo date('H:i:s') , ' Current memory usage: ' , (memory_get_usage(true) / 1024 / 1024) , " MB" , EOL;
	98	+echo date('H:i:s'), ' Current memory usage: ', (memory_get_usage(true) / 1024 / 1024), " MB", EOL;
99	99
100	100
101	101	// Echo memory peak usage
102		-echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
	102	+echo date('H:i:s'), " Peak memory usage: ", (memory_get_peak_usage(true) / 1024 / 1024), " MB", EOL;
103	103
104	104	// Echo done
105		-echo date('H:i:s') , " Done writing files" , EOL;
106		-echo 'Files have been created in ' , getcwd() , EOL;
	105	+echo date('H:i:s'), " Done writing files", EOL;
	106	+echo 'Files have been created in ', getcwd(), EOL;

PHPOffice / PhpSpreadsheet

Push — develop ( bf3457...467bab )

Status

Category

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +23 added lines, -23 removed lines patch added patch discarded remove patch

Spacing +19 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +32 added lines, -32 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch