Inspection of "Merge branch 'feature/gh-7' into develop" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( bf3457...467bab )

unknown

created 2016-08-14 23:21 UTC

Status

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -33,17 +33,17 @@
		block discarded – undo
33	33
34	34	// Add some data
35	35	$database = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit' ),
36		- array( 'Apple', 18, 20, 14, 105.00 ),
37		- array( 'Pear', 12, 12, 10, 96.00 ),
38		- array( 'Cherry', 13, 14, 9, 105.00 ),
39		- array( 'Apple', 14, 15, 10, 75.00 ),
40		- array( 'Pear', 9, 8, 8, 76.80 ),
41		- array( 'Apple', 8, 9, 6, 45.00 ),
42		- );
	36	+ array( 'Apple', 18, 20, 14, 105.00 ),
	37	+ array( 'Pear', 12, 12, 10, 96.00 ),
	38	+ array( 'Cherry', 13, 14, 9, 105.00 ),
	39	+ array( 'Apple', 14, 15, 10, 75.00 ),
	40	+ array( 'Pear', 9, 8, 8, 76.80 ),
	41	+ array( 'Apple', 8, 9, 6, 45.00 ),
	42	+ );
43	43	$criteria = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height' ),
44		- array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
45		- array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
46		- );
	44	+ array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
	45	+ array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
	46	+ );
47	47
48	48	$worksheet->fromArray( $criteria, NULL, 'A1' );
49	49	$worksheet->fromArray( $database, NULL, 'A4' );

Please login to merge, or discard this patch.

Documentation/Examples/Calculations/Database/DMIN.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -33,17 +33,17 @@
		block discarded – undo
33	33
34	34	// Add some data
35	35	$database = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit' ),
36		- array( 'Apple', 18, 20, 14, 105.00 ),
37		- array( 'Pear', 12, 12, 10, 96.00 ),
38		- array( 'Cherry', 13, 14, 9, 105.00 ),
39		- array( 'Apple', 14, 15, 10, 75.00 ),
40		- array( 'Pear', 9, 8, 8, 76.80 ),
41		- array( 'Apple', 8, 9, 6, 45.00 ),
42		- );
	36	+ array( 'Apple', 18, 20, 14, 105.00 ),
	37	+ array( 'Pear', 12, 12, 10, 96.00 ),
	38	+ array( 'Cherry', 13, 14, 9, 105.00 ),
	39	+ array( 'Apple', 14, 15, 10, 75.00 ),
	40	+ array( 'Pear', 9, 8, 8, 76.80 ),
	41	+ array( 'Apple', 8, 9, 6, 45.00 ),
	42	+ );
43	43	$criteria = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height' ),
44		- array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
45		- array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
46		- );
	44	+ array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
	45	+ array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
	46	+ );
47	47
48	48	$worksheet->fromArray( $criteria, NULL, 'A1' );
49	49	$worksheet->fromArray( $database, NULL, 'A4' );

Please login to merge, or discard this patch.

Documentation/Examples/Calculations/Database/DGET.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -33,17 +33,17 @@
		block discarded – undo
33	33
34	34	// Add some data
35	35	$database = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit' ),
36		- array( 'Apple', 18, 20, 14, 105.00 ),
37		- array( 'Pear', 12, 12, 10, 96.00 ),
38		- array( 'Cherry', 13, 14, 9, 105.00 ),
39		- array( 'Apple', 14, 15, 10, 75.00 ),
40		- array( 'Pear', 9, 8, 8, 76.80 ),
41		- array( 'Apple', 8, 9, 6, 45.00 ),
42		- );
	36	+ array( 'Apple', 18, 20, 14, 105.00 ),
	37	+ array( 'Pear', 12, 12, 10, 96.00 ),
	38	+ array( 'Cherry', 13, 14, 9, 105.00 ),
	39	+ array( 'Apple', 14, 15, 10, 75.00 ),
	40	+ array( 'Pear', 9, 8, 8, 76.80 ),
	41	+ array( 'Apple', 8, 9, 6, 45.00 ),
	42	+ );
43	43	$criteria = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height' ),
44		- array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
45		- array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
46		- );
	44	+ array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
	45	+ array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
	46	+ );
47	47
48	48	$worksheet->fromArray( $criteria, NULL, 'A1' );
49	49	$worksheet->fromArray( $database, NULL, 'A4' );

Please login to merge, or discard this patch.

Documentation/Examples/Calculations/Database/DMAX.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -33,17 +33,17 @@
		block discarded – undo
33	33
34	34	// Add some data
35	35	$database = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit' ),
36		- array( 'Apple', 18, 20, 14, 105.00 ),
37		- array( 'Pear', 12, 12, 10, 96.00 ),
38		- array( 'Cherry', 13, 14, 9, 105.00 ),
39		- array( 'Apple', 14, 15, 10, 75.00 ),
40		- array( 'Pear', 9, 8, 8, 76.80 ),
41		- array( 'Apple', 8, 9, 6, 45.00 ),
42		- );
	36	+ array( 'Apple', 18, 20, 14, 105.00 ),
	37	+ array( 'Pear', 12, 12, 10, 96.00 ),
	38	+ array( 'Cherry', 13, 14, 9, 105.00 ),
	39	+ array( 'Apple', 14, 15, 10, 75.00 ),
	40	+ array( 'Pear', 9, 8, 8, 76.80 ),
	41	+ array( 'Apple', 8, 9, 6, 45.00 ),
	42	+ );
43	43	$criteria = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height' ),
44		- array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
45		- array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
46		- );
	44	+ array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
	45	+ array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
	46	+ );
47	47
48	48	$worksheet->fromArray( $criteria, NULL, 'A1' );
49	49	$worksheet->fromArray( $database, NULL, 'A4' );

Please login to merge, or discard this patch.

Documentation/Examples/Calculations/Database/DVAR.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -33,17 +33,17 @@
		block discarded – undo
33	33
34	34	// Add some data
35	35	$database = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit' ),
36		- array( 'Apple', 18, 20, 14, 105.00 ),
37		- array( 'Pear', 12, 12, 10, 96.00 ),
38		- array( 'Cherry', 13, 14, 9, 105.00 ),
39		- array( 'Apple', 14, 15, 10, 75.00 ),
40		- array( 'Pear', 9, 8, 8, 76.80 ),
41		- array( 'Apple', 8, 9, 6, 45.00 ),
42		- );
	36	+ array( 'Apple', 18, 20, 14, 105.00 ),
	37	+ array( 'Pear', 12, 12, 10, 96.00 ),
	38	+ array( 'Cherry', 13, 14, 9, 105.00 ),
	39	+ array( 'Apple', 14, 15, 10, 75.00 ),
	40	+ array( 'Pear', 9, 8, 8, 76.80 ),
	41	+ array( 'Apple', 8, 9, 6, 45.00 ),
	42	+ );
43	43	$criteria = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height' ),
44		- array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
45		- array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
46		- );
	44	+ array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
	45	+ array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
	46	+ );
47	47
48	48	$worksheet->fromArray( $criteria, NULL, 'A1' );
49	49	$worksheet->fromArray( $database, NULL, 'A4' );

Please login to merge, or discard this patch.

Documentation/Examples/Calculations/Database/DCOUNT.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -33,17 +33,17 @@
		block discarded – undo
33	33
34	34	// Add some data
35	35	$database = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit' ),
36		- array( 'Apple', 18, 20, 14, 105.00 ),
37		- array( 'Pear', 12, 12, 10, 96.00 ),
38		- array( 'Cherry', 13, 14, 9, 105.00 ),
39		- array( 'Apple', 14, 15, 10, 75.00 ),
40		- array( 'Pear', 9, 8, 8, 76.80 ),
41		- array( 'Apple', 8, 9, 6, 45.00 ),
42		- );
	36	+ array( 'Apple', 18, 20, 14, 105.00 ),
	37	+ array( 'Pear', 12, 12, 10, 96.00 ),
	38	+ array( 'Cherry', 13, 14, 9, 105.00 ),
	39	+ array( 'Apple', 14, 15, 10, 75.00 ),
	40	+ array( 'Pear', 9, 8, 8, 76.80 ),
	41	+ array( 'Apple', 8, 9, 6, 45.00 ),
	42	+ );
43	43	$criteria = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height' ),
44		- array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
45		- array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
46		- );
	44	+ array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
	45	+ array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
	46	+ );
47	47
48	48	$worksheet->fromArray( $criteria, NULL, 'A1' );
49	49	$worksheet->fromArray( $database, NULL, 'A4' );

Please login to merge, or discard this patch.

Documentation/Examples/Calculations/Database/DAVERAGE.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -33,17 +33,17 @@
		block discarded – undo
33	33
34	34	// Add some data
35	35	$database = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit' ),
36		- array( 'Apple', 18, 20, 14, 105.00 ),
37		- array( 'Pear', 12, 12, 10, 96.00 ),
38		- array( 'Cherry', 13, 14, 9, 105.00 ),
39		- array( 'Apple', 14, 15, 10, 75.00 ),
40		- array( 'Pear', 9, 8, 8, 76.80 ),
41		- array( 'Apple', 8, 9, 6, 45.00 ),
42		- );
	36	+ array( 'Apple', 18, 20, 14, 105.00 ),
	37	+ array( 'Pear', 12, 12, 10, 96.00 ),
	38	+ array( 'Cherry', 13, 14, 9, 105.00 ),
	39	+ array( 'Apple', 14, 15, 10, 75.00 ),
	40	+ array( 'Pear', 9, 8, 8, 76.80 ),
	41	+ array( 'Apple', 8, 9, 6, 45.00 ),
	42	+ );
43	43	$criteria = array( array( 'Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height' ),
44		- array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
45		- array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
46		- );
	44	+ array( '="=Apple"', '>10', NULL, NULL, NULL, '<16' ),
	45	+ array( '="=Pear"', NULL, NULL, NULL, NULL, NULL )
	46	+ );
47	47
48	48	$worksheet->fromArray( $criteria, NULL, 'A1' );
49	49	$worksheet->fromArray( $database, NULL, 'A4' );

Please login to merge, or discard this patch.

Examples/06largescale-xls.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -52,12 +52,12 @@  discard block
 block discarded – undo
 // Set document properties
 echo date('H:i:s') , " Set properties" , EOL;
 $objPHPExcel->getProperties()->setCreator("Maarten Balliauw")
-							 ->setLastModifiedBy("Maarten Balliauw")
-							 ->setTitle("Office 2007 XLSX Test Document")
-							 ->setSubject("Office 2007 XLSX Test Document")
-							 ->setDescription("Test document for Office 2007 XLSX, generated using PHP classes.")
-							 ->setKeywords("office 2007 openxml php")
-							 ->setCategory("Test result file");
+                                ->setLastModifiedBy("Maarten Balliauw")
+                                ->setTitle("Office 2007 XLSX Test Document")
+                                ->setSubject("Office 2007 XLSX Test Document")
+                                ->setDescription("Test document for Office 2007 XLSX, generated using PHP classes.")
+                                ->setKeywords("office 2007 openxml php")
+                                ->setCategory("Test result file");
 
 
 // Create a first sheet
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
 // Set outline levels
 echo date('H:i:s') , " Set outline levels" , EOL;
 $objPHPExcel->getActiveSheet()->getColumnDimension('E')->setOutlineLevel(1)
-                                                       ->setVisible(false)
-                                                       ->setCollapsed(true);
+                                                        ->setVisible(false)
+                                                        ->setCollapsed(true);
 
 // Freeze panes
 echo date('H:i:s') , " Freeze panes" , EOL;
@@ -94,11 +94,11 @@  discard block
 block discarded – undo
 
 // Add data
 for ($i = 2; $i <= 5000; $i++) {
-	$objPHPExcel->getActiveSheet()->setCellValue('A' . $i, "FName $i")
-	                              ->setCellValue('B' . $i, "LName $i")
-	                              ->setCellValue('C' . $i, "PhoneNo $i")
-	                              ->setCellValue('D' . $i, "FaxNo $i")
-	                              ->setCellValue('E' . $i, true);
+    $objPHPExcel->getActiveSheet()->setCellValue('A' . $i, "FName $i")
+                                    ->setCellValue('B' . $i, "LName $i")
+                                    ->setCellValue('C' . $i, "PhoneNo $i")
+                                    ->setCellValue('D' . $i, "FaxNo $i")
+                                    ->setCellValue('E' . $i, true);
 }
 
 

Please login to merge, or discard this patch.

Examples/07readerPCLZip.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@
 block discarded – undo
 
 
 if (!file_exists("05featuredemo.xlsx")) {
-	exit("Please run 05featuredemo.php first." . EOL);
+    exit("Please run 05featuredemo.php first." . EOL);
 }
 
 echo date('H:i:s') , " Load from Excel2007 file" , EOL;

Please login to merge, or discard this patch.

		@@ -52,12 +52,12 @@ discard block
		block discarded – undo
52	52	// Set document properties
53	53	echo date('H:i:s') , " Set properties" , EOL;
54	54	$objPHPExcel->getProperties()->setCreator("Maarten Balliauw")
55		- ->setLastModifiedBy("Maarten Balliauw")
56		- ->setTitle("Office 2007 XLSX Test Document")
57		- ->setSubject("Office 2007 XLSX Test Document")
58		- ->setDescription("Test document for Office 2007 XLSX, generated using PHP classes.")
59		- ->setKeywords("office 2007 openxml php")
60		- ->setCategory("Test result file");
	55	+ ->setLastModifiedBy("Maarten Balliauw")
	56	+ ->setTitle("Office 2007 XLSX Test Document")
	57	+ ->setSubject("Office 2007 XLSX Test Document")
	58	+ ->setDescription("Test document for Office 2007 XLSX, generated using PHP classes.")
	59	+ ->setKeywords("office 2007 openxml php")
	60	+ ->setCategory("Test result file");
61	61
62	62
63	63	// Create a first sheet
		@@ -79,8 +79,8 @@ discard block
		block discarded – undo
79	79	// Set outline levels
80	80	echo date('H:i:s') , " Set outline levels" , EOL;
81	81	$objPHPExcel->getActiveSheet()->getColumnDimension('E')->setOutlineLevel(1)
82		- ->setVisible(false)
83		- ->setCollapsed(true);
	82	+ ->setVisible(false)
	83	+ ->setCollapsed(true);
84	84
85	85	// Freeze panes
86	86	echo date('H:i:s') , " Freeze panes" , EOL;
		@@ -94,11 +94,11 @@ discard block
		block discarded – undo
94	94
95	95	// Add data
96	96	for ($i = 2; $i <= 5000; $i++) {
97		- $objPHPExcel->getActiveSheet()->setCellValue('A' . $i, "FName $i")
98		- ->setCellValue('B' . $i, "LName $i")
99		- ->setCellValue('C' . $i, "PhoneNo $i")
100		- ->setCellValue('D' . $i, "FaxNo $i")
101		- ->setCellValue('E' . $i, true);
	97	+ $objPHPExcel->getActiveSheet()->setCellValue('A' . $i, "FName $i")
	98	+ ->setCellValue('B' . $i, "LName $i")
	99	+ ->setCellValue('C' . $i, "PhoneNo $i")
	100	+ ->setCellValue('D' . $i, "FaxNo $i")
	101	+ ->setCellValue('E' . $i, true);
102	102	}
103	103
104	104

		@@ -38,7 +38,7 @@
		block discarded – undo
38	38
39	39
40	40	if (!file_exists("05featuredemo.xlsx")) {
41		- exit("Please run 05featuredemo.php first." . EOL);
	41	+ exit("Please run 05featuredemo.php first." . EOL);
42	42	}
43	43
44	44	echo date('H:i:s') , " Load from Excel2007 file" , EOL;

PHPOffice / PhpSpreadsheet

Push — develop ( bf3457...467bab )

Status

Category

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch