Inspection of "Report coverage to Scrutinizer" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 539a89...685e29 )

by Adrien

created 2016-08-16 14:42 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@
 block discarded – undo
 
     public function testGetErrorCodes()
     {
-        $result = call_user_func(array(DataType::class,'getErrorCodes'));
+        $result = call_user_func(array(DataType::class, 'getErrorCodes'));
         $this->assertInternalType('array', $result);
         $this->assertGreaterThan(0, count($result));
         $this->assertArrayHasKey('#NULL!', $result);

Please login to merge, or discard this patch.

tests/PhpSpreadsheet/ReferenceHelperTest.php 1 patch

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -14,19 +14,19 @@  discard block
 block discarded – undo
     public function testColumnSort()
     {
         $columnBase = $columnExpectedResult = [
-            'A','B','Z',
-            'AA','AB','AZ',
-            'BA','BB','BZ',
-            'ZA','ZB','ZZ',
-            'AAA','AAB','AAZ',
-            'ABA','ABB','ABZ',
-            'AZA','AZB','AZZ',
-            'BAA','BAB','BAZ',
-            'BBA','BBB','BBZ',
-            'BZA','BZB','BZZ'
+            'A', 'B', 'Z',
+            'AA', 'AB', 'AZ',
+            'BA', 'BB', 'BZ',
+            'ZA', 'ZB', 'ZZ',
+            'AAA', 'AAB', 'AAZ',
+            'ABA', 'ABB', 'ABZ',
+            'AZA', 'AZB', 'AZZ',
+            'BAA', 'BAB', 'BAZ',
+            'BBA', 'BBB', 'BBZ',
+            'BZA', 'BZB', 'BZZ'
         ];
         shuffle($columnBase);
-        usort($columnBase, array(ReferenceHelper::class,'columnSort'));
+        usort($columnBase, array(ReferenceHelper::class, 'columnSort'));
         foreach ($columnBase as $key => $value) {
             $this->assertEquals($columnExpectedResult[$key], $value);
         }
@@ -35,20 +35,20 @@  discard block
 block discarded – undo
     public function testColumnReverseSort()
     {
         $columnBase = $columnExpectedResult = [
-            'A','B','Z',
-            'AA','AB','AZ',
-            'BA','BB','BZ',
-            'ZA','ZB','ZZ',
-            'AAA','AAB','AAZ',
-            'ABA','ABB','ABZ',
-            'AZA','AZB','AZZ',
-            'BAA','BAB','BAZ',
-            'BBA','BBB','BBZ',
-            'BZA','BZB','BZZ'
+            'A', 'B', 'Z',
+            'AA', 'AB', 'AZ',
+            'BA', 'BB', 'BZ',
+            'ZA', 'ZB', 'ZZ',
+            'AAA', 'AAB', 'AAZ',
+            'ABA', 'ABB', 'ABZ',
+            'AZA', 'AZB', 'AZZ',
+            'BAA', 'BAB', 'BAZ',
+            'BBA', 'BBB', 'BBZ',
+            'BZA', 'BZB', 'BZZ'
         ];
         shuffle($columnBase);
         $columnExpectedResult = array_reverse($columnExpectedResult);
-        usort($columnBase, array(ReferenceHelper::class,'columnReverseSort'));
+        usort($columnBase, array(ReferenceHelper::class, 'columnReverseSort'));
         foreach ($columnBase as $key => $value) {
             $this->assertEquals($columnExpectedResult[$key], $value);
         }

Please login to merge, or discard this patch.

tests/PhpSpreadsheet/Style/NumberFormatTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@
 block discarded – undo
 
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(NumberFormat::class,'toFormattedString'), $args);
+        $result = call_user_func_array(array(NumberFormat::class, 'toFormattedString'), $args);
         $this->assertEquals($expectedResult, $result);
     }
 

Please login to merge, or discard this patch.

tests/PhpSpreadsheet/Shared/DateTest.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@  discard block
 block discarded – undo
         );
 
         foreach ($calendarValues as $calendarValue) {
-            $result = call_user_func(array(Date::class,'setExcelCalendar'), $calendarValue);
+            $result = call_user_func(array(Date::class, 'setExcelCalendar'), $calendarValue);
             $this->assertTrue($result);
         }
     }
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
     public function testSetExcelCalendarWithInvalidValue()
     {
         $unsupportedCalendar = '2012';
-        $result = call_user_func(array(Date::class,'setExcelCalendar'), $unsupportedCalendar);
+        $result = call_user_func(array(Date::class, 'setExcelCalendar'), $unsupportedCalendar);
         $this->assertFalse($result);
     }
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
     public function testDateTimeExcelToTimestamp1900()
     {
         $result = call_user_func(
-            array(Date::class,'setExcelCalendar'),
+            array(Date::class, 'setExcelCalendar'),
             Date::CALENDAR_WINDOWS_1900
         );
 
@@ -53,13 +53,13 @@  discard block
 block discarded – undo
     public function testDateTimeTimestampToExcel1900()
     {
         $result = call_user_func(
-            array(Date::class,'setExcelCalendar'),
+            array(Date::class, 'setExcelCalendar'),
             Date::CALENDAR_WINDOWS_1900
         );
 
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(Date::class,'timestampToExcel'), $args);
+        $result = call_user_func_array(array(Date::class, 'timestampToExcel'), $args);
         $this->assertEquals($expectedResult, $result, null, 1E-5);
     }
 
@@ -74,13 +74,13 @@  discard block
 block discarded – undo
     public function testDateTimeDateTimeToExcel()
     {
         $result = call_user_func(
-            array(Date::class,'setExcelCalendar'),
+            array(Date::class, 'setExcelCalendar'),
             Date::CALENDAR_WINDOWS_1900
         );
 
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(Date::class,'dateTimeToExcel'), $args);
+        $result = call_user_func_array(array(Date::class, 'dateTimeToExcel'), $args);
         $this->assertEquals($expectedResult, $result, null, 1E-5);
     }
 
@@ -95,13 +95,13 @@  discard block
 block discarded – undo
     public function testDateTimeFormattedPHPToExcel1900()
     {
         $result = call_user_func(
-            array(Date::class,'setExcelCalendar'),
+            array(Date::class, 'setExcelCalendar'),
             Date::CALENDAR_WINDOWS_1900
         );
 
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(Date::class,'formattedPHPToExcel'), $args);
+        $result = call_user_func_array(array(Date::class, 'formattedPHPToExcel'), $args);
         $this->assertEquals($expectedResult, $result, null, 1E-5);
     }
 
@@ -116,13 +116,13 @@  discard block
 block discarded – undo
     public function testDateTimeExcelToTimestamp1904()
     {
         $result = call_user_func(
-            array(Date::class,'setExcelCalendar'),
+            array(Date::class, 'setExcelCalendar'),
             Date::CALENDAR_MAC_1904
         );
 
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
+        $result = call_user_func_array(array(Date::class, 'excelToTimestamp'), $args);
         $this->assertEquals($expectedResult, $result);
     }
 
@@ -137,13 +137,13 @@  discard block
 block discarded – undo
     public function testDateTimeTimestampToExcel1904()
     {
         $result = call_user_func(
-            array(Date::class,'setExcelCalendar'),
+            array(Date::class, 'setExcelCalendar'),
             Date::CALENDAR_MAC_1904
         );
 
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(Date::class,'timestampToExcel'), $args);
+        $result = call_user_func_array(array(Date::class, 'timestampToExcel'), $args);
         $this->assertEquals($expectedResult, $result, null, 1E-5);
     }
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
     {
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(Date::class,'isDateTimeFormatCode'), $args);
+        $result = call_user_func_array(array(Date::class, 'isDateTimeFormatCode'), $args);
         $this->assertEquals($expectedResult, $result);
     }
 
@@ -174,13 +174,13 @@  discard block
 block discarded – undo
     public function testDateTimeExcelToTimestamp1900Timezone()
     {
         $result = call_user_func(
-            array(Date::class,'setExcelCalendar'),
+            array(Date::class, 'setExcelCalendar'),
             Date::CALENDAR_WINDOWS_1900
         );
 
         $args = func_get_args();
         $expectedResult = array_pop($args);
-        $result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
+        $result = call_user_func_array(array(Date::class, 'excelToTimestamp'), $args);
         $this->assertEquals($expectedResult, $result);
     }
 

Please login to merge, or discard this patch.

src/PhpSpreadsheet/Shared/Date.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -30,8 +30,8 @@  discard block
 block discarded – undo
 class Date
 {
     /** constants */
-    const CALENDAR_WINDOWS_1900 = 1900;        //    Base date of 1st Jan 1900 = 1.0
-    const CALENDAR_MAC_1904 = 1904;            //    Base date of 2nd Jan 1904 = 1.0
+    const CALENDAR_WINDOWS_1900 = 1900; //    Base date of 1st Jan 1900 = 1.0
+    const CALENDAR_MAC_1904 = 1904; //    Base date of 2nd Jan 1904 = 1.0
 
     /*
      * Names of the months of the year, indexed by shortname
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
             return false;
         }
         // Try checking for any of the date formatting characters that don't appear within square braces
-        if (preg_match('/(^|\])[^\[]*['.self::$possibleDateFormatCharacters.']/i', $pFormatCode)) {
+        if (preg_match('/(^|\])[^\[]*[' . self::$possibleDateFormatCharacters . ']/i', $pFormatCode)) {
             //    We might also have a format mask containing quoted strings...
             //        we don't want to test for any of our characters within the quoted blocks
             if (strpos($pFormatCode, '"') !== false) {
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
                 foreach (explode('"', $pFormatCode) as $subVal) {
                     //    Only test in alternate array entries (the non-quoted blocks)
                     if (($segMatcher = !$segMatcher) &&
-                        (preg_match('/(^|\])[^\[]*['.self::$possibleDateFormatCharacters.']/i', $subVal))) {
+                        (preg_match('/(^|\])[^\[]*[' . self::$possibleDateFormatCharacters . ']/i', $subVal))) {
                         return true;
                     }
                 }

Please login to merge, or discard this patch.

tests/data/Shared/Date/DateTimeToExcel.php 1 patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

		@@ -2,19 +2,19 @@
		block discarded – undo
2	2
3	3	// DateTime object Result Comments
4	4	return [
5		- [ new DateTime('1900-01-01'), 1.0 ], // Excel 1900 base calendar date
6		- [ new DateTime('1900-02-28'), 59.0 ], // This and next test show gap for the mythical
7		- [ new DateTime('1900-03-01'), 61.0 ], // MS Excel 1900 Leap Year
8		- [ new DateTime('1901-12-14'), 714.0 ], // Unix Timestamp 32-bit Earliest Date
9		- [ new DateTime('1903-12-31'), 1461.0 ],
10		- [ new DateTime('1904-01-01'), 1462.0 ], // Excel 1904 Calendar Base Date
11		- [ new DateTime('1904-01-02'), 1463.0 ],
12		- [ new DateTime('1960-12-19'), 22269.0 ],
13		- [ new DateTime('1970-01-01'), 25569.0 ], // Unix Timestamp Base Date
14		- [ new DateTime('1982-12-07'), 30292.0 ],
15		- [ new DateTime('2008-06-12'), 39611.0 ],
16		- [ new DateTime('2038-01-19'), 50424.0 ], // Unix Timestamp 32-bit Latest Date
17		- [ new DateTime('1903-05-18 13:37:46'), 1234.56789 ],
18		- [ new DateTime('1933-10-18 16:17:37'), 12345.6789 ],
19		- [ new DateTime('2099-12-31'), 73050.0 ],
	5	+ [new DateTime('1900-01-01'), 1.0], // Excel 1900 base calendar date
	6	+ [new DateTime('1900-02-28'), 59.0], // This and next test show gap for the mythical
	7	+ [new DateTime('1900-03-01'), 61.0], // MS Excel 1900 Leap Year
	8	+ [new DateTime('1901-12-14'), 714.0], // Unix Timestamp 32-bit Earliest Date
	9	+ [new DateTime('1903-12-31'), 1461.0],
	10	+ [new DateTime('1904-01-01'), 1462.0], // Excel 1904 Calendar Base Date
	11	+ [new DateTime('1904-01-02'), 1463.0],
	12	+ [new DateTime('1960-12-19'), 22269.0],
	13	+ [new DateTime('1970-01-01'), 25569.0], // Unix Timestamp Base Date
	14	+ [new DateTime('1982-12-07'), 30292.0],
	15	+ [new DateTime('2008-06-12'), 39611.0],
	16	+ [new DateTime('2038-01-19'), 50424.0], // Unix Timestamp 32-bit Latest Date
	17	+ [new DateTime('1903-05-18 13:37:46'), 1234.56789],
	18	+ [new DateTime('1933-10-18 16:17:37'), 12345.6789],
	19	+ [new DateTime('2099-12-31'), 73050.0],
20	20	];

Please login to merge, or discard this patch.

tests/data/Shared/Date/ExcelToTimestamp1900.php 1 patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

		@@ -2,18 +2,18 @@
		block discarded – undo
2	2
3	3	// Excel DateTimeStamp Result Comments
4	4	return [
5		- [ 714, -2147472000 ], // PHP 32-bit Earliest Date 14-Dec-1901
6		- [ 1461, -2082931200 ], // 31-Dec-1903
7		- [ 1462, -2082844800 ], // Excel 1904 Calendar Base Date 01-Jan-1904
8		- [ 1463, -2082758400 ], // 02-Jan-1904
9		- [ 22269, -285120000 ], // 19-Dec-1960
10		- [ 25569, 0 ], // PHP Base Date 01-Jan-1970
11		- [ 30292, 408067200 ], // 07-Dec-1982
12		- [ 39611, 1213228800 ], // 12-Jun-2008
13		- [ 50424, 2147472000 ], // PHP 32-bit Latest Date 19-Jan-2038
14		- [ 1234.56789, -2102494934 ], // 18-May-1903 13:37:46
15		- [ 12345.6789, -1142494943 ], // 18-Oct-1933 16:17:37
16		- [ 0.5, 43200 ], // 12:00:00
17		- [ 0.75, 64800 ], // 18:00.00
18		- [ 0.12345, 10666 ], // 02:57:46
	5	+ [714, -2147472000], // PHP 32-bit Earliest Date 14-Dec-1901
	6	+ [1461, -2082931200], // 31-Dec-1903
	7	+ [1462, -2082844800], // Excel 1904 Calendar Base Date 01-Jan-1904
	8	+ [1463, -2082758400], // 02-Jan-1904
	9	+ [22269, -285120000], // 19-Dec-1960
	10	+ [25569, 0], // PHP Base Date 01-Jan-1970
	11	+ [30292, 408067200], // 07-Dec-1982
	12	+ [39611, 1213228800], // 12-Jun-2008
	13	+ [50424, 2147472000], // PHP 32-bit Latest Date 19-Jan-2038
	14	+ [1234.56789, -2102494934], // 18-May-1903 13:37:46
	15	+ [12345.6789, -1142494943], // 18-Oct-1933 16:17:37
	16	+ [0.5, 43200], // 12:00:00
	17	+ [0.75, 64800], // 18:00.00
	18	+ [0.12345, 10666], // 02:57:46
19	19	];

Please login to merge, or discard this patch.

tests/data/Shared/Date/TimestampToExcel1900.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

		@@ -2,15 +2,15 @@
		block discarded – undo
2	2
3	3	// Unix TimeStamp Result Comments
4	4	return [
5		- [ -2147472000, 714 ], // PHP 32-bit Earliest Date 14-Dec-1901
6		- [ -2082931200, 1461 ], // 31-Dec-1903
7		- [ -2082844800, 1462 ], // Excel 1904 Calendar Base Date 01-Jan-1904
8		- [ -2082758400, 1463 ], // 02-Jan-1904
9		- [ -285120000, 22269 ], // 19-Dec-1960
10		- [ 0, 25569 ], // PHP Base Date 01-Jan-1970
11		- [ 408067200, 30292 ], // 07-Dec-1982
12		- [ 1213228800, 39611 ], // 12-Jun-2008
13		- [ 2147472000, 50424 ], // PHP 32-bit Latest Date 19-Jan-2038
14		- [ -2102494934, 1234.56789 ], // 18-May-1903 13:37:46
15		- [ -1142494943, 12345.6789 ], // 18-Oct-1933 16:17:37
	5	+ [ -2147472000, 714], // PHP 32-bit Earliest Date 14-Dec-1901
	6	+ [ -2082931200, 1461], // 31-Dec-1903
	7	+ [ -2082844800, 1462], // Excel 1904 Calendar Base Date 01-Jan-1904
	8	+ [ -2082758400, 1463], // 02-Jan-1904
	9	+ [ -285120000, 22269], // 19-Dec-1960
	10	+ [0, 25569], // PHP Base Date 01-Jan-1970
	11	+ [408067200, 30292], // 07-Dec-1982
	12	+ [1213228800, 39611], // 12-Jun-2008
	13	+ [2147472000, 50424], // PHP 32-bit Latest Date 19-Jan-2038
	14	+ [ -2102494934, 1234.56789], // 18-May-1903 13:37:46
	15	+ [ -1142494943, 12345.6789], // 18-Oct-1933 16:17:37
16	16	];

Please login to merge, or discard this patch.

tests/data/Shared/Date/ExcelToTimestamp1900Timezone.php 1 patch

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

		@@ -2,26 +2,26 @@
		block discarded – undo
2	2
3	3	// Excel DateTimeStamp Timezone Result Comments
4	4	return [
5		- [ 22269, 'America/New_York', -285102000 ], // 19-Dec-1960 00:00:00 EST => 19-Dec-1960 05:00:00 UTC
6		- [ 25569, 'America/New_York', 18000 ], // 01-Jan-1970 00:00:00 EST => 01-Jan-1970 05:00:00 UTC PHP Base Date
7		- [ 30292, 'America/New_York', 408085200 ], // 07-Dec-1982 00:00:00 EST => 07-Dec-1982 05:00:00 UTC
8		- [ 39611, 'America/New_York', 1213243200 ], // 12-Jun-2008 00:00:00 EDT => 12-Jun-2008 04:00:00 UTC
9		- [ 50424, 'America/New_York', 2147490000 ], // 19-Jan-2038 00:00:00 EST => 19-Jan-2038 05:00:00 UTC PHP 32-bit Latest Date
10		- [ 22345.56789, 'America/New_York', -278486534 ], // 05-Mar-1961 13:37:46 EST => 05-Mar-1961 18:37:46 UTC
11		- [ 22345.6789, 'America/New_York', -278476943 ], // 05-Mar-1961 16:17:37 EST => 05-Mar-1961 21:17:37 UTC
12		- [ 0.5, 'America/New_York', 61200 ], // 12:00:00 EST => 17:00:00 UTC
13		- [ 0.75, 'America/New_York', 82800 ], // 18:00.00 EST => 23:00:00 UTC
14		- [ 0.12345, 'America/New_York', 28666 ], // 02:57:46 EST => 07:57:46 UTC
15		- [ 41215, 'America/New_York', 1351828800 ], // 02-Nov-2012 00:00:00 EDT => 02-Nov-2012 04:00:00 UTC
16		- [ 22269, 'Pacific/Auckland', -285163200 ], // 19-Dec-1960 00:00:00 NZST => 18-Dec-1960 12:00:00 UTC
17		- [ 25569, 'Pacific/Auckland', -43200 ], // 01-Jan-1970 00:00:00 NZST => 31-Dec-1969 12:00:00 UTC PHP Base Date
18		- [ 30292, 'Pacific/Auckland', 408020400 ], // 07-Dec-1982 00:00:00 NZDT => 06-Dec-1982 11:00:00 UTC
19		- [ 39611, 'Pacific/Auckland', 1213185600 ], // 12-Jun-2008 00:00:00 NZST => 11-Jun-2008 12:00:00 UTC
20		- [ 50423.5, 'Pacific/Auckland', 2147382000 ], // 18-Jan-2038 12:00:00 NZDT => 17-Jan-2038 23:00:00 UTC PHP 32-bit Latest Date
21		- [ 22345.56789, 'Pacific/Auckland', -278547734 ], // 05-Mar-1961 13:37:46 NZST => 05-Mar-1961 01:37:46 UTC
22		- [ 22345.6789, 'Pacific/Auckland', -278538143 ], // 05-Mar-1961 16:17:37 NZST => 05-Mar-1961 04:17:37 UTC
23		- [ 0.5, 'Pacific/Auckland', 0 ], // 12:00:00 NZST => 00:00:00 UTC
24		- [ 0.75, 'Pacific/Auckland', 21600 ], // 18:00.00 NZST => 06:00:00 UTC
25		- [ 0.12345, 'Pacific/Auckland', -32534 ], // 02:57:46 NZST => 14:57:46 UTC
26		- [ 41215, 'Pacific/Auckland', 1351767600 ], // 02-Nov-2012 00:00:00 NZDT => 01-Nov-2012 11:00:00 UTC
	5	+ [22269, 'America/New_York', -285102000], // 19-Dec-1960 00:00:00 EST => 19-Dec-1960 05:00:00 UTC
	6	+ [25569, 'America/New_York', 18000], // 01-Jan-1970 00:00:00 EST => 01-Jan-1970 05:00:00 UTC PHP Base Date
	7	+ [30292, 'America/New_York', 408085200], // 07-Dec-1982 00:00:00 EST => 07-Dec-1982 05:00:00 UTC
	8	+ [39611, 'America/New_York', 1213243200], // 12-Jun-2008 00:00:00 EDT => 12-Jun-2008 04:00:00 UTC
	9	+ [50424, 'America/New_York', 2147490000], // 19-Jan-2038 00:00:00 EST => 19-Jan-2038 05:00:00 UTC PHP 32-bit Latest Date
	10	+ [22345.56789, 'America/New_York', -278486534], // 05-Mar-1961 13:37:46 EST => 05-Mar-1961 18:37:46 UTC
	11	+ [22345.6789, 'America/New_York', -278476943], // 05-Mar-1961 16:17:37 EST => 05-Mar-1961 21:17:37 UTC
	12	+ [0.5, 'America/New_York', 61200], // 12:00:00 EST => 17:00:00 UTC
	13	+ [0.75, 'America/New_York', 82800], // 18:00.00 EST => 23:00:00 UTC
	14	+ [0.12345, 'America/New_York', 28666], // 02:57:46 EST => 07:57:46 UTC
	15	+ [41215, 'America/New_York', 1351828800], // 02-Nov-2012 00:00:00 EDT => 02-Nov-2012 04:00:00 UTC
	16	+ [22269, 'Pacific/Auckland', -285163200], // 19-Dec-1960 00:00:00 NZST => 18-Dec-1960 12:00:00 UTC
	17	+ [25569, 'Pacific/Auckland', -43200], // 01-Jan-1970 00:00:00 NZST => 31-Dec-1969 12:00:00 UTC PHP Base Date
	18	+ [30292, 'Pacific/Auckland', 408020400], // 07-Dec-1982 00:00:00 NZDT => 06-Dec-1982 11:00:00 UTC
	19	+ [39611, 'Pacific/Auckland', 1213185600], // 12-Jun-2008 00:00:00 NZST => 11-Jun-2008 12:00:00 UTC
	20	+ [50423.5, 'Pacific/Auckland', 2147382000], // 18-Jan-2038 12:00:00 NZDT => 17-Jan-2038 23:00:00 UTC PHP 32-bit Latest Date
	21	+ [22345.56789, 'Pacific/Auckland', -278547734], // 05-Mar-1961 13:37:46 NZST => 05-Mar-1961 01:37:46 UTC
	22	+ [22345.6789, 'Pacific/Auckland', -278538143], // 05-Mar-1961 16:17:37 NZST => 05-Mar-1961 04:17:37 UTC
	23	+ [0.5, 'Pacific/Auckland', 0], // 12:00:00 NZST => 00:00:00 UTC
	24	+ [0.75, 'Pacific/Auckland', 21600], // 18:00.00 NZST => 06:00:00 UTC
	25	+ [0.12345, 'Pacific/Auckland', -32534], // 02:57:46 NZST => 14:57:46 UTC
	26	+ [41215, 'Pacific/Auckland', 1351767600], // 02-Nov-2012 00:00:00 NZDT => 01-Nov-2012 11:00:00 UTC
27	27	];

Please login to merge, or discard this patch.

		@@ -17,7 +17,7 @@
		block discarded – undo
17	17
18	18	public function testGetErrorCodes()
19	19	{
20		- $result = call_user_func(array(DataType::class,'getErrorCodes'));
	20	+ $result = call_user_func(array(DataType::class, 'getErrorCodes'));
21	21	$this->assertInternalType('array', $result);
22	22	$this->assertGreaterThan(0, count($result));
23	23	$this->assertArrayHasKey('#NULL!', $result);

		@@ -14,19 +14,19 @@ discard block
		block discarded – undo
14	14	public function testColumnSort()
15	15	{
16	16	$columnBase = $columnExpectedResult = [
17		- 'A','B','Z',
18		- 'AA','AB','AZ',
19		- 'BA','BB','BZ',
20		- 'ZA','ZB','ZZ',
21		- 'AAA','AAB','AAZ',
22		- 'ABA','ABB','ABZ',
23		- 'AZA','AZB','AZZ',
24		- 'BAA','BAB','BAZ',
25		- 'BBA','BBB','BBZ',
26		- 'BZA','BZB','BZZ'
	17	+ 'A', 'B', 'Z',
	18	+ 'AA', 'AB', 'AZ',
	19	+ 'BA', 'BB', 'BZ',
	20	+ 'ZA', 'ZB', 'ZZ',
	21	+ 'AAA', 'AAB', 'AAZ',
	22	+ 'ABA', 'ABB', 'ABZ',
	23	+ 'AZA', 'AZB', 'AZZ',
	24	+ 'BAA', 'BAB', 'BAZ',
	25	+ 'BBA', 'BBB', 'BBZ',
	26	+ 'BZA', 'BZB', 'BZZ'
27	27	];
28	28	shuffle($columnBase);
29		- usort($columnBase, array(ReferenceHelper::class,'columnSort'));
	29	+ usort($columnBase, array(ReferenceHelper::class, 'columnSort'));
30	30	foreach ($columnBase as $key => $value) {
31	31	$this->assertEquals($columnExpectedResult[$key], $value);
32	32	}
		@@ -35,20 +35,20 @@ discard block
		block discarded – undo
35	35	public function testColumnReverseSort()
36	36	{
37	37	$columnBase = $columnExpectedResult = [
38		- 'A','B','Z',
39		- 'AA','AB','AZ',
40		- 'BA','BB','BZ',
41		- 'ZA','ZB','ZZ',
42		- 'AAA','AAB','AAZ',
43		- 'ABA','ABB','ABZ',
44		- 'AZA','AZB','AZZ',
45		- 'BAA','BAB','BAZ',
46		- 'BBA','BBB','BBZ',
47		- 'BZA','BZB','BZZ'
	38	+ 'A', 'B', 'Z',
	39	+ 'AA', 'AB', 'AZ',
	40	+ 'BA', 'BB', 'BZ',
	41	+ 'ZA', 'ZB', 'ZZ',
	42	+ 'AAA', 'AAB', 'AAZ',
	43	+ 'ABA', 'ABB', 'ABZ',
	44	+ 'AZA', 'AZB', 'AZZ',
	45	+ 'BAA', 'BAB', 'BAZ',
	46	+ 'BBA', 'BBB', 'BBZ',
	47	+ 'BZA', 'BZB', 'BZZ'
48	48	];
49	49	shuffle($columnBase);
50	50	$columnExpectedResult = array_reverse($columnExpectedResult);
51		- usort($columnBase, array(ReferenceHelper::class,'columnReverseSort'));
	51	+ usort($columnBase, array(ReferenceHelper::class, 'columnReverseSort'));
52	52	foreach ($columnBase as $key => $value) {
53	53	$this->assertEquals($columnExpectedResult[$key], $value);
54	54	}

		@@ -23,7 +23,7 @@
		block discarded – undo
23	23
24	24	$args = func_get_args();
25	25	$expectedResult = array_pop($args);
26		- $result = call_user_func_array(array(NumberFormat::class,'toFormattedString'), $args);
	26	+ $result = call_user_func_array(array(NumberFormat::class, 'toFormattedString'), $args);
27	27	$this->assertEquals($expectedResult, $result);
28	28	}
29	29

		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14	);
15	15
16	16	foreach ($calendarValues as $calendarValue) {
17		- $result = call_user_func(array(Date::class,'setExcelCalendar'), $calendarValue);
	17	+ $result = call_user_func(array(Date::class, 'setExcelCalendar'), $calendarValue);
18	18	$this->assertTrue($result);
19	19	}
20	20	}
		@@ -22,7 +22,7 @@ discard block
		block discarded – undo
22	22	public function testSetExcelCalendarWithInvalidValue()
23	23	{
24	24	$unsupportedCalendar = '2012';
25		- $result = call_user_func(array(Date::class,'setExcelCalendar'), $unsupportedCalendar);
	25	+ $result = call_user_func(array(Date::class, 'setExcelCalendar'), $unsupportedCalendar);
26	26	$this->assertFalse($result);
27	27	}
28	28
		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	public function testDateTimeExcelToTimestamp1900()
33	33	{
34	34	$result = call_user_func(
35		- array(Date::class,'setExcelCalendar'),
	35	+ array(Date::class, 'setExcelCalendar'),
36	36	Date::CALENDAR_WINDOWS_1900
37	37	);
38	38
		@@ -53,13 +53,13 @@ discard block
		block discarded – undo
53	53	public function testDateTimeTimestampToExcel1900()
54	54	{
55	55	$result = call_user_func(
56		- array(Date::class,'setExcelCalendar'),
	56	+ array(Date::class, 'setExcelCalendar'),
57	57	Date::CALENDAR_WINDOWS_1900
58	58	);
59	59
60	60	$args = func_get_args();
61	61	$expectedResult = array_pop($args);
62		- $result = call_user_func_array(array(Date::class,'timestampToExcel'), $args);
	62	+ $result = call_user_func_array(array(Date::class, 'timestampToExcel'), $args);
63	63	$this->assertEquals($expectedResult, $result, null, 1E-5);
64	64	}
65	65
		@@ -74,13 +74,13 @@ discard block
		block discarded – undo
74	74	public function testDateTimeDateTimeToExcel()
75	75	{
76	76	$result = call_user_func(
77		- array(Date::class,'setExcelCalendar'),
	77	+ array(Date::class, 'setExcelCalendar'),
78	78	Date::CALENDAR_WINDOWS_1900
79	79	);
80	80
81	81	$args = func_get_args();
82	82	$expectedResult = array_pop($args);
83		- $result = call_user_func_array(array(Date::class,'dateTimeToExcel'), $args);
	83	+ $result = call_user_func_array(array(Date::class, 'dateTimeToExcel'), $args);
84	84	$this->assertEquals($expectedResult, $result, null, 1E-5);
85	85	}
86	86
		@@ -95,13 +95,13 @@ discard block
		block discarded – undo
95	95	public function testDateTimeFormattedPHPToExcel1900()
96	96	{
97	97	$result = call_user_func(
98		- array(Date::class,'setExcelCalendar'),
	98	+ array(Date::class, 'setExcelCalendar'),
99	99	Date::CALENDAR_WINDOWS_1900
100	100	);
101	101
102	102	$args = func_get_args();
103	103	$expectedResult = array_pop($args);
104		- $result = call_user_func_array(array(Date::class,'formattedPHPToExcel'), $args);
	104	+ $result = call_user_func_array(array(Date::class, 'formattedPHPToExcel'), $args);
105	105	$this->assertEquals($expectedResult, $result, null, 1E-5);
106	106	}
107	107
		@@ -116,13 +116,13 @@ discard block
		block discarded – undo
116	116	public function testDateTimeExcelToTimestamp1904()
117	117	{
118	118	$result = call_user_func(
119		- array(Date::class,'setExcelCalendar'),
	119	+ array(Date::class, 'setExcelCalendar'),
120	120	Date::CALENDAR_MAC_1904
121	121	);
122	122
123	123	$args = func_get_args();
124	124	$expectedResult = array_pop($args);
125		- $result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
	125	+ $result = call_user_func_array(array(Date::class, 'excelToTimestamp'), $args);
126	126	$this->assertEquals($expectedResult, $result);
127	127	}
128	128
		@@ -137,13 +137,13 @@ discard block
		block discarded – undo
137	137	public function testDateTimeTimestampToExcel1904()
138	138	{
139	139	$result = call_user_func(
140		- array(Date::class,'setExcelCalendar'),
	140	+ array(Date::class, 'setExcelCalendar'),
141	141	Date::CALENDAR_MAC_1904
142	142	);
143	143
144	144	$args = func_get_args();
145	145	$expectedResult = array_pop($args);
146		- $result = call_user_func_array(array(Date::class,'timestampToExcel'), $args);
	146	+ $result = call_user_func_array(array(Date::class, 'timestampToExcel'), $args);
147	147	$this->assertEquals($expectedResult, $result, null, 1E-5);
148	148	}
149	149
		@@ -159,7 +159,7 @@ discard block
		block discarded – undo
159	159	{
160	160	$args = func_get_args();
161	161	$expectedResult = array_pop($args);
162		- $result = call_user_func_array(array(Date::class,'isDateTimeFormatCode'), $args);
	162	+ $result = call_user_func_array(array(Date::class, 'isDateTimeFormatCode'), $args);
163	163	$this->assertEquals($expectedResult, $result);
164	164	}
165	165
		@@ -174,13 +174,13 @@ discard block
		block discarded – undo
174	174	public function testDateTimeExcelToTimestamp1900Timezone()
175	175	{
176	176	$result = call_user_func(
177		- array(Date::class,'setExcelCalendar'),
	177	+ array(Date::class, 'setExcelCalendar'),
178	178	Date::CALENDAR_WINDOWS_1900
179	179	);
180	180
181	181	$args = func_get_args();
182	182	$expectedResult = array_pop($args);
183		- $result = call_user_func_array(array(Date::class,'excelToTimestamp'), $args);
	183	+ $result = call_user_func_array(array(Date::class, 'excelToTimestamp'), $args);
184	184	$this->assertEquals($expectedResult, $result);
185	185	}
186	186

		@@ -30,8 +30,8 @@ discard block
		block discarded – undo
30	30	class Date
31	31	{
32	32	/** constants */
33		- const CALENDAR_WINDOWS_1900 = 1900; // Base date of 1st Jan 1900 = 1.0
34		- const CALENDAR_MAC_1904 = 1904; // Base date of 2nd Jan 1904 = 1.0
	33	+ const CALENDAR_WINDOWS_1900 = 1900; // Base date of 1st Jan 1900 = 1.0
	34	+ const CALENDAR_MAC_1904 = 1904; // Base date of 2nd Jan 1904 = 1.0
35	35
36	36	/*
37	37	* Names of the months of the year, indexed by shortname
		@@ -388,7 +388,7 @@ discard block
		block discarded – undo
388	388	return false;
389	389	}
390	390	// Try checking for any of the date formatting characters that don't appear within square braces
391		- if (preg_match('/(^\|\])[^\[]*['.self::$possibleDateFormatCharacters.']/i', $pFormatCode)) {
	391	+ if (preg_match('/(^\|\])[^\[]*[' . self::$possibleDateFormatCharacters . ']/i', $pFormatCode)) {
392	392	// We might also have a format mask containing quoted strings...
393	393	// we don't want to test for any of our characters within the quoted blocks
394	394	if (strpos($pFormatCode, '"') !== false) {
		@@ -396,7 +396,7 @@ discard block
		block discarded – undo
396	396	foreach (explode('"', $pFormatCode) as $subVal) {
397	397	// Only test in alternate array entries (the non-quoted blocks)
398	398	if (($segMatcher = !$segMatcher) &&
399		- (preg_match('/(^\|\])[^\[]*['.self::$possibleDateFormatCharacters.']/i', $subVal))) {
	399	+ (preg_match('/(^\|\])[^\[]*[' . self::$possibleDateFormatCharacters . ']/i', $subVal))) {
400	400	return true;
401	401	}
402	402	}

PHPOffice / PhpSpreadsheet

Push — develop ( 539a89...685e29 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch