Completed
Pull Request — develop (#147)
by
unknown
24:31 queued 11:25
created
src/PhpSpreadsheet/Shared/OLE/PPS/Root.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      * If a resource pointer to a stream created by fopen() is passed
57 57
      * it will be used, but you have to close such stream by yourself.
58 58
      *
59
-     * @param string|resource $filename the name of the file or stream where to save the OLE container
59
+     * @param string $filename the name of the file or stream where to save the OLE container
60 60
      *
61 61
      * @throws \PhpOffice\PhpSpreadsheet\Writer\Exception
62 62
      *
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      *
122 122
      * @param array $raList Reference to an array of PPS's
123 123
      *
124
-     * @return float[] The array of numbers
124
+     * @return double[] The array of numbers
125 125
      */
126 126
     public function _calcSize(&$raList)
127 127
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Spreadsheet.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
      * set ribbon XML data.
219 219
      *
220 220
      * @param null|mixed $target
221
-     * @param null|mixed $xmlData
221
+     * @param string $xmlData
222 222
      */
223 223
     public function setRibbonXMLData($target, $xmlData)
224 224
     {
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
     /**
286 286
      * retrieve Binaries Ribbon Objects.
287 287
      *
288
-     * @param mixed $what
288
+     * @param string $what
289 289
      */
290 290
     public function getRibbonBinObjects($what = 'all')
291 291
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet.php 1 patch
Doc Comments   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -580,7 +580,7 @@  discard block
 block discarded – undo
580 580
      *
581 581
      * @throws Exception
582 582
      *
583
-     * @return false|Chart
583
+     * @return Chart
584 584
      */
585 585
     public function getChartByIndex($index)
586 586
     {
@@ -1089,7 +1089,7 @@  discard block
 block discarded – undo
1089 1089
      * @param string $column Return the highest data row for the specified column,
1090 1090
      *                                     or the highest data row of any column if no column letter is passed
1091 1091
      *
1092
-     * @return string Highest row number that contains data
1092
+     * @return integer Highest row number that contains data
1093 1093
      */
1094 1094
     public function getHighestDataRow($column = null)
1095 1095
     {
@@ -1141,7 +1141,7 @@  discard block
 block discarded – undo
1141 1141
      * Set a cell value.
1142 1142
      *
1143 1143
      * @param string $pCoordinate Coordinate of the cell, eg: 'A1'
1144
-     * @param mixed $pValue Value of the cell
1144
+     * @param string $pValue Value of the cell
1145 1145
      * @param string $pDataType Explicit data type, see Cell\DataType::TYPE_*
1146 1146
      *
1147 1147
      * @return Worksheet
@@ -1161,7 +1161,6 @@  discard block
 block discarded – undo
1161 1161
      * @param int $pRow Numeric row coordinate of the cell
1162 1162
      * @param mixed $pValue Value of the cell
1163 1163
      * @param string $pDataType Explicit data type, see Cell\DataType::TYPE_*
1164
-     * @param bool $returnCell Return the worksheet (false, default) or the cell (true)
1165 1164
      *
1166 1165
      * @return Worksheet
1167 1166
      */
@@ -1347,7 +1346,7 @@  discard block
 block discarded – undo
1347 1346
      * Get row dimension at a specific row.
1348 1347
      *
1349 1348
      * @param int $pRow Numeric index of the row
1350
-     * @param mixed $create
1349
+     * @param boolean $create
1351 1350
      *
1352 1351
      * @return Worksheet\RowDimension
1353 1352
      */
@@ -1373,7 +1372,7 @@  discard block
 block discarded – undo
1373 1372
      * Get column dimension at a specific column.
1374 1373
      *
1375 1374
      * @param string $pColumn String index of the column eg: 'A'
1376
-     * @param mixed $create
1375
+     * @param boolean $create
1377 1376
      *
1378 1377
      * @return Worksheet\ColumnDimension
1379 1378
      */
@@ -1919,7 +1918,7 @@  discard block
 block discarded – undo
1919 1918
     /**
1920 1919
      * Set AutoFilter.
1921 1920
      *
1922
-     * @param Worksheet\AutoFilter|string $pValue
1921
+     * @param string $pValue
1923 1922
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
1924 1923
      *
1925 1924
      * @throws Exception
@@ -2977,11 +2976,11 @@  discard block
 block discarded – undo
2977 2976
      * Define the code name of the sheet.
2978 2977
      *
2979 2978
      * @param null|string Same rule as Title minus space not allowed (but, like Excel, change silently space to underscore)
2980
-     * @param null|mixed $pValue
2979
+     * @param string $pValue
2981 2980
      *
2982 2981
      * @throws Exception
2983 2982
      *
2984
-     * @return objWorksheet
2983
+     * @return Worksheet
2985 2984
      */
2986 2985
     public function setCodeName($pValue)
2987 2986
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/PageSetup.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
     /**
472 472
      * Set Columns to repeat at left.
473 473
      *
474
-     * @param array $pValue Containing start column and end column, empty array if option unset
474
+     * @param string[] $pValue Containing start column and end column, empty array if option unset
475 475
      *
476 476
      * @return PageSetup
477 477
      */
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
526 526
     /**
527 527
      * Set Rows to repeat at top.
528 528
      *
529
-     * @param array $pValue Containing start column and end column, empty array if option unset
529
+     * @param string[] $pValue Containing start column and end column, empty array if option unset
530 530
      *
531 531
      * @return PageSetup
532 532
      */
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader09.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,9 +48,9 @@
 block discarded – undo
48 48
 
49 49
 $filterSubset = new MyReadFilter();
50 50
 
51
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
51
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
52 52
 $reader = IOFactory::createReader($inputFileType);
53
-echo 'Loading Sheet "',$sheetname,'" only<br />';
53
+echo 'Loading Sheet "', $sheetname, '" only<br />';
54 54
 $reader->setLoadSheetsOnly($sheetname);
55 55
 echo 'Loading Sheet using filter<br />';
56 56
 $reader->setReadFilter($filterSubset);
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader03.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 //	$inputFileType = 'Csv';
33 33
 $inputFileName = './sampleData/example1.xls';
34 34
 
35
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
35
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36 36
 $reader = IOFactory::createReader($inputFileType);
37 37
 $spreadsheet = $reader->load($inputFileName);
38 38
 
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader14.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
 /*  Tell the Reader that we want to use the Read Filter that we've Instantiated  **/
72 72
 /*    and that we want to store it in contiguous rows/columns  **/
73 73
 $reader->setReadFilter($chunkFilter)
74
-          ->setContiguous(true);
74
+            ->setContiguous(true);
75 75
 
76 76
 /*  Instantiate a new PhpSpreadsheet object manually  **/
77 77
 $spreadsheet = new Spreadsheet();
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
     }
58 58
 }
59 59
 
60
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
60
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
61 61
 /*  Create a new Reader of the type defined in $inputFileType  **/
62 62
 $reader = IOFactory::createReader($inputFileType);
63 63
 
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader07.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,18 +31,18 @@
 block discarded – undo
31 31
 $inputFileName = './sampleData/example1.xls';
32 32
 $sheetname = 'Data Sheet #2';
33 33
 
34
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
34
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
35 35
 $reader = IOFactory::createReader($inputFileType);
36
-echo 'Loading Sheet "',$sheetname,'" only<br />';
36
+echo 'Loading Sheet "', $sheetname, '" only<br />';
37 37
 $reader->setLoadSheetsOnly($sheetname);
38 38
 $spreadsheet = $reader->load($inputFileName);
39 39
 
40 40
 echo '<hr />';
41 41
 
42
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
42
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
43 43
 $loadedSheetNames = $spreadsheet->getSheetNames();
44 44
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
45
-    echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
45
+    echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
46 46
 }
47 47
 
48 48
 ?>
Please login to merge, or discard this patch.
docs/Examples/Reader/exampleReader04.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@
 block discarded – undo
26 26
 $inputFileName = './sampleData/example1.xls';
27 27
 
28 28
 $inputFileType = IOFactory::identify($inputFileName);
29
-echo 'File ',pathinfo($inputFileName, PATHINFO_BASENAME),' has been identified as an ',$inputFileType,' file<br />';
29
+echo 'File ', pathinfo($inputFileName, PATHINFO_BASENAME), ' has been identified as an ', $inputFileType, ' file<br />';
30 30
 
31
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with the identified reader type<br />';
31
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with the identified reader type<br />';
32 32
 $reader = IOFactory::createReader($inputFileType);
33 33
 $spreadsheet = $reader->load($inputFileName);
34 34
 
Please login to merge, or discard this patch.