Completed
Pull Request — develop (#222)
by Adrien
23:38 queued 17:58
created
src/PhpSpreadsheet/Shared/JAMA/Matrix.php 1 patch
Doc Comments   +2 added lines, -19 removed lines patch added patch discarded remove patch
@@ -149,10 +149,6 @@  discard block
 block discarded – undo
149 149
      *
150 150
      *    Get a submatrix
151 151
      *
152
-     * @param int $i0 Initial row index
153
-     * @param int $iF Final row index
154
-     * @param int $j0 Initial column index
155
-     * @param int $jF Final column index
156 152
      *
157 153
      * @return Matrix Submatrix
158 154
      */
@@ -345,7 +341,7 @@  discard block
 block discarded – undo
345 341
      *
346 342
      * @param int $m Row dimension
347 343
      * @param int $n Column dimension
348
-     * @param mixed $c Diagonal value
344
+     * @param integer $c Diagonal value
349 345
      *
350 346
      * @return Matrix Diagonal matrix
351 347
      */
@@ -429,7 +425,7 @@  discard block
 block discarded – undo
429 425
      *
430 426
      *    Sum of diagonal elements
431 427
      *
432
-     * @return float Sum of diagonal elements
428
+     * @return integer Sum of diagonal elements
433 429
      */
434 430
     public function trace()
435 431
     {
@@ -458,7 +454,6 @@  discard block
 block discarded – undo
458 454
      *
459 455
      *    A + B
460 456
      *
461
-     * @param mixed $B Matrix/Array
462 457
      *
463 458
      * @return Matrix Sum
464 459
      */
@@ -500,7 +495,6 @@  discard block
 block discarded – undo
500 495
      *
501 496
      *    A = A + B
502 497
      *
503
-     * @param mixed $B Matrix/Array
504 498
      *
505 499
      * @return Matrix Sum
506 500
      */
@@ -556,7 +550,6 @@  discard block
 block discarded – undo
556 550
      *
557 551
      *    A - B
558 552
      *
559
-     * @param mixed $B Matrix/Array
560 553
      *
561 554
      * @return Matrix Sum
562 555
      */
@@ -598,7 +591,6 @@  discard block
 block discarded – undo
598 591
      *
599 592
      *    A = A - B
600 593
      *
601
-     * @param mixed $B Matrix/Array
602 594
      *
603 595
      * @return Matrix Sum
604 596
      */
@@ -655,7 +647,6 @@  discard block
 block discarded – undo
655 647
      *    Element-by-element multiplication
656 648
      *    Cij = Aij * Bij
657 649
      *
658
-     * @param mixed $B Matrix/Array
659 650
      *
660 651
      * @return Matrix Matrix Cij
661 652
      */
@@ -698,7 +689,6 @@  discard block
 block discarded – undo
698 689
      *    Element-by-element multiplication
699 690
      *    Aij = Aij * Bij
700 691
      *
701
-     * @param mixed $B Matrix/Array
702 692
      *
703 693
      * @return Matrix Matrix Aij
704 694
      */
@@ -755,7 +745,6 @@  discard block
 block discarded – undo
755 745
      *    Element-by-element right division
756 746
      *    A / B
757 747
      *
758
-     * @param Matrix $B Matrix B
759 748
      *
760 749
      * @return Matrix Division result
761 750
      */
@@ -817,7 +806,6 @@  discard block
 block discarded – undo
817 806
      *    Element-by-element right division
818 807
      *    Aij = Aij / Bij
819 808
      *
820
-     * @param mixed $B Matrix/Array
821 809
      *
822 810
      * @return Matrix Matrix Aij
823 811
      */
@@ -860,7 +848,6 @@  discard block
 block discarded – undo
860 848
      *    Element-by-element Left division
861 849
      *    A / B
862 850
      *
863
-     * @param Matrix $B Matrix B
864 851
      *
865 852
      * @return Matrix Division result
866 853
      */
@@ -903,7 +890,6 @@  discard block
 block discarded – undo
903 890
      *    Element-by-element Left division
904 891
      *    Aij = Aij / Bij
905 892
      *
906
-     * @param mixed $B Matrix/Array
907 893
      *
908 894
      * @return Matrix Matrix Aij
909 895
      */
@@ -945,7 +931,6 @@  discard block
 block discarded – undo
945 931
      *
946 932
      *    Matrix multiplication
947 933
      *
948
-     * @param mixed $n Matrix/Array/Scalar
949 934
      *
950 935
      * @return Matrix Product
951 936
      */
@@ -1038,7 +1023,6 @@  discard block
 block discarded – undo
1038 1023
      *
1039 1024
      *    A = A ^ B
1040 1025
      *
1041
-     * @param mixed $B Matrix/Array
1042 1026
      *
1043 1027
      * @return Matrix Sum
1044 1028
      */
@@ -1094,7 +1078,6 @@  discard block
 block discarded – undo
1094 1078
      *
1095 1079
      *    A = A & B
1096 1080
      *
1097
-     * @param mixed $B Matrix/Array
1098 1081
      *
1099 1082
      * @return Matrix Sum
1100 1083
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/JAMA/SingularValueDecomposition.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
     /**
442 442
      * Return the left singular vectors.
443 443
      *
444
-     * @return U
444
+     * @return Matrix
445 445
      */
446 446
     public function getU()
447 447
     {
@@ -451,7 +451,7 @@  discard block
 block discarded – undo
451 451
     /**
452 452
      * Return the right singular vectors.
453 453
      *
454
-     * @return V
454
+     * @return Matrix
455 455
      */
456 456
     public function getV()
457 457
     {
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
     /**
472 472
      * Return the diagonal matrix of singular values.
473 473
      *
474
-     * @return S
474
+     * @return Matrix
475 475
      */
476 476
     public function getS()
477 477
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Workbook.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -240,8 +240,8 @@  discard block
 block discarded – undo
240 240
      *
241 241
      * @param \PhpOffice\PhpSpreadsheet\Style
242 242
      * @param bool Is it a style XF?
243
-     * @param mixed $style
244
-     * @param mixed $isStyleXf
243
+     * @param \PhpOffice\PhpSpreadsheet\Style $style
244
+     * @param boolean $isStyleXf
245 245
      *
246 246
      * @return int Index to XF record
247 247
      */
@@ -796,7 +796,7 @@  discard block
 block discarded – undo
796 796
      *
797 797
      * @param string $name The name in UTF-8
798 798
      * @param string $formulaData The binary formula data
799
-     * @param string $sheetIndex 1-based sheet index the defined name applies to. 0 = global
799
+     * @param integer $sheetIndex 1-based sheet index the defined name applies to. 0 = global
800 800
      * @param bool $isBuiltIn Built-in name?
801 801
      *
802 802
      * @return string Complete binary record data
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Worksheet.php 1 patch
Doc Comments   +9 added lines, -7 removed lines patch added patch discarded remove patch
@@ -223,10 +223,12 @@  discard block
 block discarded – undo
223 223
      * @param int &$str_unique Total number of unique strings
224 224
      * @param array &$str_table String Table
225 225
      * @param array &$colors Colour Table
226
-     * @param mixed $parser The formula parser created for the Workbook
226
+     * @param Parser $parser The formula parser created for the Workbook
227 227
      * @param bool $preCalculateFormulas Flag indicating whether formulas should be calculated or just written
228 228
      * @param string $phpSheet The worksheet to write
229 229
      * @param \PhpOffice\PhpSpreadsheet\Worksheet $phpSheet
230
+     * @param integer $str_total
231
+     * @param integer $str_unique
230 232
      */
231 233
     public function __construct(&$str_total, &$str_unique, &$str_table, &$colors, $parser, $preCalculateFormulas, $phpSheet)
232 234
     {
@@ -624,7 +626,7 @@  discard block
 block discarded – undo
624 626
      * @param int $row Zero indexed row
625 627
      * @param int $col Zero indexed column
626 628
      * @param float $num The number to write
627
-     * @param mixed $xfIndex The optional XF format
629
+     * @param integer $xfIndex The optional XF format
628 630
      *
629 631
      * @return int
630 632
      */
@@ -733,7 +735,7 @@  discard block
 block discarded – undo
733 735
      * @param int $row Zero indexed row
734 736
      * @param int $col Zero indexed column
735 737
      * @param string $str The string to write
736
-     * @param mixed $xfIndex The XF format index for the cell
738
+     * @param integer $xfIndex The XF format index for the cell
737 739
      *
738 740
      * @return int
739 741
      */
@@ -800,7 +802,7 @@  discard block
 block discarded – undo
800 802
      *
801 803
      * @param int $row Zero indexed row
802 804
      * @param int $col Zero indexed column
803
-     * @param mixed $xfIndex The XF format index
805
+     * @param integer $xfIndex The XF format index
804 806
      */
805 807
     public function writeBlank($row, $col, $xfIndex)
806 808
     {
@@ -847,7 +849,7 @@  discard block
 block discarded – undo
847 849
      * @param int $row Zero indexed row
848 850
      * @param int $col Zero indexed column
849 851
      * @param string $formula The formula text string
850
-     * @param mixed $xfIndex The XF format index
852
+     * @param integer $xfIndex The XF format index
851 853
      * @param mixed $calculatedValue Calculated value
852 854
      *
853 855
      * @return int
@@ -2327,8 +2329,8 @@  discard block
 block discarded – undo
2327 2329
      * @param mixed $bitmap The bitmap filename or GD-image resource
2328 2330
      * @param int $x the horizontal position (offset) of the image inside the cell
2329 2331
      * @param int $y the vertical position (offset) of the image inside the cell
2330
-     * @param float $scale_x The horizontal scale
2331
-     * @param float $scale_y The vertical scale
2332
+     * @param integer $scale_x The horizontal scale
2333
+     * @param integer $scale_y The vertical scale
2332 2334
      */
2333 2335
     public function insertBitmap($row, $col, $bitmap, $x = 0, $y = 0, $scale_x = 1, $scale_y = 1)
2334 2336
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/Statistical.php 1 patch
Doc Comments   +9 added lines, -14 removed lines patch added patch discarded remove patch
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      * @param mixed $p
134 134
      * @param mixed $q
135 135
      *
136
-     * @return 0 if p<=0, q<=0 or p+q>2.55E305 to avoid errors and over/underflow
136
+     * @return double if p<=0, q<=0 or p+q>2.55E305 to avoid errors and over/underflow
137 137
      *
138 138
      * @author Jaco van Kooten
139 139
      */
@@ -159,8 +159,8 @@  discard block
 block discarded – undo
159 159
      * @author Jaco van Kooten
160 160
      *
161 161
      * @param mixed $x
162
-     * @param mixed $p
163
-     * @param mixed $q
162
+     * @param double $p
163
+     * @param double $q
164 164
      */
165 165
     private static function betaFraction($x, $p, $q)
166 166
     {
@@ -909,8 +909,8 @@  discard block
 block discarded – undo
909 909
      * @param float $value Value at which you want to evaluate the distribution
910 910
      * @param float $alpha Parameter to the distribution
911 911
      * @param float $beta Parameter to the distribution
912
-     * @param mixed $rMin
913
-     * @param mixed $rMax
912
+     * @param integer $rMin
913
+     * @param integer $rMax
914 914
      *
915 915
      * @return float
916 916
      */
@@ -948,8 +948,8 @@  discard block
 block discarded – undo
948 948
      * @param float $probability Probability at which you want to evaluate the distribution
949 949
      * @param float $alpha Parameter to the distribution
950 950
      * @param float $beta Parameter to the distribution
951
-     * @param float $rMin Minimum value
952
-     * @param float $rMax Maximum value
951
+     * @param integer $rMin Minimum value
952
+     * @param integer $rMax Maximum value
953 953
      *
954 954
      * @return float
955 955
      */
@@ -2015,7 +2015,6 @@  discard block
 block discarded – undo
2015 2015
      * @category Statistical Functions
2016 2016
      *
2017 2017
      * @param mixed $args Data values
2018
-     * @param int $entry Position (ordered from the largest) in the array or range of data to return
2019 2018
      *
2020 2019
      * @return float
2021 2020
      */
@@ -2745,7 +2744,6 @@  discard block
 block discarded – undo
2745 2744
      * @category Statistical Functions
2746 2745
      *
2747 2746
      * @param mixed $args Data values
2748
-     * @param float $entry Percentile value in the range 0..1, inclusive.
2749 2747
      *
2750 2748
      * @return float
2751 2749
      */
@@ -2796,7 +2794,7 @@  discard block
 block discarded – undo
2796 2794
      * @param number the number of significant digits for the returned percentage value
2797 2795
      * @param mixed $valueSet
2798 2796
      * @param mixed $value
2799
-     * @param mixed $significance
2797
+     * @param integer $significance
2800 2798
      *
2801 2799
      * @return float
2802 2800
      */
@@ -2917,7 +2915,6 @@  discard block
 block discarded – undo
2917 2915
      * @category Statistical Functions
2918 2916
      *
2919 2917
      * @param mixed $args Data values
2920
-     * @param int $entry Quartile value in the range 1..3, inclusive.
2921 2918
      *
2922 2919
      * @return float
2923 2920
      */
@@ -2950,7 +2947,7 @@  discard block
 block discarded – undo
2950 2947
      * @param mixed Order to sort the values in the value set
2951 2948
      * @param mixed $value
2952 2949
      * @param mixed $valueSet
2953
-     * @param mixed $order
2950
+     * @param integer $order
2954 2951
      *
2955 2952
      * @return float
2956 2953
      */
@@ -3092,7 +3089,6 @@  discard block
 block discarded – undo
3092 3089
      * @category Statistical Functions
3093 3090
      *
3094 3091
      * @param mixed $args Data values
3095
-     * @param int $entry Position (ordered from the smallest) in the array or range of data to return
3096 3092
      *
3097 3093
      * @return float
3098 3094
      */
@@ -3556,7 +3552,6 @@  discard block
 block discarded – undo
3556 3552
      * @category Statistical Functions
3557 3553
      *
3558 3554
      * @param mixed $args Data values
3559
-     * @param float $discard Percentage to discard
3560 3555
      *
3561 3556
      * @return float
3562 3557
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Reader/Xls.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -5118,7 +5118,7 @@  discard block
 block discarded – undo
5118 5118
      * is in one piece.
5119 5119
      * Moves to next current position in data stream to start of next record different from a CONtINUE record.
5120 5120
      *
5121
-     * @return array
5121
+     * @return integer|null
5122 5122
      */
5123 5123
     private function getSplicedRecordData()
5124 5124
     {
@@ -5368,7 +5368,7 @@  discard block
 block discarded – undo
5368 5368
      *
5369 5369
      * @throws Exception
5370 5370
      *
5371
-     * @return array
5371
+     * @return string
5372 5372
      */
5373 5373
     private function getNextToken($formulaData, $baseCell = 'A1')
5374 5374
     {
@@ -6945,7 +6945,7 @@  discard block
 block discarded – undo
6945 6945
      *
6946 6946
      * @param string $subData
6947 6947
      *
6948
-     * @return array
6948
+     * @return string
6949 6949
      */
6950 6950
     private function readBIFF8CellRangeAddressList($subData)
6951 6951
     {
@@ -7060,7 +7060,7 @@  discard block
 block discarded – undo
7060 7060
      *
7061 7061
      * @param string $arrayData
7062 7062
      *
7063
-     * @return array
7063
+     * @return string
7064 7064
      */
7065 7065
     private static function readBIFF8ConstantArray($arrayData)
7066 7066
     {
@@ -7099,7 +7099,7 @@  discard block
 block discarded – undo
7099 7099
      *
7100 7100
      * @param string $valueData
7101 7101
      *
7102
-     * @return array
7102
+     * @return string
7103 7103
      */
7104 7104
     private static function readBIFF8Constant($valueData)
7105 7105
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Reader/Xls/MD5.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -187,6 +187,11 @@
 block discarded – undo
187 187
         return $Y ^ ($X | (~$Z)); // Y XOR (X OR NOT Z)
188 188
     }
189 189
 
190
+    /**
191
+     * @param string[] $func
192
+     * @param integer $s
193
+     * @param integer $t
194
+     */
190 195
     private static function step($func, &$A, $B, $C, $D, $M, $s, $t)
191 196
     {
192 197
         $A = ($A + call_user_func($func, $B, $C, $D) + $M + $t) & 0xffffffff;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Style.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
     /**
148 148
      * Get parent. Only used for style supervisor.
149 149
      *
150
-     * @return Spreadsheet
150
+     * @return Style
151 151
      */
152 152
     public function getParent()
153 153
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xls/Parser.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
      *
506 506
      * @param mixed $token the token to convert
507 507
      *
508
-     * @return mixed the converted token on success
508
+     * @return string the converted token on success
509 509
      */
510 510
     private function convert($token)
511 511
     {
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
      *
577 577
      * @param string $string a string for conversion to its ptg value
578 578
      *
579
-     * @return mixed the converted token on success
579
+     * @return string the converted token on success
580 580
      */
581 581
     private function convertString($string)
582 582
     {
@@ -654,7 +654,7 @@  discard block
 block discarded – undo
654 654
      *
655 655
      * @param string $token an Excel range in the Sheet1!A1:A2 format
656 656
      *
657
-     * @return mixed the packed ptgArea3d token on success
657
+     * @return string the packed ptgArea3d token on success
658 658
      */
659 659
     private function convertRange3d($token)
660 660
     {
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
706 706
      *
707 707
      * @param string $cell An Excel cell reference
708 708
      *
709
-     * @return mixed the packed ptgRef3d token on success
709
+     * @return string the packed ptgRef3d token on success
710 710
      */
711 711
     private function convertRef3d($cell)
712 712
     {
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
      *
806 806
      * @param string $ext_ref The name of the external reference
807 807
      *
808
-     * @return mixed The reference index in packed() format on success
808
+     * @return string The reference index in packed() format on success
809 809
      */
810 810
     private function getRefIndex($ext_ref)
811 811
     {
@@ -896,7 +896,7 @@  discard block
 block discarded – undo
896 896
      *
897 897
      * @param string $cell The Excel cell reference to be packed
898 898
      *
899
-     * @return array Array containing the row and column in packed() format
899
+     * @return string[] Array containing the row and column in packed() format
900 900
      */
901 901
     private function cellToPackedRowcol($cell)
902 902
     {
@@ -925,7 +925,7 @@  discard block
 block discarded – undo
925 925
      *
926 926
      * @param string $range The Excel range to be packed
927 927
      *
928
-     * @return array Array containing (row1,col1,row2,col2) in packed() format
928
+     * @return string[] Array containing (row1,col1,row2,col2) in packed() format
929 929
      */
930 930
     private function rangeToPackedRange($range)
931 931
     {
@@ -1041,7 +1041,7 @@  discard block
 block discarded – undo
1041 1041
     /**
1042 1042
      * Checks if it's a valid token.
1043 1043
      *
1044
-     * @param mixed $token the token to check
1044
+     * @param string $token the token to check
1045 1045
      *
1046 1046
      * @return mixed The checked token or false on failure
1047 1047
      */
@@ -1127,7 +1127,7 @@  discard block
 block discarded – undo
1127 1127
      * @param string $formula the formula to parse, without the initial equal
1128 1128
      *                        sign (=)
1129 1129
      *
1130
-     * @return mixed true on success
1130
+     * @return boolean true on success
1131 1131
      */
1132 1132
     public function parse($formula)
1133 1133
     {
Please login to merge, or discard this patch.