Stack::pop() - Code Metrics - Inspection of "New method `evaluateGCD()` should stay private" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( 90366f...812a46 )

by Adrien

created 2017-12-03 08:41 UTC

Stack::pop() A

↳ Parent: Stack

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	0
dl	0
loc	7
ccs	4
cts	4
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace PhpOffice\PhpSpreadsheet\Calculation\Token;

use PhpOffice\PhpSpreadsheet\Calculation\Calculation;

class Stack
{
    /**
     * The parser stack for formulae.
     *
     * @var mixed[]
     */
    private $stack = [];

    /**
     * Count of entries in the parser stack.
     *
     * @var int
     */
    private $count = 0;

    /**
     * Return the number of entries on the stack.
     *
     * @return int
     */
    public function count()
    {
        return $this->count;
    }

    /**
     * Push a new entry onto the stack.
     *
     * @param mixed $type
     * @param mixed $value
     * @param mixed $reference
     */
    public function push($type, $value, $reference = null)
    {
        $this->stack[$this->count++] = [
            'type' => $type,
            'value' => $value,
            'reference' => $reference,
        ];
        if ($type == 'Function') {
            $localeFunction = Calculation::localeFunc($value);
            if ($localeFunction != $value) {
                $this->stack[($this->count - 1)]['localeValue'] = $localeFunction;
            }
        }
    }

    /**
     * Pop the last entry from the stack.
     *
     * @return mixed
     */
    public function pop()
    {
        if ($this->count > 0) {
            return $this->stack[--$this->count];
        }

        return null;
    }

    /**
     * Return an entry from the stack without removing it.
     *
     * @param int $n number indicating how far back in the stack we want to look
     *
     * @return mixed
     */
    public function last($n = 1)
    {
        if ($this->count - $n < 0) {
            return null;
        }

        return $this->stack[$this->count - $n];
    }

    /**
     * Clear the stack.
     */
    public function clear()
    {
        $this->stack = [];
        $this->count = 0;
    }
}


1		<?php
2
3		namespace PhpOffice\PhpSpreadsheet\Calculation\Token;
4
5		use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
6
7		class Stack
8		{
9		/**
10		* The parser stack for formulae.
11		*
12		* @var mixed[]
13		*/
14		private $stack = [];
15
16		/**
17		* Count of entries in the parser stack.
18		*
19		* @var int
20		*/
21		private $count = 0;
22
23		/**
24		* Return the number of entries on the stack.
25		*
26		* @return int
27		*/
28	118	public function count()
29		{
30	118	return $this->count;
31		}
32
33		/**
34		* Push a new entry onto the stack.
35		*
36		* @param mixed $type
37		* @param mixed $value
38		* @param mixed $reference
39		*/
40	118	public function push($type, $value, $reference = null)
41		{
42	118	$this->stack[$this->count++] = [
43	118	'type' => $type,
44	118	'value' => $value,
45	118	'reference' => $reference,
46		];
47	118	if ($type == 'Function') {
48	46	$localeFunction = Calculation::localeFunc($value);
49	46	if ($localeFunction != $value) {
50		$this->stack[($this->count - 1)]['localeValue'] = $localeFunction;
51		}
52		}
53	118	}
54
55		/**
56		* Pop the last entry from the stack.
57		*
58		* @return mixed
59		*/
60	118	public function pop()
61		{
62	118	if ($this->count > 0) {
63	118	return $this->stack[--$this->count];
64		}
65
66	118	return null;
67		}
68
69		/**
70		* Return an entry from the stack without removing it.
71		*
72		* @param int $n number indicating how far back in the stack we want to look
73		*
74		* @return mixed
75		*/
76	118	public function last($n = 1)
77		{
78	118	if ($this->count - $n < 0) {
79	111	return null;
80		}
81
82	117	return $this->stack[$this->count - $n];
83		}
84
85		/**
86		* Clear the stack.
87		*/
88		public function clear()
89		{
90		$this->stack = [];
91		$this->count = 0;
92		}
93		}
94

PHPOffice / PhpSpreadsheet

Push — develop ( 90366f...812a46 )

Stack::pop() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like