Total Complexity | 8 |
Total Lines | 78 |
Duplicated Lines | 10.26 % |
Coverage | 60% |
Changes | 0 |
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | class TextElement implements ITextElement |
||
6 | { |
||
7 | /** |
||
8 | * Text. |
||
9 | * |
||
10 | * @var string |
||
11 | */ |
||
12 | private $text; |
||
13 | |||
14 | /** |
||
15 | * Create a new TextElement instance. |
||
16 | * |
||
17 | * @param string $pText Text |
||
18 | */ |
||
19 | 24 | public function __construct($pText = '') |
|
20 | { |
||
21 | // Initialise variables |
||
22 | 24 | $this->text = $pText; |
|
23 | 24 | } |
|
24 | |||
25 | /** |
||
26 | * Get text. |
||
27 | * |
||
28 | * @return string Text |
||
29 | */ |
||
30 | 34 | public function getText() |
|
31 | { |
||
32 | 34 | return $this->text; |
|
33 | } |
||
34 | |||
35 | /** |
||
36 | * Set text. |
||
37 | * |
||
38 | * @param $text string Text |
||
39 | * |
||
40 | * @return ITextElement |
||
41 | */ |
||
42 | 30 | public function setText($text) |
|
47 | } |
||
48 | |||
49 | /** |
||
50 | * Get font. |
||
51 | * |
||
52 | * @return \PhpOffice\PhpSpreadsheet\Style\Font |
||
53 | */ |
||
54 | public function getFont() |
||
55 | { |
||
56 | return null; |
||
57 | } |
||
58 | |||
59 | /** |
||
60 | * Get hash code. |
||
61 | * |
||
62 | * @return string Hash code |
||
63 | */ |
||
64 | 8 | public function getHashCode() |
|
69 | ); |
||
70 | } |
||
71 | |||
72 | /** |
||
73 | * Implement PHP __clone to create a deep clone, not just a shallow copy. |
||
74 | */ |
||
75 | View Code Duplication | public function __clone() |
|
83 | } |
||
84 | } |
||
85 | } |
||
87 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.