Completed
Pull Request — develop (#242)
by Claudio
30:08 queued 23:24
created
src/PhpSpreadsheet/Reader/Xml.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -236,6 +236,9 @@  discard block
 block discarded – undo
236 236
         return $this->loadIntoExisting($pFilename, $spreadsheet);
237 237
     }
238 238
 
239
+    /**
240
+     * @param string $styleAttributeValue
241
+     */
239 242
     private static function identifyFixedStyleValue($styleList, &$styleAttributeValue)
240 243
     {
241 244
         $styleAttributeValue = strtolower($styleAttributeValue);
@@ -811,6 +814,9 @@  discard block
 block discarded – undo
811 814
         return $spreadsheet;
812 815
     }
813 816
 
817
+    /**
818
+     * @param string $charset
819
+     */
814 820
     protected static function convertStringEncoding($string, $charset)
815 821
     {
816 822
         if ($charset != 'UTF-8') {
@@ -820,6 +826,9 @@  discard block
 block discarded – undo
820 826
         return $string;
821 827
     }
822 828
 
829
+    /**
830
+     * @param string $is
831
+     */
823 832
     protected function parseRichText($is)
824 833
     {
825 834
         $value = new RichText();
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/OLE.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -536,7 +536,7 @@
 block discarded – undo
536 536
      *
537 537
      * @param int $string A binary string with the encoded date
538 538
      *
539
-     * @return string The timestamp corresponding to the string
539
+     * @return double The timestamp corresponding to the string
540 540
      */
541 541
     public static function OLE2LocalDate($string)
542 542
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/MathTrig.php 1 patch
Doc Comments   +12 added lines, -11 removed lines patch added patch discarded remove patch
@@ -34,6 +34,10 @@  discard block
 block discarded – undo
34 34
         return [(int) $value];
35 35
     }
36 36
 
37
+    /**
38
+     * @param integer $num
39
+     * @param integer $n
40
+     */
37 41
     private static function romanCut($num, $n)
38 42
     {
39 43
         return ($num - ($num % $n)) / $n;
@@ -326,6 +330,7 @@  discard block
 block discarded – undo
326 330
      * @category Mathematical and Trigonometric Functions
327 331
      *
328 332
      * @param mixed ...$args Data values
333
+     * @param string $args
329 334
      *
330 335
      * @return int Greatest Common Divisor
331 336
      */
@@ -486,7 +491,7 @@  discard block
 block discarded – undo
486 491
      * @category Mathematical and Trigonometric Functions
487 492
      *
488 493
      * @param float $number The positive real number for which you want the logarithm
489
-     * @param float $base The base of the logarithm. If base is omitted, it is assumed to be 10.
494
+     * @param integer $base The base of the logarithm. If base is omitted, it is assumed to be 10.
490 495
      *
491 496
      * @return float
492 497
      */
@@ -804,8 +809,8 @@  discard block
 block discarded – undo
804 809
      *
805 810
      * Computes x raised to the power y.
806 811
      *
807
-     * @param float $x
808
-     * @param float $y
812
+     * @param integer $x
813
+     * @param integer $y
809 814
      *
810 815
      * @return float
811 816
      */
@@ -879,7 +884,7 @@  discard block
 block discarded – undo
879 884
      *
880 885
      * @param mixed ...$args Data values
881 886
      *
882
-     * @return float
887
+     * @return integer
883 888
      */
884 889
     public static function QUOTIENT(...$args)
885 890
     {
@@ -1017,9 +1022,6 @@  discard block
 block discarded – undo
1017 1022
      *
1018 1023
      * Returns the sum of a power series
1019 1024
      *
1020
-     * @param float $x Input value to the power series
1021
-     * @param float $n Initial power to which you want to raise $x
1022
-     * @param float $m Step by which to increase $n for each term in the series
1023 1025
      * @param array of mixed Data Series
1024 1026
      *
1025 1027
      * @return float
@@ -1216,7 +1218,7 @@  discard block
 block discarded – undo
1216 1218
      * @param mixed $aArgs
1217 1219
      * @param mixed $sumArgs
1218 1220
      *
1219
-     * @return float
1221
+     * @return integer
1220 1222
      */
1221 1223
     public static function SUMIF($aArgs, $condition, $sumArgs = [])
1222 1224
     {
@@ -1256,9 +1258,8 @@  discard block
 block discarded – undo
1256 1258
      *    @category Mathematical and Trigonometric Functions
1257 1259
      *
1258 1260
      * @param mixed $args Data values
1259
-     * @param string $condition the criteria that defines which cells will be summed
1260 1261
      *
1261
-     * @return float
1262
+     * @return integer
1262 1263
      */
1263 1264
     public static function SUMIFS(...$args)
1264 1265
     {
@@ -1447,7 +1448,7 @@  discard block
 block discarded – undo
1447 1448
      *
1448 1449
      * Truncates value to the number of fractional digits by number_digits.
1449 1450
      *
1450
-     * @param float $value
1451
+     * @param integer $value
1451 1452
      * @param int $digits
1452 1453
      *
1453 1454
      * @return float Truncated value
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Cell.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -768,7 +768,7 @@  discard block
 block discarded – undo
768 768
      *
769 769
      * @param string $pRange Cell range (e.g. A1:A1)
770 770
      *
771
-     * @return array Range coordinates array(Start Cell, End Cell)
771
+     * @return integer Range coordinates array(Start Cell, End Cell)
772 772
      *                    where Start Cell and End Cell are arrays (Column ID, Row Number)
773 773
      */
774 774
     public static function getRangeBoundaries($pRange)
@@ -943,7 +943,7 @@  discard block
 block discarded – undo
943 943
      *
944 944
      *    [ 'A1:A3' => 'x', 'A4' => 'y' ]
945 945
      *
946
-     * @param array $pCoordCollection associative array mapping coordinates to values
946
+     * @param Cell\DataValidation[] $pCoordCollection associative array mapping coordinates to values
947 947
      *
948 948
      * @return array associative array mapping coordinate ranges to valuea
949 949
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -558,7 +558,7 @@  discard block
 block discarded – undo
558 558
      *
559 559
      * @throws Exception
560 560
      *
561
-     * @return Chart|false
561
+     * @return Chart
562 562
      */
563 563
     public function getChartByIndex($index)
564 564
     {
@@ -1069,7 +1069,7 @@  discard block
 block discarded – undo
1069 1069
      * @param string $column Return the highest data row for the specified column,
1070 1070
      *                                     or the highest data row of any column if no column letter is passed
1071 1071
      *
1072
-     * @return string Highest row number that contains data
1072
+     * @return integer Highest row number that contains data
1073 1073
      */
1074 1074
     public function getHighestDataRow($column = null)
1075 1075
     {
@@ -1090,7 +1090,7 @@  discard block
 block discarded – undo
1090 1090
      * Set a cell value.
1091 1091
      *
1092 1092
      * @param string $pCoordinate Coordinate of the cell, eg: 'A1'
1093
-     * @param mixed $pValue Value of the cell
1093
+     * @param string $pValue Value of the cell
1094 1094
      *
1095 1095
      * @return Worksheet
1096 1096
      */
@@ -1327,7 +1327,7 @@  discard block
 block discarded – undo
1327 1327
      * Get row dimension at a specific row.
1328 1328
      *
1329 1329
      * @param int $pRow Numeric index of the row
1330
-     * @param mixed $create
1330
+     * @param boolean $create
1331 1331
      *
1332 1332
      * @return Worksheet\RowDimension
1333 1333
      */
@@ -1353,7 +1353,7 @@  discard block
 block discarded – undo
1353 1353
      * Get column dimension at a specific column.
1354 1354
      *
1355 1355
      * @param string $pColumn String index of the column eg: 'A'
1356
-     * @param mixed $create
1356
+     * @param boolean $create
1357 1357
      *
1358 1358
      * @return Worksheet\ColumnDimension
1359 1359
      */
@@ -1899,7 +1899,7 @@  discard block
 block discarded – undo
1899 1899
     /**
1900 1900
      * Set AutoFilter.
1901 1901
      *
1902
-     * @param string|Worksheet\AutoFilter $pValue
1902
+     * @param string $pValue
1903 1903
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
1904 1904
      *
1905 1905
      * @throws Exception
@@ -2965,7 +2965,7 @@  discard block
 block discarded – undo
2965 2965
      *
2966 2966
      * @throws Exception
2967 2967
      *
2968
-     * @return objWorksheet
2968
+     * @return Worksheet
2969 2969
      */
2970 2970
     public function setCodeName($pValue, $validate = true)
2971 2971
     {
Please login to merge, or discard this patch.