Completed
Pull Request — develop (#242)
by Claudio
30:08 queued 23:24
created
src/PhpSpreadsheet/Worksheet/BaseDrawing.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -137,8 +137,7 @@
 block discarded – undo
137 137
         $this->rotation = 0;
138 138
         $this->shadow = new Drawing\Shadow();
139 139
 
140
-        // Set image index
141
-        ++self::$imageCounter;
140
+        // Set image index++self::$imageCounter;
142 141
         $this->imageIndex = self::$imageCounter;
143 142
     }
144 143
 
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/Trend/BestFit.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -316,6 +316,10 @@
 block discarded – undo
316 316
         return $this->yBestFitValues;
317 317
     }
318 318
 
319
+    /**
320
+     * @param double $sumY2
321
+     * @param boolean $const
322
+     */
319 323
     protected function calculateGoodnessOfFit($sumX, $sumY, $sumX2, $sumY2, $sumXY, $meanX, $meanY, $const)
320 324
     {
321 325
         $SSres = $SScov = $SScor = $SStot = $SSsex = 0.0;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet/AutoFilter.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -567,6 +567,11 @@
 block discarded – undo
567 567
         return ['method' => 'filterTestInCustomDataSet', 'arguments' => ['filterRules' => $ruleValues, 'join' => AutoFilter\Column::AUTOFILTER_COLUMN_JOIN_AND]];
568 568
     }
569 569
 
570
+    /**
571
+     * @param integer $columnID
572
+     * @param integer $startRow
573
+     * @param string $ruleType
574
+     */
570 575
     private function calculateTopTenValue($columnID, $startRow, $endRow, $ruleType, $ruleValue)
571 576
     {
572 577
         $range = $columnID . $startRow . ':' . $columnID . $endRow;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/FormulaParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@
 block discarded – undo
119 119
      *
120 120
      * @throws Exception
121 121
      *
122
-     * @return string
122
+     * @return FormulaToken
123 123
      */
124 124
     public function getToken($pId = 0)
125 125
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Reader/Xlsx/Theme.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
57 57
     /**
58 58
      * Create a new Theme.
59 59
      *
60
-     * @param mixed $themeName
61
-     * @param mixed $colourSchemeName
60
+     * @param string $themeName
61
+     * @param string $colourSchemeName
62 62
      * @param mixed $colourMap
63 63
      */
64 64
     public function __construct($themeName, $colourSchemeName, $colourMap)
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     /**
93 93
      * Get colour Map Value by Position.
94 94
      *
95
-     * @param mixed $index
95
+     * @param integer $index
96 96
      *
97 97
      * @return string
98 98
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Reader/Xlsx.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -294,6 +294,11 @@  discard block
 block discarded – undo
294 294
         return isset($c->v) ? (string) $c->v : null;
295 295
     }
296 296
 
297
+    /**
298
+     * @param string $r
299
+     * @param string $cellDataType
300
+     * @param string $castBaseType
301
+     */
297 302
     private function castToFormula($c, $r, &$cellDataType, &$value, &$calculatedValue, &$sharedFormulas, $castBaseType)
298 303
     {
299 304
         $cellDataType = 'f';
@@ -2159,6 +2164,9 @@  discard block
 block discarded – undo
2159 2164
         return preg_replace('~[^/]+/\.\./~', '', dirname($base) . "/$add");
2160 2165
     }
2161 2166
 
2167
+    /**
2168
+     * @param string $style
2169
+     */
2162 2170
     private static function toCSSArray($style)
2163 2171
     {
2164 2172
         $style = str_replace(["\r", "\n"], '', $style);
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/DateTime.php 1 patch
Doc Comments   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
      *
472 472
      * @category Date/Time Functions
473 473
      *
474
-     * @param string $dateValue Text that represents a date in a Microsoft Excel date format.
474
+     * @param integer $dateValue Text that represents a date in a Microsoft Excel date format.
475 475
      *                                    For example, "1/30/2008" or "30-Jan-2008" are text strings within
476 476
      *                                    quotation marks that represent dates. Using the default date
477 477
      *                                    system in Excel for Windows, date_text must represent a date from
@@ -657,9 +657,9 @@  discard block
 block discarded – undo
657 657
     /**
658 658
      * DATEDIF.
659 659
      *
660
-     * @param mixed $startDate Excel date serial value, PHP date/time stamp, PHP DateTime object
660
+     * @param integer $startDate Excel date serial value, PHP date/time stamp, PHP DateTime object
661 661
      *                                    or a standard date string
662
-     * @param mixed $endDate Excel date serial value, PHP date/time stamp, PHP DateTime object
662
+     * @param integer $endDate Excel date serial value, PHP date/time stamp, PHP DateTime object
663 663
      *                                    or a standard date string
664 664
      * @param string $unit
665 665
      *
@@ -783,9 +783,9 @@  discard block
 block discarded – undo
783 783
      *
784 784
      * @category Date/Time Functions
785 785
      *
786
-     * @param mixed $startDate Excel date serial value (float), PHP date timestamp (integer),
786
+     * @param integer $startDate Excel date serial value (float), PHP date timestamp (integer),
787 787
      *                                        PHP DateTime object, or a standard date string
788
-     * @param mixed $endDate Excel date serial value (float), PHP date timestamp (integer),
788
+     * @param integer $endDate Excel date serial value (float), PHP date timestamp (integer),
789 789
      *                                        PHP DateTime object, or a standard date string
790 790
      * @param bool $method US or European Method
791 791
      *                                        FALSE or omitted: U.S. (NASD) method. If the starting date is
@@ -844,9 +844,9 @@  discard block
 block discarded – undo
844 844
      *
845 845
      * @category Date/Time Functions
846 846
      *
847
-     * @param mixed $startDate Excel date serial value (float), PHP date timestamp (integer),
847
+     * @param integer $startDate Excel date serial value (float), PHP date timestamp (integer),
848 848
      *                                    PHP DateTime object, or a standard date string
849
-     * @param mixed $endDate Excel date serial value (float), PHP date timestamp (integer),
849
+     * @param integer $endDate Excel date serial value (float), PHP date timestamp (integer),
850 850
      *                                    PHP DateTime object, or a standard date string
851 851
      * @param int $method Method used for the calculation
852 852
      *                                        0 or omitted    US (NASD) 30/360
@@ -1135,7 +1135,7 @@  discard block
 block discarded – undo
1135 1135
      * Excel Function:
1136 1136
      *        DAY(dateValue)
1137 1137
      *
1138
-     * @param mixed $dateValue Excel date serial value (float), PHP date timestamp (integer),
1138
+     * @param integer $dateValue Excel date serial value (float), PHP date timestamp (integer),
1139 1139
      *                                    PHP DateTime object, or a standard date string
1140 1140
      *
1141 1141
      * @return int Day of the month
@@ -1246,7 +1246,7 @@  discard block
 block discarded – undo
1246 1246
      * Excel Function:
1247 1247
      *        WEEKNUM(dateValue[,style])
1248 1248
      *
1249
-     * @param mixed $dateValue Excel date serial value (float), PHP date timestamp (integer),
1249
+     * @param integer $dateValue Excel date serial value (float), PHP date timestamp (integer),
1250 1250
      *                                    PHP DateTime object, or a standard date string
1251 1251
      * @param int $method Week begins on Sunday or Monday
1252 1252
      *                                        1 or omitted    Week begins on Sunday.
@@ -1299,7 +1299,7 @@  discard block
 block discarded – undo
1299 1299
      * Excel Function:
1300 1300
      *        MONTH(dateValue)
1301 1301
      *
1302
-     * @param mixed $dateValue Excel date serial value (float), PHP date timestamp (integer),
1302
+     * @param integer $dateValue Excel date serial value (float), PHP date timestamp (integer),
1303 1303
      *                                    PHP DateTime object, or a standard date string
1304 1304
      *
1305 1305
      * @return int Month of the year
@@ -1332,7 +1332,7 @@  discard block
 block discarded – undo
1332 1332
      * Excel Function:
1333 1333
      *        YEAR(dateValue)
1334 1334
      *
1335
-     * @param mixed $dateValue Excel date serial value (float), PHP date timestamp (integer),
1335
+     * @param integer $dateValue Excel date serial value (float), PHP date timestamp (integer),
1336 1336
      *                                    PHP DateTime object, or a standard date string
1337 1337
      *
1338 1338
      * @return int Year
@@ -1364,7 +1364,7 @@  discard block
 block discarded – undo
1364 1364
      * Excel Function:
1365 1365
      *        HOUR(timeValue)
1366 1366
      *
1367
-     * @param mixed $timeValue Excel date serial value (float), PHP date timestamp (integer),
1367
+     * @param integer $timeValue Excel date serial value (float), PHP date timestamp (integer),
1368 1368
      *                                    PHP DateTime object, or a standard time string
1369 1369
      *
1370 1370
      * @return int Hour
@@ -1405,7 +1405,7 @@  discard block
 block discarded – undo
1405 1405
      * Excel Function:
1406 1406
      *        MINUTE(timeValue)
1407 1407
      *
1408
-     * @param mixed $timeValue Excel date serial value (float), PHP date timestamp (integer),
1408
+     * @param integer $timeValue Excel date serial value (float), PHP date timestamp (integer),
1409 1409
      *                                    PHP DateTime object, or a standard time string
1410 1410
      *
1411 1411
      * @return int Minute
@@ -1446,7 +1446,7 @@  discard block
 block discarded – undo
1446 1446
      * Excel Function:
1447 1447
      *        SECOND(timeValue)
1448 1448
      *
1449
-     * @param mixed $timeValue Excel date serial value (float), PHP date timestamp (integer),
1449
+     * @param integer $timeValue Excel date serial value (float), PHP date timestamp (integer),
1450 1450
      *                                    PHP DateTime object, or a standard time string
1451 1451
      *
1452 1452
      * @return int Second
@@ -1489,7 +1489,7 @@  discard block
 block discarded – undo
1489 1489
      * Excel Function:
1490 1490
      *        EDATE(dateValue,adjustmentMonths)
1491 1491
      *
1492
-     * @param mixed $dateValue Excel date serial value (float), PHP date timestamp (integer),
1492
+     * @param integer $dateValue Excel date serial value (float), PHP date timestamp (integer),
1493 1493
      *                                        PHP DateTime object, or a standard date string
1494 1494
      * @param int $adjustmentMonths The number of months before or after start_date.
1495 1495
      *                                        A positive value for months yields a future date;
@@ -1535,7 +1535,7 @@  discard block
 block discarded – undo
1535 1535
      * Excel Function:
1536 1536
      *        EOMONTH(dateValue,adjustmentMonths)
1537 1537
      *
1538
-     * @param mixed $dateValue Excel date serial value (float), PHP date timestamp (integer),
1538
+     * @param integer $dateValue Excel date serial value (float), PHP date timestamp (integer),
1539 1539
      *                                        PHP DateTime object, or a standard date string
1540 1540
      * @param int $adjustmentMonths The number of months before or after start_date.
1541 1541
      *                                        A positive value for months yields a future date;
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/TextData.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
      * This function converts a number to text using currency format, with the decimals rounded to the specified place.
170 170
      * The format used is $#,##0.00_);($#,##0.00)..
171 171
      *
172
-     * @param float $value The value to format
172
+     * @param integer $value The value to format
173 173
      * @param int $decimals The number of digits to display to the right of the decimal point.
174 174
      *                                    If decimals is negative, number is rounded to the left of the decimal point.
175 175
      *                                    If you omit decimals, it is assumed to be 2
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/JAMA/EigenvalueDecomposition.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
     /**
820 820
      * Return the eigenvector matrix.
821 821
      *
822
-     * @return V
822
+     * @return Matrix
823 823
      */
824 824
     public function getV()
825 825
     {
@@ -849,7 +849,7 @@  discard block
 block discarded – undo
849 849
     /**
850 850
      * Return the block diagonal eigenvalue matrix.
851 851
      *
852
-     * @return D
852
+     * @return Matrix
853 853
      */
854 854
     public function getD()
855 855
     {
Please login to merge, or discard this patch.