PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional

Complexity

Total Complexity

1

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	writeAndReload()	0	11	1

<?php

namespace PhpOffice\PhpSpreadsheetTests\Functional;

use PhpOffice\PhpSpreadsheet\IOFactory;
use PhpOffice\PhpSpreadsheet\Shared\File;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PHPUnit\Framework\TestCase;

/**
 * Base class for functional test to write and reload file on disk across different formats.
 */
abstract class AbstractFunctional extends TestCase
{
    /**
     * Write spreadsheet to disk, reload and return it.
     *
     * @param Spreadsheet $spreadsheet
     * @param string $format
     *
     * @return Spreadsheet
     */
    protected function writeAndReload(Spreadsheet $spreadsheet, $format)
    {
        $filename = tempnam(File::sysGetTempDir(), 'phpspreadsheet-test');
        $writer = IOFactory::createWriter($spreadsheet, $format);
        $writer->save($filename);

It seems like $filename can also be of type false; however, parameter $pFilename of PhpOffice\PhpSpreadsheet\Writer\IWriter::save() does only seem to accept string, maybe add an additional type check?

        $reader = IOFactory::createReader($format);
        $reloadedSpreadsheet = $reader->load($filename);

It seems like $filename can also be of type false; however, parameter $pFilename of PhpOffice\PhpSpreadsheet\Reader\IReader::load() does only seem to accept string, maybe add an additional type check?

        unlink($filename);

It seems like $filename can also be of type false; however, parameter $filename of unlink() does only seem to accept string, maybe add an additional type check?

        return $reloadedSpreadsheet;
    }
}