Inspection of "Read background color of cells from HTML file" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( ab7aa6...720fb3 )

by Adrien

created 2016-12-14 12:42 UTC

Status

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -33,18 +33,18 @@
 block discarded – undo
 $inputFileName = './sampleData/example1.xls';
 $sheetname = 'Data Sheet #2';
 
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
 $objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
-echo 'Loading Sheet "',$sheetname,'" only<br />';
+echo 'Loading Sheet "', $sheetname, '" only<br />';
 $objReader->setLoadSheetsOnly($sheetname);
 $spreadsheet = $objReader->load($inputFileName);
 
 echo '<hr />';
 
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
 $loadedSheetNames = $spreadsheet->getSheetNames();
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
+    echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
 }
 
 ?>

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader06.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@  discard block
 block discarded – undo
 //	$inputFileType = 'Gnumeric';
 $inputFileName = './sampleData/example1.xls';
 
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
 $objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
 echo 'Loading all WorkSheets<br />';
 $objReader->setLoadAllSheets();
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
 
 echo '<hr />';
 
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
 $loadedSheetNames = $spreadsheet->getSheetNames();
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
+    echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
 }
 
 ?>

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader02.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@
 block discarded – undo
 
 $inputFileName = './sampleData/example1.xls';
 
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
 $objReader = new \PhpOffice\PhpSpreadsheet\Reader\Xls();
 //	$objReader = new \PhpOffice\PhpSpreadsheet\Reader\Xlsx();
 //	$objReader = new \PhpOffice\PhpSpreadsheet\Reader\Excel2003XML();

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader15.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -26,17 +26,17 @@  discard block
 block discarded – undo
 $inputFileName = './sampleData/example1.tsv';
 
 $objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #1 using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #1 using IOFactory with a defined reader type of ', $inputFileType, '<br />';
 $objReader->setDelimiter("\t");
 $spreadsheet = $objReader->load($inputFileName);
 $spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
 
 echo '<hr />';
 
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
 $loadedSheetNames = $spreadsheet->getSheetNames();
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,' (Formatted)</b><br />';
+    echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, ' (Formatted)</b><br />';
     $spreadsheet->setActiveSheetIndexByName($loadedSheetName);
     $sheetData = $spreadsheet->getActiveSheet()->toArray(null, true, true, true);
     var_dump($sheetData);
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
 echo '<hr />';
 
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,' (Unformatted)</b><br />';
+    echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, ' (Unformatted)</b><br />';
     $spreadsheet->setActiveSheetIndexByName($loadedSheetName);
     $sheetData = $spreadsheet->getActiveSheet()->toArray(null, true, false, true);
     var_dump($sheetData);
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 echo '<hr />';
 
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,' (Raw)</b><br />';
+    echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, ' (Raw)</b><br />';
     $spreadsheet->setActiveSheetIndexByName($loadedSheetName);
     $sheetData = $spreadsheet->getActiveSheet()->toArray(null, false, false, true);
     var_dump($sheetData);

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader18.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@
 block discarded – undo
 //	$inputFileType = 'Gnumeric';
 $inputFileName = './sampleData/example1.xls';
 
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' information using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' information using IOFactory with a defined reader type of ', $inputFileType, '<br />';
 
 $objReader = PHPExcel_IOFactory::createReader($inputFileType);
 $worksheetData = $objReader->listWorksheetInfo($inputFileName);

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader13.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -30,11 +30,11 @@  discard block
 block discarded – undo
 
 $objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
 $inputFileName = array_shift($inputFileNames);
-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #1 using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #1 using IOFactory with a defined reader type of ', $inputFileType, '<br />';
 $spreadsheet = $objReader->load($inputFileName);
 $spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
 foreach ($inputFileNames as $sheet => $inputFileName) {
-    echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #',($sheet + 2),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
+    echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #', ($sheet + 2), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
     $objReader->setSheetIndex($sheet + 1);
     $objReader->loadIntoExisting($inputFileName, $spreadsheet);
     $spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
@@ -42,10 +42,10 @@  discard block
 block discarded – undo
 
 echo '<hr />';
 
-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
 $loadedSheetNames = $spreadsheet->getSheetNames();
 foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
-    echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,'</b><br />';
+    echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, '</b><br />';
     $spreadsheet->setActiveSheetIndexByName($loadedSheetName);
     $sheetData = $spreadsheet->getActiveSheet()->toArray(null, true, true, true);
     var_dump($sheetData);

Please login to merge, or discard this patch.

src/PhpSpreadsheet/Shared/OLERead.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -69,7 +69,7 @@
 block discarded – undo
     /**
      * Read the file
      *
-     * @param $pFilename string Filename
+     * @param string $pFilename string Filename
      * @throws \PhpOffice\PhpSpreadsheet\Reader\Exception
      */
     public function read($pFilename)

Please login to merge, or discard this patch.

		@@ -33,18 +33,18 @@
		block discarded – undo
33	33	$inputFileName = './sampleData/example1.xls';
34	34	$sheetname = 'Data Sheet #2';
35	35
36		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
	36	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
37	37	$objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
38		-echo 'Loading Sheet "',$sheetname,'" only<br />';
	38	+echo 'Loading Sheet "', $sheetname, '" only<br />';
39	39	$objReader->setLoadSheetsOnly($sheetname);
40	40	$spreadsheet = $objReader->load($inputFileName);
41	41
42	42	echo '<hr />';
43	43
44		-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
	44	+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
45	45	$loadedSheetNames = $spreadsheet->getSheetNames();
46	46	foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
47		- echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
	47	+ echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
48	48	}
49	49
50	50	?>

		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	// $inputFileType = 'Gnumeric';
33	33	$inputFileName = './sampleData/example1.xls';
34	34
35		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
	35	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36	36	$objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
37	37	echo 'Loading all WorkSheets<br />';
38	38	$objReader->setLoadAllSheets();
		@@ -40,10 +40,10 @@ discard block
		block discarded – undo
40	40
41	41	echo '<hr />';
42	42
43		-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
	43	+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
44	44	$loadedSheetNames = $spreadsheet->getSheetNames();
45	45	foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
46		- echo $sheetIndex,' -> ',$loadedSheetName,'<br />';
	46	+ echo $sheetIndex, ' -> ', $loadedSheetName, '<br />';
47	47	}
48	48
49	49	?>

		@@ -27,7 +27,7 @@
		block discarded – undo
27	27
28	28	$inputFileName = './sampleData/example1.xls';
29	29
30		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
	30	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' using \PhpOffice\PhpSpreadsheet\Reader\Xls<br />';
31	31	$objReader = new \PhpOffice\PhpSpreadsheet\Reader\Xls();
32	32	// $objReader = new \PhpOffice\PhpSpreadsheet\Reader\Xlsx();
33	33	// $objReader = new \PhpOffice\PhpSpreadsheet\Reader\Excel2003XML();

		@@ -26,17 +26,17 @@ discard block
		block discarded – undo
26	26	$inputFileName = './sampleData/example1.tsv';
27	27
28	28	$objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
29		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #1 using IOFactory with a defined reader type of ',$inputFileType,'<br />';
	29	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #1 using IOFactory with a defined reader type of ', $inputFileType, '<br />';
30	30	$objReader->setDelimiter("\t");
31	31	$spreadsheet = $objReader->load($inputFileName);
32	32	$spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
33	33
34	34	echo '<hr />';
35	35
36		-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
	36	+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
37	37	$loadedSheetNames = $spreadsheet->getSheetNames();
38	38	foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
39		- echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,' (Formatted)</b><br />';
	39	+ echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, ' (Formatted)</b><br />';
40	40	$spreadsheet->setActiveSheetIndexByName($loadedSheetName);
41	41	$sheetData = $spreadsheet->getActiveSheet()->toArray(null, true, true, true);
42	42	var_dump($sheetData);
		@@ -46,7 +46,7 @@ discard block
		block discarded – undo
46	46	echo '<hr />';
47	47
48	48	foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
49		- echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,' (Unformatted)</b><br />';
	49	+ echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, ' (Unformatted)</b><br />';
50	50	$spreadsheet->setActiveSheetIndexByName($loadedSheetName);
51	51	$sheetData = $spreadsheet->getActiveSheet()->toArray(null, true, false, true);
52	52	var_dump($sheetData);
		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	echo '<hr />';
57	57
58	58	foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
59		- echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,' (Raw)</b><br />';
	59	+ echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, ' (Raw)</b><br />';
60	60	$spreadsheet->setActiveSheetIndexByName($loadedSheetName);
61	61	$sheetData = $spreadsheet->getActiveSheet()->toArray(null, false, false, true);
62	62	var_dump($sheetData);

		@@ -32,7 +32,7 @@
		block discarded – undo
32	32	// $inputFileType = 'Gnumeric';
33	33	$inputFileName = './sampleData/example1.xls';
34	34
35		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' information using IOFactory with a defined reader type of ',$inputFileType,'<br />';
	35	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' information using IOFactory with a defined reader type of ', $inputFileType, '<br />';
36	36
37	37	$objReader = PHPExcel_IOFactory::createReader($inputFileType);
38	38	$worksheetData = $objReader->listWorksheetInfo($inputFileName);

		@@ -30,11 +30,11 @@ discard block
		block discarded – undo
30	30
31	31	$objReader = \PhpOffice\PhpSpreadsheet\IOFactory::createReader($inputFileType);
32	32	$inputFileName = array_shift($inputFileNames);
33		-echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #1 using IOFactory with a defined reader type of ',$inputFileType,'<br />';
	33	+echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #1 using IOFactory with a defined reader type of ', $inputFileType, '<br />';
34	34	$spreadsheet = $objReader->load($inputFileName);
35	35	$spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
36	36	foreach ($inputFileNames as $sheet => $inputFileName) {
37		- echo 'Loading file ',pathinfo($inputFileName, PATHINFO_BASENAME),' into WorkSheet #',($sheet + 2),' using IOFactory with a defined reader type of ',$inputFileType,'<br />';
	37	+ echo 'Loading file ', pathinfo($inputFileName, PATHINFO_BASENAME), ' into WorkSheet #', ($sheet + 2), ' using IOFactory with a defined reader type of ', $inputFileType, '<br />';
38	38	$objReader->setSheetIndex($sheet + 1);
39	39	$objReader->loadIntoExisting($inputFileName, $spreadsheet);
40	40	$spreadsheet->getActiveSheet()->setTitle(pathinfo($inputFileName, PATHINFO_BASENAME));
		@@ -42,10 +42,10 @@ discard block
		block discarded – undo
42	42
43	43	echo '<hr />';
44	44
45		-echo $spreadsheet->getSheetCount(),' worksheet',(($spreadsheet->getSheetCount() == 1) ? '' : 's'),' loaded<br /><br />';
	45	+echo $spreadsheet->getSheetCount(), ' worksheet', (($spreadsheet->getSheetCount() == 1) ? '' : 's'), ' loaded<br /><br />';
46	46	$loadedSheetNames = $spreadsheet->getSheetNames();
47	47	foreach ($loadedSheetNames as $sheetIndex => $loadedSheetName) {
48		- echo '<b>Worksheet #',$sheetIndex,' -> ',$loadedSheetName,'</b><br />';
	48	+ echo '<b>Worksheet #', $sheetIndex, ' -> ', $loadedSheetName, '</b><br />';
49	49	$spreadsheet->setActiveSheetIndexByName($loadedSheetName);
50	50	$sheetData = $spreadsheet->getActiveSheet()->toArray(null, true, true, true);
51	51	var_dump($sheetData);

		@@ -69,7 +69,7 @@
		block discarded – undo
69	69	/**
70	70	* Read the file
71	71	*
72		- * @param $pFilename string Filename
	72	+ * @param string $pFilename string Filename
73	73	* @throws \PhpOffice\PhpSpreadsheet\Reader\Exception
74	74	*/
75	75	public function read($pFilename)

PHPOffice / PhpSpreadsheet

Push — develop ( ab7aa6...720fb3 )

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch