Inspection of "Enforce writer parts parent to be concrete writer" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 3ee9cc...870d86 )

by Adrien

created 2017-04-21 05:49 UTC

Status

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DMIN.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DMAX.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DGET.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DCOUNT.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

docs/Examples/Calculations/Database/DPRODUCT.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

		@@ -31,17 +31,17 @@
		block discarded – undo
31	31
32	32	// Add some data
33	33	$database = [['Tree', 'Height', 'Age', 'Yield', 'Profit'],
34		- ['Apple', 18, 20, 14, 105.00],
35		- ['Pear', 12, 12, 10, 96.00],
36		- ['Cherry', 13, 14, 9, 105.00],
37		- ['Apple', 14, 15, 10, 75.00],
38		- ['Pear', 9, 8, 8, 76.80],
39		- ['Apple', 8, 9, 6, 45.00],
40		- ];
	34	+ ['Apple', 18, 20, 14, 105.00],
	35	+ ['Pear', 12, 12, 10, 96.00],
	36	+ ['Cherry', 13, 14, 9, 105.00],
	37	+ ['Apple', 14, 15, 10, 75.00],
	38	+ ['Pear', 9, 8, 8, 76.80],
	39	+ ['Apple', 8, 9, 6, 45.00],
	40	+ ];
41	41	$criteria = [['Tree', 'Height', 'Age', 'Yield', 'Profit', 'Height'],
42		- ['="=Apple"', '>10', null, null, null, '<16'],
43		- ['="=Pear"', null, null, null, null, null],
44		- ];
	42	+ ['="=Apple"', '>10', null, null, null, '<16'],
	43	+ ['="=Pear"', null, null, null, null, null],
	44	+ ];
45	45
46	46	$worksheet->fromArray($criteria, null, 'A1');
47	47	$worksheet->fromArray($database, null, 'A4');

Please login to merge, or discard this patch.

src/PhpSpreadsheet/Shared/JAMA/SingularValueDecomposition.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -436,7 +436,7 @@
 block discarded – undo
         } // end while
     }
 
- // end constructor
+    // end constructor
 
     /**
      * Return the left singular vectors.

Please login to merge, or discard this patch.

src/PhpSpreadsheet/Shared/JAMA/EigenvalueDecomposition.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -778,7 +778,7 @@
 block discarded – undo
         }
     }
 
- // end hqr2
+    // end hqr2
 
     /**
      * Constructor: Check for symmetry, then construct the eigenvalue decomposition.

Please login to merge, or discard this patch.

docs/Examples/Reader/exampleReader14.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -68,7 +68,7 @@
 block discarded – undo
 /*  Tell the Reader that we want to use the Read Filter that we've Instantiated  **/
 /*    and that we want to store it in contiguous rows/columns  **/
 $reader->setReadFilter($chunkFilter)
-          ->setContiguous(true);
+            ->setContiguous(true);
 
 /*  Instantiate a new PhpSpreadsheet object manually  **/
 $spreadsheet = new \PhpOffice\PhpSpreadsheet\Spreadsheet();

Please login to merge, or discard this patch.

		@@ -436,7 +436,7 @@
		block discarded – undo
436	436	} // end while
437	437	}
438	438
439		- // end constructor
	439	+ // end constructor
440	440
441	441	/**
442	442	* Return the left singular vectors.

		@@ -778,7 +778,7 @@
		block discarded – undo
778	778	}
779	779	}
780	780
781		- // end hqr2
	781	+ // end hqr2
782	782
783	783	/**
784	784	* Constructor: Check for symmetry, then construct the eigenvalue decomposition.

		@@ -68,7 +68,7 @@
		block discarded – undo
68	68	/* Tell the Reader that we want to use the Read Filter that we've Instantiated **/
69	69	/* and that we want to store it in contiguous rows/columns **/
70	70	$reader->setReadFilter($chunkFilter)
71		- ->setContiguous(true);
	71	+ ->setContiguous(true);
72	72
73	73	/* Instantiate a new PhpSpreadsheet object manually **/
74	74	$spreadsheet = new \PhpOffice\PhpSpreadsheet\Spreadsheet();

PHPOffice / PhpSpreadsheet

Push — develop ( 3ee9cc...870d86 )

Status

Category

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch