PHPOffice / PhpSpreadsheet

src/PhpSpreadsheet/Writer/Html.php

Doc Comments +1 added lines, -1 removed lines

@@ -1188,7 +1188,7 @@
      * @param Worksheet $pSheet \PhpOffice\PhpSpreadsheet\Worksheet
      * @param array $pValues Array containing cells in a row
      * @param int $pRow Row number (0-based)
-     * @param mixed $cellType eg: 'td'
+     * @param string $cellType eg: 'td'
      *
      * @throws WriterException
      *

src/PhpSpreadsheet/Worksheet.php

Doc Comments +7 added lines, -7 removed lines

@@ -580,7 +580,7 @@ 
      *
      * @throws Exception
      *
-     * @return false|Chart
+     * @return Chart
      */
     public function getChartByIndex($index)
     {
@@ -1091,7 +1091,7 @@ 
      * @param string $column Return the highest data row for the specified column,
      *                                     or the highest data row of any column if no column letter is passed
      *
-     * @return string Highest row number that contains data
+     * @return integer Highest row number that contains data
      */
     public function getHighestDataRow($column = null)
     {
@@ -1143,7 +1143,7 @@ 
      * Set a cell value.
      *
      * @param string $pCoordinate Coordinate of the cell, eg: 'A1'
-     * @param mixed $pValue Value of the cell
+     * @param string $pValue Value of the cell
      * @param string $pDataType Explicit data type, see Cell\DataType::TYPE_*
      *
      * @return Worksheet
@@ -1348,7 +1348,7 @@ 
      * Get row dimension at a specific row.
      *
      * @param int $pRow Numeric index of the row
-     * @param mixed $create
+     * @param boolean $create
      *
      * @return Worksheet\RowDimension
      */
@@ -1374,7 +1374,7 @@ 
      * Get column dimension at a specific column.
      *
      * @param string $pColumn String index of the column eg: 'A'
-     * @param mixed $create
+     * @param boolean $create
      *
      * @return Worksheet\ColumnDimension
      */
@@ -1920,7 +1920,7 @@ 
     /**
      * Set AutoFilter.
      *
-     * @param Worksheet\AutoFilter|string $pValue
+     * @param string $pValue
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
      *
      * @throws Exception
@@ -2984,7 +2984,7 @@ 
      *
      * @throws Exception
      *
-     * @return objWorksheet
+     * @return Worksheet
      */
     public function setCodeName($pValue, $validate = true)
     {

src/PhpSpreadsheet/Cell.php

Doc Comments +1 added lines, -1 removed lines

@@ -961,7 +961,7 @@
      *
      *    [ 'A1:A3' => 'x', 'A4' => 'y' ]
      *
-     * @param array $pCoordCollection associative array mapping coordinates to values
+     * @param Cell\DataValidation[] $pCoordCollection associative array mapping coordinates to values
      *
      * @return array associative array mapping coordinate ranges to valuea
      */

src/PhpSpreadsheet/Calculation.php

Doc Comments +5 added lines, -2 removed lines

@@ -2688,7 +2688,7 @@ 
 
     /**
      * @param string $cellReference
-     * @param mixed $cellValue
+     * @param boolean $cellValue
      */
     public function saveValueToCache($cellReference, $cellValue)
     {
@@ -2813,7 +2813,7 @@ 
      *
      * @param mixed &$matrix matrix operand
      *
-     * @return int[] An array comprising the number of rows, and number of columns
+     * @return integer[] An array comprising the number of rows, and number of columns
      */
     private static function getMatrixDimensions(&$matrix)
     {
@@ -3801,6 +3801,9 @@ 
         return $output;
     }
 
+    /**
+     * @param string|null $cellID
+     */
     private function validateBinaryOperand($cellID, &$operand, &$stack)
     {
         if (is_array($operand)) {

Spacing +1 added lines, -1 removed lines

@@ -3849,7 +3849,7 @@
      *
      * @return bool
      */
-    private function executeBinaryComparisonOperation($cellID, $operand1, $operand2, $operation, Stack &$stack, $recursingArrays = false)
+    private function executeBinaryComparisonOperation($cellID, $operand1, $operand2, $operation, Stack & $stack, $recursingArrays = false)
     {
         //    If we're dealing with matrix operations, we want a matrix result
         if ((is_array($operand1)) || (is_array($operand2))) {

src/PhpSpreadsheet/Calculation/Engineering.php

Doc Comments +5 added lines, -3 removed lines

@@ -1855,7 +1855,7 @@ 
      *
      * @param string $complexNumber the complex number for which you want the real coefficient
      *
-     * @return float
+     * @return string
      */
     public static function IMREAL($complexNumber)
     {
@@ -2294,6 +2294,7 @@ 
      *        IMSUM(complexNumber[,complexNumber[,...]])
      *
      * @param string ...$complexNumbers Series of complex numbers to add
+     * @param string[] $complexNumbers
      *
      * @return string
      */
@@ -2334,6 +2335,7 @@ 
      *        IMPRODUCT(complexNumber[,complexNumber[,...]])
      *
      * @param string ...$complexNumbers Series of complex numbers to multiply
+     * @param string[] $complexNumbers
      *
      * @return string
      */
@@ -2377,7 +2379,7 @@ 
      *        DELTA(a[,b])
      *
      * @param float $a the first number
-     * @param float $b The second number. If omitted, b is assumed to be zero.
+     * @param integer $b The second number. If omitted, b is assumed to be zero.
      *
      * @return int
      */
@@ -2400,7 +2402,7 @@ 
      * functions you calculate the count of values that exceed a threshold.
      *
      * @param float $number the value to test against step
-     * @param float $step The threshold value.
+     * @param integer $step The threshold value.
      *                                    If you omit a value for step, GESTEP uses zero.
      *
      * @return int

src/PhpSpreadsheet/Calculation/MathTrig.php

Doc Comments +11 added lines, -11 removed lines

@@ -56,6 +56,10 @@ 
         return [(int) $value];
     }
 
+    /**
+     * @param integer $num
+     * @param integer $n
+     */
     private static function romanCut($num, $n)
     {
         return ($num - ($num % $n)) / $n;
@@ -508,7 +512,7 @@ 
      * @category Mathematical and Trigonometric Functions
      *
      * @param float $number The positive real number for which you want the logarithm
-     * @param float $base The base of the logarithm. If base is omitted, it is assumed to be 10.
+     * @param integer $base The base of the logarithm. If base is omitted, it is assumed to be 10.
      *
      * @return float
      */
@@ -826,8 +830,8 @@ 
      *
      * Computes x raised to the power y.
      *
-     * @param float $x
-     * @param float $y
+     * @param integer $x
+     * @param integer $y
      *
      * @return float
      */
@@ -901,7 +905,7 @@ 
      *
      * @param mixed ...$args Data values
      *
-     * @return float
+     * @return integer
      */
     public static function QUOTIENT(...$args)
     {
@@ -1039,9 +1043,6 @@ 
      *
      * Returns the sum of a power series
      *
-     * @param float $x Input value to the power series
-     * @param float $n Initial power to which you want to raise $x
-     * @param float $m Step by which to increase $n for each term in the series
      * @param array of mixed Data Series
      *
      * @return float
@@ -1219,7 +1220,7 @@ 
      * @param mixed $aArgs
      * @param mixed $sumArgs
      *
-     * @return float
+     * @return integer
      */
     public static function SUMIF($aArgs, $condition, $sumArgs = [])
     {
@@ -1259,9 +1260,8 @@ 
      *    @category Mathematical and Trigonometric Functions
      *
      * @param mixed $args Data values
-     * @param string $condition the criteria that defines which cells will be summed
      *
-     * @return float
+     * @return integer
      */
     public static function SUMIFS(...$args)
     {
@@ -1450,7 +1450,7 @@ 
      *
      * Truncates value to the number of fractional digits by number_digits.
      *
-     * @param float $value
+     * @param integer $value
      * @param int $digits
      *
      * @return float Truncated value

tests/PhpSpreadsheetTests/Writer/Xls/WorkbookTest.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -8,9 +8,9 @@
 

 namespace PhpOffice\PhpSpreadsheetTests\Writer\Xls\Workbook;

 

-use PhpOffice\PhpSpreadsheet\Spreadsheet;

-use PhpOffice\PhpSpreadsheet\Writer\Xls\Parser;

-use PhpOffice\PhpSpreadsheet\Writer\Xls\Workbook;

+use PhpOffice\PhpSpreadsheet\Spreadsheet;
+use PhpOffice\PhpSpreadsheet\Writer\Xls\Parser;
+use PhpOffice\PhpSpreadsheet\Writer\Xls\Workbook;
 use PHPUnit_Framework_TestCase;

 

 class WorkbookTest extends PHPUnit_Framework_TestCase

Spacing +11 added lines, -11 removed lines

@@ -19,7 +19,7 @@ 
     private $workbook;

 

 

-    protected function setUp(){

+    protected function setUp() {

         $spreadsheet = new Spreadsheet();

         $strTotal = 0;

         $strUnique = 0;

@@ -27,7 +27,7 @@ 
         $colors = [];

         $parser = new Parser();

 

-        $this->workbook = new Workbook($spreadsheet, $strTotal, $strUnique, $str_table, $colors,$parser);

+        $this->workbook = new Workbook($spreadsheet, $strTotal, $strUnique, $str_table, $colors, $parser);

     }

 

     protected function tearDown()

@@ -40,7 +40,7 @@ 
      *

      * @param mixed $expectedResult

      */

-    public function testAddColor($testColors,$expectedResult){

+    public function testAddColor($testColors, $expectedResult) {

         $result = 0;

 

         $workbookReflection = new \ReflectionClass(Workbook::class);

@@ -49,7 +49,7 @@ 
         $methodAddColor->setAccessible(TRUE);

         $propertyPalette->setAccessible(TRUE);

 

-        foreach($testColors as $testColor){

+        foreach ($testColors as $testColor) {

             $result = $methodAddColor->invoke($this->workbook, $testColor);

         }

 

@@ -58,7 +58,7 @@ 
         $this->assertEquals($expectedResult, $palette);

     }

 

-    public function providerAddColor(){

+    public function providerAddColor() {

         $this->setUp();

 

         $workbookReflection = new \ReflectionClass(Workbook::class);

@@ -128,10 +128,10 @@ 
      * @param array $palette palette color

      * @return string rgb string

      */

-    public static function paletteToColor($palette){

-        return self::right('00'.dechex(intval($palette[0])),2)

-            .self::right('00'.dechex(intval($palette[1])),2)

-            .self::right('00'.dechex(intval($palette[2])),2);

+    public static function paletteToColor($palette) {

+        return self::right('00' . dechex(intval($palette[0])), 2)

+            .self::right('00' . dechex(intval($palette[1])), 2)

+            .self::right('00' . dechex(intval($palette[2])), 2);

     }

 

     /**

@@ -141,8 +141,8 @@ 
      * @param integer $nbchar number of char at right of string

      * @return string

      */

-    public static function right($value,$nbchar)

+    public static function right($value, $nbchar)

     {

-            return mb_substr($value,mb_strlen($value)-$nbchar, $nbchar);

+            return mb_substr($value, mb_strlen($value) - $nbchar, $nbchar);

     }

 }