Completed
Pull Request — develop (#237)
by Pieter
61:48
created
src/PhpSpreadsheet/Calculation/Engineering.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1855,7 +1855,7 @@  discard block
 block discarded – undo
1855 1855
      *
1856 1856
      * @param string $complexNumber the complex number for which you want the real coefficient
1857 1857
      *
1858
-     * @return float
1858
+     * @return string
1859 1859
      */
1860 1860
     public static function IMREAL($complexNumber)
1861 1861
     {
@@ -2294,6 +2294,7 @@  discard block
 block discarded – undo
2294 2294
      *        IMSUM(complexNumber[,complexNumber[,...]])
2295 2295
      *
2296 2296
      * @param string ...$complexNumbers Series of complex numbers to add
2297
+     * @param string[] $complexNumbers
2297 2298
      *
2298 2299
      * @return string
2299 2300
      */
@@ -2334,6 +2335,7 @@  discard block
 block discarded – undo
2334 2335
      *        IMPRODUCT(complexNumber[,complexNumber[,...]])
2335 2336
      *
2336 2337
      * @param string ...$complexNumbers Series of complex numbers to multiply
2338
+     * @param string[] $complexNumbers
2337 2339
      *
2338 2340
      * @return string
2339 2341
      */
@@ -2377,7 +2379,7 @@  discard block
 block discarded – undo
2377 2379
      *        DELTA(a[,b])
2378 2380
      *
2379 2381
      * @param float $a the first number
2380
-     * @param float $b The second number. If omitted, b is assumed to be zero.
2382
+     * @param integer $b The second number. If omitted, b is assumed to be zero.
2381 2383
      *
2382 2384
      * @return int
2383 2385
      */
@@ -2400,7 +2402,7 @@  discard block
 block discarded – undo
2400 2402
      * functions you calculate the count of values that exceed a threshold.
2401 2403
      *
2402 2404
      * @param float $number the value to test against step
2403
-     * @param float $step The threshold value.
2405
+     * @param integer $step The threshold value.
2404 2406
      *                                    If you omit a value for step, GESTEP uses zero.
2405 2407
      *
2406 2408
      * @return int
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/MathTrig.php 1 patch
Doc Comments   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -56,6 +56,10 @@  discard block
 block discarded – undo
56 56
         return [(int) $value];
57 57
     }
58 58
 
59
+    /**
60
+     * @param integer $num
61
+     * @param integer $n
62
+     */
59 63
     private static function romanCut($num, $n)
60 64
     {
61 65
         return ($num - ($num % $n)) / $n;
@@ -508,7 +512,7 @@  discard block
 block discarded – undo
508 512
      * @category Mathematical and Trigonometric Functions
509 513
      *
510 514
      * @param float $number The positive real number for which you want the logarithm
511
-     * @param float $base The base of the logarithm. If base is omitted, it is assumed to be 10.
515
+     * @param integer $base The base of the logarithm. If base is omitted, it is assumed to be 10.
512 516
      *
513 517
      * @return float
514 518
      */
@@ -826,8 +830,8 @@  discard block
 block discarded – undo
826 830
      *
827 831
      * Computes x raised to the power y.
828 832
      *
829
-     * @param float $x
830
-     * @param float $y
833
+     * @param integer $x
834
+     * @param integer $y
831 835
      *
832 836
      * @return float
833 837
      */
@@ -901,7 +905,7 @@  discard block
 block discarded – undo
901 905
      *
902 906
      * @param mixed ...$args Data values
903 907
      *
904
-     * @return float
908
+     * @return integer
905 909
      */
906 910
     public static function QUOTIENT(...$args)
907 911
     {
@@ -1039,9 +1043,6 @@  discard block
 block discarded – undo
1039 1043
      *
1040 1044
      * Returns the sum of a power series
1041 1045
      *
1042
-     * @param float $x Input value to the power series
1043
-     * @param float $n Initial power to which you want to raise $x
1044
-     * @param float $m Step by which to increase $n for each term in the series
1045 1046
      * @param array of mixed Data Series
1046 1047
      *
1047 1048
      * @return float
@@ -1219,7 +1220,7 @@  discard block
 block discarded – undo
1219 1220
      * @param mixed $aArgs
1220 1221
      * @param mixed $sumArgs
1221 1222
      *
1222
-     * @return float
1223
+     * @return integer
1223 1224
      */
1224 1225
     public static function SUMIF($aArgs, $condition, $sumArgs = [])
1225 1226
     {
@@ -1259,9 +1260,8 @@  discard block
 block discarded – undo
1259 1260
      *    @category Mathematical and Trigonometric Functions
1260 1261
      *
1261 1262
      * @param mixed $args Data values
1262
-     * @param string $condition the criteria that defines which cells will be summed
1263 1263
      *
1264
-     * @return float
1264
+     * @return integer
1265 1265
      */
1266 1266
     public static function SUMIFS(...$args)
1267 1267
     {
@@ -1450,7 +1450,7 @@  discard block
 block discarded – undo
1450 1450
      *
1451 1451
      * Truncates value to the number of fractional digits by number_digits.
1452 1452
      *
1453
-     * @param float $value
1453
+     * @param integer $value
1454 1454
      * @param int $digits
1455 1455
      *
1456 1456
      * @return float Truncated value
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3849,7 +3849,7 @@
 block discarded – undo
3849 3849
      *
3850 3850
      * @return bool
3851 3851
      */
3852
-    private function executeBinaryComparisonOperation($cellID, $operand1, $operand2, $operation, Stack &$stack, $recursingArrays = false)
3852
+    private function executeBinaryComparisonOperation($cellID, $operand1, $operand2, $operation, Stack & $stack, $recursingArrays = false)
3853 3853
     {
3854 3854
         //    If we're dealing with matrix operations, we want a matrix result
3855 3855
         if ((is_array($operand1)) || (is_array($operand2))) {
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2672,7 +2672,7 @@  discard block
 block discarded – undo
2672 2672
 
2673 2673
     /**
2674 2674
      * @param string $cellReference
2675
-     * @param mixed $cellValue
2675
+     * @param boolean $cellValue
2676 2676
      */
2677 2677
     public function saveValueToCache($cellReference, $cellValue)
2678 2678
     {
@@ -2797,7 +2797,7 @@  discard block
 block discarded – undo
2797 2797
      *
2798 2798
      * @param mixed &$matrix matrix operand
2799 2799
      *
2800
-     * @return int[] An array comprising the number of rows, and number of columns
2800
+     * @return integer[] An array comprising the number of rows, and number of columns
2801 2801
      */
2802 2802
     private static function getMatrixDimensions(&$matrix)
2803 2803
     {
@@ -3800,6 +3800,9 @@  discard block
 block discarded – undo
3800 3800
         return $output;
3801 3801
     }
3802 3802
 
3803
+    /**
3804
+     * @param null|string $cellID
3805
+     */
3803 3806
     private function validateBinaryOperand($cellID, &$operand, &$stack)
3804 3807
     {
3805 3808
         if (is_array($operand)) {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/NamedRange.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@
 block discarded – undo
212 212
      * Resolve a named range to a regular cell range.
213 213
      *
214 214
      * @param string $pNamedRange Named range
215
-     * @param null|Worksheet $pSheet Scope. Use null for global scope
215
+     * @param Worksheet $pSheet Scope. Use null for global scope
216 216
      *
217 217
      * @return NamedRange
218 218
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/Font.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -217,7 +217,7 @@
 block discarded – undo
217 217
      * Calculate an (approximate) OpenXML column width, based on font size and text contained.
218 218
      *
219 219
      * @param \PhpOffice\PhpSpreadsheet\Style\Font $font Font object
220
-     * @param RichText|string $cellText Text to calculate width
220
+     * @param string $cellText Text to calculate width
221 221
      * @param int $rotation Rotation angle
222 222
      * @param null|\PhpOffice\PhpSpreadsheet\Style\Font $defaultFont Font object
223 223
      *
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/OLE/PPS/Root.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
      * If a resource pointer to a stream created by fopen() is passed
60 60
      * it will be used, but you have to close such stream by yourself.
61 61
      *
62
-     * @param resource|string $filename the name of the file or stream where to save the OLE container
62
+     * @param string $filename the name of the file or stream where to save the OLE container
63 63
      *
64 64
      * @throws WriterException
65 65
      *
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      *
125 125
      * @param array $raList Reference to an array of PPS's
126 126
      *
127
-     * @return float[] The array of numbers
127
+     * @return double[] The array of numbers
128 128
      */
129 129
     public function _calcSize(&$raList)
130 130
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Worksheet.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -558,7 +558,7 @@  discard block
 block discarded – undo
558 558
      *
559 559
      * @throws Exception
560 560
      *
561
-     * @return Chart|false
561
+     * @return Chart
562 562
      */
563 563
     public function getChartByIndex($index)
564 564
     {
@@ -1069,7 +1069,7 @@  discard block
 block discarded – undo
1069 1069
      * @param string $column Return the highest data row for the specified column,
1070 1070
      *                                     or the highest data row of any column if no column letter is passed
1071 1071
      *
1072
-     * @return string Highest row number that contains data
1072
+     * @return integer Highest row number that contains data
1073 1073
      */
1074 1074
     public function getHighestDataRow($column = null)
1075 1075
     {
@@ -1121,7 +1121,7 @@  discard block
 block discarded – undo
1121 1121
      * Set a cell value.
1122 1122
      *
1123 1123
      * @param string $pCoordinate Coordinate of the cell, eg: 'A1'
1124
-     * @param mixed $pValue Value of the cell
1124
+     * @param string $pValue Value of the cell
1125 1125
      * @param string $pDataType Explicit data type, see Cell\DataType::TYPE_*
1126 1126
      *
1127 1127
      * @return Worksheet
@@ -1327,7 +1327,7 @@  discard block
 block discarded – undo
1327 1327
      * Get row dimension at a specific row.
1328 1328
      *
1329 1329
      * @param int $pRow Numeric index of the row
1330
-     * @param mixed $create
1330
+     * @param boolean $create
1331 1331
      *
1332 1332
      * @return Worksheet\RowDimension
1333 1333
      */
@@ -1353,7 +1353,7 @@  discard block
 block discarded – undo
1353 1353
      * Get column dimension at a specific column.
1354 1354
      *
1355 1355
      * @param string $pColumn String index of the column eg: 'A'
1356
-     * @param mixed $create
1356
+     * @param boolean $create
1357 1357
      *
1358 1358
      * @return Worksheet\ColumnDimension
1359 1359
      */
@@ -1899,7 +1899,7 @@  discard block
 block discarded – undo
1899 1899
     /**
1900 1900
      * Set AutoFilter.
1901 1901
      *
1902
-     * @param string|Worksheet\AutoFilter $pValue
1902
+     * @param string $pValue
1903 1903
      *            A simple string containing a Cell range like 'A1:E10' is permitted for backward compatibility
1904 1904
      *
1905 1905
      * @throws Exception
@@ -2965,7 +2965,7 @@  discard block
 block discarded – undo
2965 2965
      *
2966 2966
      * @throws Exception
2967 2967
      *
2968
-     * @return objWorksheet
2968
+     * @return Worksheet
2969 2969
      */
2970 2970
     public function setCodeName($pValue, $validate = true)
2971 2971
     {
Please login to merge, or discard this patch.