BetterBooleanTest::testBetterBoolean() - Code Metrics - Inspection of "Html Reader/Writer Better Handling of Booleans" - PHPOffice/PhpSpreadsheet - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#4257)

by Owen

created 2024-12-02 01:27 UTC

BetterBooleanTest::testBetterBoolean() A

↳ Parent: BetterBooleanTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	21
c	2
b	0
f	0
dl	0
loc	26
rs	9.584
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace PhpOffice\PhpSpreadsheetTests\Writer\Html;

use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
use PhpOffice\PhpSpreadsheet\Cell\DataType;
use PhpOffice\PhpSpreadsheet\Reader\Html as HtmlReader;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Writer\Html as HtmlWriter;
use PhpOffice\PhpSpreadsheetTests\Functional;

class BetterBooleanTest extends Functional\AbstractFunctional
{
    private string $locale;

    protected function setUp(): void
    {
        $calculation = Calculation::getInstance();
        $this->locale = $calculation->getLocale();
    }

    protected function tearDown(): void
    {
        $calculation = Calculation::getInstance();
        $calculation->setLocale($this->locale);
    }

    public function testDefault(): void
    {
        $spreadsheet = new Spreadsheet();
        $writer = new HtmlWriter($spreadsheet);
        // Default will change with next PhpSpreadsheet release
        self::assertFalse($writer->getBetterBoolean());
        $spreadsheet->disconnectWorksheets();
    }

    public function setBetter(HtmlWriter $writer): void
    {
        $writer->setBetterBoolean(true);
    }

    public function setNotBetter(HtmlWriter $writer): void
    {
        $writer->setBetterBoolean(false);
    }

    public function testBetterBoolean(): void
    {
        $spreadsheet = new Spreadsheet();
        $sheet = $spreadsheet->getActiveSheet();
        $sheet->getCell('A1')->setValue(1);
        $sheet->getCell('B1')->setValue('Hello');
        $sheet->getCell('C1')->setValue(true);
        $sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
        $sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
        $sheet->getCell('F1')->setValue('="A"&"B"');
        $sheet->getCell('G1')->setValue('=1+2');

        /** @var callable */
        $callableWriter = [$this, 'setBetter'];
        $reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
        $spreadsheet->disconnectWorksheets();

        $rsheet = $reloaded->getActiveSheet();
        self::assertSame(1, $rsheet->getCell('A1')->getValue());
        self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
        self::assertTrue($rsheet->getCell('C1')->getValue());
        self::assertFalse($rsheet->getCell('D1')->getValue());
        self::assertSame('1', $rsheet->getCell('E1')->getValue());
        self::assertSame('AB', $rsheet->getCell('F1')->getValue());
        self::assertSame(3, $rsheet->getCell('G1')->getValue());
        $reloaded->disconnectWorksheets();
    }

    public function testNotBetterBoolean(): void
    {
        $spreadsheet = new Spreadsheet();
        $sheet = $spreadsheet->getActiveSheet();
        $sheet->getCell('A1')->setValue(1);
        $sheet->getCell('B1')->setValue('Hello');
        $sheet->getCell('C1')->setValue(true);
        $sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
        $sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
        $sheet->getCell('F1')->setValue('="A"&"B"');
        $sheet->getCell('G1')->setValue('=1+2');

        /** @var callable */
        $callableWriter = [$this, 'setNotBetter'];
        $reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
        $spreadsheet->disconnectWorksheets();

        $rsheet = $reloaded->getActiveSheet();
        self::assertSame(1, $rsheet->getCell('A1')->getValue());
        self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
        self::assertSame(1, $rsheet->getCell('C1')->getValue());
        self::assertNull($rsheet->getCell('D1')->getValue());
        self::assertSame(1, $rsheet->getCell('E1')->getValue());
        self::assertSame('AB', $rsheet->getCell('F1')->getValue());
        self::assertSame(3, $rsheet->getCell('G1')->getValue());
        $reloaded->disconnectWorksheets();
    }

    public function testLocale(): void
    {
        $spreadsheet = new Spreadsheet();
        $sheet = $spreadsheet->getActiveSheet();
        $sheet->getCell('A1')->setValue(1);
        $sheet->getCell('B1')->setValue('Hello');
        $sheet->getCell('C1')->setValue(true);
        $sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
        $sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
        $sheet->getCell('F1')->setValue('="A"&"B"');
        $sheet->getCell('G1')->setValue('=1+2');
        $calc = Calculation::getInstance();
        $calc->setLocale('fr');
        $writer = new HtmlWriter($spreadsheet);
        $writer->setBetterBoolean(true);
        $html = $writer->generateHtmlAll();
        self::assertStringNotContainsString('TRUE', $html);
        self::assertStringContainsString('<td data-type="b" class="column2 style0 b">VRAI</td>', $html);
        self::assertStringContainsString('<td data-type="b" class="column3 style0 b">FAUX</td>', $html);
        self::assertStringContainsString('<td data-type="s" class="column4 style0 s">1</td>', $html);
        self::assertStringContainsString('<td class="column5 style0 s">AB</td>', $html);
        self::assertStringContainsString('<td class="column6 style0 n">3</td>', $html);

        /** @var callable */
        $callableWriter = [$this, 'setBetter'];
        $reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
        $spreadsheet->disconnectWorksheets();

        $rsheet = $reloaded->getActiveSheet();
        self::assertSame(1, $rsheet->getCell('A1')->getValue());
        self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
        self::assertTrue($rsheet->getCell('C1')->getValue());
        self::assertFalse($rsheet->getCell('D1')->getValue());
        self::assertSame('1', $rsheet->getCell('E1')->getValue());
        self::assertSame('AB', $rsheet->getCell('F1')->getValue());
        self::assertSame(3, $rsheet->getCell('G1')->getValue());
        $reloaded->disconnectWorksheets();
    }

    public function testInline(): void
    {
        $spreadsheet = new Spreadsheet();
        $sheet = $spreadsheet->getActiveSheet();
        $sheet->getCell('A1')->setValue(1);
        $sheet->getCell('B1')->setValue('Hello');
        $sheet->getCell('C1')->setValue(true);
        $sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
        $sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
        $sheet->getCell('F1')->setValue('="A"&"B"');
        $sheet->getCell('G1')->setValue('=1+2');
        $calc = Calculation::getInstance();
        $calc->setLocale('fr');
        $writer = new HtmlWriter($spreadsheet);
        $writer->setBetterBoolean(true);
        $writer->setUseInlineCss(true);
        $html = $writer->generateHtmlAll();
        $html = str_replace('vertical-align:bottom; color:#000000; font-family:\'Calibri\'; font-size:11pt; ', '', $html);
        $html = str_replace(' width:42pt" class="gridlines gridlinesp"', '"', $html);
        self::assertStringNotContainsString('TRUE', $html);
        self::assertStringContainsString('<td style="text-align:right;">1</td>', $html);
        self::assertStringContainsString('<td style="text-align:left;">Hello</td>', $html);
        self::assertStringContainsString('<td data-type="b" style="text-align:center;">VRAI</td>', $html);
        self::assertStringContainsString('<td data-type="b" style="text-align:center;">FAUX</td>', $html);
        self::assertStringContainsString('<td style="text-align:left;">AB</td>', $html);
        self::assertStringContainsString('<td style="text-align:right;">3</td>', $html);

        /** @var callable */
        $callableWriter = [$this, 'setBetter'];
        $reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
        $spreadsheet->disconnectWorksheets();

        $rsheet = $reloaded->getActiveSheet();
        self::assertSame(1, $rsheet->getCell('A1')->getValue());
        self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
        self::assertTrue($rsheet->getCell('C1')->getValue());
        self::assertFalse($rsheet->getCell('D1')->getValue());
        self::assertSame('1', $rsheet->getCell('E1')->getValue());
        self::assertSame('AB', $rsheet->getCell('F1')->getValue());
        self::assertSame(3, $rsheet->getCell('G1')->getValue());
        $reloaded->disconnectWorksheets();
    }

    public function testForeignNoLocale(): void
    {
        $fragment = '<table><tbody><tr>'
            . '<td>1</td>'
            . '<td>Hello</td>'
            . '<td data-type="b">ИСТИНА</td>' // Bulgarian TRUE
            . '<td data-type="b">EPÄTOSI</td>' // Finnish FALSE
            . '<td data-type="b">whatever</td>'
            . '<td data-type="b">tRuE</td>'
            . '<td data-type="s">1</td>'
            . '</tr></tbody></table>';
        $reader = new HtmlReader();
        $spreadsheet = $reader->loadFromString($fragment);
        $sheet = $spreadsheet->getActiveSheet();
        self::assertSame(1, $sheet->getCell('A1')->getValue());
        self::assertSame('Hello', $sheet->getCell('B1')->getValue());
        self::assertTrue($sheet->getCell('C1')->getValue());
        self::assertFalse($sheet->getCell('D1')->getValue());
        self::assertSame('whatever', $sheet->getCell('E1')->getValue());
        self::assertTrue($sheet->getCell('F1')->getValue());
        self::assertSame('1', $sheet->getCell('G1')->getValue());
        $spreadsheet->disconnectWorksheets();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace PhpOffice\PhpSpreadsheetTests\Writer\Html;
6
7			use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
8			use PhpOffice\PhpSpreadsheet\Cell\DataType;
9			use PhpOffice\PhpSpreadsheet\Reader\Html as HtmlReader;
10			use PhpOffice\PhpSpreadsheet\Spreadsheet;
11			use PhpOffice\PhpSpreadsheet\Writer\Html as HtmlWriter;
12			use PhpOffice\PhpSpreadsheetTests\Functional;
13
14			class BetterBooleanTest extends Functional\AbstractFunctional
15			{
16			private string $locale;
17
18			protected function setUp(): void
19			{
20			$calculation = Calculation::getInstance();
21			$this->locale = $calculation->getLocale();
22			}
23
24			protected function tearDown(): void
25			{
26			$calculation = Calculation::getInstance();
27			$calculation->setLocale($this->locale);
28			}
29
30			public function testDefault(): void
31			{
32			$spreadsheet = new Spreadsheet();
33			$writer = new HtmlWriter($spreadsheet);
34			// Default will change with next PhpSpreadsheet release
35			self::assertFalse($writer->getBetterBoolean());
36			$spreadsheet->disconnectWorksheets();
37			}
38
39			public function setBetter(HtmlWriter $writer): void
40			{
41			$writer->setBetterBoolean(true);
42			}
43
44			public function setNotBetter(HtmlWriter $writer): void
45			{
46			$writer->setBetterBoolean(false);
47			}
48
49			public function testBetterBoolean(): void
50			{
51			$spreadsheet = new Spreadsheet();
52			$sheet = $spreadsheet->getActiveSheet();
53			$sheet->getCell('A1')->setValue(1);
54			$sheet->getCell('B1')->setValue('Hello');
55			$sheet->getCell('C1')->setValue(true);
56			$sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
57			$sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
58			$sheet->getCell('F1')->setValue('="A"&"B"');
59			$sheet->getCell('G1')->setValue('=1+2');
60
61			/** @var callable */
62			$callableWriter = [$this, 'setBetter'];
63			$reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
64			$spreadsheet->disconnectWorksheets();
65
66			$rsheet = $reloaded->getActiveSheet();
67			self::assertSame(1, $rsheet->getCell('A1')->getValue());
68			self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
69			self::assertTrue($rsheet->getCell('C1')->getValue());
70			self::assertFalse($rsheet->getCell('D1')->getValue());
71			self::assertSame('1', $rsheet->getCell('E1')->getValue());
72			self::assertSame('AB', $rsheet->getCell('F1')->getValue());
73			self::assertSame(3, $rsheet->getCell('G1')->getValue());
74			$reloaded->disconnectWorksheets();
75			}
76
77			public function testNotBetterBoolean(): void
78			{
79			$spreadsheet = new Spreadsheet();
80			$sheet = $spreadsheet->getActiveSheet();
81			$sheet->getCell('A1')->setValue(1);
82			$sheet->getCell('B1')->setValue('Hello');
83			$sheet->getCell('C1')->setValue(true);
84			$sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
85			$sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
86			$sheet->getCell('F1')->setValue('="A"&"B"');
87			$sheet->getCell('G1')->setValue('=1+2');
88
89			/** @var callable */
90			$callableWriter = [$this, 'setNotBetter'];
91			$reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
92			$spreadsheet->disconnectWorksheets();
93
94			$rsheet = $reloaded->getActiveSheet();
95			self::assertSame(1, $rsheet->getCell('A1')->getValue());
96			self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
97			self::assertSame(1, $rsheet->getCell('C1')->getValue());
98			self::assertNull($rsheet->getCell('D1')->getValue());
99			self::assertSame(1, $rsheet->getCell('E1')->getValue());
100			self::assertSame('AB', $rsheet->getCell('F1')->getValue());
101			self::assertSame(3, $rsheet->getCell('G1')->getValue());
102			$reloaded->disconnectWorksheets();
103			}
104
105			public function testLocale(): void
106			{
107			$spreadsheet = new Spreadsheet();
108			$sheet = $spreadsheet->getActiveSheet();
109			$sheet->getCell('A1')->setValue(1);
110			$sheet->getCell('B1')->setValue('Hello');
111			$sheet->getCell('C1')->setValue(true);
112			$sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
113			$sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
114			$sheet->getCell('F1')->setValue('="A"&"B"');
115			$sheet->getCell('G1')->setValue('=1+2');
116			$calc = Calculation::getInstance();
117			$calc->setLocale('fr');
118			$writer = new HtmlWriter($spreadsheet);
119			$writer->setBetterBoolean(true);
120			$html = $writer->generateHtmlAll();
121			self::assertStringNotContainsString('TRUE', $html);
122			self::assertStringContainsString('<td data-type="b" class="column2 style0 b">VRAI</td>', $html);
123			self::assertStringContainsString('<td data-type="b" class="column3 style0 b">FAUX</td>', $html);
124			self::assertStringContainsString('<td data-type="s" class="column4 style0 s">1</td>', $html);
125			self::assertStringContainsString('<td class="column5 style0 s">AB</td>', $html);
126			self::assertStringContainsString('<td class="column6 style0 n">3</td>', $html);
127
128			/** @var callable */
129			$callableWriter = [$this, 'setBetter'];
130			$reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
131			$spreadsheet->disconnectWorksheets();
132
133			$rsheet = $reloaded->getActiveSheet();
134			self::assertSame(1, $rsheet->getCell('A1')->getValue());
135			self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
136			self::assertTrue($rsheet->getCell('C1')->getValue());
137			self::assertFalse($rsheet->getCell('D1')->getValue());
138			self::assertSame('1', $rsheet->getCell('E1')->getValue());
139			self::assertSame('AB', $rsheet->getCell('F1')->getValue());
140			self::assertSame(3, $rsheet->getCell('G1')->getValue());
141			$reloaded->disconnectWorksheets();
142			}
143
144			public function testInline(): void
145			{
146			$spreadsheet = new Spreadsheet();
147			$sheet = $spreadsheet->getActiveSheet();
148			$sheet->getCell('A1')->setValue(1);
149			$sheet->getCell('B1')->setValue('Hello');
150			$sheet->getCell('C1')->setValue(true);
151			$sheet->getCell('D1')->setValue('=IF(1>2, TRUE, FALSE)');
152			$sheet->getCell('E1')->setValueExplicit(1, DataType::TYPE_STRING);
153			$sheet->getCell('F1')->setValue('="A"&"B"');
154			$sheet->getCell('G1')->setValue('=1+2');
155			$calc = Calculation::getInstance();
156			$calc->setLocale('fr');
157			$writer = new HtmlWriter($spreadsheet);
158			$writer->setBetterBoolean(true);
159			$writer->setUseInlineCss(true);
160			$html = $writer->generateHtmlAll();
161			$html = str_replace('vertical-align:bottom; color:#000000; font-family:\'Calibri\'; font-size:11pt; ', '', $html);
162			$html = str_replace(' width:42pt" class="gridlines gridlinesp"', '"', $html);
163			self::assertStringNotContainsString('TRUE', $html);
164			self::assertStringContainsString('<td style="text-align:right;">1</td>', $html);
165			self::assertStringContainsString('<td style="text-align:left;">Hello</td>', $html);
166			self::assertStringContainsString('<td data-type="b" style="text-align:center;">VRAI</td>', $html);
167			self::assertStringContainsString('<td data-type="b" style="text-align:center;">FAUX</td>', $html);
168			self::assertStringContainsString('<td style="text-align:left;">AB</td>', $html);
169			self::assertStringContainsString('<td style="text-align:right;">3</td>', $html);
170
171			/** @var callable */
172			$callableWriter = [$this, 'setBetter'];
173			$reloaded = $this->writeAndReload($spreadsheet, 'Html', null, $callableWriter);
174			$spreadsheet->disconnectWorksheets();
175
176			$rsheet = $reloaded->getActiveSheet();
177			self::assertSame(1, $rsheet->getCell('A1')->getValue());
178			self::assertSame('Hello', $rsheet->getCell('B1')->getValue());
179			self::assertTrue($rsheet->getCell('C1')->getValue());
180			self::assertFalse($rsheet->getCell('D1')->getValue());
181			self::assertSame('1', $rsheet->getCell('E1')->getValue());
182			self::assertSame('AB', $rsheet->getCell('F1')->getValue());
183			self::assertSame(3, $rsheet->getCell('G1')->getValue());
184			$reloaded->disconnectWorksheets();
185			}
186
187			public function testForeignNoLocale(): void
188			{
189			$fragment = '<table><tbody><tr>'
190			. '<td>1</td>'
191			. '<td>Hello</td>'
192			. '<td data-type="b">ИСТИНА</td>' // Bulgarian TRUE
193			. '<td data-type="b">EPÄTOSI</td>' // Finnish FALSE
194			. '<td data-type="b">whatever</td>'
195			. '<td data-type="b">tRuE</td>'
196			. '<td data-type="s">1</td>'
197			. '</tr></tbody></table>';
198			$reader = new HtmlReader();
199			$spreadsheet = $reader->loadFromString($fragment);
200			$sheet = $spreadsheet->getActiveSheet();
201			self::assertSame(1, $sheet->getCell('A1')->getValue());
202			self::assertSame('Hello', $sheet->getCell('B1')->getValue());
203			self::assertTrue($sheet->getCell('C1')->getValue());
204			self::assertFalse($sheet->getCell('D1')->getValue());
205			self::assertSame('whatever', $sheet->getCell('E1')->getValue());
206			self::assertTrue($sheet->getCell('F1')->getValue());
207			self::assertSame('1', $sheet->getCell('G1')->getValue());
208			$spreadsheet->disconnectWorksheets();
209			}
210			}
211

PHPOffice / PhpSpreadsheet

Pull Request — master (#4257)

BetterBooleanTest::testBetterBoolean() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like