Completed
Pull Request — develop (#241)
by Claudio
27:28
created
src/PhpSpreadsheet/Shared/OLERead.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
     /**
72 72
      * Read the file.
73 73
      *
74
-     * @param $pFilename string Filename
74
+     * @param string $pFilename string Filename
75 75
      *
76 76
      * @throws ReaderException
77 77
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Html.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1188,7 +1188,7 @@
 block discarded – undo
1188 1188
      * @param Worksheet $pSheet \PhpOffice\PhpSpreadsheet\Worksheet
1189 1189
      * @param array $pValues Array containing cells in a row
1190 1190
      * @param int $pRow Row number (0-based)
1191
-     * @param mixed $cellType eg: 'td'
1191
+     * @param string $cellType eg: 'td'
1192 1192
      *
1193 1193
      * @throws WriterException
1194 1194
      *
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Chart/Layout.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
     /**
237 237
      * Get X-Position.
238 238
      *
239
-     * @return number
239
+     * @return string
240 240
      */
241 241
     public function getXPosition()
242 242
     {
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
     /**
261 261
      * Get Y-Position.
262 262
      *
263
-     * @return number
263
+     * @return string
264 264
      */
265 265
     public function getYPosition()
266 266
     {
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
     /**
285 285
      * Get Width.
286 286
      *
287
-     * @return number
287
+     * @return string
288 288
      */
289 289
     public function getWidth()
290 290
     {
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     /**
309 309
      * Get Height.
310 310
      *
311
-     * @return number
311
+     * @return string
312 312
      */
313 313
     public function getHeight()
314 314
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Cell.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -961,7 +961,7 @@
 block discarded – undo
961 961
      *
962 962
      *    [ 'A1:A3' => 'x', 'A4' => 'y' ]
963 963
      *
964
-     * @param array $pCoordCollection associative array mapping coordinates to values
964
+     * @param Cell\DataValidation[] $pCoordCollection associative array mapping coordinates to values
965 965
      *
966 966
      * @return array associative array mapping coordinate ranges to valuea
967 967
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/Engineering.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1855,7 +1855,7 @@  discard block
 block discarded – undo
1855 1855
      *
1856 1856
      * @param string $complexNumber the complex number for which you want the real coefficient
1857 1857
      *
1858
-     * @return float
1858
+     * @return string
1859 1859
      */
1860 1860
     public static function IMREAL($complexNumber)
1861 1861
     {
@@ -2294,6 +2294,7 @@  discard block
 block discarded – undo
2294 2294
      *        IMSUM(complexNumber[,complexNumber[,...]])
2295 2295
      *
2296 2296
      * @param string ...$complexNumbers Series of complex numbers to add
2297
+     * @param string[] $complexNumbers
2297 2298
      *
2298 2299
      * @return string
2299 2300
      */
@@ -2334,6 +2335,7 @@  discard block
 block discarded – undo
2334 2335
      *        IMPRODUCT(complexNumber[,complexNumber[,...]])
2335 2336
      *
2336 2337
      * @param string ...$complexNumbers Series of complex numbers to multiply
2338
+     * @param string[] $complexNumbers
2337 2339
      *
2338 2340
      * @return string
2339 2341
      */
@@ -2377,7 +2379,7 @@  discard block
 block discarded – undo
2377 2379
      *        DELTA(a[,b])
2378 2380
      *
2379 2381
      * @param float $a the first number
2380
-     * @param float $b The second number. If omitted, b is assumed to be zero.
2382
+     * @param integer $b The second number. If omitted, b is assumed to be zero.
2381 2383
      *
2382 2384
      * @return int
2383 2385
      */
@@ -2400,7 +2402,7 @@  discard block
 block discarded – undo
2400 2402
      * functions you calculate the count of values that exceed a threshold.
2401 2403
      *
2402 2404
      * @param float $number the value to test against step
2403
-     * @param float $step The threshold value.
2405
+     * @param integer $step The threshold value.
2404 2406
      *                                    If you omit a value for step, GESTEP uses zero.
2405 2407
      *
2406 2408
      * @return int
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation/MathTrig.php 1 patch
Doc Comments   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -56,6 +56,10 @@  discard block
 block discarded – undo
56 56
         return [(int) $value];
57 57
     }
58 58
 
59
+    /**
60
+     * @param integer $num
61
+     * @param integer $n
62
+     */
59 63
     private static function romanCut($num, $n)
60 64
     {
61 65
         return ($num - ($num % $n)) / $n;
@@ -508,7 +512,7 @@  discard block
 block discarded – undo
508 512
      * @category Mathematical and Trigonometric Functions
509 513
      *
510 514
      * @param float $number The positive real number for which you want the logarithm
511
-     * @param float $base The base of the logarithm. If base is omitted, it is assumed to be 10.
515
+     * @param integer $base The base of the logarithm. If base is omitted, it is assumed to be 10.
512 516
      *
513 517
      * @return float
514 518
      */
@@ -826,8 +830,8 @@  discard block
 block discarded – undo
826 830
      *
827 831
      * Computes x raised to the power y.
828 832
      *
829
-     * @param float $x
830
-     * @param float $y
833
+     * @param integer $x
834
+     * @param integer $y
831 835
      *
832 836
      * @return float
833 837
      */
@@ -901,7 +905,7 @@  discard block
 block discarded – undo
901 905
      *
902 906
      * @param mixed ...$args Data values
903 907
      *
904
-     * @return float
908
+     * @return integer
905 909
      */
906 910
     public static function QUOTIENT(...$args)
907 911
     {
@@ -1039,9 +1043,6 @@  discard block
 block discarded – undo
1039 1043
      *
1040 1044
      * Returns the sum of a power series
1041 1045
      *
1042
-     * @param float $x Input value to the power series
1043
-     * @param float $n Initial power to which you want to raise $x
1044
-     * @param float $m Step by which to increase $n for each term in the series
1045 1046
      * @param array of mixed Data Series
1046 1047
      *
1047 1048
      * @return float
@@ -1219,7 +1220,7 @@  discard block
 block discarded – undo
1219 1220
      * @param mixed $aArgs
1220 1221
      * @param mixed $sumArgs
1221 1222
      *
1222
-     * @return float
1223
+     * @return integer
1223 1224
      */
1224 1225
     public static function SUMIF($aArgs, $condition, $sumArgs = [])
1225 1226
     {
@@ -1259,9 +1260,8 @@  discard block
 block discarded – undo
1259 1260
      *    @category Mathematical and Trigonometric Functions
1260 1261
      *
1261 1262
      * @param mixed $args Data values
1262
-     * @param string $condition the criteria that defines which cells will be summed
1263 1263
      *
1264
-     * @return float
1264
+     * @return integer
1265 1265
      */
1266 1266
     public static function SUMIFS(...$args)
1267 1267
     {
@@ -1450,7 +1450,7 @@  discard block
 block discarded – undo
1450 1450
      *
1451 1451
      * Truncates value to the number of fractional digits by number_digits.
1452 1452
      *
1453
-     * @param float $value
1453
+     * @param integer $value
1454 1454
      * @param int $digits
1455 1455
      *
1456 1456
      * @return float Truncated value
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Calculation.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3849,7 +3849,7 @@
 block discarded – undo
3849 3849
      *
3850 3850
      * @return bool
3851 3851
      */
3852
-    private function executeBinaryComparisonOperation($cellID, $operand1, $operand2, $operation, Stack &$stack, $recursingArrays = false)
3852
+    private function executeBinaryComparisonOperation($cellID, $operand1, $operand2, $operation, Stack & $stack, $recursingArrays = false)
3853 3853
     {
3854 3854
         //    If we're dealing with matrix operations, we want a matrix result
3855 3855
         if ((is_array($operand1)) || (is_array($operand2))) {
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2664,7 +2664,7 @@  discard block
 block discarded – undo
2664 2664
 
2665 2665
     /**
2666 2666
      * @param string $cellReference
2667
-     * @param mixed $cellValue
2667
+     * @param boolean $cellValue
2668 2668
      */
2669 2669
     public function saveValueToCache($cellReference, $cellValue)
2670 2670
     {
@@ -2789,7 +2789,7 @@  discard block
 block discarded – undo
2789 2789
      *
2790 2790
      * @param mixed &$matrix matrix operand
2791 2791
      *
2792
-     * @return int[] An array comprising the number of rows, and number of columns
2792
+     * @return integer[] An array comprising the number of rows, and number of columns
2793 2793
      */
2794 2794
     private static function getMatrixDimensions(&$matrix)
2795 2795
     {
Please login to merge, or discard this patch.
src/PhpSpreadsheet/NamedRange.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@
 block discarded – undo
212 212
      * Resolve a named range to a regular cell range.
213 213
      *
214 214
      * @param string $pNamedRange Named range
215
-     * @param null|Worksheet $pSheet Scope. Use null for global scope
215
+     * @param Worksheet $pSheet Scope. Use null for global scope
216 216
      *
217 217
      * @return NamedRange
218 218
      */
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Shared/Font.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -217,7 +217,7 @@
 block discarded – undo
217 217
      * Calculate an (approximate) OpenXML column width, based on font size and text contained.
218 218
      *
219 219
      * @param \PhpOffice\PhpSpreadsheet\Style\Font $font Font object
220
-     * @param RichText|string $cellText Text to calculate width
220
+     * @param string $cellText Text to calculate width
221 221
      * @param int $rotation Rotation angle
222 222
      * @param null|\PhpOffice\PhpSpreadsheet\Style\Font $defaultFont Font object
223 223
      *
Please login to merge, or discard this patch.