PhpOffice\PhpSpreadsheetTests\Reader\XlsxTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	35
Duplicated Lines	65.71 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testLoadXlsxWithoutCellReference()	0	5	1
A	testFreezePane()	23	23	1

<?php

namespace PhpOffice\PhpSpreadsheetTests\Reader;

use PhpOffice\PhpSpreadsheet\Reader\Xlsx as ReaderXlsx;
use PhpOffice\PhpSpreadsheet\Shared\File;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Writer\Xlsx as WriterXlsx;
use PHPUnit\Framework\TestCase;

class XlsxTest extends TestCase
{
    /**
     * Test load Xlsx file without cell reference.
     */
    public function testLoadXlsxWithoutCellReference()
    {
        $filename = './data/Reader/XLSX/without_cell_reference.xlsx';
        $reader = new ReaderXlsx();
        $reader->load($filename);
    }

    public function testFreezePane()

This method seems to be duplicated in your project.

    {
        $filename = tempnam(File::sysGetTempDir(), 'phpspreadsheet');

        $cellSplit = 'B2';
        $topLeftCell = 'E5';

        $spreadsheet = new Spreadsheet();
        $active = $spreadsheet->getActiveSheet();
        $active->freezePane($cellSplit, $topLeftCell);

        $writer = new WriterXlsx($spreadsheet);
        $writer->save($filename);

It seems like $filename can also be of type false; however, parameter $pFilename of PhpOffice\PhpSpreadsheet\Writer\Xlsx::save() does only seem to accept string, maybe add an additional type check?

        // Read written file
        $reader = new ReaderXlsx();
        $reloadedSpreadsheet = $reader->load($filename);

It seems like $filename can also be of type false; however, parameter $pFilename of PhpOffice\PhpSpreadsheet\Reader\Xlsx::load() does only seem to accept string, maybe add an additional type check?

        $reloadedActive = $reloadedSpreadsheet->getActiveSheet();
        $actualCellSplit = $reloadedActive->getFreezePane();
        $actualTopLeftCell = $reloadedActive->getTopLeftCell();

        self::assertSame($cellSplit, $actualCellSplit, 'should be able to set freeze pane');
        self::assertSame($topLeftCell, $actualTopLeftCell, 'should be able to set the top left cell');
    }
}