View GitHub Repository PhpSpreadsheet

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — master (#2787)
by Mark
12:12
created
Status
Category
Toggle Patches
src/PhpSpreadsheet/Writer/Xls.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -392,7 +392,7 @@  discard block
 
 block discarded – undo
392 392 
         }
393 393 
     }
394 394
395 
-    private function processMemoryDrawing(BstoreContainer &$bstoreContainer, MemoryDrawing $drawing, string $renderingFunctionx): void
395 
+    private function processMemoryDrawing(BstoreContainer & $bstoreContainer, MemoryDrawing $drawing, string $renderingFunctionx): void
396 396 
     {
397 397 
         switch ($renderingFunctionx) {
398 398 
             case MemoryDrawing::RENDERING_JPEG:
 
@@ -422,7 +422,7 @@  discard block
 
 block discarded – undo
422 422 
         $bstoreContainer->addBSE($BSE);
423 423 
     }
424 424
425 
-    private function processDrawing(BstoreContainer &$bstoreContainer, Drawing $drawing): void
425 
+    private function processDrawing(BstoreContainer & $bstoreContainer, Drawing $drawing): void
426 426 
     {
427 427 
         $blipType = null;
428 428 
         $blipData = '';
 
@@ -472,7 +472,7 @@  discard block
 
 block discarded – undo
472 472 
         }
473 473 
     }
474 474
475 
-    private function processBaseDrawing(BstoreContainer &$bstoreContainer, BaseDrawing $drawing): void
475 
+    private function processBaseDrawing(BstoreContainer & $bstoreContainer, BaseDrawing $drawing): void
476 476 
     {
477 477 
         if ($drawing instanceof Drawing) {
478 478 
             $this->processDrawing($bstoreContainer, $drawing);
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Chart/GridlinesLineStyleTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -151,7 +151,7 @@  discard block
 
 block discarded – undo
151 151 
             true, // plotVisibleOnly
152 152 
             DataSeries::EMPTY_AS_GAP, // displayBlanksAs
153 153 
             null, // xAxisLabel
154 
-            $yAxisLabel,  // yAxisLabel
154 
+            $yAxisLabel, // yAxisLabel
155 155 
             null, // xAxis
156 156 
             $yAxis // yAxis
157 157 
         );
 
@@ -344,7 +344,7 @@  discard block
 
 block discarded – undo
344 344 
             true, // plotVisibleOnly
345 345 
             DataSeries::EMPTY_AS_GAP, // displayBlanksAs
346 346 
             null, // xAxisLabel
347 
-            $yAxisLabel,  // yAxisLabel
347 
+            $yAxisLabel, // yAxisLabel
348 348 
             null, // xAxis
349 349 
             null, // yAxis
350 350 
             $majorGridlines,
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Chart/AxisPropertiesTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -137,7 +137,7 @@
 
 block discarded – undo
137 137 
             true, // plotVisibleOnly
138 138 
             DataSeries::EMPTY_AS_GAP, // displayBlanksAs
139 139 
             null, // xAxisLabel
140 
-            $yAxisLabel,  // yAxisLabel
140 
+            $yAxisLabel, // yAxisLabel
141 141 
             $xAxis, // xAxis
142 142 
             $yAxis, // yAxis
143 143 
             null, //majorGridlines,
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Chart/GridlinesShadowGlowTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -148,7 +148,7 @@
 
 block discarded – undo
148 148 
             true, // plotVisibleOnly
149 149 
             DataSeries::EMPTY_AS_GAP, // displayBlanksAs
150 150 
             null, // xAxisLabel
151 
-            $yAxisLabel,  // yAxisLabel
151 
+            $yAxisLabel, // yAxisLabel
152 152 
             null, // xAxis
153 153 
             $yAxis // yAxis
154 154 
         );
Please login to merge, or discard this patch.
tests/PhpSpreadsheetTests/Chart/Charts32CatAxValAxTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -127,7 +127,7 @@
 
 block discarded – undo
127 127 
             true, // plotVisibleOnly
128 128 
             DataSeries::EMPTY_AS_GAP, // displayBlanksAs
129 129 
             null, // xAxisLabel
130 
-            $yAxisLabel,  // yAxisLabel
130 
+            $yAxisLabel, // yAxisLabel
131 131 
             // added xAxis for correct date display
132 132 
             $xAxis, // xAxis
133 133 
         );
Please login to merge, or discard this patch.
src/PhpSpreadsheet/Writer/Xlsx/Chart.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1176,8 +1176,8 @@
 
 block discarded – undo
1176 1176 
                         $objWriter->startElement('c:numFmt');
1177 1177 
                         $objWriter->writeAttribute('formatCode', 'General');
1178 1178 
                         $objWriter->writeAttribute('sourceLinked', '0');
1179 
-                        $objWriter->endElement();  // numFmt
1180 
-                        $objWriter->endElement();  // trendlineLbl
1179 
+                        $objWriter->endElement(); // numFmt
1180 
+                        $objWriter->endElement(); // trendlineLbl
1181 1181 
                     }
1182 1182
1183 1183 
                     $objWriter->endElement(); // trendline
Please login to merge, or discard this patch.
samples/Chart/33_Chart_create_scatter5_trendlines.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -155,7 +155,7 @@  discard block
 
 block discarded – undo
155 155 
     true, // plotVisibleOnly
156 156 
     DataSeries::EMPTY_AS_GAP, // displayBlanksAs
157 157 
     null, // xAxisLabel
158 
-    $yAxisLabel,  // yAxisLabel
158 
+    $yAxisLabel, // yAxisLabel
159 159 
     // added xAxis for correct date display
160 160 
     $xAxis, // xAxis
161 161 
     //  $yAxis, // yAxis
 
@@ -251,7 +251,7 @@  discard block
 
 block discarded – undo
251 251 
     true, // plotVisibleOnly
252 252 
     DataSeries::EMPTY_AS_GAP, // displayBlanksAs
253 253 
     null, // xAxisLabel
254 
-    $yAxisLabel,  // yAxisLabel
254 
+    $yAxisLabel, // yAxisLabel
255 255 
     // added xAxis for correct date display
256 256 
     $xAxis, // xAxis
257 257 
     //  $yAxis, // yAxis
Please login to merge, or discard this patch.
samples/Chart/33_Chart_create_scatter3.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -129,7 +129,7 @@
 
 block discarded – undo
129 129
130 130 
 $yAxis = new ChartAxis();
131 131 
 $yAxis->setLineStyleProperties(
132 
-    2.5,     // width in points
132 
+    2.5, // width in points
133 133 
     Properties::LINE_STYLE_COMPOUND_SIMPLE,
134 134 
     Properties::LINE_STYLE_DASH_DASH_DOT,
135 135 
     Properties::LINE_STYLE_CAP_FLAT,
Please login to merge, or discard this patch.
samples/Chart/33_Chart_create_scatter2.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -128,7 +128,7 @@  discard block
 
 block discarded – undo
128 128
129 129 
 $yAxis = new ChartAxis();
130 130 
 $yAxis->setLineStyleProperties(
131 
-    2.5,     // width in points
131 
+    2.5, // width in points
132 132 
     Properties::LINE_STYLE_COMPOUND_SIMPLE,
133 133 
     Properties::LINE_STYLE_DASH_DASH_DOT,
134 134 
     Properties::LINE_STYLE_CAP_FLAT,
 
@@ -166,7 +166,7 @@  discard block
 
 block discarded – undo
166 166 
     true, // plotVisibleOnly
167 167 
     DataSeries::EMPTY_AS_GAP, // displayBlanksAs
168 168 
     null, // xAxisLabel
169 
-    $yAxisLabel,  // yAxisLabel
169 
+    $yAxisLabel, // yAxisLabel
170 170 
     // added xAxis for correct date display
171 171 
     $xAxis, // xAxis
172 172 
     $yAxis, // yAxis
Please login to merge, or discard this patch.