PHPOffice /
PhpSpreadsheet
Complex classes like StringHelper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use StringHelper, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 27 | class StringHelper |
||
| 28 | { |
||
| 29 | /** Constants */ |
||
| 30 | /** Regular Expressions */ |
||
| 31 | // Fraction |
||
| 32 | const STRING_REGEXP_FRACTION = '(-?)(\d+)\s+(\d+\/\d+)'; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * Control characters array. |
||
| 36 | * |
||
| 37 | * @var string[] |
||
| 38 | */ |
||
| 39 | private static $controlCharacters = []; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * SYLK Characters array. |
||
| 43 | * |
||
| 44 | * @var array |
||
| 45 | */ |
||
| 46 | private static $SYLKCharacters = []; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Decimal separator. |
||
| 50 | * |
||
| 51 | * @var string |
||
| 52 | */ |
||
| 53 | private static $decimalSeparator; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * Thousands separator. |
||
| 57 | * |
||
| 58 | * @var string |
||
| 59 | */ |
||
| 60 | private static $thousandsSeparator; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * Currency code. |
||
| 64 | * |
||
| 65 | * @var string |
||
| 66 | */ |
||
| 67 | private static $currencyCode; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Is iconv extension avalable? |
||
| 71 | * |
||
| 72 | * @var bool |
||
| 73 | */ |
||
| 74 | private static $isIconvEnabled; |
||
| 75 | |||
| 76 | /** |
||
| 77 | * Build control characters array. |
||
| 78 | */ |
||
| 79 | private static function buildControlCharacters() |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Build SYLK characters array. |
||
| 92 | */ |
||
| 93 | private static function buildSYLKCharacters() |
||
| 254 | |||
| 255 | /** |
||
| 256 | * Get whether iconv extension is available. |
||
| 257 | * |
||
| 258 | * @return bool |
||
| 259 | */ |
||
| 260 | 76 | public static function getIsIconvEnabled() |
|
| 300 | |||
| 301 | public static function buildCharacterSets() |
||
| 310 | |||
| 311 | /** |
||
| 312 | * Convert from OpenXML escaped control character to PHP control character. |
||
| 313 | * |
||
| 314 | * Excel 2007 team: |
||
| 315 | * ---------------- |
||
| 316 | * That's correct, control characters are stored directly in the shared-strings table. |
||
| 317 | * We do encode characters that cannot be represented in XML using the following escape sequence: |
||
| 318 | * _xHHHH_ where H represents a hexadecimal character in the character's value... |
||
| 319 | * So you could end up with something like _x0008_ in a string (either in a cell value (<v>) |
||
| 320 | * element or in the shared string <t> element. |
||
| 321 | * |
||
| 322 | * @param string $value Value to unescape |
||
| 323 | * |
||
| 324 | * @return string |
||
| 325 | */ |
||
| 326 | 8 | public static function controlCharacterOOXML2PHP($value = '') |
|
| 330 | |||
| 331 | /** |
||
| 332 | * Convert from PHP control character to OpenXML escaped control character. |
||
| 333 | * |
||
| 334 | * Excel 2007 team: |
||
| 335 | * ---------------- |
||
| 336 | * That's correct, control characters are stored directly in the shared-strings table. |
||
| 337 | * We do encode characters that cannot be represented in XML using the following escape sequence: |
||
| 338 | * _xHHHH_ where H represents a hexadecimal character in the character's value... |
||
| 339 | * So you could end up with something like _x0008_ in a string (either in a cell value (<v>) |
||
| 340 | * element or in the shared string <t> element. |
||
| 341 | * |
||
| 342 | * @param string $value Value to escape |
||
| 343 | * |
||
| 344 | * @return string |
||
| 345 | */ |
||
| 346 | 51 | public static function controlCharacterPHP2OOXML($value = '') |
|
| 350 | |||
| 351 | /** |
||
| 352 | * Try to sanitize UTF8, stripping invalid byte sequences. Not perfect. Does not surrogate characters. |
||
| 353 | * |
||
| 354 | * @param string $value |
||
| 355 | * |
||
| 356 | * @return string |
||
| 357 | */ |
||
| 358 | 65 | public static function sanitizeUTF8($value) |
|
| 370 | |||
| 371 | /** |
||
| 372 | * Check if a string contains UTF8 data. |
||
| 373 | * |
||
| 374 | * @param string $value |
||
| 375 | * |
||
| 376 | * @return bool |
||
| 377 | */ |
||
| 378 | public static function isUTF8($value = '') |
||
| 382 | |||
| 383 | /** |
||
| 384 | * Formats a numeric value as a string for output in various output writers forcing |
||
| 385 | * point as decimal separator in case locale is other than English. |
||
| 386 | * |
||
| 387 | * @param mixed $value |
||
| 388 | * |
||
| 389 | * @return string |
||
| 390 | */ |
||
| 391 | 60 | public static function formatNumber($value) |
|
| 399 | |||
| 400 | /** |
||
| 401 | * Converts a UTF-8 string into BIFF8 Unicode string data (8-bit string length) |
||
| 402 | * Writes the string using uncompressed notation, no rich text, no Asian phonetics |
||
| 403 | * If mbstring extension is not available, ASCII is assumed, and compressed notation is used |
||
| 404 | * although this will give wrong results for non-ASCII strings |
||
| 405 | * see OpenOffice.org's Documentation of the Microsoft Excel File Format, sect. 2.5.3. |
||
| 406 | * |
||
| 407 | * @param string $value UTF-8 encoded string |
||
| 408 | * @param mixed[] $arrcRuns Details of rich text runs in $value |
||
| 409 | * |
||
| 410 | * @return string |
||
| 411 | */ |
||
| 412 | 38 | public static function UTF8toBIFF8UnicodeShort($value, $arrcRuns = []) |
|
| 434 | |||
| 435 | /** |
||
| 436 | * Converts a UTF-8 string into BIFF8 Unicode string data (16-bit string length) |
||
| 437 | * Writes the string using uncompressed notation, no rich text, no Asian phonetics |
||
| 438 | * If mbstring extension is not available, ASCII is assumed, and compressed notation is used |
||
| 439 | * although this will give wrong results for non-ASCII strings |
||
| 440 | * see OpenOffice.org's Documentation of the Microsoft Excel File Format, sect. 2.5.3. |
||
| 441 | * |
||
| 442 | * @param string $value UTF-8 encoded string |
||
| 443 | * |
||
| 444 | * @return string |
||
| 445 | */ |
||
| 446 | 38 | public static function UTF8toBIFF8UnicodeLong($value) |
|
| 458 | |||
| 459 | /** |
||
| 460 | * Convert string from one encoding to another. |
||
| 461 | * |
||
| 462 | * @param string $value |
||
| 463 | * @param string $to Encoding to convert to, e.g. 'UTF-8' |
||
| 464 | * @param string $from Encoding to convert from, e.g. 'UTF-16LE' |
||
| 465 | * |
||
| 466 | * @return string |
||
| 467 | */ |
||
| 468 | 38 | public static function convertEncoding($value, $to, $from) |
|
| 476 | |||
| 477 | /** |
||
| 478 | * Get character count. |
||
| 479 | * |
||
| 480 | * @param string $value |
||
| 481 | * @param string $enc Encoding |
||
| 482 | * |
||
| 483 | * @return int Character count |
||
| 484 | */ |
||
| 485 | 97 | public static function countCharacters($value, $enc = 'UTF-8') |
|
| 489 | |||
| 490 | /** |
||
| 491 | * Get a substring of a UTF-8 encoded string. |
||
| 492 | * |
||
| 493 | * @param string $pValue UTF-8 encoded string |
||
| 494 | * @param int $pStart Start offset |
||
| 495 | * @param int $pLength Maximum number of characters in substring |
||
| 496 | * |
||
| 497 | * @return string |
||
| 498 | */ |
||
| 499 | 73 | public static function substring($pValue = '', $pStart = 0, $pLength = 0) |
|
| 503 | |||
| 504 | /** |
||
| 505 | * Convert a UTF-8 encoded string to upper case. |
||
| 506 | * |
||
| 507 | * @param string $pValue UTF-8 encoded string |
||
| 508 | * |
||
| 509 | * @return string |
||
| 510 | */ |
||
| 511 | 4 | public static function strToUpper($pValue = '') |
|
| 515 | |||
| 516 | /** |
||
| 517 | * Convert a UTF-8 encoded string to lower case. |
||
| 518 | * |
||
| 519 | * @param string $pValue UTF-8 encoded string |
||
| 520 | * |
||
| 521 | * @return string |
||
| 522 | */ |
||
| 523 | 4 | public static function strToLower($pValue = '') |
|
| 527 | |||
| 528 | /** |
||
| 529 | * Convert a UTF-8 encoded string to title/proper case |
||
| 530 | * (uppercase every first character in each word, lower case all other characters). |
||
| 531 | * |
||
| 532 | * @param string $pValue UTF-8 encoded string |
||
| 533 | * |
||
| 534 | * @return string |
||
| 535 | */ |
||
| 536 | 3 | public static function strToTitle($pValue = '') |
|
| 540 | |||
| 541 | 21 | public static function mbIsUpper($char) |
|
| 545 | |||
| 546 | 21 | public static function mbStrSplit($string) |
|
| 552 | |||
| 553 | /** |
||
| 554 | * Replace into multi-bytes string. |
||
| 555 | * |
||
| 556 | * Strangely, PHP doesn't have a mb_str_replace multibyte function |
||
| 557 | * As we'll only ever use this function with UTF-8 characters, we can simply "hard-code" the character set |
||
| 558 | * |
||
| 559 | * @param string|string[] $search |
||
| 560 | * @param string|string[] $replace |
||
| 561 | * @param string $subject |
||
| 562 | * |
||
| 563 | * @return string |
||
| 564 | */ |
||
| 565 | 2 | public static function mbStrReplace($search, $replace, $subject) |
|
| 590 | |||
| 591 | /** |
||
| 592 | * Reverse the case of a string, so that all uppercase characters become lowercase |
||
| 593 | * and all lowercase characters become uppercase. |
||
| 594 | * |
||
| 595 | * @param string $pValue UTF-8 encoded string |
||
| 596 | * |
||
| 597 | * @return string |
||
| 598 | */ |
||
| 599 | 21 | public static function strCaseReverse($pValue = '') |
|
| 612 | |||
| 613 | /** |
||
| 614 | * Identify whether a string contains a fractional numeric value, |
||
| 615 | * and convert it to a numeric if it is. |
||
| 616 | * |
||
| 617 | * @param string &$operand string value to test |
||
| 618 | * |
||
| 619 | * @return bool |
||
| 620 | */ |
||
| 621 | 1 | public static function convertToNumberIfFraction(&$operand) |
|
| 633 | |||
| 634 | // function convertToNumberIfFraction() |
||
| 635 | |||
| 636 | /** |
||
| 637 | * Get the decimal separator. If it has not yet been set explicitly, try to obtain number |
||
| 638 | * formatting information from locale. |
||
| 639 | * |
||
| 640 | * @return string |
||
| 641 | */ |
||
| 642 | 31 | public static function getDecimalSeparator() |
|
| 657 | |||
| 658 | /** |
||
| 659 | * Set the decimal separator. Only used by \PhpOffice\PhpSpreadsheet\Style\NumberFormat::toFormattedString() |
||
| 660 | * to format output by \PhpOffice\PhpSpreadsheet\Writer\Html and \PhpOffice\PhpSpreadsheet\Writer\Pdf. |
||
| 661 | * |
||
| 662 | * @param string $pValue Character for decimal separator |
||
| 663 | */ |
||
| 664 | 77 | public static function setDecimalSeparator($pValue = '.') |
|
| 668 | |||
| 669 | /** |
||
| 670 | * Get the thousands separator. If it has not yet been set explicitly, try to obtain number |
||
| 671 | * formatting information from locale. |
||
| 672 | * |
||
| 673 | * @return string |
||
| 674 | */ |
||
| 675 | 39 | public static function getThousandsSeparator() |
|
| 690 | |||
| 691 | /** |
||
| 692 | * Set the thousands separator. Only used by \PhpOffice\PhpSpreadsheet\Style\NumberFormat::toFormattedString() |
||
| 693 | * to format output by \PhpOffice\PhpSpreadsheet\Writer\Html and \PhpOffice\PhpSpreadsheet\Writer\Pdf. |
||
| 694 | * |
||
| 695 | * @param string $pValue Character for thousands separator |
||
| 696 | */ |
||
| 697 | 77 | public static function setThousandsSeparator($pValue = ',') |
|
| 701 | |||
| 702 | /** |
||
| 703 | * Get the currency code. If it has not yet been set explicitly, try to obtain the |
||
| 704 | * symbol information from locale. |
||
| 705 | * |
||
| 706 | * @return string |
||
| 707 | */ |
||
| 708 | 18 | public static function getCurrencyCode() |
|
| 728 | |||
| 729 | /** |
||
| 730 | * Set the currency code. Only used by \PhpOffice\PhpSpreadsheet\Style\NumberFormat::toFormattedString() |
||
| 731 | * to format output by \PhpOffice\PhpSpreadsheet\Writer\Html and \PhpOffice\PhpSpreadsheet\Writer\Pdf. |
||
| 732 | * |
||
| 733 | * @param string $pValue Character for currency code |
||
| 734 | */ |
||
| 735 | 38 | public static function setCurrencyCode($pValue = '$') |
|
| 739 | |||
| 740 | /** |
||
| 741 | * Convert SYLK encoded string to UTF-8. |
||
| 742 | * |
||
| 743 | * @param string $pValue |
||
| 744 | * |
||
| 745 | * @return string UTF-8 encoded string |
||
| 746 | */ |
||
| 747 | 1 | public static function SYLKtoUTF8($pValue = '') |
|
| 760 | |||
| 761 | /** |
||
| 762 | * Retrieve any leading numeric part of a string, or return the full string if no leading numeric |
||
| 763 | * (handles basic integer or float, but not exponent or non decimal). |
||
| 764 | * |
||
| 765 | * @param string $value |
||
| 766 | * |
||
| 767 | * @return mixed string or only the leading numeric part of the string |
||
| 768 | */ |
||
| 769 | 83 | public static function testStringAsNumeric($value) |
|
| 778 | } |
||
| 779 |
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.