PHPExif\Adapter\Native\Reader\Mapper\Exif\GuardInvalidArgumentsTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	guardInvalidArguments()	0	10	3

<?php
/**
 * Trait with method to validate arguments of ::mapField
 * from Exif\*Mapper classes
 *
 * @link        http://github.com/PHPExif/php-exif-native for the canonical source repository
 * @copyright   Copyright (c) 2016 Tom Van Herreweghe <tom@theanalogguy.be>
 * @license     http://github.com/PHPExif/php-exif-native/blob/master/LICENSE MIT License
 * @category    PHPExif
 * @package     Native
 */

namespace PHPExif\Adapter\Native\Reader\Mapper\Exif;

use PHPExif\Common\Data\ExifInterface;
use PHPExif\Common\Exception\Mapper\UnsupportedFieldException;
use PHPExif\Common\Exception\Mapper\UnsupportedOutputException;

/**
 * Common method to check the arguments of an Exif\* mapper
 *
 * @category    PHPExif
 * @package     Native
 */
trait GuardInvalidArgumentsTrait
{
    /**
     * Guard function for invalid arguments
     *
     * @param string $field
     * @param array $input
     * @param object $output
     *
     * @throws UnsupportedFieldException when asked to map an unsupported field
     * @throws UnsupportedOutputException when asked to map data on an unsupported output object
     *
     * @return void
     */
    private function guardInvalidArguments($field, array $input, $output)

The parameter $input is not used and could be removed.

    {
        if (!in_array($field, $this->getSupportedFields())) {

It seems like getSupportedFields() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            throw UnsupportedFieldException::forField($field);
        }

        if (!($output instanceof ExifInterface)) {
            throw UnsupportedOutputException::forOutput($output);
        }
    }
}