ExposureTime::__construct() - Code Metrics - Inspection of "Raw Data access on Metadata & Move ValueObjects" - PHPExif/php-exif-common - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#24)

by Tom Van

created 2016-11-10 09:15 UTC

ExposureTime::__construct() A

↳ Parent: ExposureTime

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	9

Duplication

Lines	19
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	19
loc	19
rs	9.4285
cc	3
eloc	9
nc	3
nop	1

<?php
/**
 * PHP Exif ExposureTime ValueObject
 *
 * @link        http://github.com/PHPExif/php-exif-common for the canonical source repository
 * @copyright   Copyright (c) 2016 Tom Van Herreweghe <[email protected]>
 * @license     http://github.com/PHPExif/php-exif-common/blob/master/LICENSE MIT License
 * @category    PHPExif
 * @package     Common
 * @codeCoverageIgnore
 */

namespace PHPExif\Common\Data\ValueObject;

use PHPExif\Common\Data\ValueObject\StringObject;
use \InvalidArgumentException;
use \RuntimeException;

/**
 * ExposureTime class
 *
 * A value object to describe the ExposureTime data
 *
 * @category    PHPExif
 * @package     Common
 */
class ExposureTime extends StringObject

{
    /**
     * @param string $stringData
     *
     * @throws InvalidArgumentException If given argument is not a string
     */
    public function __construct($stringData)
    {
        if (!is_string($stringData)) {
            throw new InvalidArgumentException('Given data is not a string');
        }

        if (!preg_match('#^([0-9]+)/([0-9]+)s?$#', $stringData, $matches)) {
            throw new RuntimeException('Given exposure time is not in a valid format. 
                Need: "1/<number>" or "1/<number>s"');
        }

        $numerator = (int) $matches[1];
        $denominator = (int) $matches[2];

        // normalize:
        $denominator /= $numerator;

        $this->setStringData("1/{$denominator}");
    }

    /**
     * Creates a new instance from given ExposureTime object
     *
     * @param ExposureTime $exposureTime
     *
     * @return ExposureTime
     */
    public static function fromExposureTime(ExposureTime $exposureTime)
    {
        return new self(
            (string) $exposureTime
        );
    }
}


1		<?php
2		/**
3		* PHP Exif ExposureTime ValueObject
4		*
5		* @link http://github.com/PHPExif/php-exif-common for the canonical source repository
6		* @copyright Copyright (c) 2016 Tom Van Herreweghe <[email protected]>
7		* @license http://github.com/PHPExif/php-exif-common/blob/master/LICENSE MIT License
8		* @category PHPExif
9		* @package Common
10		* @codeCoverageIgnore
11		*/
12
13		namespace PHPExif\Common\Data\ValueObject;
14
15		use PHPExif\Common\Data\ValueObject\StringObject;
16		use \InvalidArgumentException;
17		use \RuntimeException;
18
19		/**
20		* ExposureTime class
21		*
22		* A value object to describe the ExposureTime data
23		*
24		* @category PHPExif
25		* @package Common
26		*/
27	View Code Duplication	class ExposureTime extends StringObject
		0 ignored issues – show Duplication introduced 2016-11-08 20:23 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		/**
30		* @param string $stringData
31		*
32		* @throws InvalidArgumentException If given argument is not a string
33		*/
34		public function __construct($stringData)
35		{
36		if (!is_string($stringData)) {
37		throw new InvalidArgumentException('Given data is not a string');
38		}
39
40		if (!preg_match('#^([0-9]+)/([0-9]+)s?$#', $stringData, $matches)) {
41		throw new RuntimeException('Given exposure time is not in a valid format.
42		Need: "1/<number>" or "1/<number>s"');
43		}
44
45		$numerator = (int) $matches[1];
46		$denominator = (int) $matches[2];
47
48		// normalize:
49		$denominator /= $numerator;
50
51		$this->setStringData("1/{$denominator}");
52		}
53
54		/**
55		* Creates a new instance from given ExposureTime object
56		*
57		* @param ExposureTime $exposureTime
58		*
59		* @return ExposureTime
60		*/
61		public static function fromExposureTime(ExposureTime $exposureTime)
62		{
63		return new self(
64		(string) $exposureTime
65		);
66		}
67		}
68

PHPExif / php-exif-common

GitHub Access Token became invalid

Pull Request — develop (#24)

ExposureTime::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like